[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda updated this revision to Diff 520580. jasonmolenda added a comment. Updating to reflect what I committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150158/new/ https://reviews.llvm.org/D150158 Files: lldb/docs/lldb-gdb-remote.tx

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e93f91148ae: Add a new report_load_commands option to jGetLoadedDynamicLibrariesInfos (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D150158?vs=520546&id=520578#toc Repo

[Lldb-commits] [lldb] 4e93f91 - Add a new report_load_commands option to jGetLoadedDynamicLibrariesInfos

Author: Jason Molenda Date: 2023-05-08T20:34:58-07:00 New Revision: 4e93f91148ae4698b31ee397fb60410441df8b6b URL: https://github.com/llvm/llvm-project/commit/4e93f91148ae4698b31ee397fb60410441df8b6b DIFF: https://github.com/llvm/llvm-project/commit/4e93f91148ae4698b31ee397fb60410441df8b6b.diff

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:259-265 +static unsigned getPtrOrVecOfPtrsAddressSpace(Type *Ty) { + if (Ty->isVectorTy()) { +Ty = cast(Ty)->getElementType(); + } + assert(Ty->isPointerTy()); + return Ty->getPo

[Lldb-commits] [PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai added a comment. In D148776#4328425 , @dblaikie wrote: > Got a link to a design discussion motivating this change? No design discussion. I though that doing less work is not contentious. > I'd have thought it made sense to put modulemaps in subd

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I have no problem with removing mod_date since you're only removing the requirement in the Darwin-specific code. Also, be sure to remove the portion of the commit message that says this

[Lldb-commits] [PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

dblaikie added a comment. Got a link to a design discussion motivating this change? I'd have thought it made sense to put modulemaps in subdirectories - since they cover the whole directory, putting them in the root of an include path would be problematic if there are multiple distinct projects

[Lldb-commits] [PATCH] D150168: [lldb] Simplify predicates of find_if in BroadcastManager

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We had some custom classes that were used as the predicate for `s

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda updated this revision to Diff 520546. jasonmolenda added a comment. Update the patch to stop checking for the `mod_date` key in the JSON reply for each binary. This value is always zero with dyld for the past five+ years. It increases the size of the packet unnecessarily, but lldb

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda updated this revision to Diff 520545. jasonmolenda added a comment. Update to address Alex's comments, fix the testsuite failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150158/new/ https://reviews.llvm.org/D150158 Files: lldb

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda added a comment. Thanks for the feedback. Testing now & will update the patch in a bit. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:930-931 +if (!image_infos[i].is_valid_mach_header) { + image_infos_array_sp->AddItem(image_info_dict_sp

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

bulbazord added a comment. This looks good to me. > This patch does have a regression on > API/macosx/unregistered-macho/TestUnregisteredMacho.py that I wrote last > summer; I have the patch generate JSON for a binary that it had an address > for, but could not read the mach-o headers. This te

[Lldb-commits] [PATCH] D150160: [lldb] Simplify Log::PutString (NFC)

kastiglione updated this revision to Diff 520541. kastiglione added a comment. Update comments too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150160/new/ https://reviews.llvm.org/D150160 Files: lldb/source/Utility/Log.cpp Index: lldb/source

[Lldb-commits] [PATCH] D150160: [lldb] Simplify Log::PutString (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Utility/Log.cpp:135 -void Log::PutCString(const char *cstr) { Printf("%s", cstr); } -void Log::PutString(llvm::StringRef str) { PutCString(

[Lldb-commits] [PATCH] D150160: [lldb] Simplify Log::PutString (NFC)

kastiglione created this revision. kastiglione added reviewers: mib, bulbazord. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - As no format string is involved, avoid unecessary call into `Printf`

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. debugserver has a memory

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 520478. bolshakov-a added a subscriber: hubert.reinterpretcast. bolshakov-a added a comment. Avoid binding references in template arguments to bit-fields. @erichkeane, @hubert.reinterpretcast, please verify. CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D149774: [lldb] Use templates to simplify {Get, Set}PropertyAtIndex (NFC)

jgorbe added inline comments. Comment at: lldb/source/Target/Target.cpp:4520 const uint32_t idx = ePropertyMaxSummaryLength; - return m_collection_sp->GetPropertyAtIndexAsSInt64(idx).value_or( - g_target_properties[idx].default_uint_value); + return GetPropertyAtIndexAs

[Lldb-commits] [PATCH] D150032: [lldb, NetBSD] getValue => operator* for Optional migration

nikicoon added a comment. In D150032#4327156 , @emaste wrote: >> because Phabricator is a PoS that converts patches to useless diffs > > FWIW the Phorge folks have taken an interest in these sorts of complaints > brought by the FreeBSD community, e.g. ht

[Lldb-commits] [PATCH] D150129: [lldb] Refine call to decl printing helper (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When `ValueObjectPrinter` calls its `m_decl_printing_he

[Lldb-commits] [PATCH] D150078: [lldb] Prevent mutation of CommandAlias::GetOptionArguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG765237779ce4: [lldb] Prevent mutation of CommandAlias::GetOptionArguments (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150078/new

[Lldb-commits] [lldb] 7652377 - [lldb] Prevent mutation of CommandAlias::GetOptionArguments

Author: Dave Lee Date: 2023-05-08T09:45:26-07:00 New Revision: 765237779ce4dbb60f4faf9ebc91386ce5218e15 URL: https://github.com/llvm/llvm-project/commit/765237779ce4dbb60f4faf9ebc91386ce5218e15 DIFF: https://github.com/llvm/llvm-project/commit/765237779ce4dbb60f4faf9ebc91386ce5218e15.diff LOG:

[Lldb-commits] [PATCH] D150032: [lldb, NetBSD] getValue => operator* for Optional migration

emaste added a comment. Herald added a subscriber: JDevlieghere. > because Phabricator is a PoS that converts patches to useless diffs FWIW the Phorge folks have taken an interest in these sorts of complaints brought by the FreeBSD community, e.g. https://we.phorge.it/Q46, https://we.phorge.it/

[Lldb-commits] [lldb] ba902ef - Skip test when compiling with older versions of clang

Author: Adrian Prantl Date: 2023-05-08T09:24:40-07:00 New Revision: ba902efa499a092405c207d71a98af1e38853d7b URL: https://github.com/llvm/llvm-project/commit/ba902efa499a092405c207d71a98af1e38853d7b DIFF: https://github.com/llvm/llvm-project/commit/ba902efa499a092405c207d71a98af1e38853d7b.diff

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang updated this revision to Diff 520308. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 Files: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp llvm/test/Transforms/InferAddressSpaces/AMDGPU/icmp.ll llvm/test/Transforms/InferAddres

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang updated this revision to Diff 520302. CaprYang retitled this revision from "[InferAddressSpaces] Handle vector of pointers type" to "[InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1500

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type

CaprYang updated this revision to Diff 520296. CaprYang removed reviewers: bollu, ldionne, nicolasvasilache, rafauler, Amir, maksfb, NoQ, njames93, libc++, libc++abi, libunwind, rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. CaprYang removed projects: clang-format, Flang, clang-tools-extra,