[Lldb-commits] [PATCH] D150239: ObjectFileMachO: Prioritize the TEXT segment as the mach header segment, regardless of the order the segments appear in the file

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4331048 , @jingham wrote: > Most of this is fine. I wonder about avoiding caching the full name and name > w/o category & selector name. One of the main uses of this class is to take > incoming ObjC names from

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

jingham created this revision. jingham added reviewers: JDevlieghere, mib, bulbazord. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We can't let GetStackFrameCount get interrupted or it will give the

[Lldb-commits] [PATCH] D150235: [lldb] Change definition of DisassemblerCreateInstance

bulbazord created this revision. bulbazord added reviewers: jingham, mib, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DissassemblerCreateInstance is a function pointer whos return

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

wallace added a comment. The alias still works because it still holds a reference to it. I could add that as a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149379/new/ https://reviews.llvm.org/D149379

[Lldb-commits] [lldb] 448bd59 - [nfc] Remove dead code from ObjectFileMachO

Author: Jason Molenda Date: 2023-05-09T17:01:06-07:00 New Revision: 448bd59e18721e5357a37f080051db87cc3a4448 URL: https://github.com/llvm/llvm-project/commit/448bd59e18721e5357a37f080051db87cc3a4448 DIFF: https://github.com/llvm/llvm-project/commit/448bd59e18721e5357a37f080051db87cc3a4448.diff

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

jingham added a comment. In D140630#4276855 , @cimacmillan wrote: > Ping. Greg's been out since late March, and isn't expected back for a while still. I am entirely unfamiliar with the lldb-vscode part of lldb, so I don't feel comfortable reviewing

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

jingham added a comment. Most of this is fine. I wonder about avoiding caching the full name and name w/o category & selector name. One of the main uses of this class is to take incoming ObjC names from the ConstString pool, chop them up into full name, name w/o category, and selectorName,

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord updated this revision to Diff 520854. bulbazord added a comment. Remove unused include in header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/ https://reviews.llvm.org/D150228 Files: lldb/include/lldb/Core/dwarf.h

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord updated this revision to Diff 520853. bulbazord added a comment. Do a typedef in dwarf.h (like llvm::dwarf::Tag) instead of explicitly writing the type out everywhere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

jingham added a comment. What happens if you remove a command that had an alias bound to it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149379/new/ https://reviews.llvm.org/D149379 ___ lldb-commits

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord added a reviewer: JDevlieghere. bulbazord added a comment. In D150228#4330798 , @jingham wrote: > Apparently a similar change was made with dw_tag_t, in the line below your > first deletion I see: > > typedef llvm::dwarf::Tag dw_tag_t; > > It

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

jingham added a comment. Apparently a similar change was made with dw_tag_t, in the line below your first deletion I see: typedef llvm::dwarf::Tag dw_tag_t; It seems weird to have dw_tag_t but lvm::dwarf::Form. If there's a good reason to use the more verbose form, we should probably do the

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

jingham added inline comments. Comment at: lldb/unittests/API/SBCommandInterpreterTest.cpp:24 SBDebugger::Initialize(); m_dbg = SBDebugger::Create(/*source_init_files=*/false); } bulbazord wrote: > jingham wrote: > > It isn't clear to me how the

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

rastogishubham accepted this revision. rastogishubham added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Great refactoring! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord created this revision. bulbazord added reviewers: aprantl, rastogishubham, fdeazeve, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB currently defines `dw_form_t` as a

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

bulbazord added inline comments. Comment at: lldb/unittests/API/SBCommandInterpreterTest.cpp:24 SBDebugger::Initialize(); m_dbg = SBDebugger::Create(/*source_init_files=*/false); } jingham wrote: > It isn't clear to me how the changes in this file

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

jingham added a comment. This seems like a pretty non-intrusive way of protecting the lldb_private side of the SB API construction. Looking at the patch makes it seem like we've been semi-randomly assorting members of the SB classes to "protected" and "private". We have NO intentions of ever

[Lldb-commits] [PATCH] D150222: [lldb][NFCI] Remove custom dwarf LEB128 types

This revision was automatically updated to reflect the committed changes. Closed by commit rGb77e41f2886a: [lldb][NFCI] Remove custom dwarf LEB128 types (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150222/new/

[Lldb-commits] [lldb] b77e41f - [lldb][NFCI] Remove custom dwarf LEB128 types

Author: Alex Langford Date: 2023-05-09T13:46:27-07:00 New Revision: b77e41f2886aca278b41a85fc0f947e078b3da13 URL: https://github.com/llvm/llvm-project/commit/b77e41f2886aca278b41a85fc0f947e078b3da13 DIFF: https://github.com/llvm/llvm-project/commit/b77e41f2886aca278b41a85fc0f947e078b3da13.diff

[Lldb-commits] [PATCH] D150222: [lldb][NFCI] Remove custom dwarf LEB128 types

rastogishubham accepted this revision. rastogishubham added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150222/new/ https://reviews.llvm.org/D150222 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

bulbazord added inline comments. Comment at: lldb/include/lldb/API/SBBreakpoint.h:18-19 class ScriptInterpreter; +namespace python { +class SWIGBridge; } mib wrote: > We've talked about this offline, but I think we should stay language agnostic > in the

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with some comments. Comment at: lldb/include/lldb/API/SBBreakpoint.h:18-19 class ScriptInterpreter; +namespace python { +class SWIGBridge; } We've talked

[Lldb-commits] [PATCH] D150222: [lldb][NFCI] Remove custom dwarf LEB128 types

fdeazeve added a comment. Nice cleanup! This gets rid of some implicit conversions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150222/new/ https://reviews.llvm.org/D150222 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D150222: [lldb][NFCI] Remove custom dwarf LEB128 types

bulbazord created this revision. bulbazord added reviewers: aprantl, rastogishubham, fdeazeve, JDevlieghere, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The LEB128 type defined by the

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:381 + for (auto begin = m_event_map.begin(), end = m_event_map.end();;) { +auto iter = find_if(begin, end, listener_matches_and_shared_bits); +if (iter == m_event_map.end())

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve updated this revision to Diff 520796. fdeazeve edited the summary of this revision. fdeazeve added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150219/new/ https://reviews.llvm.org/D150219 Files:

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

jingham accepted this revision. jingham added a comment. You are inconsistent in a couple of places about whether you re-look up m_event_map.end or use the version you captured in a variable, which is a little confusing. Other than that this looks equivalent Comment at:

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

bulbazord accepted this revision. bulbazord added a comment. I like this. :) Comment at: lldb/source/Utility/Broadcaster.cpp:392 } -m_event_map.erase(iter); +iter = m_event_map.erase(iter); } I don't think you need to actually capture the

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150219/new/ https://reviews.llvm.org/D150219 ___

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

mib added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:430 - while (true) { -auto events_predicate = -[](const event_listener_key ) -> bool { - return input.second.get() == listener; -}; -collection::iterator iter, end_iter =

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:430 - while (true) { -auto events_predicate = -[](const event_listener_key ) -> bool { - return input.second.get() == listener; -}; -collection::iterator iter, end_iter =

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

mib added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:430 - while (true) { -auto events_predicate = -[](const event_listener_key ) -> bool { - return input.second.get() == listener; -}; -collection::iterator iter, end_iter =

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:382 +auto iter = find_if(begin, end, listener_matches_and_shared_bits); +if (iter == m_event_map.end()) break; Oh, this should be `== end` Comment

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve added a comment. Heavily inspired by @bulbazord's D150168 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150219/new/ https://reviews.llvm.org/D150219 ___

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve updated this revision to Diff 520786. fdeazeve added a comment. Herald added a subscriber: JDevlieghere. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150219/new/ https://reviews.llvm.org/D150219 Files:

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The code inside Broadcaster makes usage of iterators using olden C++ coding style. Hidden in this old style is a couple

[Lldb-commits] [PATCH] D150160: [lldb] Simplify Log::PutString (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG586414927418: [lldb] Simplify Log::PutString (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150160/new/

[Lldb-commits] [lldb] 5864149 - [lldb] Simplify Log::PutString (NFC)

Author: Dave Lee Date: 2023-05-09T10:40:42-07:00 New Revision: 58641492741818b987ec86ab75c2cd438dd3ac63 URL: https://github.com/llvm/llvm-project/commit/58641492741818b987ec86ab75c2cd438dd3ac63 DIFF: https://github.com/llvm/llvm-project/commit/58641492741818b987ec86ab75c2cd438dd3ac63.diff

[Lldb-commits] [PATCH] D150168: [lldb] Simplify predicates of find_if in BroadcastManager

This revision was automatically updated to reflect the committed changes. Closed by commit rGec77d1f3d9fc: [lldb] Simplify predicates of find_if in BroadcastManager (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150168/new/

[Lldb-commits] [lldb] ec77d1f - [lldb] Simplify predicates of find_if in BroadcastManager

Author: Alex Langford Date: 2023-05-09T10:00:02-07:00 New Revision: ec77d1f3d9fcf7105b6bda25fb4d0e5ed5afd0c5 URL: https://github.com/llvm/llvm-project/commit/ec77d1f3d9fcf7105b6bda25fb4d0e5ed5afd0c5 DIFF: https://github.com/llvm/llvm-project/commit/ec77d1f3d9fcf7105b6bda25fb4d0e5ed5afd0c5.diff

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 520716. bolshakov-a added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/test/Transforms/InferAddressSpaces/masked-gather-scatter.ll:3 + +; CHECK-LABEL: @masked_gather_inferas( +; CHECK: tail call <4 x i32> @llvm.masked.gather.v4i32.v4p1 arsenm wrote: > Generate full checks updated

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang updated this revision to Diff 520692. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 Files: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp llvm/test/Transforms/InferAddressSpaces/AMDGPU/icmp.ll

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 520678. bolshakov-a added a comment. Fix MS compatibility mangling algorithm. Tested with MSVC ver. 19.35 (toolset ver. 143). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files:

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:289 + +static bool hasSameElementOfPtrOrVecPtrs(Type *Ty1, Type *Ty2) { + assert(isPtrOrVecOfPtrsType(Ty1) && isPtrOrVecOfPtrsType(Ty2)); arsenm wrote: > arsenm wrote:

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

arsenm added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:289 + +static bool hasSameElementOfPtrOrVecPtrs(Type *Ty1, Type *Ty2) { + assert(isPtrOrVecOfPtrsType(Ty1) && isPtrOrVecOfPtrsType(Ty2)); arsenm wrote: > Ditto, only

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/test/Transforms/InferAddressSpaces/AMDGPU/icmp.ll:151 ; CHECK-LABEL: @icmp_flat_flat_from_group_vector( -; CHECK: %cmp = icmp eq <2 x ptr> %cast0, %cast1 +; CHECK: %cmp = icmp eq <2 x ptr addrspace(3)> %group.ptr.0, %group.ptr.1

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang updated this revision to Diff 520660. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 Files: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp llvm/test/Transforms/InferAddressSpaces/AMDGPU/icmp.ll

[Lldb-commits] [PATCH] D150168: [lldb] Simplify predicates of find_if in BroadcastManager

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150168/new/ https://reviews.llvm.org/D150168