[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp:129-134 llvm::SmallString<64> name; { llvm::raw_svector_ostre

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

bulbazord added a comment. In D152324#4403368 , @aprantl wrote: > Is the idea to remove the ConstString from these APIs too? If yes, this LGTM, > otherwise it seems to needlessly complicate things. Yes, I was going to remove ConstString from these other

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 __

[Lldb-commits] [lldb] 0dd62ac - [lldb] Disable variable watchpoints when going out of scope

Author: Med Ismail Bennani Date: 2023-06-07T16:52:11-07:00 New Revision: 0dd62ace2ee2fafcb9a08953db1b9e4e20428e28 URL: https://github.com/llvm/llvm-project/commit/0dd62ace2ee2fafcb9a08953db1b9e4e20428e28 DIFF: https://github.com/llvm/llvm-project/commit/0dd62ace2ee2fafcb9a08953db1b9e4e20428e28.

[Lldb-commits] [PATCH] D152319: [lldb] Run crashlog inside lldb when invoked in interactive mode from the command line

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b4792159cb7: [lldb] Reinvoke crashlog under lldb when run with -i from the command line (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 7b47921 - [lldb] Reinvoke crashlog under lldb when run with -i from the command line

Author: Jonas Devlieghere Date: 2023-06-07T16:21:16-07:00 New Revision: 7b4792159cb7990f50c839713be4dbf6b31191e9 URL: https://github.com/llvm/llvm-project/commit/7b4792159cb7990f50c839713be4dbf6b31191e9 DIFF: https://github.com/llvm/llvm-project/commit/7b4792159cb7990f50c839713be4dbf6b31191e9.d

[Lldb-commits] [PATCH] D152409: [lldb] Never print children if the max depth has been reached

augusto2112 created this revision. augusto2112 added reviewers: aprantl, kastiglione. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When formatting a variable, the max depth would potentially be ig

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 updated this revision to Diff 529463. augusto2112 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 Files: lldb/source/DataFormatters/ValueObjectPrinter.cpp lldb/te

[Lldb-commits] [lldb] 867ee3b - [lldb][NFCI] Change type of Broadcaster's name

Author: Alex Langford Date: 2023-06-07T10:14:53-07:00 New Revision: 867ee3b8a76a78e02c56e78382e31bfd76fa468b URL: https://github.com/llvm/llvm-project/commit/867ee3b8a76a78e02c56e78382e31bfd76fa468b DIFF: https://github.com/llvm/llvm-project/commit/867ee3b8a76a78e02c56e78382e31bfd76fa468b.diff

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

This revision was automatically updated to reflect the committed changes. Closed by commit rG867ee3b8a76a: [lldb][NFCI] Change type of Broadcaster's name (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152220/new/ https://revi

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

aprantl added a comment. Is the idea to remove the ConstString from these APIs too? If yes, this LGTM, otherwise it seems to needlessly complicate things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152324/new/ https://reviews.llvm.org/D152324

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

labath added a comment. I agree that we should have a rate limiting mechanism very close to the source, to avoid wasting work for events that aren't going to be used. This is particularly important for debug info parsing, where we have multiple threads working in parallel and taking a lock even

[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

labath created this revision. labath added reviewers: JDevlieghere, saugustine, rupprecht. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Have the Progress class spawn a thread to periodically send progress reports. The reporting period could