[Lldb-commits] [lldb] b712061 - [lldb] Remove unused forward declaration RecordingMemoryManager

Author: Kazu Hirata Date: 2023-06-14T22:04:43-07:00 New Revision: b712061441b4990c8195b940912d2a4ac0bdbee0 URL: https://github.com/llvm/llvm-project/commit/b712061441b4990c8195b940912d2a4ac0bdbee0 DIFF: https://github.com/llvm/llvm-project/commit/b712061441b4990c8195b940912d2a4ac0bdbee0.diff

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

This revision was automatically updated to reflect the committed changes. Closed by commit rG7371ec76299d: [lldb] Have crashlog warn when remapped paths are inaccessible. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7371ec7 - [lldb] Have crashlog warn when remapped paths are inaccessible.

Author: Jonas Devlieghere Date: 2023-06-14T17:15:28-07:00 New Revision: 7371ec76299df6922911233bd6ee07d7629d09b6 URL: https://github.com/llvm/llvm-project/commit/7371ec76299df6922911233bd6ee07d7629d09b6 DIFF:

[Lldb-commits] [lldb] 048204d - [lldb] Remove lldbassert from DebugNamesDWARFIndex::GetGlobalVariables

Author: Jonas Devlieghere Date: 2023-06-14T17:15:20-07:00 New Revision: 048204d6102ab984c067c1a1c9889edb7f58d419 URL: https://github.com/llvm/llvm-project/commit/048204d6102ab984c067c1a1c9889edb7f58d419 DIFF:

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 531579. splhack added a comment. Fixed diff dependencies in order to fix CI https://reviews.llvm.org/B238946 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files:

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531578. splhack added a comment. Fixed diff dependencies in order to fix CI https://reviews.llvm.org/B238938 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files:

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531576. splhack added a comment. Fixed diff dependencies in order to fix CI https://reviews.llvm.org/B238937 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files:

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152886/new/ https://reviews.llvm.org/D152886 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

JDevlieghere updated this revision to Diff 531562. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Make the warning its own line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152886/new/ https://reviews.llvm.org/D152886 Files:

[Lldb-commits] [PATCH] D152962: [lldb] Fix SBPlatform after f4be9ff6458f

This revision was automatically updated to reflect the committed changes. Closed by commit rG623ad8a8ddc9: [lldb] Fix SBPlatform after f4be9ff6458f (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152962/new/

[Lldb-commits] [lldb] 623ad8a - [lldb] Fix SBPlatform after f4be9ff6458f

Author: Alex Langford Date: 2023-06-14T15:46:00-07:00 New Revision: 623ad8a8ddc96e9dee4f354ee4e7b3e7c11b119f URL: https://github.com/llvm/llvm-project/commit/623ad8a8ddc96e9dee4f354ee4e7b3e7c11b119f DIFF: https://github.com/llvm/llvm-project/commit/623ad8a8ddc96e9dee4f354ee4e7b3e7c11b119f.diff

[Lldb-commits] [PATCH] D152870: [lldb][NFCI] Remove StructuredData::Array::GetItemAtIndexAsString overloads with ConstString

mib added inline comments. Comment at: lldb/source/Target/DynamicRegisterInfo.cpp:204 +m_sets.push_back( +{ConstString(set_name).AsCString(), nullptr, 0, nullptr}); } else { I guess `m_sets` is a vector of `char*` ... Should we change

[Lldb-commits] [PATCH] D152968: [lldb][NFCI] Remove use of ConstString in ProcessStructReader

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. std::map is naturally replaced with `llvm::StringMap` here.

[Lldb-commits] [lldb] f6ca15c - [lldb][NFCI] Remove unused method ProcessStructReader::GetOffsetOf

Author: Alex Langford Date: 2023-06-14T14:45:21-07:00 New Revision: f6ca15cfb20983e2a966efad663a25bd61826c07 URL: https://github.com/llvm/llvm-project/commit/f6ca15cfb20983e2a966efad663a25bd61826c07 DIFF: https://github.com/llvm/llvm-project/commit/f6ca15cfb20983e2a966efad663a25bd61826c07.diff

[Lldb-commits] [lldb] a9ddf45 - [lldb][NFCI] Remove ProcessStructReader header where unused

Author: Alex Langford Date: 2023-06-14T14:38:18-07:00 New Revision: a9ddf45b8ace943b637837b63e38f297ac811442 URL: https://github.com/llvm/llvm-project/commit/a9ddf45b8ace943b637837b63e38f297ac811442 DIFF: https://github.com/llvm/llvm-project/commit/a9ddf45b8ace943b637837b63e38f297ac811442.diff

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord added a comment. Looks like this actually causes TestDebuggerAPI.py to segfault because SBPlatform::SetSDKRoot can take `nullptr` for its argument, and the conversion from `nullptr -> std::string` blows up. I'm fixing that in https://reviews.llvm.org/D152962. Repository: rG LLVM

[Lldb-commits] [PATCH] D152962: [lldb] Fix SBPlatform after f4be9ff6458f

bulbazord created this revision. bulbazord added a reviewer: jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If you pass `nullptr` (or `None` from python) to SBPlatform::SetSDKRoot, LLDB

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 531509. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files: lldb/source/Plugins/Platform/Android/CMakeLists.txt

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531500. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files: lldb/source/Plugins/Platform/Android/AdbClient.h

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531499. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileResolver.h

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531498. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ce7037b5edd: Clear non-addressable bits from pc/fp/sp in unwinds (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152861/new/

[Lldb-commits] [PATCH] D152863: [lldb] NFC Add Process methods to Fix.*Address, to simplify this bit clearing across the codebase

This revision was automatically updated to reflect the committed changes. Closed by commit rG90d9f88f19a1: Add Fix*Address methods to Process, call into ABI (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152863/new/

[Lldb-commits] [lldb] 0ce7037 - Clear non-addressable bits from pc/fp/sp in unwinds

Author: Jason Molenda Date: 2023-06-14T13:49:26-07:00 New Revision: 0ce7037b5edd0f1937c9d9572ab12528d26091ed URL: https://github.com/llvm/llvm-project/commit/0ce7037b5edd0f1937c9d9572ab12528d26091ed DIFF: https://github.com/llvm/llvm-project/commit/0ce7037b5edd0f1937c9d9572ab12528d26091ed.diff

[Lldb-commits] [lldb] 90d9f88 - Add Fix*Address methods to Process, call into ABI

Author: Jason Molenda Date: 2023-06-14T13:49:26-07:00 New Revision: 90d9f88f19a128a6bacd7c8db594feb96047cded URL: https://github.com/llvm/llvm-project/commit/90d9f88f19a128a6bacd7c8db594feb96047cded DIFF: https://github.com/llvm/llvm-project/commit/90d9f88f19a128a6bacd7c8db594feb96047cded.diff

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152916/new/ https://reviews.llvm.org/D152916

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Putting this in `register info` is good, it's not too easily discoverable (to be honest I didn't know this command existed today), but as you say, the number of people who

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/include/lldb/Target/RegisterFlags.h:96 + /// Produce a text table showing the layout of all the fields. Unamed/padding + /// fields

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack updated this revision to Diff 531483. splhack added a comment. Replace `llvm::sys::RetryAfterSignal(-1, ::open)` with `FileSystem::Instance().Open`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda added a comment. In D152861#4420223 , @DavidSpickett wrote: > I'm curious how you would end up with a signed PC value, but given this is > unwind it could be a value from a previous frame that was signed when stored > to the stack. The

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. oh wait, `FileSystem::Open` is already `RetryAfterSignal::Open` in this diff. will replace `RetryAfterSignal::Open` with `FileSystem::Open`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. @JDevlieghere does `FileSystem::RetryAfterSignal::Open` sound good to you? Or `FileSystem::RetryAfterSignalOpen`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Should we make this the default behavior in `FileSystem`? Either way I think this belongs there rather than in Host. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 7d21f57 - [lldb] Fix a warning

Author: Kazu Hirata Date: 2023-06-14T10:56:22-07:00 New Revision: 7d21f5714e5a040f121fa08648c748073467db82 URL: https://github.com/llvm/llvm-project/commit/7d21f5714e5a040f121fa08648c748073467db82 DIFF: https://github.com/llvm/llvm-project/commit/7d21f5714e5a040f121fa08648c748073467db82.diff

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:344 +) +if os.path.exists(source_path): +self.resolved_source = True

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

bulbazord updated this revision to Diff 531407. bulbazord added a comment. Use STLExtras where appropriate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152846/new/ https://reviews.llvm.org/D152846 Files: lldb/source/Utility/Listener.cpp

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4be9ff6458f: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f4be9ff - [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

Author: Alex Langford Date: 2023-06-14T09:59:58-07:00 New Revision: f4be9ff6458fe6401acaf9239865e077141dd8bc URL: https://github.com/llvm/llvm-project/commit/f4be9ff6458fe6401acaf9239865e077141dd8bc DIFF: https://github.com/llvm/llvm-project/commit/f4be9ff6458fe6401acaf9239865e077141dd8bc.diff

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 531398. splhack added a comment. remove 'Depends on' from commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files:

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531396. splhack added a comment. remove 'Depend on' from commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files:

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531394. splhack added a comment. remove 'Depends on' from commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files:

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 531392. splhack added a comment. Herald added a subscriber: JDevlieghere. rebase onto D152855 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531389. splhack added a comment. rebase onto D152759 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files:

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:261-264 + if (const char *run_as = std::getenv("ANDROID_PLATFORM_RUN_AS")) +snprintf(run_as_cmd, sizeof(run_as_cmd), "run-as '%s' ", run_as); + else +run_as_cmd[0] =

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531384. splhack added a comment. rebase onto D152757 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files:

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531383. splhack added a comment. rebase onto D152712 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files:

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack updated this revision to Diff 531381. splhack added a comment. rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712 Files: lldb/include/lldb/Host/common/RetryAfterSignal.h

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:344 +) +if os.path.exists(source_path): +self.resolved_source = True

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

splhack abandoned this revision. splhack added a comment. @bulbazord thanks for the suggestion! property works well. D152933 supersedes this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152494/new/

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added reviewers: clayborg, bulbazord, labath, lanza. splhack published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When LLDB fails to

[Lldb-commits] [PATCH] D152872: Add support for __debug_line_str in Mach-O

This revision was automatically updated to reflect the committed changes. Closed by commit rG27fac4a72ae5: Add support for __debug_line_str in Mach-O (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 27fac4a - Add support for __debug_line_str in Mach-O

Author: Adrian Prantl Date: 2023-06-14T08:37:08-07:00 New Revision: 27fac4a72ae54a471471a69c0ad999585ccbb026 URL: https://github.com/llvm/llvm-project/commit/27fac4a72ae54a471471a69c0ad999585ccbb026 DIFF: https://github.com/llvm/llvm-project/commit/27fac4a72ae54a471471a69c0ad999585ccbb026.diff

[Lldb-commits] [PATCH] D152922: [lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to RISCVVTypes.def

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152922/new/

[Lldb-commits] [PATCH] D152922: [lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to RISCVVTypes.def

eopXD created this revision. eopXD added a reviewer: DavidSpickett. Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. eopXD requested review

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

DavidSpickett added a comment. This is the major use case for the command. With these diagrams matching the architecture manual (mostly) you can use them to work out what mask/shift you need. You'll be able to print a register, see that the field isn't the right value, then "register info" and

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

DavidSpickett added a comment. I think "info" is a fairly safe name for this command. I thought about "register help" but then you could do "help register help" and while that's amusing it's also pretty silly. You might think at a glance "info" does something like check the register's value

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

DavidSpickett added reviewers: jasonmolenda, labath, JDevlieghere. DavidSpickett added inline comments. Comment at: lldb/source/Core/DumpRegisterInfo.cpp:84 + +void lldb_private::DoDumpRegisterInfo( +Stream , const char *name, const char *alt_name, uint32_t byte_size,

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This teaches DumpRegisterInfo to generate a table from the register flags type. It just calls a method on

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

DavidSpickett added a comment. I'm aware we likely have 10s of adhoc table printing functions across llvm and I'm surprised someone hasn't unified them yet. Which is to say, today I am not that person though I would like to collect a list of places that could benefit from it. Repository:

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This will be used by the "register info" command to show the layout of register contents. For example if we

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a new command that will show all the information lldb knows about a register. (lldb) register info

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Nice catch! Also agree with the suggestion of using the STLExtras wrapper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152846/new/

[Lldb-commits] [PATCH] D152519: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script

This revision was automatically updated to reflect the committed changes. Closed by commit rG01e30b30d09a: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 01e30b3 - [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script

Author: David Spickett Date: 2023-06-14T14:33:47+01:00 New Revision: 01e30b30d09aca13819b40bfeff634e776e2b564 URL: https://github.com/llvm/llvm-project/commit/01e30b30d09aca13819b40bfeff634e776e2b564 DIFF:

[Lldb-commits] [PATCH] D152872: Add support for __debug_line_str in Mach-O

fdeazeve accepted this revision. fdeazeve added a comment. Nice and subtle fix! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152872/new/ https://reviews.llvm.org/D152872 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D152519: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152519/new/ https://reviews.llvm.org/D152519

[Lldb-commits] [PATCH] D152863: [lldb] NFC Add Process methods to Fix.*Address, to simplify this bit clearing across the codebase

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Sinking the whole `if abi` dance into these methods will clean up a lot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I'm curious how you would end up with a signed PC value, but given this is unwind it could be a value from a previous frame that was signed when stored to the stack. LGTM.

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531198. splhack added a comment. Herald added a subscriber: JDevlieghere. sync with D152759 new version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531195. splhack added a comment. - ZipFile: zip file parser in Utility - include/lldb/Utility/ZipFile.h - source/Utility/ZipFile.cpp - ZipFileResolver: bionic zip .so file resolver, depends on Host::FileSystem -