[Lldb-commits] [PATCH] D153597: [lldb] Adjust for changes in objc runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG28fb39f16af1: [lldb] Adjust for changes in objc runtime (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153597/new/

[Lldb-commits] [lldb] 28fb39f - [lldb] Adjust for changes in objc runtime

Author: Alex Langford Date: 2023-06-22T16:42:22-07:00 New Revision: 28fb39f16af1003e53008b75c11127b3288742f8 URL: https://github.com/llvm/llvm-project/commit/28fb39f16af1003e53008b75c11127b3288742f8 DIFF: https://github.com/llvm/llvm-project/commit/28fb39f16af1003e53008b75c11127b3288742f8.diff

[Lldb-commits] [PATCH] D153597: [lldb] Adjust for changes in objc runtime

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. This has been previously reviewed internally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153597/new/

[Lldb-commits] [PATCH] D153597: [lldb] Adjust for changes in objc runtime

bulbazord created this revision. bulbazord added a reviewer: JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The Objective-C runtime and the shared cache has changed slightly. Given a

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti requested review of this revision. ashgti added a comment. Hi @wallace I updated the tests and discovered a deadlock with my implementation of the SendReverseRequest. I refactored the function and added some additional tests to cover this more thoroughly. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti updated this revision to Diff 533806. ashgti added a comment. Cleaning up the runInTerminal test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/ https://reviews.llvm.org/D153447 Files:

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti updated this revision to Diff 533804. ashgti added a comment. Enhancing the test coverage and fixing an issue when a reverse request is invoked a request from a DAP request handler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/

[Lldb-commits] [PATCH] D153482: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153482/new/ https://reviews.llvm.org/D153482

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack added a comment. verified, Windows buildbot is now green. https://lab.llvm.org/buildbot/#/builders/219 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llvm.org/D153390

[Lldb-commits] [lldb] f9f279d - [lldb] Fix variable name mismatch between signature and docs (NFC)

Author: Jonas Devlieghere Date: 2023-06-22T13:50:54-07:00 New Revision: f9f279dc64ac8366fc9095a30d4e0e33827d6bc1 URL: https://github.com/llvm/llvm-project/commit/f9f279dc64ac8366fc9095a30d4e0e33827d6bc1 DIFF:

[Lldb-commits] [PATCH] D153482: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin

clayborg added a comment. Looks fine to me. I will let the owner of StructuredDataDarwinLog do the final approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153482/new/ https://reviews.llvm.org/D153482

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4071d22516: [lldb][Windows] Fix ZipFileResolver tests (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/

[Lldb-commits] [lldb] 5c4071d - [lldb][Windows] Fix ZipFileResolver tests

Author: Kazuki Sakamoto Date: 2023-06-22T10:42:40-07:00 New Revision: 5c4071d225169d22387dd27df0f32a4efc8a0caa URL: https://github.com/llvm/llvm-project/commit/5c4071d225169d22387dd27df0f32a4efc8a0caa DIFF:

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

kusmour accepted this revision. kusmour added a comment. The fix looks straightforward. And @splhack has verified locally. Accepting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llvm.org/D153390

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack added a comment. Yes, in fact ZipFileResolverTest is the test what is running on Windows, and failing due to POSIX vs Windows path. This diff will fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Can we test this? I will ok to unblock windows bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

DavidSpickett added a comment. In the bug report the user didn't have a debugserver on the remote, but the handling is the same for lldb-server or debugserver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153513/new/

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

DavidSpickett updated this revision to Diff 533534. DavidSpickett added a comment. Added a test from Python, which avoids a bunch of lit and Linux shell specific issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153513/new/

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

DavidSpickett added reviewers: JDevlieghere, jasonmolenda. DavidSpickett added a comment. I was about to say I don't have a way to test this but I think I might have now. Starting a platform, then moving lldb-server causes it to fail on Linux. Perhaps I can do that in an isolated way in a shell

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While looking at https://github.com/llvm/llvm-project/issues/61955 I noticed that when we send qLaunchGDBServer