[Lldb-commits] [PATCH] D153673: [lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

mib accepted this revision. mib added a comment. LGTM! May be removing the implicit conversion method to StringRef would make your unnecessary ConstString removal quest easier  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153673/new/

[Lldb-commits] [lldb] 080fa1e - [lldb] Use LLDB_LOGF for printf format strings in AppleObjCDeclVendor.cpp

Author: Dave Lee Date: 2023-06-24T15:02:01-07:00 New Revision: 080fa1ee38d65c84212fa5eb19c43bc10637fd75 URL: https://github.com/llvm/llvm-project/commit/080fa1ee38d65c84212fa5eb19c43bc10637fd75 DIFF: https://github.com/llvm/llvm-project/commit/080fa1ee38d65c84212fa5eb19c43bc10637fd75.diff

[Lldb-commits] [PATCH] D153710: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153710/new/ https://reviews.llvm.org/D153710

[Lldb-commits] [PATCH] D153711: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153711/new/ https://reviews.llvm.org/D153711

[Lldb-commits] [PATCH] D153711: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We are assuming that the pointer is always valid, might as well

[Lldb-commits] [PATCH] D153710: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We always assume the Stream pointer is valid, might as well be