[Lldb-commits] [lldb] 8ce2d90 - [lldb] Fix search & replace mistake in IRForTarget comment (NFC)

Author: Dave Lee Date: 2023-06-27T18:38:01-07:00 New Revision: 8ce2d90f1e80cf2665c2d27fc73d7d76eca91a5f URL: https://github.com/llvm/llvm-project/commit/8ce2d90f1e80cf2665c2d27fc73d7d76eca91a5f DIFF: https://github.com/llvm/llvm-project/commit/8ce2d90f1e80cf2665c2d27fc73d7d76eca91a5f.diff LOG:

[Lldb-commits] [lldb] 6feb35b - [lldb] Improve log message (NFC)

Author: Dave Lee Date: 2023-06-27T18:32:05-07:00 New Revision: 6feb35bac59ed341b90d182f1fd91aed5f840f24 URL: https://github.com/llvm/llvm-project/commit/6feb35bac59ed341b90d182f1fd91aed5f840f24 DIFF: https://github.com/llvm/llvm-project/commit/6feb35bac59ed341b90d182f1fd91aed5f840f24.diff LOG:

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153928/new/ https://reviews.llvm.org/D153928 ___

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG7d04c886f9e7: [lldb] Assert index is valid in DWARFDeclContext (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://r

[Lldb-commits] [lldb] 7d04c88 - [lldb] Assert index is valid in DWARFDeclContext

Author: Jonas Devlieghere Date: 2023-06-27T18:23:35-07:00 New Revision: 7d04c886f9e77efa5d73a7b1e2f3cdac395bf8ee URL: https://github.com/llvm/llvm-project/commit/7d04c886f9e77efa5d73a7b1e2f3cdac395bf8ee DIFF: https://github.com/llvm/llvm-project/commit/7d04c886f9e77efa5d73a7b1e2f3cdac395bf8ee.d

[Lldb-commits] [PATCH] D153917: [lldb][NFCI] Target::StopHook::GetDescription should take a Stream ref instead of pointer

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153917/new/ https://reviews.llvm.org/D153917 ___

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

bulbazord updated this revision to Diff 535199. bulbazord added a comment. Implement changes after discussing offline with Jonas and Ismail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153928/new/ https://reviews.llvm.org/D153928 Files: lldb/in

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

JDevlieghere added a comment. As discussed offline, I think it's impossible to enforce the semantic difference between the two and we'll inevitable end up with the `LLDB_UNSUPPORTED` used where `LLDB_DEPRECATED` should be used but someone didn't know, or worse someone decides to add a third mac

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h:58 Entry &operator[](uint32_t idx) { -// "idx" must be valid +assert(idx < m_entries.size() && "invalid index");

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

bulbazord added inline comments. Comment at: lldb/include/lldb/lldb-defines.h:134-140 +#if defined(__clang__) +#define LLDB_UNSUPPORTED(MSG) \ + __attribute__((deprecated("This method is no longer supported: " MSG, ""))) +#else +

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

mib added inline comments. Comment at: lldb/include/lldb/lldb-defines.h:134-140 +#if defined(__clang__) +#define LLDB_UNSUPPORTED(MSG) \ + __attribute__((deprecated("This method is no longer supported: " MSG, ""))) +#else +#defin

[Lldb-commits] [lldb] 7075f9d - Have GetKernelsAndKextsInDirectoryHelper request follow symlinks

Author: Jason Molenda Date: 2023-06-27T16:18:08-07:00 New Revision: 7075f9d926c93efefacb72caf17e93ae00b3703b URL: https://github.com/llvm/llvm-project/commit/7075f9d926c93efefacb72caf17e93ae00b3703b DIFF: https://github.com/llvm/llvm-project/commit/7075f9d926c93efefacb72caf17e93ae00b3703b.diff

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We already have LLDB_DEPRECATED which is used to mark methods as

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

bulbazord added inline comments. Comment at: lldb/include/lldb/API/SBValue.h:286 + LLDB_DEPRECATED("SBValue::GetOpaqueType() is deprecated. Do not use.", "") void *GetOpaqueType(); mib wrote: > JDevlieghere wrote: > > Similar comment as in D153900: The "Do

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

kastiglione added inline comments. Comment at: lldb/test/API/commands/platform/process/launch/TestPlatformProcessLaunch.py:50 +self.runCmd("settings set target.run-args D E") +self.runCmd("platform process launch --stdout {}".format(outfile)) +self.runCmd

[Lldb-commits] [PATCH] D153868: [lldb] Use LLVM's implementation of AppleTables for apple_objc

fdeazeve updated this revision to Diff 535163. fdeazeve added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153868/new/ https://reviews.llvm.org/D153868 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp lldb/so

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

fdeazeve updated this revision to Diff 535162. fdeazeve added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153867/new/ https://reviews.llvm.org/D153867 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp lldb/sou

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:232 + + llvm::StringRef expected_name = context[0].name; + JDevlieghere wrote: > JDevlieghere wrote: > > I assume we always have at least one entry (or that's th

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h:58 Entry &operator[](uint32_t idx) { -// "idx" must be valid +assert(idx < m_entries.size() && "invalid index"); return m_entries[idx]; Note the di

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153921/new/ https://reviews.llvm.org/D153921 ___ lldb-commits mai

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

This revision was automatically updated to reflect the committed changes. Closed by commit rG86fd957af981: [lldb] Duplicate Target::Launch resuming logic into… (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153922/new/ http

[Lldb-commits] [lldb] 86fd957 - [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

Author: Dave Lee Date: 2023-06-27T15:29:52-07:00 New Revision: 86fd957af981f146a306831608d7ad2de65b9560 URL: https://github.com/llvm/llvm-project/commit/86fd957af981f146a306831608d7ad2de65b9560 DIFF: https://github.com/llvm/llvm-project/commit/86fd957af981f146a306831608d7ad2de65b9560.diff LOG:

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve updated this revision to Diff 535160. fdeazeve added a comment. Fix rebase issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153866/new/ https://reviews.llvm.org/D153866 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve updated this revision to Diff 535155. fdeazeve added a comment. Rebase after addressing the extractor issue in a separate patch: D153913 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153866/new/ https://

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

mib added inline comments. Comment at: lldb/include/lldb/API/SBValue.h:286 + LLDB_DEPRECATED("SBValue::GetOpaqueType() is deprecated. Do not use.", "") void *GetOpaqueType(); JDevlieghere wrote: > Similar comment as in D153900: The "Do not use." part is red

[Lldb-commits] [PATCH] D153913: [lldb][NFC] Prevent slicing when converting DataExtractors

This revision was automatically updated to reflect the committed changes. Closed by commit rGab674234c440: [lldb][NFC] Prevent slicing when converting DataExtractors (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153913/new/ h

[Lldb-commits] [lldb] ab67423 - [lldb][NFC] Prevent slicing when converting DataExtractors

Author: Felipe de Azevedo Piovezan Date: 2023-06-27T18:09:40-04:00 New Revision: ab674234c440ed27302f58eeccc612c83b32c43f URL: https://github.com/llvm/llvm-project/commit/ab674234c440ed27302f58eeccc612c83b32c43f DIFF: https://github.com/llvm/llvm-project/commit/ab674234c440ed27302f58eeccc612c83

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. The fact that you had to duplicate code from Target::Launch means the various paths to Launching a process aren't properly factored out. However, that seems like a lot just to get Dave's fi

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

kastiglione added a subscriber: jingham. kastiglione added a comment. Thanks to @jingham's help in identifying this issue, I have opened https://reviews.llvm.org/D153922 as a potential fix for the issue on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBValue.h:286 + LLDB_DEPRECATED("SBValue::GetOpaqueType() is deprecated. Do not use.", "") void *GetOpaqueType(); Similar comment as in D153900: The "Do not use." part is redundant and im

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

kastiglione created this revision. kastiglione added reviewers: jingham, DavidSpickett. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix `platform process launch` on macOS where it fails for lack

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBHostOS.h:28-29 + LLDB_DEPRECATED("Threading functionality in SBHostOS is not well supported " + "and not portable. It is difficult to use from Python. Do " + "not introduce

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:232 + + llvm::StringRef expected_name = context[0].name; + JDevlieghere wrote: > I assume we always have at least one entry (or that's the assumption here).

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

JDevlieghere created this revision. JDevlieghere added a reviewer: fdeazeve. Herald added a subscriber: arphaman. Herald added a project: All. JDevlieghere requested review of this revision. Address my own comment from D153867 . https://reviews.llvm.org/D153921

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

JDevlieghere updated this revision to Diff 535136. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153834/new/ https://reviews.llvm.org/D153834 Files: lldb/include/lldb/Core/SourceManager.h lldb/include/lldb/Target/Process.h lldb/include

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

This revision was automatically updated to reflect the committed changes. Closed by commit rGca7914564e67: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [lldb] ca79145 - [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

Author: Jonas Devlieghere Date: 2023-06-27T14:19:02-07:00 New Revision: ca7914564e676fe52fa80049d9c6932653522424 URL: https://github.com/llvm/llvm-project/commit/ca7914564e676fe52fa80049d9c6932653522424 DIFF: https://github.com/llvm/llvm-project/commit/ca7914564e676fe52fa80049d9c6932653522424.d

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

kastiglione added inline comments. Comment at: lldb/test/API/commands/platform/process/launch/TestPlatformProcessLaunch.py:50 +self.runCmd("settings set target.run-args D E") +self.runCmd("platform process launch --stdout {}".format(outfile)) +self.runCmd

[Lldb-commits] [PATCH] D153913: [lldb][NFC] Prevent slicing when converting DataExtractors

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for addressing this. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153913/new/ https://reviews.llvm.org/D153913 __

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This method, as far as I can ascertain, is non-triv

[Lldb-commits] [PATCH] D153917: [lldb][NFCI] Target::StopHook::GetDescription should take a Stream ref instead of pointer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We always assume that this is valid anyway, might as well take a

[Lldb-commits] [PATCH] D153913: [lldb][NFC] Prevent slicing when converting DataExtractors

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB's implementation of DWARFDataExtractor has a method that returns a llvm::DWARFDa

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:26-29 + // We could just pass "debug_str.getAsLLVM()", but that would cause slicing: + // DWARFDataExtractor->DataExtractor + // since AppleAcceleratorTable ctors take non-DWAR

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

JDevlieghere updated this revision to Diff 535085. JDevlieghere added a comment. Fix boolean algebra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153834/new/ https://reviews.llvm.org/D153834 Files: lldb/include/lldb/Core/SourceManager.h lldb/include/lldb/Target/Process.h lldb/in

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

JDevlieghere added inline comments. Comment at: lldb/source/Core/SourceManager.cpp:86 - // It the target source path map has been updated, get this file again so we - // can successfully remap the source file - if (target_sp && file_sp && - file_sp->GetSourceMapModifica

[Lldb-commits] [PATCH] D153905: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

bulbazord updated this revision to Diff 535084. bulbazord added a comment. Remove unneeded newline from log line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153905/new/ https://reviews.llvm.org/D153905 Files: lldb/source/Plugins/ExpressionPars

[Lldb-commits] [PATCH] D153868: [lldb] Use LLVM's implementation of AppleTables for apple_objc

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153868/new/ https://reviews.llvm.org/D153868

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:232 + + llvm::StringRef expected_name = context[0].name; + I assume we

[Lldb-commits] [PATCH] D153905: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, Michael137, augusto2112, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. 2/3 of the ConstStrings in this class wer

[Lldb-commits] [PATCH] D153844: Summary: [lldb] Fix libncurses, libpanel library link order

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. This isn't a problem on macOS because both are in the shared cache. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, regardless of whether you decided the tackle the the DataExtractor issue. If you don't I would still encourage you to update/simplify/rephrase the comment. ===

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti updated this revision to Diff 535072. ashgti added a comment. Removing a dead comment that is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/ https://reviews.llvm.org/D153447 Files: lldb/packages/Python/lldbsuite/tes

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

clayborg added a comment. I think the SBHostOS::ThreadCreated() function used to just set the thread name for the current thread, but looks like that hasn't been hooked up for a while. Don't know who was using this before, but LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://reviews.llvm.org/D153900 ___

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, teemperor, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For some context, Raphael tried to this befo

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ivanhernandez13 accepted this revision. ivanhernandez13 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:569 + +// llvm::Error VSCode::Loop() { +// std::condition_variable cv; Dead code? Rep

[Lldb-commits] [PATCH] D153824: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd69ae0c5a7: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 1bd69ae - [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments

Author: Alex Langford Date: 2023-06-27T10:46:34-07:00 New Revision: 1bd69ae0c5a7e704979f6efa1c7d7c39d4e2d5c9 URL: https://github.com/llvm/llvm-project/commit/1bd69ae0c5a7e704979f6efa1c7d7c39d4e2d5c9 DIFF: https://github.com/llvm/llvm-project/commit/1bd69ae0c5a7e704979f6efa1c7d7c39d4e2d5c9.diff

[Lldb-commits] [PATCH] D153818: [lldb][NFCI] Remove use of ConstString from PluginManager

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec083107ff2: [lldb][NFCI] Remove use of ConstString from PluginManager (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153818/new/ h

[Lldb-commits] [lldb] 7ec0831 - [lldb][NFCI] Remove use of ConstString from PluginManager

Author: Alex Langford Date: 2023-06-27T10:43:35-07:00 New Revision: 7ec083107ff2dd72cb28e9cd8a45749e2619046c URL: https://github.com/llvm/llvm-project/commit/7ec083107ff2dd72cb28e9cd8a45749e2619046c DIFF: https://github.com/llvm/llvm-project/commit/7ec083107ff2dd72cb28e9cd8a45749e2619046c.diff

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. LGTM with a few nits. There is one piece of logic that I think does need to be changed before this can go in however. Comment at: lldb/source/Commands/Comman

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153726/new/ https://reviews.llvm.org/D153726 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

kastiglione added a comment. I will try to reproduce. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/ https://reviews.llvm.org/D153636 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D153891: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This uses rewrites DW_OP_addrx as a DW_OP_addr so that we can update addresses that are originally located in the debug_ad

[Lldb-commits] [PATCH] D153886: [DRAFT][lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve added a comment. This is here so I can link it in a discourse post. Please don't review seriously yet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153886/new/ https://reviews.llvm.org/D153886

[Lldb-commits] [PATCH] D153886: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve created this revision. Herald added a reviewer: shafik. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This uses a DenseMap to update addresses that are located in the debug_addr section. Re

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

DavidSpickett added a comment. Do you or anyone else have a Mac they can reproduce this on? I don't. I know it works on Linux so far, unfortunately our Windows bot is down temporarily. I looked around similar tests and didn't see any skips for Mac. Sometimes the packet log will tell us more, I

[Lldb-commits] [lldb] 3254623 - Revert "[LLDB] Fix the use of "platform process launch" with no extra arguments"

Author: David Spickett Date: 2023-06-27T14:04:41Z New Revision: 3254623d73fb7252385817d8057640c9d5d5ffd1 URL: https://github.com/llvm/llvm-project/commit/3254623d73fb7252385817d8057640c9d5d5ffd1 DIFF: https://github.com/llvm/llvm-project/commit/3254623d73fb7252385817d8057640c9d5d5ffd1.diff LOG

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:235 llvm::function_ref callback) { - if (!m_apple_names_up) -return; - - DWARFMappedHash::DIEInfoArray hash_data; - m_apple_names_up->AppendAllDIEsThatMatchingRegex(re

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve updated this revision to Diff 534951. fdeazeve added a comment. Improve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153866/new/ https://reviews.llvm.org/D153866 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp

[Lldb-commits] [PATCH] D153868: [lldb] Use LLVM's implementation of AppleTables for apple_objc

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This concludes the migration of accelerator tables from LLDB code to LLVM code. Rep

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This commit is replacing really old LLDB code, and we've found some

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. All the new code should match the behavior of the old exactly. Of note, the custom q

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

fdeazeve added a comment. I think this may have caused an LLDB test to fail: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56977/execution/node/74/log/ runCmd: platform process launch --stdout /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/command

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG956f5c5f6de8: [lldb] Use SmallVector for handling register data (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [lldb] 956f5c5 - [lldb] Use SmallVector for handling register data

Author: David Spickett Date: 2023-06-27T09:15:12Z New Revision: 956f5c5f6de88af7d0c9844ab40979bb45a51ad4 URL: https://github.com/llvm/llvm-project/commit/956f5c5f6de88af7d0c9844ab40979bb45a51ad4 DIFF: https://github.com/llvm/llvm-project/commit/956f5c5f6de88af7d0c9844ab40979bb45a51ad4.diff LOG

[Lldb-commits] [PATCH] D153844: Summary: [lldb] Fix libncurses, libpanel library link order

hauhsu created this revision. Herald added a project: All. hauhsu edited the summary of this revision. hauhsu added a reviewer: JDevlieghere. hauhsu added a subscriber: kito-cheng. Herald added a subscriber: pengfei. hauhsu published this revision for review. Herald added a project: LLDB. Herald ad

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc0fc3585405: [LLDB] Fix the use of "platform process launch" with no extra arguments (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] cc0fc35 - [LLDB] Fix the use of "platform process launch" with no extra arguments

Author: David Spickett Date: 2023-06-27T07:41:18Z New Revision: cc0fc358540517a3d205243c27bd543afeae2b02 URL: https://github.com/llvm/llvm-project/commit/cc0fc358540517a3d205243c27bd543afeae2b02 DIFF: https://github.com/llvm/llvm-project/commit/cc0fc358540517a3d205243c27bd543afeae2b02.diff LOG