[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

2023-07-02 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h:386 +// to add 1 to its return value. +return m_lock_count.fetch_add(1, std::memory_order_relaxed) + 1; + } JDevlieghere wrote: > Sorry if

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

2023-07-02 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 536573. mib added a comment. Make `DecrementLockCount` actually thread-safe and revert `IncrementLockCount` to its original implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154271/new/ https://reviews.llvm.org/D154271 Files: lldb/source

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

2023-07-02 Thread Nikolas Klauser via Phabricator via lldb-commits
philnik updated this revision to Diff 536620. philnik marked 16 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/Langu

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

2023-07-02 Thread Nikolas Klauser via Phabricator via lldb-commits
philnik updated this revision to Diff 536623. philnik edited the summary of this revision. philnik added a comment. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/Langua