[Lldb-commits] [lldb] 28c3380 - Remove unnecessary std::moves [NFC]

Author: Sterling Augustine Date: 2023-07-13T19:24:01-07:00 New Revision: 28c33805d49366b5ef22c60b32df62f123adc3bb URL: https://github.com/llvm/llvm-project/commit/28c33805d49366b5ef22c60b32df62f123adc3bb DIFF:

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

VladimirMakaev updated this revision to Diff 540251. VladimirMakaev added a comment. Herald added a reviewer: sscalpone. Rebased on master (this diff was quite a bit old) Addressed review comments - renamed method to ParseRustVariantPart - added CU check - added a good bunch of test covering

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti added a reviewer: wallace. ashgti added a comment. Hi wallace, this is a second attempt at this change set including updates to existing tests to check the behavior changes. LMKWYT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155248/new/

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 540219. ashgti added a comment. Adjusting the startDebugging test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155248/new/ https://reviews.llvm.org/D155248 Files:

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 540216. ashgti added a comment. Applying formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155248/new/ https://reviews.llvm.org/D155248 Files:

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a new flag and lldb runtime command to allow users to manage the behavior of the lldb-vscode evaluate repl

[Lldb-commits] [lldb] b716d4e - [lldb] Move decorators to test method

Author: Jonas Devlieghere Date: 2023-07-13T15:43:59-07:00 New Revision: b716d4e58543396894badd6ea8115c147ed12fae URL: https://github.com/llvm/llvm-project/commit/b716d4e58543396894badd6ea8115c147ed12fae DIFF:

[Lldb-commits] [PATCH] D155221: [lldb] Support compressed CTF

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG0e285a13eb7f: [lldb] Support compressed CTF (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 0e285a1 - [lldb] Support compressed CTF

Author: Jonas Devlieghere Date: 2023-07-13T15:10:25-07:00 New Revision: 0e285a13eb7f25d7609d6795fb2f3439c8b1c270 URL: https://github.com/llvm/llvm-project/commit/0e285a13eb7f25d7609d6795fb2f3439c8b1c270 DIFF:

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

MaskRay added a comment. In D155178#4499105 , @MaskRay wrote: > In D155178#4498911 , @thakis wrote: > >> http://45.33.8.238/linux/112305/step_4.txt looks like a missing include > > I've fixed it in

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

MaskRay added subscribers: mysterymath, phosek. MaskRay added a comment. In D155178#4498911 , @thakis wrote: > http://45.33.8.238/linux/112305/step_4.txt looks like a missing include I've fixed it in 816141ce0eb899178dbcb6f0671875eb825b2f84

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

JDevlieghere added inline comments. Comment at: lldb/source/API/SBStructuredData.cpp:51-53 + const lldb::SBDebugger ) { + return debugger.CreateStructuredDataFromScriptObject(obj); +} mib wrote: > bulbazord wrote: > > I

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:108 +} else { + $1 = $input; +} bulbazord wrote: > Do we actually have to do any conversions here? Like to turn it

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

thakis added a comment. http://45.33.8.238/linux/112305/step_4.txt looks like a missing include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155178/new/ https://reviews.llvm.org/D155178 ___

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

bulbazord added a comment. Very interesting, I think this will be pretty useful for the ergonomics of the SBAPI from python! Comment at: lldb/bindings/python/python-typemaps.swig:74-75 +if (!lldb_module) { + llvm::StringRef err_msg =

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3ff3af3086da: [lldb] Add missing StringExtras.h includes (authored by IncludeGuardian). Changed prior to commit:

[Lldb-commits] [lldb] 3ff3af3 - [lldb] Add missing StringExtras.h includes

Author: Elliot Goodrich Date: 2023-07-13T21:06:25+01:00 New Revision: 3ff3af3086da5df10d3991914262cef724156977 URL: https://github.com/llvm/llvm-project/commit/3ff3af3086da5df10d3991914262cef724156977 DIFF:

[Lldb-commits] [PATCH] D155221: [lldb] Support compressed CTF

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:151 + sizeof(ctf_header_t)); +

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

IncludeGuardian added a comment. @fdeazeve Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155178/new/ https://reviews.llvm.org/D155178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D154862: [lldb] Support Compact C Type Format (CTF)

This revision was automatically updated to reflect the committed changes. Closed by commit rGee44310a48b7: [lldb] Support Compact C Type Format (CTF) (authored by JDevlieghere). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D154668: [lldb] Support Compact C Type Format (CTF) section

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5aa4cff4323: [lldb] Support Compact C Type Format (CTF) section (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] ee44310 - [lldb] Support Compact C Type Format (CTF)

Author: Jonas Devlieghere Date: 2023-07-13T11:30:52-07:00 New Revision: ee44310a48b7d14336de75e170110e2fea90842b URL: https://github.com/llvm/llvm-project/commit/ee44310a48b7d14336de75e170110e2fea90842b DIFF:

[Lldb-commits] [lldb] e5aa4cf - [lldb] Support Compact C Type Format (CTF) section

Author: Jonas Devlieghere Date: 2023-07-13T11:30:35-07:00 New Revision: e5aa4cff43239930f87ada9183720d4182daa8fa URL: https://github.com/llvm/llvm-project/commit/e5aa4cff43239930f87ada9183720d4182daa8fa DIFF:

[Lldb-commits] [PATCH] D155129: [lldb] Move CommandOverrideCallbackWithResult to lldb_private namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rGc25e48c5d776: [lldb] Move CommandOverrideCallbackWithResult to lldb_private namespace (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c25e48c - [lldb] Move CommandOverrideCallbackWithResult to lldb_private namespace

Author: Alex Langford Date: 2023-07-13T11:21:35-07:00 New Revision: c25e48c5d776c5fb8f94f13a73f44cd930968c29 URL: https://github.com/llvm/llvm-project/commit/c25e48c5d776c5fb8f94f13a73f44cd930968c29 DIFF: https://github.com/llvm/llvm-project/commit/c25e48c5d776c5fb8f94f13a73f44cd930968c29.diff

[Lldb-commits] [PATCH] D155137: [lldb] Forward declare SBPlatform and SBTypeMember in SBDefines

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d7a3dcff778: [lldb] Forward declare SBPlatform and SBTypeMember in SBDefines (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1d7a3dc - [lldb] Forward declare SBPlatform and SBTypeMember in SBDefines

Author: Alex Langford Date: 2023-07-13T10:51:48-07:00 New Revision: 1d7a3dcff77837d63a2ef4a25ab3c683ed623ec8 URL: https://github.com/llvm/llvm-project/commit/1d7a3dcff77837d63a2ef4a25ab3c683ed623ec8 DIFF: https://github.com/llvm/llvm-project/commit/1d7a3dcff77837d63a2ef4a25ab3c683ed623ec8.diff

[Lldb-commits] [PATCH] D155221: [lldb] Support compressed CTF

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, mib. Herald added a project: All. JDevlieghere requested review of this revision. Add support for compressed CTF data. The flags in the header can indicate whether the CTF body is compressed with zlib deflate. This

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

fdeazeve added a comment. In D155178#4496936 , @IncludeGuardian wrote: > @MaskRay seems like `ninja` on its own after preparing `lldb` isn't enough to > build tests. I've now built llvm, clang, flang, bolt, lldb, + tests - I'm > hoping that this is it

[Lldb-commits] [PATCH] D155197: [lldb][NFC] Refactor test to enable subsequent reuse

fdeazeve added a comment. See the patch stack for the commit that benefits from this refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155197/new/ https://reviews.llvm.org/D155197 ___ lldb-commits

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve updated this revision to Diff 540001. fdeazeve added a comment. Minor comment improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155198/new/ https://reviews.llvm.org/D155198 Files: lldb/source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This rewrites DW_OP_addrx inside DWARFExpression as an DW_OP_addr so that we can update addresses that are originally

[Lldb-commits] [PATCH] D155197: [lldb][NFC] Refactor test to enable subsequent reuse

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On a subsequent commit, I intend to update the expression and call the evaluate function more times. This refactors

[Lldb-commits] [PATCH] D153886: [DRAFT][lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve abandoned this revision. fdeazeve added a comment. We're going with the other solution. See discourse thread linked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153886/new/ https://reviews.llvm.org/D153886

[Lldb-commits] [PATCH] D153891: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve abandoned this revision. fdeazeve added a comment. Now that we have agreement on the discourse thread, I'll close this, polish it, and post again with tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153891/new/

[Lldb-commits] [PATCH] D155100: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs

This revision was automatically updated to reflect the committed changes. Closed by commit rG85c2e420c87c: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 85c2e42 - [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs

Author: Felipe de Azevedo Piovezan Date: 2023-07-13T08:27:29-04:00 New Revision: 85c2e420c87c20af6a7e1699a7317d8adc51b5ff URL: https://github.com/llvm/llvm-project/commit/85c2e420c87c20af6a7e1699a7317d8adc51b5ff DIFF:

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

IncludeGuardian added a comment. Herald added subscribers: Michael137, JDevlieghere. @MaskRay seems like `ninja` on its own after preparing `lldb` isn't enough to build tests. I've now built llvm, clang, flang, bolt, lldb, + tests - I'm hoping that this is it now! Repository: rG LLVM Github

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

IncludeGuardian created this revision. IncludeGuardian added a reviewer: MaskRay. Herald added a subscriber: hiraditya. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. **1st

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib created this revision. mib added reviewers: jingham, JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds the ability to pass native types from the script interpreter to

[Lldb-commits] [PATCH] D155018: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 5)

This revision was automatically updated to reflect the committed changes. Closed by commit rG90bfe2df25e7: [lldb] Add missing StringExtras.h includes (authored by IncludeGuardian). Changed prior to commit: https://reviews.llvm.org/D155018?vs=539291=539872#toc Repository: rG LLVM Github

[Lldb-commits] [lldb] 90bfe2d - [lldb] Add missing StringExtras.h includes

Author: Elliot Goodrich Date: 2023-07-13T08:39:59+01:00 New Revision: 90bfe2df25e7eed4f3af33623ad26a028d94cef9 URL: https://github.com/llvm/llvm-project/commit/90bfe2df25e7eed4f3af33623ad26a028d94cef9 DIFF: