[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

2023-07-17 Thread Nikolas Klauser via Phabricator via lldb-commits
philnik added a comment. In D151683#4508209 , @MaskRay wrote: > Reverse ping @philnik :) > > The `release/17.x` branch will be created soon > (https://discourse.llvm.org/t/llvm-17-0-0-release-planning-and-update/71762). I know. I just didn't have the

[Lldb-commits] [PATCH] D155256: Add fs_base/gs_base support for Linux

2023-07-17 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan updated this revision to Diff 541272. yinghuitan edited the summary of this revision. yinghuitan added a comment. Revert x86_64 changes to reduce amount of changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

2023-07-17 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added a comment. Reverse ping @philnik :) The `release/17.x` branch will be created soon (https://discourse.llvm.org/t/llvm-17-0-0-release-planning-and-update/71762). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

2023-07-17 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Seeing some before and after disassembler dumps would be nice to see what is changing. We might also want a new lldb setting that could be set with "settings set disassembly-branch-offsets [relative|absolute]" where setting it to "relative" would keep things as they

[Lldb-commits] [PATCH] D155030: [lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue

2023-07-17 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1b29a848ffa2: [lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1b29a84 - [lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue

2023-07-17 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-17T12:53:34-07:00 New Revision: 1b29a848ffa2d2c108de9e64de1d271e10db25f0 URL: https://github.com/llvm/llvm-project/commit/1b29a848ffa2d2c108de9e64de1d271e10db25f0 DIFF: https://github.com/llvm/llvm-project/commit/1b29a848ffa2d2c108de9e64de1d271e10db25f0.diff

[Lldb-commits] [PATCH] D155030: [lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue

2023-07-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155030/new/ https://reviews.llvm.org/D155030

[Lldb-commits] [lldb] b9541b6 - Fix the root directory completion test.

2023-07-17 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2023-07-17T10:52:29-07:00 New Revision: b9541b6707715b8ea07b47f453f001e698195b3e URL: https://github.com/llvm/llvm-project/commit/b9541b6707715b8ea07b47f453f001e698195b3e DIFF: https://github.com/llvm/llvm-project/commit/b9541b6707715b8ea07b47f453f001e698195b3e.diff

[Lldb-commits] [PATCH] D155269: [lldb][AArch64] Add SME streaming vector length pseudo register

2023-07-17 Thread Thorsten via Phabricator via lldb-commits
tschuett added a comment. Could you offer higher abstractions? Show me the current SVME vector length? Show me the current SVME mode? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155269/new/ https://reviews.llvm.org/D155269

[Lldb-commits] [PATCH] D155269: [lldb][AArch64] Add SME streaming vector length pseudo register

2023-07-17 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D155269#4505021 , @DavidSpickett wrote: >> As you say above, we can show svg when in non-streaming mode but we can't >> show vg when in streaming mode. Should we only show a single vg for the >> currently-available

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

2023-07-17 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I am wondering if we actually need the second step (the architecture setting) here. The main reason it exists is the usage in `GetSupportedArchitectures` (which is called before a target is created) it seems like the value derived from the target should always be more

[Lldb-commits] [PATCH] D154823: [lldb][AArch64] Add test predicate for systems with SME enabled

2023-07-17 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3ebd6f65cb87: [lldb][AArch64] Add test predicate for systems with SME enabled (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3ebd6f6 - [lldb][AArch64] Add test predicate for systems with SME enabled

2023-07-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-07-17T09:27:12+01:00 New Revision: 3ebd6f65cb87af5227ad64f53e1a5a59022f61a0 URL: https://github.com/llvm/llvm-project/commit/3ebd6f65cb87af5227ad64f53e1a5a59022f61a0 DIFF:

[Lldb-commits] [PATCH] D154705: [lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic

2023-07-17 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfdf36c3d4b46: [lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154705/new/

[Lldb-commits] [lldb] fdf36c3 - [lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic

2023-07-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-07-17T08:11:15Z New Revision: fdf36c3d4b467a48b628c96cc7e34c2f4bf090da URL: https://github.com/llvm/llvm-project/commit/fdf36c3d4b467a48b628c96cc7e34c2f4bf090da DIFF: https://github.com/llvm/llvm-project/commit/fdf36c3d4b467a48b628c96cc7e34c2f4bf090da.diff

[Lldb-commits] [PATCH] D155269: [lldb][AArch64] Add SME streaming vector length pseudo register

2023-07-17 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett planned changes to this revision. DavidSpickett added a comment. > As you say above, we can show svg when in non-streaming mode but we can't > show vg when in streaming mode. Should we only show a single vg for the > currently-available registers? I will admit I don't have

[Lldb-commits] [PATCH] D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

2023-07-17 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/tls_registers/TestAArch64LinuxTLSRegisters.py:73 + +@skipUnlessArch("aarch64") +@skipUnlessPlatform(["linux"]) omjavaid wrote: > These three tests have a lot of commonalities

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

2023-07-17 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:222 + // In SIMD or Full mode, the data comes from the SVE regset. In streaming + // mode, it also comes from that set, so we have to switch temporarily.