[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

yinghuitan updated this revision to Diff 542292. yinghuitan added a comment. Use coredump fs_base/gs_base values from thread_crash test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/ https://reviews.llvm.org/D155256 Files:

[Lldb-commits] [PATCH] D155768: [lldb] [NFC] Remove some dead code from Watchpoint class, and a method that makes no sense

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, atanasyan, kristof.beyls, arichardson, sdardis. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. Johnny Chen added

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib added a comment. In D155161#4516564 , @bulbazord wrote: > I'm good with this approach. One thing to note is that this change is > explicitly **ABI breaking**. Specifically this change removes > `lldb::ScriptedObject` so

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

bulbazord added a comment. I'm good with this approach. One thing to note is that this change is explicitly **ABI breaking**. Specifically this change removes `lldb::ScriptedObject` so `SBProcess::GetScriptedImplementation`'s return value changes. `lldb::ScriptedObject` was originally added in

[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

dblaikie added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:1082-1089 void *src = (void *)stack.back().GetScalar().ULongLong(); intptr_t ptr; ::memcpy(, src, sizeof(void *)); // I can't decide whether the size

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib updated this revision to Diff 542217. mib marked 10 inline comments as done. mib edited the summary of this revision. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155161/new/ https://reviews.llvm.org/D155161 Files:

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b19d13fde6e: [lldb] Make frame var --regex always search globals (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155334/new/

[Lldb-commits] [lldb] 8b19d13 - [lldb] Make frame var --regex always search globals

Author: Felipe de Azevedo Piovezan Date: 2023-07-19T17:11:21-04:00 New Revision: 8b19d13fde6e32c8815f3f4e3f629208b0f1d0e9 URL: https://github.com/llvm/llvm-project/commit/8b19d13fde6e32c8815f3f4e3f629208b0f1d0e9 DIFF:

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d1f89c2e37c: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl… (authored by ashgti, committed by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 3d1f89c - [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

Author: John Harrison Date: 2023-07-19T21:04:12Z New Revision: 3d1f89c2e37c4cf9017842a7d04ae07a5e096d08 URL: https://github.com/llvm/llvm-project/commit/3d1f89c2e37c4cf9017842a7d04ae07a5e096d08 DIFF: https://github.com/llvm/llvm-project/commit/3d1f89c2e37c4cf9017842a7d04ae07a5e096d08.diff

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione updated this revision to Diff 542169. kastiglione added a comment. Redo ValueObjectDynamicValue::UpdateValue changes based on upstream testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152837/new/ https://reviews.llvm.org/D152837

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Excellent! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155334/new/ https://reviews.llvm.org/D155334

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

fdeazeve updated this revision to Diff 542122. fdeazeve added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155334/new/ https://reviews.llvm.org/D155334 Files: lldb/include/lldb/Symbol/VariableList.h

[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

dblaikie added a comment. In D154907#4487335 , @jasonmolenda wrote: > This looks good to me, thanks for digging in Caroline! Is there a naughty > compiler emitting this, or are we mis-parsing somehow? In D154907#4487523

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. LGTM, with a couple suggestions. You did add a check for requested scope when applying the regex which was missing in the original implementation. That's correct, but I don't

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

fdeazeve updated this revision to Diff 541987. fdeazeve added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155334/new/ https://reviews.llvm.org/D155334 Files: lldb/include/lldb/Symbol/VariableList.h

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve updated this revision to Diff 541986. fdeazeve added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155198/new/ https://reviews.llvm.org/D155198 Files: lldb/source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D155197: [lldb][NFC] Refactor test to enable subsequent reuse

This revision was automatically updated to reflect the committed changes. Closed by commit rG00c60496775b: [lldb][NFC] Refactor test to enable subsequent reuse (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155197/new/

[Lldb-commits] [lldb] 00c6049 - [lldb][NFC] Refactor test to enable subsequent reuse

Author: Felipe de Azevedo Piovezan Date: 2023-07-19T09:15:48-04:00 New Revision: 00c60496775b611d92bae5a69d4e6794ecad4084 URL: https://github.com/llvm/llvm-project/commit/00c60496775b611d92bae5a69d4e6794ecad4084 DIFF:

[Lldb-commits] [PATCH] D155332: [lldb][NFC] Factor out CommandObject code filtering results based on scope

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc97a3ee4f4: [lldb][NFC] Factor out CommandObject code filtering results based on scope (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8bc97a3 - [lldb][NFC] Factor out CommandObject code filtering results based on scope

Author: Felipe de Azevedo Piovezan Date: 2023-07-19T09:14:02-04:00 New Revision: 8bc97a3ee4f411e583a13e0966239848080d753d URL: https://github.com/llvm/llvm-project/commit/8bc97a3ee4f411e583a13e0966239848080d753d DIFF:

[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py:647 +self.assertTrue(reg_gs_base.IsValid(), "gs_base is not available") +# The fs_base/gs_base registers in linux-x86_64.core are both zero. +

[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/register_command/TestRegisters.py:613 +def test_fs_gs_base(self): +"""Tests fs_base register can be read and equals to pthread_self() return value.""" +self.build()

[Lldb-commits] [lldb] 865b119 - [lldb] XFAIL command-disassemble-mixed.c on Windows

Author: David Spickett Date: 2023-07-19T09:04:56Z New Revision: 865b1190e67c9c28677866d96ccab42894efdc4c URL: https://github.com/llvm/llvm-project/commit/865b1190e67c9c28677866d96ccab42894efdc4c DIFF: https://github.com/llvm/llvm-project/commit/865b1190e67c9c28677866d96ccab42894efdc4c.diff