[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

jasonmolenda created this revision. jasonmolenda added reviewers: bulbazord, JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. We have some corefiles which are intended to debug a

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

jasonmolenda created this revision. jasonmolenda added reviewers: bulbazord, JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added subscribers: lldb-commits, wangpc. DynamicLoader::LoadBinaryWithUUIDAndAddress()

[Lldb-commits] [lldb] a330759 - [lldb] Fix -Wsign-compare in TestSectionSize.cpp (NFC)

Author: Jie Fu Date: 2023-08-05T08:34:19+08:00 New Revision: a330759d6e4b7b241b70092e3dd1d0e237ad2a8a URL: https://github.com/llvm/llvm-project/commit/a330759d6e4b7b241b70092e3dd1d0e237ad2a8a DIFF: https://github.com/llvm/llvm-project/commit/a330759d6e4b7b241b70092e3dd1d0e237ad2a8a.diff LOG:

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

bulbazord added inline comments. Comment at: lldb/source/Core/Communication.cpp:43 + std::unique_lock guard(m_shared_mutex); LLDB_LOG(GetLog(LLDBLog::Communication), JDevlieghere wrote: > augusto2112 wrote: > > Do you think it's possible that between the

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere added inline comments. Comment at: lldb/source/Core/Communication.cpp:43 + std::unique_lock guard(m_shared_mutex); LLDB_LOG(GetLog(LLDBLog::Communication), augusto2112 wrote: > Do you think it's possible that between the call to `Clear` and

[Lldb-commits] [PATCH] D157165: [lldb] [darwin kernel debug] When looking for a Darwin kernel symbol file, call GetSharedModules before DownloadObjectAndSymbolFile

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. ModuleList::GetSharedModule will call in to the DebugSymbols

[Lldb-commits] [PATCH] D157137: [lldb/crashlog] Skip images with empty path and 0 UUID from loading

bulbazord added inline comments. Comment at: lldb/examples/python/symbolication.py:413-418 name = os.path.basename(self.path) +if not name: +if self.uuid == uuid.UUID(int=0): +return None +

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

bulbazord added inline comments. Comment at: lldb/source/Core/Communication.cpp:41-43 Clear(); + std::unique_lock guard(m_shared_mutex); I think this one //may// be slightly incorrect. Here's how I imagine it going wrong: - Thread 1 calls Connect. It

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. On the description you mention `unique_ptr` but I only see `shared_ptr` here. Was that a typo or do you mean that users of this class kept it behind a `unique_ptr`? In any case I

[Lldb-commits] [lldb] 34fe58e - [lldb] Add a deduction guides for scoped_lock in OptionValue.cpp & ThreadList.cpp (NFC)

Author: Jie Fu Date: 2023-08-05T07:56:38+08:00 New Revision: 34fe58e0bc76eff973c9dd7daeddf13c38d184d9 URL: https://github.com/llvm/llvm-project/commit/34fe58e0bc76eff973c9dd7daeddf13c38d184d9 DIFF: https://github.com/llvm/llvm-project/commit/34fe58e0bc76eff973c9dd7daeddf13c38d184d9.diff LOG:

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. On Darwin systems, lldb

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, augusto2112. Herald added a project: All. JDevlieghere requested review of this revision. The Communication class was trying to (ab)use `unique_ptr's` atomic properties to protected it from concurrent access. Replace it

[Lldb-commits] [PATCH] D157153: [lldb] Fix ThreadList::Update not locking the rhs's mutex

This revision was automatically updated to reflect the committed changes. Closed by commit rGd75dc9a8a86c: [lldb] Fix ThreadList::Update not locking the rhss mutex (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157153/new/

[Lldb-commits] [lldb] d75dc9a - [lldb] Fix ThreadList::Update not locking the rhs's mutex

Author: Augusto Noronha Date: 2023-08-04T16:01:20-07:00 New Revision: d75dc9a8a86c4f69408dcab3a21416729d14652e URL: https://github.com/llvm/llvm-project/commit/d75dc9a8a86c4f69408dcab3a21416729d14652e DIFF:

[Lldb-commits] [PATCH] D157153: [lldb] Fix ThreadList::Update not locking the rhs's mutex

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157153/new/ https://reviews.llvm.org/D157153

[Lldb-commits] [PATCH] D157153: [lldb] Fix ThreadList::Update not locking the rhs's mutex

augusto2112 created this revision. augusto2112 added reviewers: jingham, JDevlieghere. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ThreadList::Update is being caught by thread sanitizer. There's

[Lldb-commits] [PATCH] D157152: [lldb] Make TSan errors fatal when running the test suite

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, augusto2112. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. Set the `halt_on_error` runtime flag to make TSan errors fatal when running the test

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. I believe the unit tests should be updated to ensure that we get `EISDIR` when opening directories for reading and for writing: `llvm/unittests/Support/Path.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/Unix/Path.inc:1020 +struct stat Status; +if (stat(P.begin(), ) == -1) + return std::error_code(errno, std::generic_category()); Please try using `fstat` on the result of

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

This revision was automatically updated to reflect the committed changes. Closed by commit rG318f600722e3: [lldb] Protect OptionValue accesses from data races (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/

[Lldb-commits] [lldb] 318f600 - [lldb] Protect OptionValue accesses from data races

Author: Augusto Noronha Date: 2023-08-04T15:33:46-07:00 New Revision: 318f600722e3cc6745317bb68309f82656c97b27 URL: https://github.com/llvm/llvm-project/commit/318f600722e3cc6745317bb68309f82656c97b27 DIFF:

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

JDevlieghere added a comment. In D157041#4562033 , @aprantl wrote: >> If it's straightforward, I think would be nice to have a unit test with two >> threads modifying the same OptionValue. That way a TSan run would catch this >> issue. If that's more

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

aprantl added a comment. > If it's straightforward, I think would be nice to have a unit test with two > threads modifying the same OptionValue. That way a TSan run would catch this > issue. If that's more work than expected then this is fine as is. We might just want to set up a bot that runs

[Lldb-commits] [lldb] ecbe78c - [lldb] Fix Python test formatting (NFC)

Author: Jonas Devlieghere Date: 2023-08-04T14:36:13-07:00 New Revision: ecbe78c124a78a4ea6e06b1d52ce281dcc394332 URL: https://github.com/llvm/llvm-project/commit/ecbe78c124a78a4ea6e06b1d52ce281dcc394332 DIFF:

[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe0053bc04e6b: [lldb] Bump SWIG minimum version to 4 (authored by JDevlieghere). Herald added a project: LLDB. Changed

[Lldb-commits] [lldb] e0053bc - [lldb] Bump SWIG minimum version to 4

Author: Jonas Devlieghere Date: 2023-08-04T14:34:01-07:00 New Revision: e0053bc04e6b80ece8b334b268c2942e012009b9 URL: https://github.com/llvm/llvm-project/commit/e0053bc04e6b80ece8b334b268c2942e012009b9 DIFF:

[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

JDevlieghere added a comment. I didn't expect this to be controversial and I hear no objection so I'm going to go ahead and land this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156804/new/ https://reviews.llvm.org/D156804 ___

[Lldb-commits] [PATCH] D157137: [lldb/crashlog] Skip images with empty path and 0 UUID from loading

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch skips images with an empty path or a 0 UUID from loading as a SymbolFileJSON.

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f092f37b736: [llvm] Extract common `OptTable` bits into macros (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/

[Lldb-commits] [lldb] 3f092f3 - [llvm] Extract common `OptTable` bits into macros

Author: Jan Svoboda Date: 2023-08-04T13:57:13-07:00 New Revision: 3f092f37b7362447cbb13f5502dae4bdd5762afd URL: https://github.com/llvm/llvm-project/commit/3f092f37b7362447cbb13f5502dae4bdd5762afd DIFF: https://github.com/llvm/llvm-project/commit/3f092f37b7362447cbb13f5502dae4bdd5762afd.diff

[Lldb-commits] [lldb] e9040e8 - [lldb][PECOFF] Exclude alignment padding when reading section data

Author: Hiroshi Yamauchi Date: 2023-08-04T13:38:30-07:00 New Revision: e9040e875d9252f726c41579f70663154718c3c6 URL: https://github.com/llvm/llvm-project/commit/e9040e875d9252f726c41579f70663154718c3c6 DIFF:

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hjyamauchi marked an inline comment as done. Closed by commit rGe9040e875d92: [lldb][PECOFF] Exclude alignment padding when reading section data (authored by

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 updated this revision to Diff 547318. augusto2112 added a comment. Remove lock from DeepCopy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/ https://reviews.llvm.org/D157041 Files:

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. If it's straightforward, I think would be nice to have a unit test with two threads modifying the same `OptionValue`. That way a TSan run would catch this issue. If that's

[Lldb-commits] [PATCH] D157122: [lldb] Remove support for SBHostOS threading functionality

bulbazord updated this revision to Diff 547290. bulbazord added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Updating release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157122/new/

[Lldb-commits] [PATCH] D157043: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157043/new/ https://reviews.llvm.org/D157043 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 updated this revision to Diff 547284. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/ https://reviews.llvm.org/D157041 Files: lldb/include/lldb/Interpreter/OptionValue.h

[Lldb-commits] [PATCH] D157122: [lldb] Remove support for SBHostOS threading functionality

bulbazord created this revision. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As stated on Discourse*, these methods have been deprecated. I am removing their implementation. They will now do

[Lldb-commits] [PATCH] D157044: [lldb/crashlog] Fix sticky image parsing logic

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. The `images` list was added in D146765 . Do you remember why we needed it there and why we don't anymore? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG786bab433469: Display PC instead of unknown for stack trace in vscode (authored by zhyty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156732/new/

[Lldb-commits] [lldb] 786bab4 - Display PC instead of for stack trace in vscode

Author: Tom Yang Date: 2023-08-04T11:07:27-07:00 New Revision: 786bab43346939d5662c2a90f8c0ff72fe421614 URL: https://github.com/llvm/llvm-project/commit/786bab43346939d5662c2a90f8c0ff72fe421614 DIFF: https://github.com/llvm/llvm-project/commit/786bab43346939d5662c2a90f8c0ff72fe421614.diff

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

JDevlieghere added a comment. Despite their prevalence in LLDB, I still consider `recursive_mutex` as a potential code smell. So +1 on avoiding the need for a recursive mutex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere updated this revision to Diff 547274. JDevlieghere marked 7 inline comments as done. JDevlieghere added a comment. - Add Pavel's nominations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 Files: lldb/CODE_OWNERS.txt

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

hjyamauchi marked an inline comment as done. hjyamauchi added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:1035 + // llvm::object::COFFObjectFile::getSectionSize(). + if (m_binary->getDOSHeader()) +return

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

hjyamauchi updated this revision to Diff 547272. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157059/new/ https://reviews.llvm.org/D157059 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

[Lldb-commits] [lldb] 4185656 - Fix the NSIndexSet data formatter for changes in macOS Sonoma.

Author: Jim Ingham Date: 2023-08-04T09:55:59-07:00 New Revision: 4185656625a249832ff67f628bd00e5278721c96 URL: https://github.com/llvm/llvm-project/commit/4185656625a249832ff67f628bd00e5278721c96 DIFF: https://github.com/llvm/llvm-project/commit/4185656625a249832ff67f628bd00e5278721c96.diff

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

VladimirMakaev added a comment. I don't have commit access to the repo. Since this was accepted can somebody commit this to the repo? CC @clayborg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149213/new/ https://reviews.llvm.org/D149213

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

aprantl added inline comments. Comment at: lldb/source/Interpreter/OptionValue.cpp:55 const OptionValueBoolean *OptionValue::GetAsBoolean() const { + std::lock_guard lock(m_mutex); if (GetType() == OptionValue::eTypeBoolean) If you are following

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

zequanwu added inline comments. Comment at: lldb/CodeOwners.rst:132 + +Breakpad + labath wrote: > @zequanwu I accept this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

mgorny added a comment. Yeah, that's why I CC-ed the two people who committed that API, as I don't really understand how it's supposed to work (and don't really have the capacity to figure it out). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

MrTrillian accepted this revision. MrTrillian added a comment. Looking good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157059/new/ https://reviews.llvm.org/D157059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

DavidSpickett added inline comments. Comment at: lldb/CodeOwners.rst:150 + +ELF +~~~ labath wrote: > @DavidSpickett Ok with me. Comment at: lldb/CodeOwners.rst:220 + +lldb-server +~~~ labath wrote: > @DavidSpickett

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. Herald added a subscriber: wangpc. I've not spotted any major concerns with this patch, but I did have some minor nits to look into. I'd love to hear from @rsmith and @erichkeane before signing off on this, as the changes are pretty involved and they've both done

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

labath accepted this revision. labath added a comment. I've suggested some additional/alternative/backup (choose your interpretation) owners for the components I'm listed as the only owner (I only wish I could find someone to take over android). If they accept, then take this as my endorsement

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

aaron.ballman added inline comments. Comment at: lldb/CodeOwners.rst:7-8 +particular part of LLDB are reviewed, either by themself or by someone else. +They are also the gatekeepers for their part of LLDB, with the final word on +what goes in or not. + tonic

[Lldb-commits] [PATCH] D156997: [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGe383776ad0fb: [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable (authored by jryans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e383776 - [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable

Author: J. Ryan Stinnett Date: 2023-08-04T11:24:36+01:00 New Revision: e383776ad0fbbe3d3704558fc8852c826680ce8f URL: https://github.com/llvm/llvm-project/commit/e383776ad0fbbe3d3704558fc8852c826680ce8f DIFF:

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

DavidSpickett added a comment. > Do you have any additional information about the failure? The link looks like > a timeout, so I'm not sure where things are timing out. Sorry for the false alarm, https://github.com/llvm/llvm-project/commit/9a3f0cd717f68ccf9e348bce2d76a2372482f4f2 fixed a few

[Lldb-commits] [lldb] 27a0a74 - Revert "[lldb][lldb-vscode] Skip disassembler test on Arm"

Author: David Spickett Date: 2023-08-04T09:26:40Z New Revision: 27a0a743cff3734f56358ee6c1f5b0dab3342dc4 URL: https://github.com/llvm/llvm-project/commit/27a0a743cff3734f56358ee6c1f5b0dab3342dc4 DIFF: https://github.com/llvm/llvm-project/commit/27a0a743cff3734f56358ee6c1f5b0dab3342dc4.diff