[Lldb-commits] [PATCH] D157589: [lldb] Fix building with latest libc++

mstorsjo created this revision. mstorsjo added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. Since https://reviews.llvm.org/D157058 in libc++, the base template for char_traits has been removed - it is

[Lldb-commits] [PATCH] D157589: [lldb] Fix building with latest libc++

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157589/new/ https://reviews.llvm.org/D157589

[Lldb-commits] [PATCH] D157589: [lldb] Fix building with latest libc++

This revision was automatically updated to reflect the committed changes. Closed by commit rG68744ffbdd7d: [lldb] Fix building with latest libc++ (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157589/new/ https://reviews.llvm.

[Lldb-commits] [lldb] 68744ff - [lldb] Fix building with latest libc++

Author: Martin Storsjö Date: 2023-08-10T12:59:35+03:00 New Revision: 68744ffbdd7daac41da274eef9ac0d191e11c16d URL: https://github.com/llvm/llvm-project/commit/68744ffbdd7daac41da274eef9ac0d191e11c16d DIFF: https://github.com/llvm/llvm-project/commit/68744ffbdd7daac41da274eef9ac0d191e11c16d.diff

[Lldb-commits] [PATCH] D157609: WIP: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB. DavidSpickett planned changes to this revision. Herald added

[Lldb-commits] [PATCH] D157609: WIP: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett added a comment. For https://github.com/llvm/llvm-project/issues/28667 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/Event.h:228 void Clear() { m_data_sp.reset(); } + + /// This is used by Broadcasters with Primary Listeners to store the other Nit: trailing whitespace Comment at:

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

bulbazord accepted this revision. bulbazord added a comment. Sorry, this fell off my radar for a while. I re-read through it and it looks fine to me, the lambda vs static methods function thing doesn't really matter much. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141702/new/

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D157636: [lldb][test] Remove tests relying on deprecated std::char_traits specializations

Michael137 created this revision. Michael137 added reviewers: gribozavr2, JDevlieghere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. (motivated by test failures after D157058

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c135f1478cd: [lldb] Fix data race in NativeFile (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D157347?vs=548849&id=549116#toc Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [lldb] 9c135f1 - [lldb] Fix data race in NativeFile

Author: Jonas Devlieghere Date: 2023-08-10T11:13:47-07:00 New Revision: 9c135f1478cd9d7c81c11c6a6c9ac85b16d68d74 URL: https://github.com/llvm/llvm-project/commit/9c135f1478cd9d7c81c11c6a6c9ac85b16d68d74 DIFF: https://github.com/llvm/llvm-project/commit/9c135f1478cd9d7c81c11c6a6c9ac85b16d68d74.d

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. On the Swift forums [1][2], people are disabling SIP in order to debug process that are missing the get-task-allow entitlement. Imp

[Lldb-commits] [PATCH] D157538: [lldb][NFCI] Remove use of ifdef __cpluplus where unneeded

This revision was automatically updated to reflect the committed changes. Closed by commit rGd21ec35dcf3c: [lldb][NFCI] Remove use of ifdef __cpluplus where unneeded (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157538/new/

[Lldb-commits] [PATCH] D157636: [lldb][test] Remove tests relying on deprecated std::char_traits specializations

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. If this was important we could put this behind a define, break up the test and conditionally skip it based on the libc++ version. But I personally don't think that's worth it for t

[Lldb-commits] [lldb] d21ec35 - [lldb][NFCI] Remove use of ifdef __cpluplus where unneeded

Author: Alex Langford Date: 2023-08-10T11:24:40-07:00 New Revision: d21ec35dcf3c351395522807beac0f45b7bcf6b9 URL: https://github.com/llvm/llvm-project/commit/d21ec35dcf3c351395522807beac0f45b7bcf6b9 DIFF: https://github.com/llvm/llvm-project/commit/d21ec35dcf3c351395522807beac0f45b7bcf6b9.diff

[Lldb-commits] [PATCH] D157636: [lldb][test] Remove tests relying on deprecated std::char_traits specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rG487ab39a5082: [lldb][test] Remove tests relying on deprecated std::char_traits specializations (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] 487ab39 - [lldb][test] Remove tests relying on deprecated std::char_traits specializations

Author: Michael Buch Date: 2023-08-10T19:48:44+01:00 New Revision: 487ab39a5082098f92e886de606505f25031a22a URL: https://github.com/llvm/llvm-project/commit/487ab39a5082098f92e886de606505f25031a22a DIFF: https://github.com/llvm/llvm-project/commit/487ab39a5082098f92e886de606505f25031a22a.diff

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

clayborg added inline comments. Comment at: lldb/source/Target/Process.cpp:372 +const int Process::g_all_event_bits = eBroadcastBitStateChanged + | eBroadcastBitInterrupt mib wrote: > nit: this could probably be `constexpr` yes, th

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

jasonmolenda added a comment. I'm fine with this but on macOS I believe it's com.apple.security.get-task-allow v. "Entitlements on macOS" https://developer.apple.com/documentation/technotes/tn3125-inside-code-signing-provisioning-profiles CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

jasonmolenda added a comment. Maybe get-task-allow is allowed (lol) on macOS too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157640/new/ https://reviews.llvm.org/D157640 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

jasonmolenda added a comment. Maybe const char *ent_name = #if TARGET_OS_OSX "com.apple.security.get-task-allow"; #else "get-task-allow"; #endif debugserver is running on the target device so compile time checks are fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15764

[Lldb-commits] [PATCH] D157636: [lldb][test] Remove tests relying on deprecated std::char_traits specializations

gribozavr2 added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157636/new/ https://reviews.llvm.org/D157636 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

augusto2112 created this revision. augusto2112 added reviewers: bulbazord, JDevlieghere. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sanitizer reports a data race in Process.cpp in the usa

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

jingham added a comment. In this function we have the path to the binary. We could spawn `codesign -d -entitlements -` and then we would know whether it had that entitlement. Maybe that's more work than you wanted to do here, however. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1576

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

jingham added a comment. Not sure if codesign exists on iOS devices, but at least we could do this on macOS. I thought we'd be able to tell from the Team Identifier whether it was a platform binary, but for /bin/ls & Co I get "not set" for the Team Identifier. CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, bulbazord. Herald added a subscriber: kristof.beyls. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sanitizer rep

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, bulbazord. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. This patch addresses two issues I found while looking

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

bulbazord added inline comments. Comment at: lldb/source/Host/posix/PipePosix.cpp:69 PipeBase::operator=(std::move(pipe_posix)); - m_fds[READ] = pipe_posix.ReleaseReadFileDescriptor(); - m_fds[WRITE] = pipe_posix.ReleaseWriteFileDescriptor(); + std::lock_guard guard(m_lock)

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

JDevlieghere added a comment. Is the reported race specifically about the shared pointer being accessed concurrently or operations on the `IOHandler`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157648/new/ https://reviews.llvm.org/D157648

[Lldb-commits] [PATCH] D157662: [lldb][NFCI] Change parameter type in Process::SetExitStatus

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. My primary motivation here is actually to change so

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

augusto2112 added a comment. In D157648#4578420 , @JDevlieghere wrote: > Is the reported race specifically about the shared pointer being accessed > concurrently or operations on the `IOHandler`? I believe it's the shared pointer being accessed. Here's

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

jasonmolenda added a comment. One more bit of explanation about the changes: There is an SBTarget::AddModule which takes individual parts of a module spec, and an SBTarget::AddModule which takes an SBModuleSpec. I was going to need to duplicate my code to force the expensive search & update t

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. To recap, o

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

jasonmolenda updated this revision to Diff 549214. jasonmolenda added a comment. update comments a tiny bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157667/new/ https://reviews.llvm.org/D157667 Files: lldb/docs/lldb-gdb-remote.txt lldb/i

[Lldb-commits] [lldb] 989f250 - [lldb] 'scoped_lock' may not intend to support class template argument deduction (NFC)

Author: Jie Fu Date: 2023-08-11T09:06:11+08:00 New Revision: 989f25001aee3457738c431ba1e977a8140726a0 URL: https://github.com/llvm/llvm-project/commit/989f25001aee3457738c431ba1e977a8140726a0 DIFF: https://github.com/llvm/llvm-project/commit/989f25001aee3457738c431ba1e977a8140726a0.diff LOG: [

[Lldb-commits] [PATCH] D157662: [lldb][NFCI] Change parameter type in Process::SetExitStatus

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Sounds reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157662/new/ https://reviews.llvm.org/D157662 ___