[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

DavidSpickett added a comment. I was in this exact situation yesterday but luckily I had already used a virtualenv to fix some other Python problems so I knew how to fix it. Had it not been for that, seeing the exact Python path would have been very useful here, thanks for adding this message.

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

DavidSpickett added a comment. I think `CMAKE_TOOLCHAIN_FILE` is the "proper" way to be passing `CMAKE_SYSTEM_NAME` etc. so let me look into that. It may be something we get away with with current CMake, but breaks later, much like `CMAKE_CROSS_COMPILING` seemed to be less effective as time wen

[Lldb-commits] [lldb] f8d1209 - [lldb] Fix Windows on Arm build

Author: David Spickett Date: 2023-08-17T09:56:54Z New Revision: f8d1209f966ccd1dd0a19f3acef0871bf8fc3c94 URL: https://github.com/llvm/llvm-project/commit/f8d1209f966ccd1dd0a19f3acef0871bf8fc3c94 DIFF: https://github.com/llvm/llvm-project/commit/f8d1209f966ccd1dd0a19f3acef0871bf8fc3c94.diff LOG

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

DavidSpickett added a comment. I fixed a typo in this to get the Windows build going again: https://github.com/llvm/llvm-project/commit/f8d1209f966ccd1dd0a19f3acef0871bf8fc3c94 I assume it's a typo, not an attempt to use what seems to have been a NetBSD type at one point. Repository: rG LLV

[Lldb-commits] [PATCH] D158172: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a su

[Lldb-commits] [PATCH] D158172: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

Michael137 updated this revision to Diff 551086. Michael137 added a comment. - Reword commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158172/new/ https://reviews.llvm.org/D158172 Files: lldb/source/Plugins/ExpressionParser/Clang/Cla

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

VladimirMakaev added a comment. Thanks @DavidSpickett for fixing this. I did not intend to use that type. Any number of that size would work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149213/new/ https://reviews.llvm.org/D149213 _

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett updated this revision to Diff 551122. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

[Lldb-commits] [PATCH] D158182: [lldb] Try to find relative DWO files by file name only, as a last resort

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB. Relative DWO files are normally found at some/path/to/file.

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1737 + if (!dwo_file.IsRelative()) { +found = FileSystem::Instance().Exists(dwo_file); + } else { David

[Lldb-commits] [PATCH] D158182: [lldb] Try to find relative DWO files by file name only, as a last resort

DavidSpickett added a comment. @clayborg This is I think what you meant. I'm not 100% sure it's safe because I keep wondering if we could find the wrong files this way, but with 1 DWO file per program it seems unlikely. I've reduced the nesting in the new tests compared to the previous patch. A

[Lldb-commits] [lldb] 4139461 - [lldb] Fix REQUIRES for DWO relative path test

Author: David Spickett Date: 2023-08-17T14:19:27Z New Revision: 4139461d4e7788128c2da5f77712b8d39898f189 URL: https://github.com/llvm/llvm-project/commit/4139461d4e7788128c2da5f77712b8d39898f189 DIFF: https://github.com/llvm/llvm-project/commit/4139461d4e7788128c2da5f77712b8d39898f189.diff LOG

[Lldb-commits] [lldb] 9c3f1f4 - [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

Author: Michael Buch Date: 2023-08-17T17:54:51+01:00 New Revision: 9c3f1f42cbed0fa6184cd2047b34ab5090503e9e URL: https://github.com/llvm/llvm-project/commit/9c3f1f42cbed0fa6184cd2047b34ab5090503e9e DIFF: https://github.com/llvm/llvm-project/commit/9c3f1f42cbed0fa6184cd2047b34ab5090503e9e.diff

[Lldb-commits] [PATCH] D158172: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c3f1f42cbed: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D158017: [lldb][NFCI] Rewrite error-handling code in ProcessGDBRemote::MonitorDebugserverProcess

This revision was automatically updated to reflect the committed changes. Closed by commit rG90c5675a3db2: [lldb][NFCI] Rewrite error-handling code in ProcessGDBRemote… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158017/new

[Lldb-commits] [lldb] 90c5675 - [lldb][NFCI] Rewrite error-handling code in ProcessGDBRemote::MonitorDebugserverProcess

Author: Alex Langford Date: 2023-08-17T10:32:23-07:00 New Revision: 90c5675a3db2319dd449a1753c79568355dfaaed URL: https://github.com/llvm/llvm-project/commit/90c5675a3db2319dd449a1753c79568355dfaaed DIFF: https://github.com/llvm/llvm-project/commit/90c5675a3db2319dd449a1753c79568355dfaaed.diff

[Lldb-commits] [lldb] 9e6d48e - [lldb][NFCI] Module constructor should take ConstString by value

Author: Alex Langford Date: 2023-08-17T10:34:57-07:00 New Revision: 9e6d48ef6085b762d8eb2531bbb481f57446da1c URL: https://github.com/llvm/llvm-project/commit/9e6d48ef6085b762d8eb2531bbb481f57446da1c DIFF: https://github.com/llvm/llvm-project/commit/9e6d48ef6085b762d8eb2531bbb481f57446da1c.diff

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e6d48ef6085: [lldb][NFCI] Module constructor should take ConstString by value (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

mgorny added a comment. This is the final version that was pushed, correct? (the commits don't link the revision) I've raised some concerns about the resulting API in https://reviews.llvm.org/D156270#4557902. I'd appreciate if you could take a look. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [lldb] 3415798 - [lldb][NFCI] Remove unneeded ConstString from ValueObject::GetValueForExpressionPath_Impl

Author: Alex Langford Date: 2023-08-17T10:44:01-07:00 New Revision: 3415798f7993974a19bd22b0481f2f6a71e4a2ab URL: https://github.com/llvm/llvm-project/commit/3415798f7993974a19bd22b0481f2f6a71e4a2ab DIFF: https://github.com/llvm/llvm-project/commit/3415798f7993974a19bd22b0481f2f6a71e4a2ab.diff

[Lldb-commits] [PATCH] D158026: [lldb][NFCI] Remove unneeded ConstString from ValueObject::GetValueForExpressionPath_Impl

This revision was automatically updated to reflect the committed changes. Closed by commit rG3415798f7993: [lldb][NFCI] Remove unneeded ConstString from ValueObject… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158026/new/

[Lldb-commits] [PATCH] D158182: [lldb] Try to find relative DWO files by file name only, as a last resort

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1784-1804 + FileSpec spec_to_get_name(dwo_name); + llvm::StringRef filename_o

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

clayborg added a comment. Just one question if we should still try all of your new code if we have a full path to a DW_AT_comp_dir, but we don't find the .dwo file, should be allow your code to run and still try to just append the relative "dwo_name" (without comp dir) to each of the search pat

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

clayborg accepted this revision. clayborg added a comment. Looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155905/new/ https://reviews.llvm.org/D155905 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

sgraenitz created this revision. sgraenitz added reviewers: jasonmolenda, jingham, bulbazord, aprantl. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We added support for the GNUstep ObjC runtime in 0

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

sgraenitz added a comment. Herald added a subscriber: JDevlieghere. The issue was reported in https://github.com/llvm/llvm-project/issues/64582 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158205/new/ https://reviews.llvm.org/D158205

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158205/new/ https://reviews.llvm.org/D158205

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

theraven added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:49 + if (TT.isOSBinFormatELF()) +return filename.starts_with("libobjc.so"); + if (TT.isOSWindows()) This is a bit unfortunate. I

[Lldb-commits] [PATCH] D158209: [lldb] Change UnixSignals::GetSignalAsCString to GetSignalAsStringRef

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jasonmolenda, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is in preparation to remove the uses of ConstS

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:49 + if (TT.isOSBinFormatELF()) +return filename.starts_with("libobjc.so"); + if (TT.isOSWindows()) theraven wrote: > This is

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

bulbazord accepted this revision. bulbazord added a comment. This looks fine to me. Did you have the chance to verify that it improves performance of non-objc inferiors on Linux? We'll also probably want to make sure this gets back ported into llvm-17. Comment at: lldb/sourc

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

jingham accepted this revision. jingham added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:49 + if (TT.isOSBinFormatELF()) +return filename.starts_with("libobjc.so"); + if (TT.isOSWindows()) ---

[Lldb-commits] [lldb] d37642b - Simplify address mask setting logic in AddressableBits

Author: Jason Molenda Date: 2023-08-17T16:22:39-07:00 New Revision: d37642b4a261b5b5687725fd60f7da5dc5ec4782 URL: https://github.com/llvm/llvm-project/commit/d37642b4a261b5b5687725fd60f7da5dc5ec4782 DIFF: https://github.com/llvm/llvm-project/commit/d37642b4a261b5b5687725fd60f7da5dc5ec4782.diff

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158023/new/ https://reviews.llvm.org/D158023 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D158237: Change LLGSTest.cpp to run environment_check inferior with stdin/stdout disabled, to work around ASAN CI bot issue

jasonmolenda created this revision. jasonmolenda added a reviewer: labath. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. We have an ASAN+UBSAN bot fo

[Lldb-commits] [PATCH] D158237: Change LLGSTest.cpp to run environment_check inferior with stdin/stdout disabled, to work around ASAN CI bot issue

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This seems good to me. Tests that aren't using stdio for a purpose shouldn't have to worry about random output. But wait on my acceptance a bit to see if Pavel (or anyone else) has a strong

[Lldb-commits] [lldb] 10f494d - Only set the "low" address masks when only one adressable bits specified

Author: Jason Molenda Date: 2023-08-17T18:16:31-07:00 New Revision: 10f494d2896b8a58f69cc47d0db35d2b84c2fb44 URL: https://github.com/llvm/llvm-project/commit/10f494d2896b8a58f69cc47d0db35d2b84c2fb44 DIFF: https://github.com/llvm/llvm-project/commit/10f494d2896b8a58f69cc47d0db35d2b84c2fb44.diff

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

paperchalice added a comment. When I made D141907 , I want `get_clang_resource_dir` in cmake and GetResourcesPath in clang to have the same behavior and it also respects the doc string

[Lldb-commits] [PATCH] D158251: [lldb] Propagate destination type's byte order to memory writer

kkcode0 created this revision. Herald added a project: All. kkcode0 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When a compiler attaches endianess to type, debugger should honor that when writing to variables of that variable. Reposi

[Lldb-commits] [PATCH] D158251: [lldb] Propagate destination type's byte order to memory writer

kkcode0 updated this revision to Diff 551397. kkcode0 added a comment. Herald added a subscriber: JDevlieghere. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158251/new/ https://reviews.llvm.org/D158251 Files: lldb/include/lldb/Symb

[Lldb-commits] [PATCH] D158251: [lldb] Propagate destination type's byte order to memory writer

kkcode0 updated this revision to Diff 551398. kkcode0 added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158251/new/ https://reviews.llvm.org/D158251 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/lldb/Symbol/Type