[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

2023-08-22 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, GeorgeHuyubo, yinghuitan, kusmour. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We ran into a case where shared librar

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

2023-08-22 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. LGTM, fwiw. Comment at: lldb/docs/use/aarch64-linux.rst:37 +The example above has a vector length of 16 bytes. Within LLDB you will always +see "vg" as in the ``vg`` register, which is 2 in this case (8*2 = 16). +Elsewhere you may see "vq" which is

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

2023-08-22 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. @JDevlieghere , that worked. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/ https://reviews.llvm.org/D157764 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] 7822e5d - [LLDB] Allow expression evaluators to set arbitrary timeouts

2023-08-22 Thread walter erquinigo via lldb-commits
Author: walter erquinigo Date: 2023-08-22T17:41:14-04:00 New Revision: 7822e5dbf1cb4be2d73eb13da27b04de684c318b URL: https://github.com/llvm/llvm-project/commit/7822e5dbf1cb4be2d73eb13da27b04de684c318b DIFF: https://github.com/llvm/llvm-project/commit/7822e5dbf1cb4be2d73eb13da27b04de684c318b.di

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

2023-08-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D157764#4608265 , @wallace wrote: > @jasonmolenda , yep. I have already reverted this patch. I'll figure out how > to make that work nicely with these changes. My recommendation would be to change the timeout in the test

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

2023-08-22 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D157764#4608265 , @wallace wrote: > @jasonmolenda , yep. I have already reverted this patch. I'll figure out how > to make that work nicely with these changes. oh lol sorry took me a little while to confirm and I missed

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

2023-08-22 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. @jasonmolenda , yep. I have already reverted this patch. I'll figure out how to make that work nicely with these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/ https://reviews.llvm.org/D157764

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

2023-08-22 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. @wallace this is breaking TestIRInterpreter.py on macOS now; https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ has been failing since it went in (there was another llvm issue causing failures right before this went in, so it was easy to miss). On my des

[Lldb-commits] [lldb] 9e66ea5 - Revert "[LLDB] Allow expression evaluators to set arbitrary timeouts"

2023-08-22 Thread walter erquinigo via lldb-commits
Author: walter erquinigo Date: 2023-08-22T17:04:53-04:00 New Revision: 9e66ea503ea1727b333ecb088e73e81a4c0736d5 URL: https://github.com/llvm/llvm-project/commit/9e66ea503ea1727b333ecb088e73e81a4c0736d5 DIFF: https://github.com/llvm/llvm-project/commit/9e66ea503ea1727b333ecb088e73e81a4c0736d5.di

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

2023-08-22 Thread Ted Woodward via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbe88462cd6aa: Platform qemu-user: Build path to qemu automatically if not specified (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155117/n

[Lldb-commits] [lldb] be88462 - Platform qemu-user: Build path to qemu automatically if not specified

2023-08-22 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2023-08-22T14:20:18-05:00 New Revision: be88462cd6aa819c22185ff0916988d4f03b6ab0 URL: https://github.com/llvm/llvm-project/commit/be88462cd6aa819c22185ff0916988d4f03b6ab0 DIFF: https://github.com/llvm/llvm-project/commit/be88462cd6aa819c22185ff0916988d4f03b6ab0.diff

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

2023-08-22 Thread Ted Woodward via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG523110d654a2: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress (authored by ted). Changed prior to commit: https://reviews.llvm.org/D155107?vs=539679&id=552465#toc Repository: rG LLVM

[Lldb-commits] [lldb] 523110d - Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

2023-08-22 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2023-08-22T14:16:14-05:00 New Revision: 523110d654a286607790e7637da6be312de3a7c7 URL: https://github.com/llvm/llvm-project/commit/523110d654a286607790e7637da6be312de3a7c7 DIFF: https://github.com/llvm/llvm-project/commit/523110d654a286607790e7637da6be312de3a7c7.diff

[Lldb-commits] [PATCH] D158467: [lldb] Link back to the LLVM Project and Developer Policy from the docs

2023-08-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG34f84697c37e: [lldb] Link back to the LLVM Project and Developer Policy from the docs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [lldb] 34f8469 - [lldb] Link back to the LLVM Project and Developer Policy from the docs

2023-08-22 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2023-08-22T11:42:46-07:00 New Revision: 34f84697c37ece745e1c66a36b0faca281e8da3e URL: https://github.com/llvm/llvm-project/commit/34f84697c37ece745e1c66a36b0faca281e8da3e DIFF: https://github.com/llvm/llvm-project/commit/34f84697c37ece745e1c66a36b0faca281e8da3e.d

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

2023-08-22 Thread Alex Langford via Phabricator via lldb-commits
bulbazord requested changes to this revision. bulbazord added a comment. In D157497#4592330 , @Pivnoy wrote: > At the moment, the TargetParser architecture is extensible. This complicates > the addition of new architectures, operating systems, and so on.

[Lldb-commits] [lldb] fef609d - Revert "[lldb] Fix data race in ThreadList"

2023-08-22 Thread Augusto Noronha via lldb-commits
Author: Augusto Noronha Date: 2023-08-22T11:14:04-07:00 New Revision: fef609d2d1da573150121a6ee897e1d90f235eb1 URL: https://github.com/llvm/llvm-project/commit/fef609d2d1da573150121a6ee897e1d90f235eb1 DIFF: https://github.com/llvm/llvm-project/commit/fef609d2d1da573150121a6ee897e1d90f235eb1.dif

[Lldb-commits] [lldb] 07afc41 - [lldb] Fix broken link in docs/index.rst

2023-08-22 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2023-08-22T10:58:44-07:00 New Revision: 07afc41a2e6ab47097246f3f7c6e525a89ce1b9f URL: https://github.com/llvm/llvm-project/commit/07afc41a2e6ab47097246f3f7c6e525a89ce1b9f DIFF: https://github.com/llvm/llvm-project/commit/07afc41a2e6ab47097246f3f7c6e525a89ce1b9f.d

[Lldb-commits] [PATCH] D158457: [lldb][NFCI] Change return type of UnixSignals::GetSignalInfo

2023-08-22 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGebff12d675aa: [lldb][NFCI] Change return type of UnixSignals::GetSignalInfo (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158457/new

[Lldb-commits] [lldb] ebff12d - [lldb][NFCI] Change return type of UnixSignals::GetSignalInfo

2023-08-22 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-22T10:54:06-07:00 New Revision: ebff12d675aa4db4ee8762c165a387a8d86dd0d5 URL: https://github.com/llvm/llvm-project/commit/ebff12d675aa4db4ee8762c165a387a8d86dd0d5 DIFF: https://github.com/llvm/llvm-project/commit/ebff12d675aa4db4ee8762c165a387a8d86dd0d5.diff

[Lldb-commits] [lldb] a43e23a - [lldb][NFCI] Silence warning about unhandled value eManglingSchemeSwift in switch statement

2023-08-22 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-22T10:35:36-07:00 New Revision: a43e23a2141f4fa78940844d810648ff8d40f474 URL: https://github.com/llvm/llvm-project/commit/a43e23a2141f4fa78940844d810648ff8d40f474 DIFF: https://github.com/llvm/llvm-project/commit/a43e23a2141f4fa78940844d810648ff8d40f474.diff

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

2023-08-22 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGedc64d49de92: [lldb] Add support for recognizing swift mangled names (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158470/new/ http

[Lldb-commits] [lldb] edc64d4 - [lldb] Add support for recognizing swift mangled names

2023-08-22 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-22T10:28:55-07:00 New Revision: edc64d49de92d33e709bcde1db5670ff430f5fad URL: https://github.com/llvm/llvm-project/commit/edc64d49de92d33e709bcde1db5670ff430f5fad DIFF: https://github.com/llvm/llvm-project/commit/edc64d49de92d33e709bcde1db5670ff430f5fad.diff

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

2023-08-22 Thread Alex Langford via Phabricator via lldb-commits
bulbazord marked 4 inline comments as done. bulbazord added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

2023-08-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start aprantl wrote: > fdeazev

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

2023-08-22 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start fdeazeve wrote: > JDevliegher

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

2023-08-22 Thread walter erquinigo via Phabricator via lldb-commits
wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - electriclilies wrote: > jingham wrote: > > electriclilies wrote: > > > rriddle wrote: > > > > Why is this dropped? > > > Walter and I want to us

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

2023-08-22 Thread walter erquinigo via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa4dbdf474993: [LLDB] Allow expression evaluators to set arbitrary timeouts (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/

[Lldb-commits] [lldb] a4dbdf4 - [LLDB] Allow expression evaluators to set arbitrary timeouts

2023-08-22 Thread walter erquinigo via lldb-commits
Author: walter erquinigo Date: 2023-08-22T12:27:08-04:00 New Revision: a4dbdf4749938396dbf913478289fa426d8341ae URL: https://github.com/llvm/llvm-project/commit/a4dbdf4749938396dbf913478289fa426d8341ae DIFF: https://github.com/llvm/llvm-project/commit/a4dbdf4749938396dbf913478289fa426d8341ae.di

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

2023-08-22 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start JDevlieghere wrote: > aprant

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

2023-08-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start aprantl wrote: > Feel fr

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

2023-08-22 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start Feel free to completely ignor

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

2023-08-22 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1083ae234718: [LLDB][Docs] Update cross compilation docs and examples (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158085/new/

[Lldb-commits] [lldb] 1083ae2 - [LLDB][Docs] Update cross compilation docs and examples

2023-08-22 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-08-22T15:53:47+01:00 New Revision: 1083ae23471839878153412d9c78955d9a7a29ac URL: https://github.com/llvm/llvm-project/commit/1083ae23471839878153412d9c78955d9a7a29ac DIFF: https://github.com/llvm/llvm-project/commit/1083ae23471839878153412d9c78955d9a7a29ac.diff

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

2023-08-22 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. > IMO it's usually the safest/most sustainable way to maintain > cross-compilation jobs. Part of my unfamiliarity is that I don't cross compile more than one configuration at a time, so a another config file just to do what I already do always seems like work I d

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

2023-08-22 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 552360. DavidSpickett added a comment. Link to CMake's cross compilation docs up front, as a fallback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158085/new/ https://reviews.llvm.org/D158085 Files:

[Lldb-commits] [PATCH] D151567: [Support] Report EISDIR when opening a directory

2023-08-22 Thread Alison Zhang via Phabricator via lldb-commits
azhan92 updated this revision to Diff 552353. azhan92 retitled this revision from "[Support] Report EISDIR when opening a directory " to "[Support] Report EISDIR when opening a directory". azhan92 added a comment. Add unit test to verify patch. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

2023-08-22 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. And if you're wondering, ZA being disabled after a vector length change is expected. lldb is just reporting what the kernel does here. lldb-server will still give you back a block of 0s though and that's what was not shown in this situation. Repository: rG LLV

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

2023-08-22 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes a bug where writing vg during streaming mode could

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

2023-08-22 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. And if one of those is why does lldb use `vg` with these strange units, I think "vg" the term Arm's Fast Models used and GDB adopted it. It's possible we could improve that later but for now it is what it is. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

2023-08-22 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added reviewers: omjavaid, jasonmolenda. DavidSpickett added a subscriber: jasonmolenda. DavidSpickett added a comment. @jasonmolenda you asked some good questions about all this before, any of those not answered by this doc? No need to look deeply into anything, just stuff that co

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

2023-08-22 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added subscribers: ctetreau, arphaman, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This adds a release note for all

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

2023-08-22 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. I did have some code to verify the arguments were passed correctly to the program but it made each core file 200k so I don't think it's worth it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://revi

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

2023-08-22 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds the ability to read streaming SVE registers, ZA, SV

[Lldb-commits] [PATCH] D158034: [lldb] Fix data race in ThreadList

2023-08-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. After this patch, python_api/run_locker/TestRunLocker.py becomes flaky. https://lab.llvm.org/buildbot/#/builders/68/builds/58456 is the first such failure, but there have been about a dozen failures since then. The backtraces on the buildbot page are fairly useless, but

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

2023-08-22 Thread Nikita Popov via Phabricator via lldb-commits
nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. This change looks strictly worse in isolation, the proposal on discourse did not reach consensus, and looking at the diagram in https://discourse

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

2023-08-22 Thread Evgeniy Makarev via Phabricator via lldb-commits
Pivnoy added a comment. Herald added a subscriber: sunshaoce. @bulbazord @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157497/new/ https://reviews.llvm.org/D157497 ___ lldb-commits mailing list