[Lldb-commits] [PATCH] D158801: [lldb-vscode] Update package.json

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bd632895816: [lldb-vscode] Update package.json (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D158801?vs=553320&id=553363#toc Repository:

[Lldb-commits] [lldb] 7bd6328 - [lldb-vscode] Update package.json

Author: Jonas Devlieghere Date: 2023-08-24T22:36:53-07:00 New Revision: 7bd632895816206a9f868019124ebb190e4a65c1 URL: https://github.com/llvm/llvm-project/commit/7bd632895816206a9f868019124ebb190e4a65c1 DIFF: https://github.com/llvm/llvm-project/commit/7bd632895816206a9f868019124ebb190e4a65c1.d

[Lldb-commits] [lldb] 653f776 - [mlir][complex] Convert complex.abs to arith with fastmath flag

Author: Kai Sasaki Date: 2023-08-25T12:10:43+09:00 New Revision: 653f77690bb2473ff405ccc681c73217fae8b748 URL: https://github.com/llvm/llvm-project/commit/653f77690bb2473ff405ccc681c73217fae8b748 DIFF: https://github.com/llvm/llvm-project/commit/653f77690bb2473ff405ccc681c73217fae8b748.diff LO

[Lldb-commits] [PATCH] D158801: [lldb-vscode] Update package.json

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Awesome! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158801/new/ https://reviews.llvm.org/D158801 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

jasonmolenda updated this revision to Diff 553324. jasonmolenda added a subscriber: jingham. jasonmolenda added a comment. After thinking about this more, and talking with @jingham I rewrote the patch so LC_NOTE "thread extrainfo" is a JSON dictionary with a key `threads` that has an array. The

[Lldb-commits] [PATCH] D158801: [lldb-vscode] Update package.json

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, wallace. Herald added a project: All. JDevlieghere requested review of this revision. Update package.json: - Update license, display name, repository and keywords - Add homepage, issue page - Fix formatting and typos ht

[Lldb-commits] [PATCH] D158788: [lldb-vscode] Use a switch to avoid else-after-return (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG719506769a89: [lldb-vscode] Use a switch to avoid else-after-return (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [lldb] 7195067 - [lldb-vscode] Use a switch to avoid else-after-return (NFC)

Author: Jonas Devlieghere Date: 2023-08-24T15:53:14-07:00 New Revision: 719506769a89c4f01fc8513cf3553e723591294c URL: https://github.com/llvm/llvm-project/commit/719506769a89c4f01fc8513cf3553e723591294c DIFF: https://github.com/llvm/llvm-project/commit/719506769a89c4f01fc8513cf3553e723591294c.d

[Lldb-commits] [PATCH] D158788: [lldb-vscode] Use a switch to avoid else-after-return (NFC)

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158788/new/ https://reviews.llvm.org/D158788 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D158788: [lldb-vscode] Use a switch to avoid else-after-return

JDevlieghere created this revision. JDevlieghere added a reviewer: wallace. Herald added a project: All. JDevlieghere requested review of this revision. Use a switch to avoid else-after-return. https://reviews.llvm.org/D158788 Files: lldb/tools/lldb-vscode/ProgressEvent.cpp Index: lldb/tool

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

jasonmolenda added a comment. As soon as I started thinking about thread names and queue names and mach exception data, all variable length things, a binary format doesn't seem ideal. We do already send a lot of thread information about processes in JSON in gdb remote serial protocol from debu

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

jasonmolenda added a comment. Or possibly we should just make "thread extrainfo" a JSON blob with a dictionary for each thread, which would make it easier to extend, instead of a binary format. I'm not sure I have a strong opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, bulbazord. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. This adds a new LC_NOTE to ObjectFileMachO to save th

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

clayborg updated this revision to Diff 553259. clayborg added a comment. Fixed more header documentation and cleaned up the test even more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158583/new/ https://reviews.llvm.org/D158583 Files: lldb/so

[Lldb-commits] [lldb] a902015 - [lldb] Fix grammar in error message emitted by IRExecutionUnit

Author: Jonas Devlieghere Date: 2023-08-24T14:11:30-07:00 New Revision: a902015f543097720fed4d2c04e34daa0fdfbda7 URL: https://github.com/llvm/llvm-project/commit/a902015f543097720fed4d2c04e34daa0fdfbda7 DIFF: https://github.com/llvm/llvm-project/commit/a902015f543097720fed4d2c04e34daa0fdfbda7.d

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

aaron.ballman added a comment. In D158323#4614717 , @mib wrote: > Given that the bot is still red, I've reverted the patch in > dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7 > Thank you f

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

mib added a comment. Given that the bot is still red, I've reverted the patch in dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158323/ne

[Lldb-commits] [lldb] dfb48dc - Revert "[lldb/infra] Revamp lldb.llvm.org"

Author: Med Ismail Bennani Date: 2023-08-24T19:44:16+01:00 New Revision: dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7 URL: https://github.com/llvm/llvm-project/commit/dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7 DIFF: https://github.com/llvm/llvm-project/commit/dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7.

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

aprantl added a comment. Test LGTM, I'll defer to others for the dynamic loader plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158583/new/ https://reviews.llvm.org/D158583 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - wallace wrote: > electriclilies wrote: > > jingham wrote: > > > electriclilies wrote: > > > > rriddle wrote: > > > > > Why is this dropped? > >

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

mib added a comment. In D158323#4614469 , @aaron.ballman wrote: > In D158323#4614446 , @mib wrote: > >> In D158323#4614373 , >> @aaron.ballman wrote: >> >>> In D158323#4

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

aaron.ballman added a comment. In D158323#4614446 , @mib wrote: > In D158323#4614373 , @aaron.ballman > wrote: > >> In D158323#4613878 , @mib wrote: >> >>> Given we didn'

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

mib added subscribers: tonic, gkistanova. mib added a comment. In D158323#4614373 , @aaron.ballman wrote: > In D158323#4613878 , @mib wrote: > >> Given we didn't receive more feedback on this, I'll land it now. I

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

aaron.ballman added a comment. In D158323#4613878 , @mib wrote: > Given we didn't receive more feedback on this, I'll land it now. If there are > other comments, we can address those after the fact. Hello! It seems the changes here have taken out the sp

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rGeea887406498: [lldb/infra] Revamp lldb.llvm.org (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158323/new/ https://reviews.llvm.org/D15832

[Lldb-commits] [lldb] eea8874 - [lldb/infra] Revamp lldb.llvm.org

Author: Med Ismail Bennani Date: 2023-08-24T15:41:16+01:00 New Revision: eea887406498d3a420ed0afbb654915a7e08e2ad URL: https://github.com/llvm/llvm-project/commit/eea887406498d3a420ed0afbb654915a7e08e2ad DIFF: https://github.com/llvm/llvm-project/commit/eea887406498d3a420ed0afbb654915a7e08e2ad.

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

mib added a comment. Given we didn't receive more feedback on this, I'll land it now. If there are other comments, we can address those after the fact. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158323/new/ https://reviews.llvm.org/D158323 __