[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. In D156774#4644623 , @Michael137 wrote: > Also, I assume the extra changes to make the PointerIntPair formatter work > will be in a follow-up patch? Yes. That work is not finished yet. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

https://github.com/chelcassanova resolved https://github.com/llvm/llvm-project/pull/66144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/66139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/HerrCai0907 requested changes to this pull request. This check has some issue in my opinion, the semantic of `std::move(*p)` are not same as `*std::move(p)` ```c++ #include #include #include using std::unique_ptr; void f1() { unique_ptr p{new std::string("demo")};

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

jimingham wrote: > > It seems a bit weird to have an Execution context with a thread and a stack > > frame but not the process they belong to. I don't know that it would really > > help either. Even if you removed the process so that you no longer had to > > check for that being invalid, if a

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

jimingham wrote: Okay, here's my understanding of what's going on here: So what's going on here is that in order to support background fetching of dSYM's, there's a thread that calls dsymForUUID when someone tells it there's a binary with an unknown UUID, then when it gets the dSYM it needs

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

pizzud wrote: > I don't see problem described by this check as an performance issue. For > example: > > ``` > std::unique_ptr> ptr; > std::vector local = std::move(*ptr); > ``` > > No performance issue here, simply value may need to be moved, do not expect > that someone have to always keep

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139: >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/3] [clang-tidy] Add performance-move-smart-pointer-contents

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,80 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,80 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139: >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/2] [clang-tidy] Add performance-move-smart-pointer-contents

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

clayborg wrote: So if we use the ExecutionContextScope and init a ExectionContext with a target, it can calculate the process and target. If you init it with a thread, it can calculate the thread, process and target. And if you init it with a frame, it can get the frame, thread, process and

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

@@ -83,7 +83,7 @@ class Debugger : public std::enable_shared_from_this, eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1 << 1), eBroadcastBitError = (1 << 2), -eBroadcastSymbolChange = (1 << 3), +eBroadcastBitSymbolChange = (1 << 3),

[Lldb-commits] [lldb] [lldb][NFCI] BreakpointResolverName ctor shouldn't unnecessarily copy data (PR #66001)

https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/66001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6412258 - [lldb][NFCI] BreakpointResolverName ctor shouldn't unnecessarily copy data (#66001)

Author: Alex Date: 2023-09-12T15:32:06-07:00 New Revision: 64122580c0809fc6fc15bd955fea4e9ace80a135 URL: https://github.com/llvm/llvm-project/commit/64122580c0809fc6fc15bd955fea4e9ace80a135 DIFF: https://github.com/llvm/llvm-project/commit/64122580c0809fc6fc15bd955fea4e9ace80a135.diff LOG:

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

@@ -83,7 +83,7 @@ class Debugger : public std::enable_shared_from_this, eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1 << 1), eBroadcastBitError = (1 << 2), -eBroadcastSymbolChange = (1 << 3), +eBroadcastBitSymbolChange = (1 << 3),

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

clayborg wrote: > It seems a bit weird to have an Execution context with a thread and a stack > frame but not the process they belong to. I don't know that it would really > help either. Even if you removed the process so that you no longer had to > check for that being invalid, if a thread

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

@@ -13,6 +13,7 @@ #include "lldb/API/SBDefines.h" #include "lldb/API/SBPlatform.h" +#include "lldb/API/SBStructuredData.h" chelcassanova wrote: Correct, I left this in here by mistake. https://github.com/llvm/llvm-project/pull/66144

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/66144: >From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 12 Sep 2023 13:49:50 -0700 Subject: [PATCH] [lldb][Commands] Show symbol change bit in SB API

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

@@ -13,6 +13,7 @@ #include "lldb/API/SBDefines.h" #include "lldb/API/SBPlatform.h" +#include "lldb/API/SBStructuredData.h" clayborg wrote: This isn't needed in the header file right? Move to SBDebugger.cpp if it is still needed? No mention of

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

https://github.com/clayborg commented: We should be able to extract the SBModuleSpec from the event in response to the eBroadcastBitSymbolChange event. This will require adding a static method to SBDebugger.h/.cpp to get the SBModuleSpec from the event: ``` static lldb::SBModuleSpec

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

@@ -46,6 +47,7 @@ class LLDB_API SBDebugger { eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1 << 1), eBroadcastBitError = (1 << 2), + eBroadcastBitSymbolChange = (1 << 3), clayborg wrote: See comment below about possible

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

@@ -83,7 +83,7 @@ class Debugger : public std::enable_shared_from_this, eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1 << 1), eBroadcastBitError = (1 << 2), -eBroadcastSymbolChange = (1 << 3), +eBroadcastBitSymbolChange = (1 << 3),

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/66144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/10] [libc++] Implement ranges::contains Differential

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/66144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

@@ -57,6 +57,30 @@ def test_add_dsym_with_dSYM_bundle(self): self.exe_name = "a.out" self.do_add_dsym_with_dSYM_bundle(self.exe_name) +@no_debug_info_test +def test_report_symbol_change(self): +"""Test that when adding a symbol file, the

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

llvmbot wrote: @llvm/pr-subscribers-lldb Changes This exposes the `eBroadcastBitSymbolChange` bit to the SB API to show when a symbol change event has been broadcast as this wasn't being done before. Also refactors `eBroadcastSymbolChange` to `eBroadcastBitSymbolChange` to

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/66144: This exposes the `eBroadcastBitSymbolChange` bit to the SB API to show when a symbol change event has been broadcast as this wasn't being done before. Also refactors `eBroadcastSymbolChange` to

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

https://github.com/chelcassanova review_requested https://github.com/llvm/llvm-project/pull/66144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. Also, I assume the extra changes to make the PointerIntPair formatter work will be in a follow-up patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.org/D156774

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. In D156774#4644503 , @Endill wrote: > Ping @Michael137 Sorry for the delay, just came back from vacation The change itself LGTM. Can we add a test though? We do have DWARFASTParserClang unittests:

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( +

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable CommandOptions m_options; }; +#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles + +// Image debug dwo dumping command + +class CommandObjectTargetModulesDumpSeparateDebugInfoFiles +:

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( +

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. Ping @Michael137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.org/D156774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

https://github.com/nbpatel edited https://github.com/llvm/llvm-project/pull/65539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( +

[Lldb-commits] [lldb] [AMDGPU] Port AMDGPURewriteUndefForPHI to new pass manager (PR #66008)

https://github.com/jwanggit86 updated https://github.com/llvm/llvm-project/pull/66008: >From c68ad692f9d4c657f5dfaeb5d8c52c5331ebbb64 Mon Sep 17 00:00:00 2001 From: Jun Wang Date: Mon, 11 Sep 2023 15:25:42 -0500 Subject: [PATCH 1/2] [AMDGPU] Port AMDGPURewriteUndefForPHI to new pass manager

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

adrian-prantl wrote: Oh nice! I was unsuccessfully looking in the LLDb subdir because I had assumed this was LLDB-specific! https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

Not necessary for this review, but it might be nice to have a --missing or similar flag to this command that filters the output to only the ones that are missing. Seems like a lot of the time I would want to use this command it would be to find missing dwo or oso files. Jim > On Sep 11,

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

JDevlieghere wrote: > Have (should we) we documented that we format all python code with black > somewhere and how to install the tool? https://llvm.org/docs/CodingStandards.html#python-version-and-source-code-formatting https://github.com/llvm/llvm-project/pull/66053

Re: [Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

Is there any chance we can use something other than black. I would never never write Python code that ugly. Jim > On Sep 12, 2023, at 8:47 AM, Adrian Prantl via lldb-commits > wrote: > > > adrian-prantl wrote: > > Have (should we) we documented that we format all python code with black

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

@@ -2005,9 +2021,10 @@ class CommandObjectTargetModulesDumpSymtab result.GetOutputStream().EOL(); result.GetOutputStream().EOL(); } - if (INTERRUPT_REQUESTED(GetDebugger(), + if (INTERRUPT_REQUESTED(GetDebugger(),

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

jimingham wrote: > > I don't think the lldb command line dumps raw JSON anywhere as a command > > result. Can we make something a little more human readable? > > It was my idea to make this JSON. The problem is each debug info (.dwo and > DWARF in .o files for Mac) has very different fields

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

jimingham wrote: I don't see where you approve a PR in this UI but this is approved. https://github.com/llvm/llvm-project/pull/65974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

jimingham wrote: Excellent, thanks for chasing that logic down. This is the correct solution, since we really do want `h` to mean `help` not just accidentally. https://github.com/llvm/llvm-project/pull/65974 ___ lldb-commits mailing list

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

https://github.com/adrian-prantl review_requested https://github.com/llvm/llvm-project/pull/66035 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

adrian-prantl wrote: Have (should we) we documented that we format all python code with black somewhere and how to install the tool? https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added a comment. > I can make this change here, but I wonder if it should be a separate change. Sounds like bitness confusion, so yes it's worth making a patch for that. We don't test that scenario on the build bots but people do do this. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added a comment. @DavidSpickett update on testing: I'm running tests. I found an issue in the IR Interpreter when calling class methods. Somehow a 32 bit pointer gets the upper 32 bits in the 64 bit uint it's stored in set to 0x, which causes an assert. The assert should probably

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556565. DavidSpickett added a comment. Rebase after changes to previous patch to arm64 regsets test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files:

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

DavidSpickett updated this revision to Diff 556564. DavidSpickett added a comment. Use the simpler way to get the register sets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/new/ https://reviews.llvm.org/D157846 Files:

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

DavidSpickett added a comment. > In this test can we figure out whether SVE was read from Streaming mode or > normal SVE mode?? and if yes may be add a check for that. Not sure what you mean. If you mean: - write non-streaming SVE with one set of values - write streaming SVE with another -

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett added a comment. Should all be updated now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett updated this revision to Diff 556563. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514 Files:

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 556562. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

omjavaid added a comment. In this test can we figure out whether SVE was read from Streaming mode or normal SVE mode?? and if yes may be add a check for that. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:156 + +

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 556561. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files:

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 556560. DavidSpickett added a comment. Herald added a subscriber: sunshaoce. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files:

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556559. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files:

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett updated this revision to Diff 556558. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 Files:

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 556557. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 Files:

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett updated this revision to Diff 556556. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/ https://reviews.llvm.org/D159502 Files: lldb/include/lldb/Utility/RegisterValue.h

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

DavidSpickett updated this revision to Diff 556555. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/new/ https://reviews.llvm.org/D157846 Files:

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self): self.assertTrue(result.Succeeded()) self.assertEqual("apropos script", result.GetOutput()) -command_interpreter.ResolveCommand("h", result) +

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self): self.assertTrue(result.Succeeded()) self.assertEqual("apropos script", result.GetOutput()) -command_interpreter.ResolveCommand("h", result) +

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65974: >From 2e415b3d0bca50b4c172e12a27697b8adf6fabf0 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 11:42:45 + Subject: [PATCH 1/3] [lldb] Treat user aliases the same as built-ins when

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

omjavaid added a comment. This patch requires rebasing does not apply cleanly on top of its parent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 ___

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

DavidSpickett added a comment. > Any chance we could simplify this situation and have dwo searches use exactly > the same/shared logic as source file searches? I'm not sure what exactly this means, can you clarify? I know that DWP and DWO have different search functions, that could certainly

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett abandoned this revision. DavidSpickett added a comment. I've split them. I didn't split ZA definition and read/write because the former would be almost nothing, but otherwise it's into a few commits now ending with testing. I won't fold the ZA bugfix into this as I think it's

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. An SME enabled program has the following extra state: -

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The size of ZA depends on the streamnig vector length

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett created this revision. Herald added subscribers: sunshaoce, ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a register "svg" which mirrors SVE's

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. Note: This requires later commits for ZA to

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

DavidSpickett added a comment. Did my best to update the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/new/ https://reviews.llvm.org/D157846 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's SVE register state to TestArm64DynamicRegsets

DavidSpickett updated this revision to Diff 556541. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/new/ https://reviews.llvm.org/D157846 Files:

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's SVE register state to TestArm64DynamicRegsets

omjavaid added a comment. Can you add more description to this patch. at the moment reading it without SME context in mind does not provide enough information to figure out what we are doing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. The patch looks to implement all stuff needed at once lets break it down into three patches instead: 1. First patch that just adds SME register set and does not implement

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

DavidSpickett wrote: FYI I committed https://reviews.llvm.org/D157609 recently. Looks like your test cases are pretty straightforward but just in case you are confused why lldb manages to find a file when it didn't previously. https://github.com/llvm/llvm-project/pull/66035

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable CommandOptions m_options; }; +#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles + +// Image debug dwo dumping command + +class CommandObjectTargetModulesDumpSeparateDebugInfoFiles +:

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

@@ -4214,6 +4216,62 @@ void SymbolFileDWARF::DumpClangAST(Stream ) { clang->Dump(s.AsRawOstream()); } +bool SymbolFileDWARF::GetSeparateDebugInfoFiles(StructuredData::Array ) { + DWARFDebugInfo = DebugInfo(); + const size_t num_cus = info.GetNumUnits(); + for (size_t

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

@@ -282,6 +283,10 @@ class SymbolFileDWARF : public lldb_private::SymbolFileCommon { void DumpClangAST(lldb_private::Stream ) override; + /// Retrieve the external dwo files. DavidSpickett wrote: "external dwo file details." ?

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable CommandOptions m_options; }; +#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles + +// Image debug dwo dumping command + +class CommandObjectTargetModulesDumpSeparateDebugInfoFiles +:

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable CommandOptions m_options; }; +#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles + +// Image debug dwo dumping command + +class CommandObjectTargetModulesDumpSeparateDebugInfoFiles +:

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

@@ -2005,9 +2021,10 @@ class CommandObjectTargetModulesDumpSymtab result.GetOutputStream().EOL(); result.GetOutputStream().EOL(); } - if (INTERRUPT_REQUESTED(GetDebugger(), + if (INTERRUPT_REQUESTED(GetDebugger(),

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

llvmbot wrote: @llvm/pr-subscribers-lldb Changes Using: black --exclude "third_party/" ./lldb/ -- Patch is 108.25 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/66053.diff 17 Files Affected: - (modified) lldb/scripts/analyze-project-deps.py

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/65979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c8387a3 - [lldb] Format more Python files with black (#65979)

Author: David Spickett Date: 2023-09-12T08:46:34+01:00 New Revision: c8387a31a4adfa9c29a578cf67321f756d3b4ac1 URL: https://github.com/llvm/llvm-project/commit/c8387a31a4adfa9c29a578cf67321f756d3b4ac1 DIFF:

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65979: >From 251eaf5271db6ef9646f843ef037d54406544f8d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 16:52:05 + Subject: [PATCH] [lldb] Format more Python files with black By running

[Lldb-commits] [lldb] 6bf6c47 - Reland "[lldb] Improve completion tests (#65973)"

Author: David Spickett Date: 2023-09-12T08:40:43+01:00 New Revision: 6bf6c4762c355ce4f4fb976039375a2c8ff6038f URL: https://github.com/llvm/llvm-project/commit/6bf6c4762c355ce4f4fb976039375a2c8ff6038f DIFF: