[Lldb-commits] [lldb] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-29 Thread Yuanfang Chen via lldb-commits
https://github.com/yuanfang-chen approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67373 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 466ea89 - [lldb] Fix failures when evaluating C++ expression and loading modules

2023-09-29 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2023-09-29T18:56:02-07:00 New Revision: 466ea89fc6d8bfd197cbc1055bbc38e730e9d523 URL: https://github.com/llvm/llvm-project/commit/466ea89fc6d8bfd197cbc1055bbc38e730e9d523 DIFF:

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Greg Clayton via lldb-commits
clayborg wrote: > I think I am on the same page with Greg for not exposing these symbols for > not shoving everything into `lldb_private`. Perhaps instead of `lldb_plugin` > we can name it something like `lldb_private::plugin` instead? Not a huge > difference, but keeping the top-level

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: > Perhaps instead of lldb_plugin we can name it something like > lldb_private::plugin instead? Well, that would definitely work for me, as these symbols would be automatically exported alongside all the other `lldb_private` symbols. What I'm not completely sure about

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Alex Langford via lldb-commits
bulbazord wrote: Adding Jonas and Adrian for visibility https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Alex Langford via lldb-commits
bulbazord wrote: I think I am on the same page with Greg for not exposing these symbols for not shoving everything into `lldb_private`. Perhaps instead of `lldb_plugin` we can name it something like `lldb_private::plugin` instead? Not a huge difference, but keeping the top-level private

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: After chatting with @clayborg , I'm going to try a different approach: - putting all of these dwarf-related files from the plugin in a `lldb_plugins::dwarf` namespace. - adding a new cmake flag that operates along with `LLDB_EXPORT_ALL_SYMBOLS` to specify a custom

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @clayborg , LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` (see https://github.com/llvm/llvm-project/blob/main/lldb/cmake/modules/AddLLDB.cmake#L177) that is used to export `lldb_private` as well as `lldb` symbols. This shows that there's been a precedent for this

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Greg Clayton via lldb-commits
clayborg wrote: But the above comments are my personal opinion. I would love to hear from other developers on what they would like to see. https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/67851 >From b5cfeaad26ecd29f15aadaad408ff30899a8a16d Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 29 Sep 2023 15:44:05 -0400 Subject: [PATCH] [LLDB] Export DWARF Parser symbols for external

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Greg Clayton via lldb-commits
clayborg wrote: I didn't realize there was already a cmake option for exporting the lldb_private namespace when I made my first comments. For this option to truly be useful, I would prefer to have a liblldb_private.so/LLDBPrivate.framework that we would create and then have the

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Greg Clayton via lldb-commits
clayborg wrote: So no plug-ins currently exist in the lldb_private namespace. I would rather not have all plug-in code end up in the lldb_private namespace either if people want access to these unsafe APIs outside of lldb. Maybe we should be creating a lldb_plugins namespace, and each plugin

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Most plug-ins inside of lldb either have their own namespace or none. If there is a larger patch that will go into open source that exposes the lldb_private namespace, then this would be applicable. In that case we would need a liblldb_private.so which

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes I'm developing support for the Mojo language as an out-of-tree plugin, and in order to implement the DWARF AST parser, I need to export the DWARF-related symbols that the TypeSystem expects me to use. I have CMake configured to export all

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/67851 >From 616b08f7c9e30b501d5f0fe2ff8d6fbf3ecb9582 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 29 Sep 2023 15:44:05 -0400 Subject: [PATCH] [LLDB] Export DWARF Parser symbols for external

[Lldb-commits] [lldb] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-29 Thread Shafik Yaghmour via lldb-commits
shafik wrote: ping https://github.com/llvm/llvm-project/pull/67373 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 12f4e11 - [lldb][NFCI] Remove unneeded use of ConstString from StructuredDataDarwinLog

2023-09-29 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-09-29T14:09:22-07:00 New Revision: 12f4e113869ff93d7b25cfc83c56f546e3d52c0f URL: https://github.com/llvm/llvm-project/commit/12f4e113869ff93d7b25cfc83c56f546e3d52c0f DIFF: https://github.com/llvm/llvm-project/commit/12f4e113869ff93d7b25cfc83c56f546e3d52c0f.diff

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/67851 None >From 78edde6c7b6294c0e1a78b18cdf81d156c636a38 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 29 Sep 2023 15:44:05 -0400 Subject: [PATCH] [LLDB] Export DWARF Parser symbols for

[Lldb-commits] [lldb] [mlir][sparse] Update Enum name for CompressedWithHigh (PR #67845)

2023-09-29 Thread Aart Bik via lldb-commits
https://github.com/aartbik approved this pull request. https://github.com/llvm/llvm-project/pull/67845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [mlir][sparse] Update Enum name for CompressedWithHigh (PR #67845)

2023-09-29 Thread Peiming Liu via lldb-commits
@@ -26,20 +26,20 @@ MLIR_DECLARE_CAPI_DIALECT_REGISTRATION(SparseTensor, sparse_tensor); /// If updating, keep them in sync and update the static_assert in the impl /// file. enum MlirSparseTensorDimLevelType { - MLIR_SPARSE_TENSOR_DIM_LEVEL_DENSE = 4, //

[Lldb-commits] [lldb] [mlir][sparse] Update Enum name for CompressedWithHigh (PR #67845)

2023-09-29 Thread Yinying Li via lldb-commits
https://github.com/yinying-lisa-li updated https://github.com/llvm/llvm-project/pull/67845 >From ab46cf0f76aeaa78f2eb8865d647400f810e35ec Mon Sep 17 00:00:00 2001 From: Yinying Li Date: Fri, 29 Sep 2023 19:09:21 + Subject: [PATCH] [mlir][sparse] Update Enum name for CompressedWithHigh

[Lldb-commits] [lldb] [lldb] Replace lldb's DWARFDebugAbbrev implementation with llvm's (PR #67841)

2023-09-29 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/67841 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace lldb's DWARFDebugAbbrev implementation with llvm's (PR #67841)

2023-09-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Exciting! https://github.com/llvm/llvm-project/pull/67841 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2e12fc3 - [lldb][NFCI] Remove unused constructors from BreakpointName

2023-09-29 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-09-29T12:06:13-07:00 New Revision: 2e12fc3d04032be743b2aded354d81d53c5195ec URL: https://github.com/llvm/llvm-project/commit/2e12fc3d04032be743b2aded354d81d53c5195ec DIFF: https://github.com/llvm/llvm-project/commit/2e12fc3d04032be743b2aded354d81d53c5195ec.diff

[Lldb-commits] [lldb] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-09-29 Thread via lldb-commits
https://github.com/shraiysh edited https://github.com/llvm/llvm-project/pull/67723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
junior-jl wrote: > @junior-jl You pushed 921 commits to your branch, I doubt you wanted to do > this. > > To fix this, I'd first find all your commits (so you don't lose your previous > work): > > ``` > $ git log --author "José Lira Junior" # or your email address > ``` > > Save the commit

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/67019 From c2396253b9584af9eabe1e67ed922f5f5f0e879c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Thu, 21 Sep 2023 11:12:58 -0300 Subject: [PATCH] [lldb] add stop-at-user-entry option to

[Lldb-commits] [lldb] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-29 Thread Shafik Yaghmour via lldb-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/67373 >From beab5db738483795ecb0bace2842acdbb1c9869a Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Mon, 25 Sep 2023 13:56:43 -0700 Subject: [PATCH] [Clang] Fix crash when ill-formed code is treated as a

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/67019 From 2cfb8089b455113524921d43565f1e1c1b569d8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Thu, 21 Sep 2023 11:12:58 -0300 Subject: [PATCH 1/9] [lldb] add command start ---

[Lldb-commits] [lldb] [lldb] Replace lldb's DWARFDebugAbbrev implementation with llvm's (PR #67841)

2023-09-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes The implementations are now close enough that replacing it is trivial. --- Full diff: https://github.com/llvm/llvm-project/pull/67841.diff 11 Files Affected: - (modified) lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt (-1) -

[Lldb-commits] [lldb] [lldb] Replace lldb's DWARFDebugAbbrev implementation with llvm's (PR #67841)

2023-09-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/67841 The implementations are now close enough that replacing it is trivial. >From 8913eb7f4c768545debf12dd42f2e308466f200b Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Fri, 29 Sep 2023 11:09:09 -0700

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior ,Leandro Lupori ,David

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/67019 From 9130096419bd3211af0163ec28ba9471de398d47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Thu, 21 Sep 2023 11:12:58 -0300 Subject: [PATCH 1/9] [lldb] add command start ---

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl resolved https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a514c30 - [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (#67628)

2023-09-29 Thread via lldb-commits
Author: River Riddle Date: 2023-09-29T10:33:11-07:00 New Revision: a514c30a7cf6ea99e5398b695601235b41a43939 URL: https://github.com/llvm/llvm-project/commit/a514c30a7cf6ea99e5398b695601235b41a43939 DIFF: https://github.com/llvm/llvm-project/commit/a514c30a7cf6ea99e5398b695601235b41a43939.diff

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

2023-09-29 Thread River Riddle via lldb-commits
https://github.com/River707 closed https://github.com/llvm/llvm-project/pull/67628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-09-29 Thread via lldb-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/67019 From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Thu, 21 Sep 2023 11:12:58 -0300 Subject: [PATCH 1/9] [lldb] add command start ---

[Lldb-commits] [lldb] [lldb] Add support for updating string during debug process (PR #67782)

2023-09-29 Thread via lldb-commits
jimingham wrote: BTW, I have no problem with the general direction of this change. It makes a lot more sense to ask a synthetic child provider to change a value - since it does represent the value of the ValueObject - rather than the summary which is just some free-form text. And being able

[Lldb-commits] [lldb] 2fc90af - [lldb] Fix build after 2da8f30c

2023-09-29 Thread Jan Svoboda via lldb-commits
Author: Jan Svoboda Date: 2023-09-29T10:01:37-07:00 New Revision: 2fc90afdac451b49d67c72bd41a99886811dd36c URL: https://github.com/llvm/llvm-project/commit/2fc90afdac451b49d67c72bd41a99886811dd36c DIFF: https://github.com/llvm/llvm-project/commit/2fc90afdac451b49d67c72bd41a99886811dd36c.diff

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: medismailben wrote: > Hi, @medismailben. I changed the code with

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
junior-jl wrote: Hi, @medismailben. I changed the code with your suggestions. Can you take a look if the early exits are correct before I commit, please? ```cpp case 'm': // Stop at user entry point { TargetSP target_sp = execution_context ? execution_context->GetTargetSP() :

[Lldb-commits] [lldb] c87b2c9 - [RISC-V] Remove unnecessary VLA

2023-09-29 Thread Benjamin Kramer via lldb-commits
Author: Benjamin Kramer Date: 2023-09-29T18:45:05+02:00 New Revision: c87b2c9c82e54b6cb21e668cd3e1097a44d5d48a URL: https://github.com/llvm/llvm-project/commit/c87b2c9c82e54b6cb21e668cd3e1097a44d5d48a DIFF:

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-29 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From a05c9b5c082395d0bade0bdef3faf7f00035c96d Mon Sep 17 00:00:00 2001 From: SHENG-YI HONG Date: Sat, 30 Sep 2023 00:28:38 +0800 Subject: [PATCH] Add DynamicLoader Plugin Fore FreeBSD Kernel coredump This

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-29 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From df60e39a644ddf0973c87f14b784a69b78c359f9 Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Sat, 30 Sep 2023 00:14:08 +0800 Subject: [PATCH 1/2] [clangd] Allow --query-driver to match a dot-normalized form

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl edited https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D159550: Remove unused #include

2023-09-29 Thread Ted Woodward via Phabricator via lldb-commits
ted added a subscriber: jasonmolenda. ted added a comment. Remove unused #include pointed out by @jasonmolenda in D159101 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159550/new/

[Lldb-commits] [PATCH] D159550: Remove unused #include

2023-09-29 Thread Ted Woodward via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb14153490134: Remove unused #include (authored by ted). Herald

[Lldb-commits] [lldb] b141534 - Remove unused #include

2023-09-29 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2023-09-29T11:07:38-05:00 New Revision: b14153490134e210c05bafae330a270cf60c0e2a URL: https://github.com/llvm/llvm-project/commit/b14153490134e210c05bafae330a270cf60c0e2a DIFF: https://github.com/llvm/llvm-project/commit/b14153490134e210c05bafae330a270cf60c0e2a.diff

[Lldb-commits] [PATCH] D159550: Remove unused #include

2023-09-29 Thread Ted Woodward via Phabricator via lldb-commits
ted created this revision. Herald added subscribers: luke, sunshaoce, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: medismailben wrote: @junior-jl I'm actually in favor of adding a

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior Message-ID: In-Reply-To: https://github.com/medismailben

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -38,7 +40,40 @@ Status

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior Message-ID: In-Reply-To: @@ -127,6 +127,8

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -160,6 +166,10 @@ class Language : public

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -27,6 +27,8 @@ class ObjCPlusPlusLanguage :

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior Message-ID: In-Reply-To: @@ -103,6 +103,8

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior Message-ID: In-Reply-To: @@ -160,6

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: https://github.com/medismailben edited

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior Message-ID: In-Reply-To: @@ -38,7 +40,40

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

2023-09-29 Thread Ted Woodward via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG847de9c33277: [RISC-V] Add RISC-V ABI plugin (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 847de9c - [RISC-V] Add RISC-V ABI plugin

2023-09-29 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2023-09-29T10:31:01-05:00 New Revision: 847de9c332775d1841fec9fea5cb5c41592a4c8f URL: https://github.com/llvm/llvm-project/commit/847de9c332775d1841fec9fea5cb5c41592a4c8f DIFF: https://github.com/llvm/llvm-project/commit/847de9c332775d1841fec9fea5cb5c41592a4c8f.diff

[Lldb-commits] [lldb] [lldb] Add support for updating string during debug process (PR #67782)

2023-09-29 Thread via lldb-commits
jimingham wrote: To clear up terminology... Strings had data formatters before AND after this change. The difference is that you've switched from a "Summary Provider" data formatter to a "Synthetic Child Provider" data formatter. It looks like you've made the printing of std::strings less

[Lldb-commits] [lldb] [lldb] Add support for updating string during debug process (PR #67782)

2023-09-29 Thread via lldb-commits
@@ -231,23 +244,39 @@ def cleanup(): "frame variable is", substrs=[ multimap, -"size=4", -'[0] = (first = 1, second = "is")', -'[1] = (first = 2, second = "smart")', -'[2] =

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl resolved https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
@@ -38,7 +39,37 @@ Status CommandOptionsProcessLaunch::SetOptionValue( case 's': // Stop at program entry point launch_info.GetFlags().Set(eLaunchFlagStopAtEntry); break; - + case 'm': // Stop at user entry point + { +TargetSP target_sp = +

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
junior-jl wrote: In this last commit, I changed the comments style and used @Michael137 suggestion by declaring a `llvm::SetVector` instead of a temporary `std::set`. https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Add support for changing char in Scalar::SetValueFromCString (PR #67784)

2023-09-29 Thread via lldb-commits
jimingham wrote: This seems like a somewhat limited way to poke a character into the value if the string has more than one character already in it. If you are trying to do more fancy setting of the contents of an SBValue, then it would be more straightforward to get the SBData for the value

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/67019 From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Thu, 21 Sep 2023 11:12:58 -0300 Subject: [PATCH 1/8] [lldb] add command start ---

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-29 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl resolved https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-29 Thread Michael Buch via lldb-commits
Michael137 wrote: Thanks, the API test looks good Apologies for the delay, didn't have a chance to follow-up on Greg's concern yet. But will hopefully get a chance in the next few days https://github.com/llvm/llvm-project/pull/66879 ___ lldb-commits

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-29 Thread via lldb-commits
@@ -0,0 +1,145 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-29 Thread via lldb-commits
https://github.com/huixie90 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-29 Thread via lldb-commits
@@ -0,0 +1,145 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-29 Thread via lldb-commits
@@ -0,0 +1,145 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-29 Thread via lldb-commits
@@ -0,0 +1,145 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-29 Thread Pavel Kosov via lldb-commits
kpdev wrote: @jimingham @bulbazord Please check patch with all supposed changes (without breaking into different patches) https://github.com/llvm/llvm-project/pull/67784 https://github.com/llvm/llvm-project/pull/67309 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Add support for updating string during debug process (PR #67782)

2023-09-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 9284b03e87df5153fe425b6b81b8402f666deb18..433d3973716cc46e1ffd7044898189f845e536f6

[Lldb-commits] [lldb] [lldb] Add support for changing char in Scalar::SetValueFromCString (PR #67784)

2023-09-29 Thread Pavel Kosov via lldb-commits
kpdev wrote: Depends on: https://github.com/llvm/llvm-project/pull/67309#issuecomment-1740657973 https://github.com/llvm/llvm-project/pull/67784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Add support for updating string during debug process (PR #67782)

2023-09-29 Thread Pavel Kosov via lldb-commits
kpdev wrote: Depends on: https://github.com/llvm/llvm-project/pull/67309#issuecomment-1740657973 https://github.com/llvm/llvm-project/pull/67782 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-29 Thread Pavel Kosov via lldb-commits
kpdev wrote: Patch 2: https://github.com/llvm/llvm-project/pull/67782 Patch 3: https://github.com/llvm/llvm-project/pull/67784 https://github.com/llvm/llvm-project/pull/67309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Add support for changing char in Scalar::SetValueFromCString (PR #67784)

2023-09-29 Thread Pavel Kosov via lldb-commits
https://github.com/kpdev created https://github.com/llvm/llvm-project/pull/67784 When we trying to change not the whole string, but single character in it - lldb's ValueObject fits in Scalar and therefore lldb trying to update it as a Scalar value which is currently only support numbers, so

[Lldb-commits] [lldb] [lldb] Add support for updating string during debug process (PR #67782)

2023-09-29 Thread Pavel Kosov via lldb-commits
https://github.com/kpdev created https://github.com/llvm/llvm-project/pull/67782 Before this update strings has only DataFormatters, and therefore the way they were printed was slightly different (see comment here:

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-29 Thread via lldb-commits
aokblast wrote: OK, I have modified the commit message. https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-29 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From 17cad831181b07c4397aa78039ede79fc8b20513 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 29 Sep 2023 15:27:42 +0800 Subject: [PATCH] Add DynamicLoader Plugin Fore FreeBSD Kernel coredump This patch

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-29 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/67599 >From 8fa9aae354ac455f4ea443de1bb5f753fe93fb51 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 27 Sep 2023 13:03:40 -0700 Subject: [PATCH 1/5] Add the ability to get a C++ vtable ValueObject from

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-29 Thread Greg Clayton via lldb-commits
clayborg wrote: > > > * Can we test this during multiple inheritance? Should we print multiple > > > vtables? > > > [Greg] I can add a test for this and make sure things works when > > > dynamic typing is on and off. We won't print multiple vtables, as each > > > class has only 1

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-29 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-29 Thread Greg Clayton via lldb-commits
clayborg wrote: > As my mentor Li-Wen Hsu suggest, It is better to separate this patch into two > commits. One for DynamicLoaderFreeBSDKernel class, and another for the > modification about ObjectFile.cpp. Should I use 1 commits to include both of > these change or separate it as two? I am