https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68013
>From a472a16e6032ce0cef0acae6957f690f7e6cc4a3 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 13:56:00 -0400
Subject: [PATCH] [LLDB] Allow specifying a custom exports file
LLDB
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68013
>From d557ea59b9c24387244280566260c33ac6bb9367 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 13:56:00 -0400
Subject: [PATCH] [LLDB] Allow specifying a custom exports file
LLDB
walter-erquinigo wrote:
I'll add the warning as you guys mention. That'll set clear expectations on
what users will be getting.
Besides that, @bulbazord , the current symbols getting exported by
`third-party/llvm-project/lldb/source/API/liblldb-private.exports` are not all
the symbols, but
jimingham wrote:
That sounds appropriate to me.
Jim
> On Oct 4, 2023, at 3:03 PM, Alex Langford ***@***.***> wrote:
>
>
> I think we need to make it clear wherever in the build system that the knob
> for turning on these exports lives that you use these symbols at your own
> risk, and we
bulbazord wrote:
> I think we need to make it clear wherever in the build system that the knob
> for turning on these exports lives that you use these symbols at your own
> risk, and we guarantee NO ABI stability for anything but the SB API's. We
> know that on this list but somebody getting
jimingham wrote:
I think we need to make it clear wherever in the build system that the knob for
turning on these exports lives that you use these symbols at your own risk, and
we guarantee NO ABI stability for anything but the SB API's. We know that on
this list but somebody getting the
bulbazord wrote:
Personally I have no qualms about this. It's just an option that lets you
choose which symbols to export. We already allow exporting every symbol, why
not just some of them? I would be careful though, since we don't guarantee any
stability for lldb_private (including things
jimingham wrote:
The other bit that we mentioned in the course of this review was showing
invalid vtables. You still have the code that just makes an error in the child
creation if you can't look up the value that a vtable slot is pointing to. It
would be better to make the child and report
@@ -8,18 +8,21 @@
#include "CommandOptionsProcessLaunch.h"
+#include "lldb/Core/Module.h"
#include "lldb/Host/FileSystem.h"
#include "lldb/Host/HostInfo.h"
#include "lldb/Host/OptionParser.h"
#include "lldb/Interpreter/CommandCompletions.h"
#include
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 6de148adcdd1eedea7e23b4e267c6f42bb68bc45 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 3 Oct 2023 15:28:45 -0300
Subject: [PATCH 1/3] [lldb] add stop-at-user-entry option
@@ -18,7 +18,9 @@
#include "llvm/DebugInfo/DWARF/DWARFLocationExpression.h"
#include
+namespace lldb_plugin::dwarf {
walter-erquinigo wrote:
This is possible after the switch to c++17, and that's probably why no one else
is using it in LLDB. There's no
@@ -18,7 +18,9 @@
#include "llvm/DebugInfo/DWARF/DWARFLocationExpression.h"
#include
+namespace lldb_plugin::dwarf {
clayborg wrote:
Do we do this anywhere else? Should this be split into:
```
namespace lldb_plugin {
namespace dwarf {
```
Not sure if there
https://github.com/clayborg commented:
I have no issues with putting this into a namespace either. Just a question in
my inline comment
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/clayborg commented:
Just remove the includes that are no longer needed and this is good to go!
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -8,18 +8,21 @@
#include "CommandOptionsProcessLaunch.h"
+#include "lldb/Core/Module.h"
#include "lldb/Host/FileSystem.h"
#include "lldb/Host/HostInfo.h"
#include "lldb/Host/OptionParser.h"
#include
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jeffreytan81 wrote:
> > > > * Can we test this during multiple inheritance? Should we print
> > > > multiple vtables?
> > > > [Greg] I can add a test for this and make sure things works when
> > > > dynamic typing is on and off. We won't print multiple vtables, as each
> > > > class has
bulbazord wrote:
I have no problem with putting things form SymbolFileDWARF into its own
namespace. Let's wait a bit though to see if anyone else has any opinions.
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
https://github.com/clayborg approved this pull request.
Looks good!
https://github.com/llvm/llvm-project/pull/68231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
I think all review comments have been taken into account. Anything else needed?
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
lldb-vscode had installation instructions based on creating a folder inside
~/.vscode/extensions, which no longer works. A different installation mechanism
is needed based on a VSCode command. More can be read in the contents of this
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/68234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/68234
lldb-vscode had installation instructions based on creating a folder inside
~/.vscode/extensions, which no longer works. A different installation mechanism
is needed based on a VSCode command. More can
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/68231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -519,6 +519,33 @@ TypeSP DWARFASTParserClang::ParseTypeFromDWARF(const
SymbolContext ,
return UpdateSymbolContextScopeForType(sc, die, type_sp);
}
+static std::optional
Michael137 wrote:
The integer types are a bit inconsistent (but this didn't change
felipepiovezan wrote:
this must have felt good to fix!
https://github.com/llvm/llvm-project/pull/68231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
https://github.com/llvm/llvm-project/pull/68231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
erichkeane wrote:
Ah, I see, apologies. I thought you meant the resign/etc complaint meant you
couldn't commit through the UI.
https://github.com/llvm/llvm-project/pull/66487
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
https://github.com/whisperity edited
https://github.com/llvm/llvm-project/pull/66487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Currently this non-trivial calculation is repeated multiple times, making it
hard to reason about when the `byte_offset`/`member_byte_offset` is being set
or not.
This patch simply moves all those instances of the same calculation into a
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/68231
Currently this non-trivial calculation is repeated multiple times, making it
hard to reason about when the `byte_offset`/`member_byte_offset` is being set
or not.
This patch simply moves all those instances
JDevlieghere wrote:
Thank you @antmox and @DavidSpickett for following up on this.
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=,
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=
Message-ID:
In-Reply-To:
https://github.com/whisperity approved this pull request.
> TIL there is no way to resign a review here like there was on Phab...
https://github.com/llvm/llvm-project/pull/66487
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
https://github.com/whisperity commented:
LGTM with previous discussion. I will do the commit... On the UI...
:slightly_smiling_face:
https://github.com/llvm/llvm-project/pull/66487
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/68224
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Samira Bazuzi
Date: 2023-10-04T09:04:13-07:00
New Revision: 19141c4172ea5a4979fa0419dcf712d3f0cadefc
URL:
https://github.com/llvm/llvm-project/commit/19141c4172ea5a4979fa0419dcf712d3f0cadefc
DIFF:
https://github.com/llvm/llvm-project/commit/19141c4172ea5a4979fa0419dcf712d3f0cadefc.diff
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
https://github.com/whisperity edited
https://github.com/llvm/llvm-project/pull/66487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/yinying-lisa-li updated
https://github.com/llvm/llvm-project/pull/68130
>From 47b34bb327e1078678d3ba0c96ebce3fc89cf2ae Mon Sep 17 00:00:00 2001
From: Yinying Li
Date: Tue, 3 Oct 2023 16:43:50 +
Subject: [PATCH 1/5] [mlir][sparse] Print new syntax
Printing changes from
https://github.com/yinying-lisa-li updated
https://github.com/llvm/llvm-project/pull/68130
>From 47b34bb327e1078678d3ba0c96ebce3fc89cf2ae Mon Sep 17 00:00:00 2001
From: Yinying Li
Date: Tue, 3 Oct 2023 16:43:50 +
Subject: [PATCH 1/4] [mlir][sparse] Print new syntax
Printing changes from
@@ -85,3 +85,38 @@ int main() {
}
+
+namespace deduceTemplatedConstructor{
HoBoIs wrote:
Done
https://github.com/llvm/llvm-project/pull/66487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=
Message-ID:
In-Reply-To:
https://github.com/whisperity requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
bazuzi wrote:
Thanks, Jonas. Can you also merge for me? I don't have write access.
https://github.com/llvm/llvm-project/pull/68224
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/68224
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bazuzi wrote:
@JDevlieghere @labath Are either of you able to review?
https://github.com/llvm/llvm-project/pull/68224
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
C++20 will automatically generate an operator== with reversed operand order,
which is ambiguous with the written operator== when one argument is marked
const and the other isn't.
These operators currently trigger
https://github.com/bazuzi created
https://github.com/llvm/llvm-project/pull/68224
C++20 will automatically generate an operator== with reversed operand order,
which is ambiguous with the written operator== when one argument is marked
const and the other isn't.
These operators currently
HoBoIs wrote:
@erichkeane @shafik I don't have write access. Could you merge if there is
nothing to be done?
https://github.com/llvm/llvm-project/pull/66487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
antmox wrote:
Yes, thanks @DavidSpickett
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
No warning present in https://lab.llvm.org/buildbot/#/builders/17/builds/44083
or https://lab.llvm.org/buildbot/#/builders/219/builds/6093. So this worked.
https://github.com/llvm/llvm-project/pull/68210
___
lldb-commits mailing
DavidSpickett wrote:
I've skipped it entirely in
https://github.com/llvm/llvm-project/commit/ceec9a7874af2eea8b00b5616fad388ccfa2b4f3.
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: David Spickett
Date: 2023-10-04T12:46:35Z
New Revision: ceec9a7874af2eea8b00b5616fad388ccfa2b4f3
URL:
https://github.com/llvm/llvm-project/commit/ceec9a7874af2eea8b00b5616fad388ccfa2b4f3
DIFF:
https://github.com/llvm/llvm-project/commit/ceec9a7874af2eea8b00b5616fad388ccfa2b4f3.diff
Author: aokblast
Date: 2023-10-04T08:12:27-04:00
New Revision: e00f2272d640ad5e8eda8982cd616d3ae56036b7
URL:
https://github.com/llvm/llvm-project/commit/e00f2272d640ad5e8eda8982cd616d3ae56036b7
DIFF:
https://github.com/llvm/llvm-project/commit/e00f2272d640ad5e8eda8982cd616d3ae56036b7.diff
https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/68210
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
`%zu` is used a lot elsewhere for logs and prints, none of which I've seen warn
across Linaro's bots. So this LGTM, thanks for the fix.
https://github.com/llvm/llvm-project/pull/68210
___
aokblast wrote:
I send another PR in [68210](https://github.com/llvm/llvm-project/pull/68210).
I don't know if it is the correct way to fix this problem.
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
https://github.com/aokblast created
https://github.com/llvm/llvm-project/pull/68210
None
>From 9df1a71c17219216bc34e9e750a26c5a874abc17 Mon Sep 17 00:00:00 2001
From: SHENG-YI HONG
Date: Wed, 4 Oct 2023 19:55:50 +0800
Subject: [PATCH] fix i386 size_t error when printing value
---
emaste wrote:
I'm not sure why @aokblast's reply didn't appear here, but indeed `%zu` is the
right format specifier.
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: Martin Storsjö
Date: 2023-10-04T14:34:12+03:00
New Revision: d918b813c852fb4632875c683f4b9552eddea30d
URL:
https://github.com/llvm/llvm-project/commit/d918b813c852fb4632875c683f4b9552eddea30d
DIFF:
aokblast wrote:
I think the answer is %z from cpp reference as the following screenshot shows.
I will check the whole code to prevent issues like this.
DavidSpickett wrote:
FYI on our Windows on Arm (aka AArch64) bot we got this warning:
```
[4840/6117] Building CXX object
tools\lldb\source\Plugins\DynamicLoader\FreeBSD-Kernel\CMakeFiles\lldbPluginDynamicLoaderFreeBSDKernel.dir\DynamicLoaderFreeBSDKernel.cpp.obj
Author: antoine moynault
Date: 2023-10-04T12:13:31+02:00
New Revision: 75f295c2455131993f9c945320736b84c5fcf99c
URL:
https://github.com/llvm/llvm-project/commit/75f295c2455131993f9c945320736b84c5fcf99c
DIFF:
https://github.com/antmox closed https://github.com/llvm/llvm-project/pull/68193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/antmox edited https://github.com/llvm/llvm-project/pull/68193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
Might as well go ahead and try this. If it's still unstable by end of your work
day, add a skipifwindows and let Jonas look into it.
https://github.com/llvm/llvm-project/pull/68193
___
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Looks like this test pass since #68050.
---
Full diff: https://github.com/llvm/llvm-project/pull/68193.diff
1 Files Affected:
- (modified)
lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py (-1)
``diff
https://github.com/antmox created
https://github.com/llvm/llvm-project/pull/68193
Looks like this test pass since #68050.
>From 24ae4ebf70c2b6884b31ca99a72eb0ba16bddf33 Mon Sep 17 00:00:00 2001
From: Antoine Moynault
Date: Wed, 4 Oct 2023 09:27:46 +
Subject: [PATCH] [lldb][test] Remove
https://github.com/HoBoIs updated
https://github.com/llvm/llvm-project/pull/66487
From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001
From: hobois
Date: Fri, 15 Sep 2023 09:28:21 +0200
Subject: [PATCH 1/5] Choose the correct deduction guide
If there are two guides, one of
DavidSpickett wrote:
@antmox You could remove the expected failure marker and see what the result is
then. It will be less confusing.
It may be that it does pass, but occasionally times out for another reason.
Though that is weird given that all the server parts involved are mocks.
antmox wrote:
Hi! Could this commit cause the lldb-aarch64-windows bot failure ?
https://lab.llvm.org/buildbot/#/builders/219/builds/6086
https://lab.llvm.org/buildbot/#/builders/219/builds/6076
Not sure if it's an unexpected pass or a timeout.
Could you please take a look ?
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/68094
>From 3816b0fbc31825d3878b031a49fb78dd7c256278 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 3 Oct 2023 11:44:17 +0100
Subject: [PATCH 1/3] [lldb][AArch64] Add isAArch64SMEFA64 check to SME
https://github.com/HoBoIs updated
https://github.com/llvm/llvm-project/pull/66487
From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001
From: hobois
Date: Fri, 15 Sep 2023 09:28:21 +0200
Subject: [PATCH 1/4] Choose the correct deduction guide
If there are two guides, one of
74 matches
Mail list logo
