[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/69726 >From 08c246316c2daa7dde701d5c4beb1de77021520a Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 20 Oct 2023 14:45:06 +0100 Subject: [PATCH 1/2] [lldb][docs] Update contributing links Patches now go

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

@@ -102,10 +102,13 @@ Additionally it builds: See the :doc:`LLDB Build Page ` for build instructions. Discussions about LLDB should go to the `LLDB forum -`__. Commit +`__ or the ``ll

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

DavidSpickett wrote: I don't have the experience to know if enabling this globally makes sense, but I do have a future use case for it. At a some point I want to be able to describe register fields as enums, and having the value as well as the name means you can match it up with the code you'

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

jasonmolenda wrote: @bulbazord @JDevlieghere OK this is the second set of refinement where it's closer to the structure of BreakpointSites. It's still not actually doing anything -- each one WatchpointResource corresponds to one Watchpoint, a single Watchpoint's request is not broken into mul

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

Endilll wrote: > What happens with values that don't have a name, do we already have a > fallback for that? I think we do: https://github.com/llvm/llvm-project/blob/2ad9fde41839879d8805d430c2e0857466d9c5d6/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp#L8563-L8571 Later there is a fa

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

@@ -74,9 +74,13 @@ def test(self): ) # Test an enum with fixed underlying type. -self.expect_expr("A::scoped_char_enum_val", result_value="case2") -self.expect_expr("A::scoped_ll_enum_val_neg", result_value="case0") -self.expect_expr("A:

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

https://github.com/Michael137 deleted https://github.com/llvm/llvm-project/pull/69815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

@@ -23,9 +23,18 @@ def check_enum(self, suffix): substrs=["Case1", "Case2", "Case3"], ) # Test each case in the enum. -self.expect_expr("var1_" + suffix, result_type=enum_name, result_value="Case1") -self.expect_expr("var2_" + suffix

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

@@ -23,9 +23,18 @@ def check_enum(self, suffix): substrs=["Case1", "Case2", "Case3"], ) # Test each case in the enum. -self.expect_expr("var1_" + suffix, result_type=enum_name, result_value="Case1") -self.expect_expr("var2_" + suffix

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

DavidSpickett wrote: > I think we do: I commented those out and got a bunch of test failures, so we're good on coverage there. https://github.com/llvm/llvm-project/pull/69815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

DavidSpickett wrote: @bulbazord Ok to land this? (looks like I'll be going ahead with the work presented in the RFC) https://github.com/llvm/llvm-project/pull/69315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [mlir] Add config for PDL (PR #69927)

https://github.com/jpienaar updated https://github.com/llvm/llvm-project/pull/69927 >From eea36708d838411d70eb99265c3a2f3aabb91460 Mon Sep 17 00:00:00 2001 From: Jacques Pienaar Date: Sun, 22 Oct 2023 09:33:40 -0700 Subject: [PATCH] [mlir] Add config for PDL Make it so that PDL can be optional

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -1506,13 +1513,39 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -1548,14 +1581,17 @@ static uint32_t LookupSymbolInModule(CommandInterpreter &interpreter, Symbol *symbol = symtab->SymbolAtIndex(match_indexes[i]); if (symbol) { if (symbol->ValueIsAddress()) { + // Using the new dump function to add colors in

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -642,7 +680,11 @@ bool Address::Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, if (pointer_sc.function != nullptr || pointer_sc.symbol != nullptr) { s->PutCString(": "); - pointer_sc.

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -680,21 +722,33 @@ bool Address::Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, if (show_stop_context) { // We have a function or a symbol from the same sections as this // address. - sc.DumpStopContex

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -680,21 +722,33 @@ bool Address::Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, if (show_stop_context) { // We have a function or a symbol from the same sections as this // address. - sc.DumpStopContex

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -185,6 +226,111 @@ bool SymbolContext::DumpStopContext(Stream *s, ExecutionContextScope *exe_scope, return dumped_something; } +void SymbolContext::GetDescription(Stream *s, lldb::DescriptionLevel level, + Target *target, const char* nam

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -1506,13 +1513,39 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -1506,13 +1513,39 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

DavidSpickett wrote: Cool, some good improvements so far. > Instead of this, should I call the next dump function with name parameter and > handle the name=nullptr in the PrintRed function. It would be a good idea to do this yes. I left some comments suggesting things to check there. I would

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -642,7 +680,11 @@ bool Address::Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, if (pointer_sc.function != nullptr || pointer_sc.symbol != nullptr) { s->PutCString(": "); - pointer_sc.

[Lldb-commits] [lldb] [lldb] Check for duplicate interpreter modules without loading them (PR #69932)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69932 Fixes #68987 Early on we load the interpreter (most commonly ld-linux) in LoadInterpreterModule. Then later when we get the first DYLD rendezvous we get a list of libraries that commonly includes ld-linux

[Lldb-commits] [lldb] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/69878 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Check for duplicate interpreter modules without loading them (PR #69932)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Fixes #68987 Early on we load the interpreter (most commonly ld-linux) in LoadInterpreterModule. Then later when we get the first DYLD rendezvous we get a list of libraries that commonly includes ld-

[Lldb-commits] [lldb] [lldb] Check for duplicate interpreter modules without loading them (PR #69932)

DavidSpickett wrote: Following the code down into `ObjectFileELF::SetLoadAddress` for ELF, I don't see the value we get from `I->base_addr` being any different from the one we get later as `module_sp->GetObjectFile()->GetBaseAddress().GetLoadAddress`. We set `value_is_offset` to true, if it we

[Lldb-commits] [lldb] [lldb] On POSIX, check for duplicate interpreter modules without loading them (PR #69932)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/69932 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

AaronBallman wrote: I'm not qualified to provide much of a review, but I'm in support of the change, thank you for the patch! https://github.com/llvm/llvm-project/pull/69815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [lldb] 7030623 - [lldb][docs] Add strace example to Debugging doc

Author: David Spickett Date: 2023-10-23T17:04:34+01:00 New Revision: 70306238cf3730fd7ef02170a1fdfa302676ac2b URL: https://github.com/llvm/llvm-project/commit/70306238cf3730fd7ef02170a1fdfa302676ac2b DIFF: https://github.com/llvm/llvm-project/commit/70306238cf3730fd7ef02170a1fdfa302676ac2b.diff

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

@@ -23,6 +23,7 @@ #if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 202311L #define __STDC_VERSION_STDCKDINT_H__ 202311L +#endif AaronBallman wrote: GCC exposes this value in all C and C++ language modes, so we should go ahead and remove the `#if` entirel

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

@@ -1,4 +1,5 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 +// RUN: %clang_cc1 -triple=x86_64 -verify -ffreestanding -std=c2x %s AaronBallman wrote: This triple is the same as the one below (c2x and c23 a

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -0,0 +1,140 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] 77374d3 - [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

Author: Med Ismail Bennani Date: 2023-10-23T09:51:01-07:00 New Revision: 77374d3b53cee7829ba70b13abf33e0d63d9d256 URL: https://github.com/llvm/llvm-project/commit/77374d3b53cee7829ba70b13abf33e0d63d9d256 DIFF: https://github.com/llvm/llvm-project/commit/77374d3b53cee7829ba70b13abf33e0d63d9d256.

[Lldb-commits] [lldb] 6bff2d5 - [lldb] Move template python files to separate directory

Author: Med Ismail Bennani Date: 2023-10-23T09:51:25-07:00 New Revision: 6bff2d51dcc7a369ba82fd44faa9eb207c621267 URL: https://github.com/llvm/llvm-project/commit/6bff2d51dcc7a369ba82fd44faa9eb207c621267 DIFF: https://github.com/llvm/llvm-project/commit/6bff2d51dcc7a369ba82fd44faa9eb207c621267.

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77374d3b53ce: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC) (authored by mib). Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D159310: [lldb] Move template python files to separate directory

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bff2d51dcc7: [lldb] Move template python files to separate directory (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159310/new/ https://r

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

https://github.com/bulbazord approved this pull request. Sorry for the delay, this looks fine to me. I don't have much to say about your RFC (since it's not something I have a lot of expertise on) but I look forward to seeing it get implemented! 😄 https://github.com/llvm/llvm-project/pull/693

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/69726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fe92977 - [lldb] Add a single bit constructor for RegisterFlags::Field (#69315)

Author: David Spickett Date: 2023-10-23T18:16:03+01:00 New Revision: fe929770f41e7b962ebaaeb0a3a3b03f8b8c URL: https://github.com/llvm/llvm-project/commit/fe929770f41e7b962ebaaeb0a3a3b03f8b8c DIFF: https://github.com/llvm/llvm-project/commit/fe929770f41e7b962ebaaeb0a3a3b03f8b8c.diff

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/69315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] aab0626 - [lldb][docs] Update contributing links (#69726)

Author: David Spickett Date: 2023-10-23T18:20:27+01:00 New Revision: aab0626c2e3e8ffedcb69dd2c73a4c9fe0e2aca4 URL: https://github.com/llvm/llvm-project/commit/aab0626c2e3e8ffedcb69dd2c73a4c9fe0e2aca4 DIFF: https://github.com/llvm/llvm-project/commit/aab0626c2e3e8ffedcb69dd2c73a4c9fe0e2aca4.diff

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/69726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

jimingham wrote: SymbolFiles can be owned by more than one debugger at a time. That's actually a very common mode for GUI's that can host more than one debugging session at a time. You can iterate over the list of debuggers from anywhere, and query the value of this property, but if two Debu

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH 1/3] Update stdckdint.h and make it available in pre-C23 modes.

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending registerflags as XML (PR #69951)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69951 This adds ToXML methods to encode RegisterFlags and its fields into XML according to GDB's target XML format: https://sourceware.org/gdb/onlinedocs/gdb/Target-Description-Format.html#Target-Description-Form

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/69951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

DavidSpickett wrote: For https://discourse.llvm.org/t/rfc-adding-register-field-information-to-lldb-server/74143. May be helpful to look at https://github.com/DavidSpickett/llvm-project/commit/93bdc630f6a4d27c4849b756838c5d70d23e2e90 which will be the next PR and adds the first register infor

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This adds ToXML methods to encode RegisterFlags and its fields into XML according to GDB's target XML format: https://sourceware.org/gdb/onlinedocs/gdb/Target-Description-Format.html#Target-Description

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

DavidSpickett wrote: And if you're not familiar with lldb-server and XML, as I wasn't, it doesn't use libXML to generate it. That's why I'm building strings to fit with the existing target.xml code. https://github.com/llvm/llvm-project/pull/69951 ___

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

https://github.com/ZijunZhaoCCK edited https://github.com/llvm/llvm-project/pull/69649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

https://github.com/clayborg requested changes to this pull request. I am not sure about always showing the signed or unsigned value by default. Enum values by default get displayed as the string value if we can find it. If you want to see the value as signed or unsigned you can change the displ

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

clayborg wrote: To clarify a bit: each value (SBValue in our public API, and ValueObject in our private API) has the ability to supply a value string and a summary string. The value string can depend on what the current format is set to. For an enum value, the format defaults to `lldb::eFormat

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

https://github.com/JDevlieghere approved this pull request. LGTM with SWIG all caps. https://github.com/llvm/llvm-project/pull/69858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

@@ -403,13 +403,21 @@ dependencies are required: * Sphinx (for the website and the Python API reference) * Graphviz (for the 'dot' tool) * doxygen (if you wish to build the C++ API reference) +* Swig (for generating Python bindings) JDevlieghere wrote: `s/Swig

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/69858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] On POSIX, check for duplicate interpreter modules without loading them (PR #69932)

https://github.com/clayborg approved this pull request. LGTM. I have seen multiple VSDO libraries being loaded sometimes too, but it doesn't use this path in the code, so this fix should work for ld.so https://github.com/llvm/llvm-project/pull/69932 _

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

@@ -175,3 +175,35 @@ std::string RegisterFlags::AsTable(uint32_t max_width) const { return table; } + +void RegisterFlags::ToXML(StreamString &strm) const { + // Example XML: + // + // + // + strm.Indent(); + strm << ""; + for (const Field &field : m_fields) { +

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

@@ -3113,6 +3119,10 @@ GDBRemoteCommunicationServerLLGS::BuildTargetXml() { if (!format.empty()) response << "format=\"" << format << "\" "; +if (reg_info->flags_type) { + response << "type=\"" << reg_info->flags_type->GetID() << "\" "; +} --

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

@@ -10,6 +10,7 @@ #define LLDB_TARGET_REGISTERFLAGS_H #include "lldb/Utility/Log.h" +#include "lldb/Utility/StreamString.h" clayborg wrote: We can just forward declare StreamString, and possibly remove Log.h above as well if we want to. https://github.com/l

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

AaronBallman wrote: Making sure I'm following along properly. For context, this is the debug experience I'm most used to:  It sounds like you're saying we shouldn't change the enum formatter to d

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH 1/4] Update stdckdint.h and make it available in pre-C23 modes.

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/69858 >From 4d94c5fae6f72e3ad551cf3381b0a0e9efecbf9a Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 21 Oct 2023 15:46:39 -0700 Subject: [PATCH 1/2] [LLDB] Update docs on building documentation This pa

[Lldb-commits] [lldb] 2f15082 - [LLDB] Update docs on building documentation (#69858)

Author: Aiden Grossman Date: 2023-10-23T12:59:39-07:00 New Revision: 2f15082b15f12461246e9e1fe1ea0cb106c27a34 URL: https://github.com/llvm/llvm-project/commit/2f15082b15f12461246e9e1fe1ea0cb106c27a34 DIFF: https://github.com/llvm/llvm-project/commit/2f15082b15f12461246e9e1fe1ea0cb106c27a34.diff

[Lldb-commits] [lldb] [LLDB] Update docs on building documentation (PR #69858)

https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/69858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

JDevlieghere wrote: > And if you're not familiar with lldb-server and XML, as I wasn't, it doesn't > use libXML to generate it. That's why I'm building strings to fit with the > existing target.xml code. It's somewhat implied, but is the goal to (continue to) avoid that dependency? Other part

[Lldb-commits] [lldb] [clang-format] Don't break between string literal operands of << (PR #69871)

owenca wrote: > I think adding the possibility of breaking '<<' is a good idea if it's > optional, what do u think? +1, but see also https://github.com/llvm/llvm-project/pull/69859#issuecomment-1776064714. https://github.com/llvm/llvm-project/pull/69871 ___

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

https://github.com/JDevlieghere approved this pull request. LGTM with the filename updated. https://github.com/llvm/llvm-project/pull/69388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/69388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

@@ -0,0 +1,120 @@ +//===-- InstrumentationRuntimeASan.cpp ===// JDevlieghere wrote: I know it's a bit unwieldy, but should this file be called `InstrumentationRuntimeASanLibsanitizers`? https://github.com/llvm/llvm-project/

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

clayborg wrote: > Making sure I'm following along properly. For context, this is the debug > experience I'm most used to: >  > > It sounds like you're saying we shouldn't change the

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

clayborg wrote: What IDE are you using for the screenshot above? The issue you might run into is that IDE might only be showing the value string and not the summary string. XCode and Visual Studio code will show the value if there is one _and_ the summary if there is one. If there is no value

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

clayborg wrote: If we have a "Foo *", the value will show up as the pointer value _and_ the summary for the Pointee (if `Foo` has a summary provider, it will show a summary for it along with the pointer. If we have a "Foo", then there will be no value for the struct/class instance and it will

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

clayborg wrote: Another thing other IDEs do is show something like "{...}" as the value for a struct/union/class. This is what Visual Studio used to do. https://github.com/llvm/llvm-project/pull/69815 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

jimingham wrote: This is a mostly orthogonal comment, but at some point, we really should switch all the summaries that pretend to be the value of a variable to value providing Synthetic Children. Summaries are currently playing two fairly different roles, one some free-form text that describ

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

clayborg wrote: I agree with what Jim said as well. I would rather see the IDEs add the ability to change the format for the values like Xcode can so that people can see their values as needed. The summary here isn't a perfect option for this because if you switch the format to `lldb::eFormatD

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make us it

mib updated this revision to Diff 557856. mib marked 2 inline comments as done. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159314/new/ https://reviews.llvm.org/D159314 Files: lldb/include/lldb/Interpreter/Interfaces/OperatingSystem

[Lldb-commits] [lldb] 83a6b02 - [lldb] Move comments and add missing periods (NFC)

Author: Jonas Devlieghere Date: 2023-10-23T15:29:01-07:00 New Revision: 83a6b02c3d79f0ac714690e1baec14efb1c24fe9 URL: https://github.com/llvm/llvm-project/commit/83a6b02c3d79f0ac714690e1baec14efb1c24fe9 DIFF: https://github.com/llvm/llvm-project/commit/83a6b02c3d79f0ac714690e1baec14efb1c24fe9.d

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -0,0 +1,140 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

https://github.com/bulbazord approved this pull request. Thanks for breaking it up, that made it easier for me to review. I don't see any issues with it right now, so LGTM. https://github.com/llvm/llvm-project/pull/69388 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -0,0 +1,140 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

bulbazord wrote: In that case, maybe it doesn't make sense for every Debugger to have its own callback and SymbolFile should own it? Can't say I'm a fan of having this effectively be a global variable since I've seen it be an issue in other situations (e.g. Logging). https://github.com/llvm/l

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/69981 I need this API in the Swift plugin, but it seems generally useful enough to expose it in the main branch. >From 6b41e8ccaf7c3daf787cb7f7399ba815c5fe5b77 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date:

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes I need this API in the Swift plugin, but it seems generally useful enough to expose it in the main branch. --- Full diff: https://github.com/llvm/llvm-project/pull/69981.diff 15 Files Affected: - (m

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/69981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

@@ -533,6 +533,12 @@ class Function : public UserID, public SymbolContextScope { /// The DeclContext, or NULL if none exists. CompilerDeclContext GetDeclContext(); + /// Get the CompilerContext for this function, if available. + /// + /// \return + /// The Comp

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

https://github.com/bulbazord commented: overall LGTM, few questions though https://github.com/llvm/llvm-project/pull/69981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/69981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

@@ -816,6 +818,8 @@ Expected opts::symbols::getAction() { "Specify search type (-find) to use search options."); return dumpModule; + + bulbazord wrote: Spurious whitespace https://github.com/llvm/llvm-project/pull/69981 __

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

@@ -519,7 +530,17 @@ CompilerDeclContext Function::GetDeclContext() { if (SymbolFile *sym_file = module_sp->GetSymbolFile()) return sym_file->GetDeclContextForUID(GetID()); } - return CompilerDeclContext(); + return {}; +} + +std::vector Function::GetCompilerConte

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

@@ -1391,7 +1391,16 @@ SymbolFileDWARFDebugMap::GetDeclContextContainingUID(lldb::user_id_t type_uid) { SymbolFileDWARF *oso_dwarf = GetSymbolFileByOSOIndex(oso_idx); if (oso_dwarf) return oso_dwarf->GetDeclContextContainingUID(type_uid); - return CompilerDeclContext(

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

@@ -142,8 +142,7 @@ TypeSP DWARFASTParserClang::ParseTypeFromClangModule(const SymbolContext &sc, // If this type comes from a Clang module, recursively look in the // DWARF section of the .pcm file in the module cache. Clang // generates DWO skeleton units as breadcrumb

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

@@ -533,6 +533,12 @@ class Function : public UserID, public SymbolContextScope { /// The DeclContext, or NULL if none exists. CompilerDeclContext GetDeclContext(); + /// Get the CompilerContext for this function, if available. + /// + /// \return + /// The Comp

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 840d0b7e03045c30b052dce8d0bb82f3fa0c5d6d 6b41e8ccaf7c3daf787cb7f7399ba815c5fe5b77 --

[Lldb-commits] [lldb] 61c4ee9 - [lldb][NFC] Implement llvm-style RTTI for DWARFASTParser (#69762)

Author: Augusto Noronha Date: 2023-10-23T16:25:18-07:00 New Revision: 61c4ee94498f99f45b630bc491ad11db236a3b82 URL: https://github.com/llvm/llvm-project/commit/61c4ee94498f99f45b630bc491ad11db236a3b82 DIFF: https://github.com/llvm/llvm-project/commit/61c4ee94498f99f45b630bc491ad11db236a3b82.dif

[Lldb-commits] [lldb] [lldb][NFC] Implement llvm-style RTTI for DWARFASTParser (PR #69762)

https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/69762 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

@@ -396,6 +396,17 @@ void Function::GetDescription(Stream *s, lldb::DescriptionLevel level, s->AsRawOstream() << ", name = \"" << name << '"'; if (mangled) s->AsRawOstream() << ", mangled = \"" << mangled << '"'; + if (level == eDescriptionLevelVerbose) { +*s <<

[Lldb-commits] [lldb] [lldb][NFC] Move GetTypeForDIE from to DWARFASTParser (PR #69764)

https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/69764 >From d84b4b293a97b75a34e4208c914988a2e5231d66 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Fri, 20 Oct 2023 12:59:00 -0700 Subject: [PATCH] [lldb][NFC] Move GetTypeForDIE from to DWARFASTParser ---

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

@@ -322,10 +322,12 @@ std::vector parseCompilerContext() { } result.push_back({kind, ConstString{value}}); } - outs() << "Search context: {\n"; - for (auto entry: result) -entry.Dump(); - outs() << "}\n"; + outs() << "Search context: {"; + lldb_private::Strea

[Lldb-commits] [lldb] Expose DWARFDIE::GetDeclContext() in lldb_private::Function. (PR #69981)

@@ -396,6 +396,17 @@ void Function::GetDescription(Stream *s, lldb::DescriptionLevel level, s->AsRawOstream() << ", name = \"" << name << '"'; if (mangled) s->AsRawOstream() << ", mangled = \"" << mangled << '"'; + if (level == eDescriptionLevelVerbose) { +*s <<

[Lldb-commits] [lldb] [lldb][NFC] Remote reference to Swift in DWARFASTParser::Kind enum (PR #69984)

https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/69984 None >From 2500e7fadc72c56a887b27d5f271bea5af70ccab Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Mon, 23 Oct 2023 16:35:24 -0700 Subject: [PATCH] [lldb][NFC] Remote reference to Swift in DWARFASTPars

  1   2   >