medismailben wrote:
Add test like @jimingham suggested.
https://github.com/llvm/llvm-project/pull/70351
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/70351
>From 604a03a8be94f5a9390f39a1606bad809c939ffc Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 27 Oct 2023 19:47:53 -0700
Subject: [PATCH] [lldb/Target] Delay image loading after corefile proces
@@ -461,13 +461,11 @@ static void ParseOSVersion(llvm::VersionTuple &version,
NSString *Key) {
// Invoke xcrun with the shlib dir.
if (FileSpec fspec = HostInfo::GetShlibDir()) {
if (FileSystem::Instance().Exists(fspec)) {
-std::string contents_dir =
-
@@ -461,13 +461,11 @@ static void ParseOSVersion(llvm::VersionTuple &version,
NSString *Key) {
// Invoke xcrun with the shlib dir.
if (FileSpec fspec = HostInfo::GetShlibDir()) {
if (FileSystem::Instance().Exists(fspec)) {
-std::string contents_dir =
-
@@ -461,13 +461,11 @@ static void ParseOSVersion(llvm::VersionTuple &version,
NSString *Key) {
// Invoke xcrun with the shlib dir.
if (FileSpec fspec = HostInfo::GetShlibDir()) {
if (FileSystem::Instance().Exists(fspec)) {
-std::string contents_dir =
-
https://github.com/bulbazord approved this pull request.
Makes sense to me
https://github.com/llvm/llvm-project/pull/70528
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/70528
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
The code was incorrectly going into the wrong direction by removing one
component instead of appendeing /Developer to it. Due to fallback mechanisms in
xcrun this never seemed to have caused any issues
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/70528
The code was incorrectly going into the wrong direction by removing one
component instead of appendeing /Developer to it. Due to fallback mechanisms in
xcrun this never seemed to have caused any issues.
>
https://github.com/s-barannikov closed
https://github.com/llvm/llvm-project/pull/70514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Sergei Barannikov
Date: 2023-10-28T02:33:50+03:00
New Revision: 4e4433f629a5ecfea538808449d513b5762a67b6
URL:
https://github.com/llvm/llvm-project/commit/4e4433f629a5ecfea538808449d513b5762a67b6
DIFF:
https://github.com/llvm/llvm-project/commit/4e4433f629a5ecfea538808449d513b5762a67b6.d
https://github.com/bulbazord approved this pull request.
I can't find any uses of these either.
I also checked in Apple's downstream swift fork, it doesn't look used there
either.
LGTM
https://github.com/llvm/llvm-project/pull/70514
___
lldb-commits
https://github.com/bulbazord approved this pull request.
I think all of my comments have been addressed. Thanks!
https://github.com/llvm/llvm-project/pull/70392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -104,6 +104,19 @@ ScriptInterpreter::GetStatusFromSBError(const
lldb::SBError &error) const {
return Status();
}
+Event *
+ScriptInterpreter::GetOpaqueTypeFromSBEvent(const lldb::SBEvent &event) const {
+ return event.m_opaque_ptr;
+}
+
+Stream *ScriptInterpreter::GetOp
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/70392
>From 56f95c1a16bc448d050865ba433e56af82dfbe2e Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 27 Oct 2023 15:20:28 -0700
Subject: [PATCH] [lldb] Make use of Scripted{Python,}Interface for
Scri
https://github.com/ayermolo closed
https://github.com/llvm/llvm-project/pull/70512
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Sergei Barannikov (s-barannikov)
Changes
The corresponding definitions were removed in 7dcbe3d3 and 2a8fa2a8.
Also remove a couple of variables made dead by these changes.
---
Full diff: https://github.com/llvm/llvm-project/pull/70514.diff
https://github.com/s-barannikov created
https://github.com/llvm/llvm-project/pull/70514
The corresponding definitions were removed in 7dcbe3d3 and 2a8fa2a8.
Also remove a couple of variables made dead by these changes.
>From e06880e4af9e1d8bd535d08174eb8a0fffd2e780 Mon Sep 17 00:00:00 2001
Fro
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/70512
>From 1c6a604df93b833c3bb9c7d34f4f27415592dbe5 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Thu, 5 Oct 2023 12:39:02 -0700
Subject: [PATCH] [LLVM][DWARF] Add support for monolithic types in
.debug
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/70512
>From 1c6a604df93b833c3bb9c7d34f4f27415592dbe5 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Thu, 5 Oct 2023 12:39:02 -0700
Subject: [PATCH] [LLVM][DWARF] Add support for monolithic types in
.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/70490
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2023-10-27T14:50:21-07:00
New Revision: d3cbf9fb64399dbf8718c600d8ac63bd1afaa9d1
URL:
https://github.com/llvm/llvm-project/commit/d3cbf9fb64399dbf8718c600d8ac63bd1afaa9d1
DIFF:
https://github.com/llvm/llvm-project/commit/d3cbf9fb64399dbf8718c600d8ac63bd1afaa9d1.d
aprantl added a comment.
@Mordante @Michael137 This seems to fail on older versions of compiler/libcxx
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/7247/ You can
probably fix this by just requiring a minimum clang version in the tests
Repository:
rG LLVM Github Monorepo
@@ -104,6 +104,19 @@ ScriptInterpreter::GetStatusFromSBError(const
lldb::SBError &error) const {
return Status();
}
+Event *
+ScriptInterpreter::GetOpaqueTypeFromSBEvent(const lldb::SBEvent &event) const {
+ return event.m_opaque_ptr;
+}
+
+Stream *ScriptInterpreter::GetOp
@@ -2652,7 +2654,9 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
std::vector external_sym_trie_entries;
std::set resolver_addresses;
- if (dyld_trie_data.GetByteSize() > 0) {
+ const size_t dyld_trie_data_size = dyld_trie_data.GetByteSize();
+ if (dyld_trie_dat
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/70392
>From 086c5f8a4056f027377e490c0387f2d1344cb5db Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 27 Oct 2023 12:13:00 -0700
Subject: [PATCH] [lldb] Make use of Scripted{Python,}Interface for
Scri
@@ -104,6 +104,19 @@ ScriptInterpreter::GetStatusFromSBError(const
lldb::SBError &error) const {
return Status();
}
+Event *
+ScriptInterpreter::GetOpaqueTypeFromSBEvent(const lldb::SBEvent &event) const {
+ return event.m_opaque_ptr;
+}
+
+Stream *ScriptInterpreter::GetOp
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/70445
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
LGTM!
https://github.com/llvm/llvm-project/pull/70445
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,92 @@
+//===-- ScriptedThreadPlanPythonInterface.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/70392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,40 @@
+//===-- ScriptedThreadInterface.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Author: Med Ismail Bennani
Date: 2023-10-27T11:58:59-07:00
New Revision: 11b3b3834cfdd9183eff903ef8ac34a733af2068
URL:
https://github.com/llvm/llvm-project/commit/11b3b3834cfdd9183eff903ef8ac34a733af2068
DIFF:
https://github.com/llvm/llvm-project/commit/11b3b3834cfdd9183eff903ef8ac34a733af2068.
@@ -2652,7 +2654,9 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
std::vector external_sym_trie_entries;
std::set resolver_addresses;
- if (dyld_trie_data.GetByteSize() > 0) {
+ const size_t dyld_trie_data_size = dyld_trie_data.GetByteSize();
+ if (dyld_trie_dat
https://github.com/bulbazord approved this pull request.
looks fine to me, one small question though
https://github.com/llvm/llvm-project/pull/70490
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/70490
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -104,6 +104,19 @@ ScriptInterpreter::GetStatusFromSBError(const
lldb::SBError &error) const {
return Status();
}
+Event *
+ScriptInterpreter::GetOpaqueTypeFromSBEvent(const lldb::SBEvent &event) const {
+ return event.m_opaque_ptr;
+}
+
+Stream *ScriptInterpreter::GetOp
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/70392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,40 @@
+//===-- ScriptedThreadInterface.h ---*- C++
-*-===//
bulbazord wrote:
The header is missing the world `Plan`
https://github.com/llvm/llvm-project/pull/70392
___
lldb-commi
@@ -0,0 +1,40 @@
+//===-- ScriptedThreadInterface.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,92 @@
+//===-- ScriptedThreadPlanPythonInterface.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
I have a crash when parsing the dyld trie data and I want to ask the originator
to send me the (possibly corrupted) binary that's causing this. This patch adds
some logging to help pinpoint that fil
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/70490
I have a crash when parsing the dyld trie data and I want to ask the originator
to send me the (possibly corrupted) binary that's causing this. This patch adds
some logging to help pinpoint that file.
>Fro
https://github.com/bulbazord commented:
`importlib` has been around since Python 3.1, maybe we shouldn't have the
conditional logic to use `imp` instead? I'm pretty sure the minimum supported
version is 3.6 since that's what LLVM requires.
https://github.com/llvm/llvm-project/pull/70443
__
https://github.com/fel-cab updated
https://github.com/llvm/llvm-project/pull/68016
>From dd44de067c26ba94b6561c5ed7fa4a5d812a3d1a Mon Sep 17 00:00:00 2001
From: Felipe Cabarcas
Date: Mon, 18 Sep 2023 12:07:12 +
Subject: [PATCH 01/13] testing Profiler features
---
openmp/libomptarget/src/i
jpienaar wrote:
> Can you expand on the motivation? Why is it a problem that PDL is always
> included? Your description isn’t very explicit on the impact.
Done. Its not PDL specific, I think it is a problem if any dialect is always
included even if not used :) The others just have a simple met
https://github.com/jpienaar edited
https://github.com/llvm/llvm-project/pull/69927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-10-27T15:35:15Z
New Revision: d8003d021b87485836a8f685b0ac6473069c229b
URL:
https://github.com/llvm/llvm-project/commit/d8003d021b87485836a8f685b0ac6473069c229b
DIFF:
https://github.com/llvm/llvm-project/commit/d8003d021b87485836a8f685b0ac6473069c229b.diff
LOG
erichkeane wrote:
Build failures are all 1 test, and are:
`File
/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-fdgrz-1/llvm-project/clang-ci/libcxx/test/libcxx/algorithms/cpp17_iterator_concepts.verify.cpp
Line 410: cannot find start of regex ('{{') in static assertion failed`
The patch r
tuliom wrote:
I believe it's also important to mention this PR does not solve issue #70453.
But it helps to solve `ModuleNotFoundError: No module named 'imp'` kind of
issues.
https://github.com/llvm/llvm-project/pull/70443
___
lldb-commits mailing lis
tuliom wrote:
[This document](https://docs.python.org/3/library/importlib.html) mentions 3.1.
Many functions were added after 3.6, but none of them are being explicitly used
in this patch.
I'm afraid the easiest way to guarantee is by testing with Python 3.6.
https://github.com/llvm/llvm-projec
DavidSpickett wrote:
Do you know when `importlib` was added? I wonder if the overlap is enough to
not need a fallback. We appear to advertise a 3.6 or 3.7 minimum in our
documentation, and llvm wants >=3.6
(https://llvm.org/docs/GettingStarted.html#software).
@JDevlieghere will know for sure.
@@ -0,0 +1,7 @@
+// RUN: %clang_cc1 -verify -fsyntax-only -std=c++17 %s
+
+struct S {
+ int n;
+ int d = (4, []() { return n; }()); // expected-error {{'this' cannot be
implicitly captured in this context}} \
+ // expected-note {{explicitly
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tulio Magno Quites Machado Filho (tuliom)
Changes
1. Remove usage of PyEval_ThreadsInitialized and PyEval_InitThreads
Both of these functions were removed in Python 3.13 [1] after being deprecated
since Python 3.9.
According to "What's ne
https://github.com/tuliom created
https://github.com/llvm/llvm-project/pull/70445
1. Remove usage of PyEval_ThreadsInitialized and PyEval_InitThreads
Both of these functions were removed in Python 3.13 [1] after being deprecated
since Python 3.9.
According to "What's new in Python 3.13" docum
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tulio Magno Quites Machado Filho (tuliom)
Changes
imp got removed in Python 3.12 [1] and the community recommends using importlib
in newer Python versions.
[1] https://docs.python.org/3.12/whatsnew/3.12.html#imp
---
Full diff: https://git
https://github.com/tuliom created
https://github.com/llvm/llvm-project/pull/70443
imp got removed in Python 3.12 [1] and the community recommends using importlib
in newer Python versions.
[1] https://docs.python.org/3.12/whatsnew/3.12.html#imp
>From 16fd09f102eff20825847e32f225715960d1c082 Mo
DavidSpickett wrote:
https://github.com/llvm/llvm-project/commit/02ef12dd808f19191a4d0a9f511c4e5a5dda59b5
fixes the Windows test. If the behaviour seems suspicious to you, I can check
more details of the build but I don't know anything about `Scripted...` so I'll
need you to tell me what to lo
Author: David Spickett
Date: 2023-10-27T11:24:03Z
New Revision: 02ef12dd808f19191a4d0a9f511c4e5a5dda59b5
URL:
https://github.com/llvm/llvm-project/commit/02ef12dd808f19191a4d0a9f511c4e5a5dda59b5
DIFF:
https://github.com/llvm/llvm-project/commit/02ef12dd808f19191a4d0a9f511c4e5a5dda59b5.diff
LOG
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/70300
>From 45a9d131ce6c9fb31355519cd810ceff32c05ee7 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 11 Oct 2023 14:54:07 +0100
Subject: [PATCH 1/4] [lldb][AArch64][Linux] Add field information for the C
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/70300
>From 45a9d131ce6c9fb31355519cd810ceff32c05ee7 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 11 Oct 2023 14:54:07 +0100
Subject: [PATCH 1/3] [lldb][AArch64][Linux] Add field information for the C
DavidSpickett wrote:
@omjavaid Any objections?
https://github.com/llvm/llvm-project/pull/70303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/70303
>From bbcdfa3bb4844f609efabbb819444bbab02b02f8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 26 Oct 2023 08:28:02 +
Subject: [PATCH] [lldb][AArch64][Linux] Reanme IsEnabled to
IsPresent
For
63 matches
Mail list logo
