[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-13 Thread Haojian Wu via lldb-commits
hokein wrote: Thanks for the review. https://github.com/llvm/llvm-project/pull/71928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-13 Thread Haojian Wu via lldb-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/71928 >From 08c3b1a40b508d360f47bed6d7d42050c18b01a0 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 10 Nov 2023 12:35:10 +0100 Subject: [PATCH 1/5] [LLDB] Display artificial __promise and __coro_frame variables.

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for threads (PR #72196)

2023-11-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. On simple change and this is good to go. https://github.com/llvm/llvm-project/pull/72196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for threads (PR #72196)

2023-11-13 Thread Greg Clayton via lldb-commits
@@ -839,4 +839,19 @@ void DAP::SetFrameFormat(llvm::StringRef format) { } } +void DAP::SetThreadFormat(llvm::StringRef format) { + if (format.empty()) +return; + lldb::SBError error; + g_dap.thread_format = lldb::SBFormat(format.data(), error);

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for threads (PR #72196)

2023-11-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/72196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for threads (PR #72196)

2023-11-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/72196 >From bedae95f3c3f9d719b3677ef59c262283b813284 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 13 Nov 2023 21:42:26 -0500 Subject: [PATCH] thread format --- lldb/include/lldb/API/SBFormat.h

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for threads (PR #72196)

2023-11-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/72196 >From 00c258dd5c90cd920e5771ac89c0a8d2e97be937 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 13 Nov 2023 21:42:26 -0500 Subject: [PATCH] thread format --- lldb/include/lldb/API/SBFormat.h

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for threads (PR #72196)

2023-11-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r e9453f3c3c7e682e39952c9e18e6b1f8152b0ffa..5b5ec92b655e390e652fafbe3f56628ff822ee51

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for threads (PR #72196)

2023-11-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes When this option gets enabled, descriptions of threads will be generated using the format provided in the launch configuration instead of generating it manually in the dap code. This allows

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for threads (PR #72196)

2023-11-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/72196 When this option gets enabled, descriptions of threads will be generated using the format provided in the launch configuration instead of generating it manually in the dap code. This allows lldb-dap to

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/71843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d9ec4b2 - [lldb-dap] Add an option to provide a format for stack frames (#71843)

2023-11-13 Thread via lldb-commits
Author: Walter Erquinigo Date: 2023-11-13T21:10:16-05:00 New Revision: d9ec4b24a84addb8bd77b5d9dd990181351cf84c URL: https://github.com/llvm/llvm-project/commit/d9ec4b24a84addb8bd77b5d9dd990181351cf84c DIFF:

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/71843 >From 9dab558339346e15149bb59da4dc2d58070dafa2 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 9 Nov 2023 13:15:55 -0500 Subject: [PATCH 1/2] [lldb-dap] Add an option to show function args in

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Thanks for all of the changes. Looks great! https://github.com/llvm/llvm-project/pull/71843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 0e1a52f556a90cc7b7ce7666fc476c99cf7bfb02..9dab558339346e15149bb59da4dc2d58070dafa2

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/71843 >From 9dab558339346e15149bb59da4dc2d58070dafa2 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 9 Nov 2023 13:15:55 -0500 Subject: [PATCH] [lldb-dap] Add an option to show function args in

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r a41b149f481e2bcba24e81f208a1938247f040e0..aaeb653198f32386f8f7d38e4607fdd274f285d5

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
jimingham wrote: I addressed most of the review comments - a few I had questions about - and also did the clang-format & python-deformatting. https://github.com/llvm/llvm-project/pull/70734 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. One last request: test the SBFormat API in a stand alone test in `lldb/test/api/sbformat` so we can see if the errors work and the "operator bool" works as expected: ``` format = lldb.SBFormat() self.assertFalse(format) err =

[Lldb-commits] [lldb] [llvm] Emit DIE's size in bits when size is not a multiple of 8 (PR #69741)

2023-11-13 Thread David Blaikie via lldb-commits
dwblaikie wrote: > @dwblaikie I talked with Adrian, his idea is to emit the size in bits > whenever it does not cleanly fit in a byte. His point (and I agree) is that > there may be tools that can use this bit size, and if we always round up when > emitting the DWARF we will lose this

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/71843 >From 96d3b9e61dde88bc5d7b6dbad7c35932054b8981 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 9 Nov 2023 13:15:55 -0500 Subject: [PATCH] [lldb-dap] Add an option to show function args in

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Walter Erquinigo via lldb-commits
@@ -0,0 +1,47 @@ +//===-- SBFormat.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,47 @@ +//===-- SBFormat.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [flang] [mlir] [clang] [clang-tools-extra] [llvm] [lldb] [compiler-rt] [CodeGen][DebugInfo] Add missing debug info for jump table BB (PR #71021)

2023-11-13 Thread via lldb-commits
https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/71021 >From 1be56cf6541d34e4e2ead3f4b3d3ce482d69f68f Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Thu, 2 Nov 2023 12:14:15 +0800 Subject: [PATCH 1/4] [DebugInfo] Add debug info test for jump table Test whether

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,69 @@ + +//===-- SBFormat.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Greg Clayton via lldb-commits
@@ -824,4 +824,15 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +void DAP::SetFrameFormat(llvm::StringRef format) { + if (format.empty()) +return; + lldb::SBError error; + g_dap.frame_format =

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/71843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. Just need to not use `llvm::errs()` or `llvm::outs()` in lldb DAP, use DAP::SendOutput(OutputType::Console, ...)` to ensure that the users sees this. https://github.com/llvm/llvm-project/pull/71843

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/71843 >From 650690b3c8333b6ce54359508519c881f23cf4c4 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 9 Nov 2023 13:15:55 -0500 Subject: [PATCH] [lldb-dap] Add an option to show function args in

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/71843 >From f7e9a2a9e206062f187ae4cc74038bd31ba32d26 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 9 Nov 2023 13:15:55 -0500 Subject: [PATCH] [lldb-dap] Add an option to show function args in

[Lldb-commits] [mlir] [lldb] [llvm] [clang] [compiler-rt] Enable Custom Lowering for fabs.v8f16 on AVX (PR #71730)

2023-11-13 Thread David Li via lldb-commits
https://github.com/david-xl updated https://github.com/llvm/llvm-project/pull/71730 >From 6032b965f85482b39e841bd95842f4e17c92fefd Mon Sep 17 00:00:00 2001 From: David Li Date: Tue, 7 Nov 2023 23:29:44 -0800 Subject: [PATCH 1/6] Enable Custom Lowering for fabs.v8f16 on AVX ---

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -1255,6 +1258,676 @@ class CommandObjectScriptingObject : public CommandObjectRaw { CompletionType m_completion_type = eNoCompletion; }; + +/// This command implements a lldb parsed scripted command. The command +/// provides a definition of the options and arguments,

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -476,6 +476,14 @@ class ScriptInterpreter : public PluginInterface { return false; } + virtual bool RunScriptBasedParsedCommand( + StructuredData::GenericSP impl_obj_sp, Args& args, + ScriptedCommandSynchronicity synchronicity, +

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/71843 >From 8ad22d82fb987c1f32446220d96760e71b9f5130 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 9 Nov 2023 13:15:55 -0500 Subject: [PATCH] [lldb-dap] Add an option to show function args in

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -2873,6 +2925,204 @@ uint32_t ScriptInterpreterPythonImpl::GetFlagsForCommandObject( return result; } +StructuredData::ObjectSP +ScriptInterpreterPythonImpl::GetOptionsForCommandObject( +StructuredData::GenericSP cmd_obj_sp) { + StructuredData::ObjectSP result =

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -1255,6 +1258,676 @@ class CommandObjectScriptingObject : public CommandObjectRaw { CompletionType m_completion_type = eNoCompletion; }; + +/// This command implements a lldb parsed scripted command. The command +/// provides a definition of the options and arguments,

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -447,6 +447,22 @@ bool CommandObject::IsPairType(ArgumentRepetitionType arg_repeat_type) { (arg_repeat_type == eArgRepeatPairRangeOptional); } +std::optional +CommandObject::ArgRepetitionFromString(llvm::StringRef string) { + if (string == "plain") return

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-13 Thread via lldb-commits
@@ -2755,6 +2755,58 @@ bool ScriptInterpreterPythonImpl::RunScriptBasedCommand( return ret_val; } +bool ScriptInterpreterPythonImpl::RunScriptBasedParsedCommand( +StructuredData::GenericSP impl_obj_sp, Args , +ScriptedCommandSynchronicity synchronicity, +

[Lldb-commits] [libcxxabi] [llvm] [lldb] [libc] [libcxx] [lld] [flang] [libunwind] [mlir] [compiler-rt] [clang-tools-extra] [clang] Have fir::unwrapSeqOrBoxedSeqType work with BaseBoxType (PR #72160)

2023-11-13 Thread Renaud Kauffmann via lldb-commits
https://github.com/Renaud-K closed https://github.com/llvm/llvm-project/pull/72160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [llvm] [lldb] [libc] [libcxx] [lld] [flang] [libunwind] [mlir] [compiler-rt] [clang-tools-extra] [clang] Have fir::unwrapSeqOrBoxedSeqType work with BaseBoxType (PR #72160)

2023-11-13 Thread Renaud Kauffmann via lldb-commits
https://github.com/Renaud-K created https://github.com/llvm/llvm-project/pull/72160 Fixing fir::unwrapSeqOrBoxedSeqType so it also works with the fir::ClassType >From af6200e4466066f92a67d69e6f49c8baa28bf62f Mon Sep 17 00:00:00 2001 From: Renaud-K Date: Wed, 8 Mar 2023 18:39:40 -0800

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Extract static data member decl creation into helper (PR #72109)

2023-11-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/72109 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 743c4fe - [lldb][DWARFASTParserClang][NFC] Extract static data member decl creation into helper (#72109)

2023-11-13 Thread via lldb-commits
Author: Michael Buch Date: 2023-11-13T19:30:28Z New Revision: 743c4fe43cad05dad422c1c64fd855fc506bb209 URL: https://github.com/llvm/llvm-project/commit/743c4fe43cad05dad422c1c64fd855fc506bb209 DIFF: https://github.com/llvm/llvm-project/commit/743c4fe43cad05dad422c1c64fd855fc506bb209.diff LOG:

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/71928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM (once bots are happy) https://github.com/llvm/llvm-project/pull/71928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [compiler-rt] [mlir] [llvm] Changes to support running tests for Windows arm64 asan (PR #66973)

2023-11-13 Thread Farzon Lotfi via lldb-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/66973 >From 85e5f76f0e9ccf4c3ed77eac0aaa3de944091c2c Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Wed, 20 Sep 2023 22:58:08 -0400 Subject: [PATCH 01/13] Changes to support running tests for Windows arm64 asan 1.

[Lldb-commits] [lldb] [lldb] DRAFT - Remove 2nd "error: " and print caret (^) below last input line from the developer. (PR #72150)

2023-11-13 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete created https://github.com/llvm/llvm-project/pull/72150 This patch serves 2 goals: - Remove a second "error: " substring in error messages from debugging Swift. - Print caret (^) line with optional leading/trailing tildes (~) below the line the developer last

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-13 Thread Greg Clayton via lldb-commits
clayborg wrote: Does anyone have access to a native windows arm64 build of LLDB that could help look at this? https://github.com/llvm/llvm-project/pull/71772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Extract static data member decl creation into helper (PR #72109)

2023-11-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/72109 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-13 Thread Greg Clayton via lldb-commits
clayborg wrote: > Hello @clayborg ! Looks like this patch broke lldb-aarch64-windows bot: > https://lab.llvm.org/buildbot/#/builders/219/builds/6868 Could you please > look at this ? @antmox I looked at this and I didn't touch anything related to native windows core file saving. If this is

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl edited https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl edited https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
@@ -253,9 +264,20 @@ void Symbol::GetDescription(Stream *s, lldb::DescriptionLevel level, m_addr_range.GetBaseAddress().GetOffset()); } ConstString demangled = GetMangled().GetDemangledName(); - if (demangled) + + // Checking if the name (i.e., searched

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
junior-jl wrote: >> - Please remove any commented out code, comments that are now obvious from reading the code, etc. - Rename name to pattern, it will be a 1000% less confusing for all of us :) - Make sure that ninja check-lldb has no failures. - clang-format your changes

[Lldb-commits] [lldb] [lldb] Remove StructuredData::Array::GetItemAtIndexAsArray (PR #71994)

2023-11-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/71994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ad20a9e - [lldb] Remove StructuredData::Array::GetItemAtIndexAsArray (#71994)

2023-11-13 Thread via lldb-commits
Author: Alex Langford Date: 2023-11-13T10:12:36-08:00 New Revision: ad20a9e1a15d1694f7ab3d878bcfaab3d52c5abf URL: https://github.com/llvm/llvm-project/commit/ad20a9e1a15d1694f7ab3d878bcfaab3d52c5abf DIFF: https://github.com/llvm/llvm-project/commit/ad20a9e1a15d1694f7ab3d878bcfaab3d52c5abf.diff

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
@@ -163,6 +176,14 @@ bool SymbolContext::DumpStopContext(Stream *s, ExecutionContextScope *exe_scope, dumped_something = true; if (symbol->GetType() == eSymbolTypeTrampoline) s->PutCString("symbol stub for: "); + + // Similar here, Using DumpName if

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
@@ -0,0 +1,25 @@ +# RUN: %clang_host -g %S/Inputs/main.c -o %t junior-jl wrote: Yes, I believe that was the case. Removed the other test. https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
@@ -89,13 +97,18 @@ bool SymbolContext::DumpStopContext(Stream *s, ExecutionContextScope *exe_scope, s->Printf("<"); dumped_something = true; } else { - ConstString name; + ConstString name_func; junior-jl wrote: Since the argument

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
@@ -252,11 +263,24 @@ void Symbol::GetDescription(Stream *s, lldb::DescriptionLevel level, s->Printf(", value = 0x%16.16" PRIx64, m_addr_range.GetBaseAddress().GetOffset()); } - ConstString demangled = GetMangled().GetDemangledName(); - if

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
@@ -252,11 +263,24 @@ void Symbol::GetDescription(Stream *s, lldb::DescriptionLevel level, s->Printf(", value = 0x%16.16" PRIx64, m_addr_range.GetBaseAddress().GetOffset()); } - ConstString demangled = GetMangled().GetDemangledName(); - if

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/69422 From 2c23aaf231beef11d3e0db6506fe82323a0be6a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Tue, 7 Nov 2023 16:57:18 -0300 Subject: [PATCH] [lldb] colorize symbols in image lookup

[Lldb-commits] [llvm] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > Oh, one more thing: Can you document the deprecation of this method into the > release notes? The file is `llvm-project/llvm/docs/ReleaseNotes.rst` and > there is an LLDB section. Thanks for the tip, did that. https://github.com/llvm/llvm-project/pull/72012

[Lldb-commits] [llvm] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/72012 >From 1d22db051b0115e622208802cede47de6bdf507c Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Fri, 10 Nov 2023 17:38:59 -0800 Subject: [PATCH 1/2] Remove hardware index from watchpoints and breakpoints

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/69422 From 620ce688faba76bee7deb1429e7499f473d7509c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Tue, 7 Nov 2023 16:57:18 -0300 Subject: [PATCH] [lldb] colorize symbols in image lookup

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > > The Linux MIPS support has been ripped out and the remaining support for > > MIPS probably gets no real testing > > Don't know the status but the BSD's still have some MIPS support. Yeah I've been trying to keep the MIPS watchpoint code in the sources as I've been

[Lldb-commits] [flang] [lld] [libcxx] [clang] [libc] [lldb] [llvm] [clang-tools-extra] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Alexey Bataev via lldb-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/70234 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [clang] [lld] [libcxx] [lldb] [llvm] [clang-tools-extra] [flang] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Erich Keane via lldb-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/70234 >From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 23 Oct 2023 11:09:11 -0700 Subject: [PATCH 1/8] [OpenACC] Initial commit for OpenACC Support This is the

[Lldb-commits] [lldb] [libc] [llvm] [clang-tools-extra] [lld] [clang] [flang] [libcxx] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Erich Keane via lldb-commits
@@ -3633,6 +3633,22 @@ static void RenderHLSLOptions(const ArgList , ArgStringList , CmdArgs.push_back("-finclude-default-header"); } +static void RenderOpenACCOptions(const Driver , const ArgList , + ArgStringList , types::ID InputType) {

[Lldb-commits] [libc] [clang] [lld] [libcxx] [lldb] [llvm] [clang-tools-extra] [flang] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Erich Keane via lldb-commits
@@ -4001,6 +4008,14 @@ bool CompilerInvocation::ParseLangArgs(LangOptions , ArgList , (T.isNVPTX() || T.isAMDGCN()) && Args.hasArg(options::OPT_fopenmp_cuda_mode); + // OpenACC Configuration. + if

[Lldb-commits] [flang] [lld] [libcxx] [clang] [libc] [lldb] [llvm] [clang-tools-extra] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Alexey Bataev via lldb-commits
@@ -3633,6 +3633,22 @@ static void RenderHLSLOptions(const ArgList , ArgStringList , CmdArgs.push_back("-finclude-default-header"); } +static void RenderOpenACCOptions(const Driver , const ArgList , + ArgStringList , types::ID InputType) {

[Lldb-commits] [flang] [llvm] [clang] [lld] [libcxx] [lldb] [clang-tools-extra] [libc] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Alexey Bataev via lldb-commits
@@ -4001,6 +4008,14 @@ bool CompilerInvocation::ParseLangArgs(LangOptions , ArgList , (T.isNVPTX() || T.isAMDGCN()) && Args.hasArg(options::OPT_fopenmp_cuda_mode); + // OpenACC Configuration. + if

[Lldb-commits] [flang] [llvm] [clang] [lld] [libcxx] [lldb] [clang-tools-extra] [libc] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Erich Keane via lldb-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/70234 >From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 23 Oct 2023 11:09:11 -0700 Subject: [PATCH 1/7] [OpenACC] Initial commit for OpenACC Support This is the

[Lldb-commits] [clang] [libc] [flang] [clang-tools-extra] [llvm] [libcxx] [lld] [lldb] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Erich Keane via lldb-commits
@@ -1349,6 +1349,19 @@ def fno_hip_emit_relocatable : Flag<["-"], "fno-hip-emit-relocatable">, HelpText<"Do not override toolchain to compile HIP source to relocatable">; } +// Clang specific/exclusive options for OpenACC. +def openacc_macro_override

[Lldb-commits] [clang] [libc] [flang] [clang-tools-extra] [llvm] [libcxx] [lld] [lldb] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Alexey Bataev via lldb-commits
@@ -1349,6 +1349,19 @@ def fno_hip_emit_relocatable : Flag<["-"], "fno-hip-emit-relocatable">, HelpText<"Do not override toolchain to compile HIP source to relocatable">; } +// Clang specific/exclusive options for OpenACC. +def openacc_macro_override

[Lldb-commits] [flang] [llvm] [clang] [lld] [libcxx] [lldb] [clang-tools-extra] [libc] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Alexey Bataev via lldb-commits
@@ -229,6 +230,9 @@ class Parser : public CodeCompletionHandler { /// Parsing OpenMP directive mode. bool OpenMPDirectiveParsing = false; + /// Parsing OpenACC directive mode. + bool OpenACCDirectiveParsing = false; alexey-bataev wrote: I think better

[Lldb-commits] [flang] [llvm] [clang] [lld] [libcxx] [lldb] [clang-tools-extra] [libc] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Erich Keane via lldb-commits
@@ -229,6 +230,9 @@ class Parser : public CodeCompletionHandler { /// Parsing OpenMP directive mode. bool OpenMPDirectiveParsing = false; + /// Parsing OpenACC directive mode. + bool OpenACCDirectiveParsing = false; erichkeane wrote: Ah, I see. As it

[Lldb-commits] [flang] [llvm] [clang] [lld] [libcxx] [lldb] [clang-tools-extra] [libc] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Alexey Bataev via lldb-commits
@@ -229,6 +230,9 @@ class Parser : public CodeCompletionHandler { /// Parsing OpenMP directive mode. bool OpenMPDirectiveParsing = false; + /// Parsing OpenACC directive mode. + bool OpenACCDirectiveParsing = false; alexey-bataev wrote: I mean, it has

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Extract static data member decl creation into helper (PR #72109)

2023-11-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/72109 >From 3513963ac45aff2296f687e6c7b315e0f25b8586 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 7 Nov 2023 10:57:08 + Subject: [PATCH 1/2] [lldb][DWARFASTParserClang][NFC] Extract static data

[Lldb-commits] [llvm] [lld] [clang] [lldb] [flang] [libcxx] [clang-tools-extra] [libc] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Erich Keane via lldb-commits
@@ -0,0 +1,14 @@ +// RUN: %clang -S -### -fopenacc %s 2>&1 | FileCheck %s --check-prefix=CHECK-DRIVER +// CHECK-DRIVER: "-cc1" {{.*}} "-fopenacc" + +// RUN: %clang -S -### -fopenacc -fexperimental-openacc-macro-override=202211 %s 2>&1 | FileCheck %s

[Lldb-commits] [llvm] [lld] [clang] [lldb] [flang] [libcxx] [clang-tools-extra] [libc] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-13 Thread Erich Keane via lldb-commits
@@ -229,6 +230,9 @@ class Parser : public CodeCompletionHandler { /// Parsing OpenMP directive mode. bool OpenMPDirectiveParsing = false; + /// Parsing OpenACC directive mode. + bool OpenACCDirectiveParsing = false; erichkeane wrote: Its currently

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/69422 From a857d725625ea0d094da1860316f5204f11c9ba1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Tue, 7 Nov 2023 16:57:18 -0300 Subject: [PATCH] [lldb] colorize symbols in image lookup

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/69422 From 7f228a5c2ef65ba595ca9b7c0d7227cd82f63b3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Tue, 7 Nov 2023 16:57:18 -0300 Subject: [PATCH] [lldb] colorize symbols in image lookup

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-13 Thread Haojian Wu via lldb-commits
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type): ], ) -# Run until after the `co_yield` process = self.process() + +# Break at a coroutine body +lldbutil.continue_to_source_breakpoint( + self, process,

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-13 Thread Haojian Wu via lldb-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/71928 >From 08c3b1a40b508d360f47bed6d7d42050c18b01a0 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 10 Nov 2023 12:35:10 +0100 Subject: [PATCH 1/4] [LLDB] Display artificial __promise and __coro_frame variables.

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-13 Thread antoine moynault via lldb-commits
antmox wrote: Hello @clayborg ! Looks like this patch broke lldb-aarch64-windows bot: https://lab.llvm.org/buildbot/#/builders/219/builds/6868 Could you please look at this ? https://github.com/llvm/llvm-project/pull/71772 ___ lldb-commits mailing

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-13 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: DavidSpickett wrote: > For all 3 API command test, the error is same i.e., > > AssertionError: 'error: Couldn't look up symbols: > std::deque>::size() const > ' is not success This feels like a version problem. Perhaps the libstdc++ on

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Extract static data member decl creation into helper (PR #72109)

2023-11-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch extracts the logic to create a static variable member decl into a helper. We will use this in an upcoming patch which will need to call exactly the same logic from a separate part of the DWARF

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Extract static data member decl creation into helper (PR #72109)

2023-11-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/72109 This patch extracts the logic to create a static variable member decl into a helper. We will use this in an upcoming patch which will need to call exactly the same logic from a separate part of the DWARF

[Lldb-commits] [lldb] 0515ccc - [lldb] Fix a typo in the comment, NFC

2023-11-13 Thread Haojian Wu via lldb-commits
Author: Haojian Wu Date: 2023-11-13T10:12:55+01:00 New Revision: 0515ccc0c48b919dae03edc391304e66cdb75d66 URL: https://github.com/llvm/llvm-project/commit/0515ccc0c48b919dae03edc391304e66cdb75d66 DIFF: https://github.com/llvm/llvm-project/commit/0515ccc0c48b919dae03edc391304e66cdb75d66.diff

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: > The Linux MIPS support has been ripped out and the remaining support for MIPS > probably gets no real testing Don't know the status but the BSD's still have some MIPS support. https://github.com/llvm/llvm-project/pull/72012

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-13 Thread Michael Buch via lldb-commits
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type): ], ) -# Run until after the `co_yield` process = self.process() + +# Break at a coroutine body +lldbutil.continue_to_source_breakpoint( + self, process,

[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-13 Thread Haojian Wu via lldb-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/71928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >