https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From fd42e87a663754ca7273715ea40f397df41e3da0 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Wed, 8 Nov 2023 16:25:34 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From fd42e87a663754ca7273715ea40f397df41e3da0 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Wed, 8 Nov 2023 16:25:34 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From 76f7fd2c62921f15c35b4dd57cc6bfa8a8be93b2 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Wed, 8 Nov 2023 16:25:34 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From 6550a970a88ef92fbadf63e7913ad7325d7aebc4 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Wed, 8 Nov 2023 16:25:34 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From b2160235dea7b18395dc3dba9e6a5b735278ac9e Mon Sep 17 00:00:00 2001
From: George Hu
Date: Wed, 8 Nov 2023 16:25:34 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/72012
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> > > The Linux MIPS support has been ripped out and the remaining support for
> > > MIPS probably gets no real testing
> >
> >
> > Don't know the status but the BSD's still have some MIPS support.
>
> Yeah I've been trying to keep the MIPS watchpoint code in the sources
https://github.com/bulbazord approved this pull request.
Awesome, thank you!
https://github.com/llvm/llvm-project/pull/72012
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From e6b2d9d1bbd4fe2fceeb9474fd0af636370b3079 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Wed, 8 Nov 2023 16:25:34 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
@@ -1255,6 +1258,676 @@ class CommandObjectScriptingObject : public
CommandObjectRaw {
CompletionType m_completion_type = eNoCompletion;
};
+
+/// This command implements a lldb parsed scripted command. The command
+/// provides a definition of the options and arguments,
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From 493be399a8d8e024769a9eba66d6a86192ff11e9 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Wed, 8 Nov 2023 16:25:34 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
@@ -2755,6 +2755,58 @@ bool ScriptInterpreterPythonImpl::RunScriptBasedCommand(
return ret_val;
}
+bool ScriptInterpreterPythonImpl::RunScriptBasedParsedCommand(
+StructuredData::GenericSP impl_obj_sp, Args ,
+ScriptedCommandSynchronicity synchronicity,
+
@@ -476,6 +476,14 @@ class ScriptInterpreter : public PluginInterface {
return false;
}
+ virtual bool RunScriptBasedParsedCommand(
+ StructuredData::GenericSP impl_obj_sp, Args& args,
+ ScriptedCommandSynchronicity synchronicity,
+
@@ -0,0 +1,315 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for you command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
@@ -0,0 +1,315 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for you command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
@@ -0,0 +1,315 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for you command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
@@ -0,0 +1,315 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for you command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
@@ -0,0 +1,315 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for you command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
clayborg wrote:
@antmox Hopefully this clears up the issue on the build bot! Thanks for testing
this for me.
https://github.com/llvm/llvm-project/pull/72315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/72315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Greg Clayton
Date: 2023-11-14T16:49:44-08:00
New Revision: beb702c0ad69244da6caedca9a0f3c6ee42e5bae
URL:
https://github.com/llvm/llvm-project/commit/beb702c0ad69244da6caedca9a0f3c6ee42e5bae
DIFF:
https://github.com/llvm/llvm-project/commit/beb702c0ad69244da6caedca9a0f3c6ee42e5bae.diff
https://github.com/antmox approved this pull request.
https://github.com/llvm/llvm-project/pull/72315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> LGTM. minidump tests are now OK on linaro-armv8-windows-msvc machine.
Feel free to accept this patch then and I can get it merged!
https://github.com/llvm/llvm-project/pull/72315
___
lldb-commits mailing list
antmox wrote:
LGTM. minidump tests are now OK on linaro-armv8-windows-msvc machine.
https://github.com/llvm/llvm-project/pull/72315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dwblaikie wrote:
> > I guess one question that might be relevant - does Swift have something
> > like sizeof and what result does it give for these sort of types with bits
> > to spare?
>
> You can't actually use that with these types as these are special compiler
> builtin types which
augusto2112 wrote:
> I guess one question that might be relevant - does Swift have something like
> sizeof and what result does it give for these sort of types with bits to
> spare?
You can't actually use that with these types as these are special compiler
builtin types which aren't actually
antmox wrote:
@clayborg yes sure I will test this on the same machine
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/72315
>From dd4dd79853566049874f49d1290217f5abde23fd Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 14 Nov 2023 13:53:25 -0800
Subject: [PATCH 1/2] Add support for arm64 registers in minidump core file
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 447af1ce99c066169c5ea85a23963e8d3d93124a
dd4dd79853566049874f49d1290217f5abde23fd --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
This patch adds support for saving minidumps with the arm64 architecture. It
also will cause unsupported architectures to emit an error where before this
patch it would emit a minidump with partial
clayborg wrote:
> [antmox](/antmox)
https://github.com/llvm/llvm-project/pull/72315
A new PR to fix this issue. Is there any way you can test this to see if this
works?
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/72315
This patch adds support for saving minidumps with the arm64 architecture. It
also will cause unsupported architectures to emit an error where before this
patch it would emit a minidump with partial
clayborg wrote:
> [core_dmps.tar.gz](https://github.com/llvm/llvm-project/files/13355872/core_dmps.tar.gz)
> here is an archive with the 2 core.dmp files
It does indeed seem like my new core file creation code is being triggered on
windows. I am working on a fix that adds ARM64 support to the
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/71771
>From 06c4cf02dfb4b20c8349c5f3c7209276f6d56edf Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 9 Nov 2023 02:21:46 +
Subject: [PATCH 1/3] Fix clang to recognize new C23 modifiers %w and %wf when
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/71771
>From 06c4cf02dfb4b20c8349c5f3c7209276f6d56edf Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 9 Nov 2023 02:21:46 +
Subject: [PATCH 1/3] Fix clang to recognize new C23 modifiers %w and %wf when
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/71771
>From 06c4cf02dfb4b20c8349c5f3c7209276f6d56edf Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 9 Nov 2023 02:21:46 +
Subject: [PATCH 1/2] Fix clang to recognize new C23 modifiers %w and %wf when
antmox wrote:
[core_dmps.tar.gz](https://github.com/llvm/llvm-project/files/13355872/core_dmps.tar.gz)
here is an archive with the 2 core.dmp files
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
https://github.com/changpeng closed
https://github.com/llvm/llvm-project/pull/71989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/changpeng reopened
https://github.com/llvm/llvm-project/pull/71989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/changpeng closed
https://github.com/llvm/llvm-project/pull/71989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rampitec approved this pull request.
https://github.com/llvm/llvm-project/pull/71989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id =
@@ -0,0 +1,56 @@
+// RUN: mlir-opt %s
-pass-pipeline='builtin.module(spirv-attach-target{ver=v1.0
clayborg wrote:
LGTM. I didn't mean to accept the patch when it was using `PRIo32`
https://github.com/llvm/llvm-project/pull/72292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -377,10 +379,17 @@
llvm::LaunchKernel::createKernelLaunch(mlir::gpu::LaunchFuncOp op,
if (!binary)
return op.emitError() << "Couldn't find the binary: " << binaryIdentifier;
+ auto binaryVar = dyn_cast(binary);
+ llvm::Constant *binaryInit =
@@ -4,6 +4,7 @@
module attributes {gpu.container_module} {
// CHECK: [[ARGS_TY:%.*]] = type { i32, i32 }
// CHECK: @kernel_module_bin_cst = internal constant [4 x i8] c"BLOB", align
8
+ // CHECK: @kernel_module_bin_size_cst = internal constant i64 4, align 8
https://github.com/silee2 updated
https://github.com/llvm/llvm-project/pull/71430
>From c76403cf8629b8f7d8a5b7a3ee5da2881713a7f8 Mon Sep 17 00:00:00 2001
From: "Lee, Sang Ik"
Date: Mon, 6 Nov 2023 18:47:23 +
Subject: [PATCH 1/5] [MLIR] Enable GPU Dialect to SYCL runtime integration
GPU
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id =
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id =
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/72292
>From ed4b044027e4ccc02bd19af394a076892baeea95 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 14 Nov 2023 10:02:41 -0800
Subject: [PATCH] [lldb-dap] Fixing a type encoding issue with dap Stopped
events.
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/72236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id =
clayborg wrote:
> @clayborg I will try to reproduce on the buildbot windows machine. build
> ongoing
If you end up being able to reproduce, if you can send the minidump file that
was produced I should be able to look at it to make sure it was not produced by
the core file saver. But if this
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id =
changpeng wrote:
> Typo in subject "**Guard** return ..."?
You are right. Thanks.
https://github.com/llvm/llvm-project/pull/71989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/changpeng edited
https://github.com/llvm/llvm-project/pull/71989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/72292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id =
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/72292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/72196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Walter Erquinigo
Date: 2023-11-14T13:23:55-05:00
New Revision: 1654d7dc38af3bd10ab55929161966601672c115
URL:
https://github.com/llvm/llvm-project/commit/1654d7dc38af3bd10ab55929161966601672c115
DIFF:
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/72196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id =
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
Previously the type of the breakpoint id in the Stopped event was a uint64_t,
however thats the wrong type for a breakpoint id, which can cause encoding
issues when internal breakpoints are hit.
---
Full
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/72292
Previously the type of the breakpoint id in the Stopped event was a uint64_t,
however thats the wrong type for a breakpoint id, which can cause encoding
issues when internal breakpoints are hit.
>From
junior-jl wrote:
In this last commit, your suggestions on the algorithm were done (the use of
`remaining` instead of `text` and `drop_front`. Also, the method is now on
`Stream` and called `PutCStringColorHighlighted` as you recommended. It looks
way better that way.
> Then later use that
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From 2c23aaf231beef11d3e0db6506fe82323a0be6a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/3] [lldb] colorize symbols in image
antmox wrote:
@clayborg
I will try to reproduce on the buildbot windows machine. build ongoing
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -163,7 +166,10 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
dumped_something = true;
if (symbol->GetType() == eSymbolTypeTrampoline)
s->PutCString("symbol stub for: ");
- symbol->GetName().Dump(s);
+ if
@@ -252,11 +253,16 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
s->Printf(", value = 0x%16.16" PRIx64,
m_addr_range.GetBaseAddress().GetOffset());
}
- ConstString demangled = GetMangled().GetDemangledName();
- if
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -95,7 +97,8 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
if (!name)
name = function->GetName();
if (name)
-name.Dump(s);
+pattern ? Address::DumpName(s, name.GetStringRef(), pattern)
+
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/72196
>From b6205d1befdaefc5ef17a9bc7b3eec960caecda6 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 13 Nov 2023 21:42:26 -0500
Subject: [PATCH] thread format
---
lldb/include/lldb/API/SBFormat.h
@@ -839,4 +839,19 @@ void DAP::SetFrameFormat(llvm::StringRef format) {
}
}
+void DAP::SetThreadFormat(llvm::StringRef format) {
+ if (format.empty())
+return;
+ lldb::SBError error;
+ g_dap.thread_format = lldb::SBFormat(format.data(), error);
dancing-leaves wrote:
@DavidSpickett sure, thanks for the tip on where to add it. Will update the PR
with tests.
https://github.com/llvm/llvm-project/pull/72233
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/taalhaataahir0102 updated
https://github.com/llvm/llvm-project/pull/69422
>From 2c23aaf231beef11d3e0db6506fe82323a0be6a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/2] [lldb] colorize symbols in
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/72236
>From de2be505917256a03718a10928547730d03bc8bc Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 13 Nov 2023 08:13:08 +
Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] DWARFv5: support
Author: Michael Buch
Date: 2023-11-14T10:31:07Z
New Revision: 27c5a9bbb01a464bb85624db2d0808f30de7c996
URL:
https://github.com/llvm/llvm-project/commit/27c5a9bbb01a464bb85624db2d0808f30de7c996
DIFF:
https://github.com/llvm/llvm-project/commit/27c5a9bbb01a464bb85624db2d0808f30de7c996.diff
LOG:
DavidSpickett wrote:
If you are comfortable adding and running tests,
`lldb/test/API/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py`
is the place for it, after the `max-children-count` ones.
https://github.com/llvm/llvm-project/pull/72233
DavidSpickett wrote:
Turns out you can't set a negative value from within lldb at least:
```
(lldb) settings set target.max-string-summary-length -1
error: unknown or ambiguous option
```
https://github.com/llvm/llvm-project/pull/72233
___
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/72236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
The accepted DWARFv5 issue 161118.1: "DW_TAG for C++ static data members"
specifies that static data member declaration be described by DW_TAG_variable.
Make sure we recognize such members.
---
Full
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/72236
The accepted DWARFv5 issue 161118.1: "DW_TAG for C++ static data members"
specifies that static data member declaration be described by DW_TAG_variable.
Make sure we recognize such members.
>From
DavidSpickett wrote:
Thanks for the fix!
You'll be shocked (not shocked :) ) to know that there are zero tests for this
setting currently. I'll have a look for an obvious place to put that, isn't
difficult to test as you've shown.
I can't think of any reason to have negative summary lengths,
DavidSpickett wrote:
> Hello again, David. We've done these. When I fetched the most recent changes
> in LLVM project today, the ninja check-lldb was okay again. Just FYI, I did
> not update any dependency.
Nice, there was a change around there recently but I didn't feel like making
you
@@ -0,0 +1,25 @@
+# RUN: %clang_host -g %S/Inputs/main.c -o %t
+
+# Checking simple search
+
+# RUN: %lldb %t -b -o 'settings set use-color true' -o 'image lookup -r -s ma'
| FileCheck %s --check-prefix CHECK1
+# CHECK1: Name: {{.+}}31mma{{.+}}0min.c
+# CHECK1:
@@ -403,9 +404,41 @@ bool Address::GetDescription(Stream , Target ,
return false;
}
+void Address::DumpName(Stream *strm, llvm::StringRef text,
+ const char *pattern) {
+ if (!pattern) {
+strm->PutCString(text.data());
+return;
+ }
+
+
@@ -403,9 +404,41 @@ bool Address::GetDescription(Stream , Target ,
return false;
}
+void Address::DumpName(Stream *strm, llvm::StringRef text,
+ const char *pattern) {
+ if (!pattern) {
+strm->PutCString(text.data());
+return;
+ }
+
+
@@ -403,9 +404,41 @@ bool Address::GetDescription(Stream , Target ,
return false;
}
+void Address::DumpName(Stream *strm, llvm::StringRef text,
+ const char *pattern) {
+ if (!pattern) {
+strm->PutCString(text.data());
+return;
+ }
+
+
@@ -95,7 +97,8 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
if (!name)
name = function->GetName();
if (name)
-name.Dump(s);
+pattern ? Address::DumpName(s, name.GetStringRef(), pattern)
+
@@ -95,7 +97,8 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
if (!name)
name = function->GetName();
if (name)
-name.Dump(s);
+pattern ? Address::DumpName(s, name.GetStringRef(), pattern)
+
@@ -403,9 +404,41 @@ bool Address::GetDescription(Stream , Target ,
return false;
}
+void Address::DumpName(Stream *strm, llvm::StringRef text,
+ const char *pattern) {
+ if (!pattern) {
+strm->PutCString(text.data());
+return;
+ }
+
+
@@ -403,9 +404,41 @@ bool Address::GetDescription(Stream , Target ,
return false;
}
+void Address::DumpName(Stream *strm, llvm::StringRef text,
+ const char *pattern) {
+ if (!pattern) {
+strm->PutCString(text.data());
+return;
+ }
+
+
@@ -0,0 +1,25 @@
+# RUN: %clang_host -g %S/Inputs/main.c -o %t
+
+# Checking simple search
DavidSpickett wrote:
This one is also regex, so "simple regex search"?
https://github.com/llvm/llvm-project/pull/69422
___
@@ -0,0 +1,25 @@
+# RUN: %clang_host -g %S/Inputs/main.c -o %t
+
+# Checking simple search
+
+# RUN: %lldb %t -b -o 'settings set use-color true' -o 'image lookup -r -s ma'
| FileCheck %s --check-prefix CHECK1
+# CHECK1: Name: {{.+}}31mma{{.+}}0min.c
+# CHECK1:
@@ -163,7 +166,10 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
dumped_something = true;
if (symbol->GetType() == eSymbolTypeTrampoline)
s->PutCString("symbol stub for: ");
- symbol->GetName().Dump(s);
+ if
@@ -0,0 +1,25 @@
+# RUN: %clang_host -g %S/Inputs/main.c -o %t
+
+# Checking simple search
+
+# RUN: %lldb %t -b -o 'settings set use-color true' -o 'image lookup -r -s ma'
| FileCheck %s --check-prefix CHECK1
+# CHECK1: Name: {{.+}}31mma{{.+}}0min.c
+# CHECK1:
@@ -252,11 +253,16 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
s->Printf(", value = 0x%16.16" PRIx64,
m_addr_range.GetBaseAddress().GetOffset());
}
- ConstString demangled = GetMangled().GetDemangledName();
- if
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (dancing-leaves)
Changes
Hi, there seems to be a regression since
https://github.com/llvm/llvm-project/commit/6f8b33f6dfd0a0f8d2522b6c832bd6298ae2f3f3.
`Max String Summary Length` target property is not read properly and the
default
1 - 100 of 103 matches
Mail list logo
