ecnelises wrote:
> Is there any existing vector test coverage?
Yes, there are vector tests in PowerPC's fminimum-fmaximum.ll.
https://github.com/llvm/llvm-project/pull/67301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
@@ -8262,6 +8262,64 @@ SDValue TargetLowering::expandFMINNUM_FMAXNUM(SDNode
*Node,
return SDValue();
}
+SDValue TargetLowering::expandFMINIMUM_FMAXIMUM(SDNode *N,
+SelectionDAG &DAG) const {
+ SDLoc DL(N);
+ SDValue LHS = N-
@@ -8262,6 +8262,64 @@ SDValue TargetLowering::expandFMINNUM_FMAXNUM(SDNode
*Node,
return SDValue();
}
+SDValue TargetLowering::expandFMINIMUM_FMAXIMUM(SDNode *N,
+SelectionDAG &DAG) const {
+ SDLoc DL(N);
+ SDValue LHS = N-
https://github.com/ecnelises updated
https://github.com/llvm/llvm-project/pull/67301
>From 92abb76631594dfc2ca586c46c38031610be0548 Mon Sep 17 00:00:00 2001
From: Qiu Chaofan
Date: Mon, 25 Sep 2023 17:08:59 +0800
Subject: [PATCH 1/5] [Legalizer] Expand fmaximum and fminimum
According to langre
https://github.com/H-G-Hristov updated
https://github.com/llvm/llvm-project/pull/74994
>From 6e26ca239c49e1b7d9ab72217db7339e92df163f Mon Sep 17 00:00:00 2001
From: Zingam
Date: Sun, 10 Dec 2023 14:16:02 +0200
Subject: [PATCH 01/17] [libc++][span] P2821R5: span.at()
---
libcxx/include/span
https://github.com/PortalPete closed
https://github.com/llvm/llvm-project/pull/74912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/PortalPete closed
https://github.com/llvm/llvm-project/pull/72150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
minglotus-6 wrote:
And pushed https://github.com/llvm/llvm-project/pull/76005 to require 64-bit
systems for IR test. Raw profile reader swaps byte orders properly so
`REQUIRES: host-byteorder-little-endian` looks actually unnecessary but will
keep it fwiw for now.
I feel sorry for dance aroun
minglotus-6 wrote:
> I'm seeing spurious failures from big-endian systems. I'll revert and
> investigate a fix.
I ended up sending a fix forward in
https://github.com/llvm/llvm-project/pull/76001 . Will monitor the build-bots.
https://github.com/llvm/llvm-project/pull/75954
__
minglotus-6 wrote:
I'm seeing spurious failures from big-endian systems. I'll revert and
investigate a fix.
https://github.com/llvm/llvm-project/pull/75954
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/silver-popov updated
https://github.com/llvm/llvm-project/pull/75909
>From 00edd52687d6e15f3453912b5dbf236714a386f9 Mon Sep 17 00:00:00 2001
From: Igor Popov
Date: Tue, 19 Dec 2023 11:43:45 +0300
Subject: [PATCH] Remove wrong float-128 extension for CLang
---
libc/src/__sup
rampitec wrote:
This is the place I am creating it: https://reviews.llvm.org/D108315
https://github.com/llvm/llvm-project/pull/75974
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
@JDevlieghere and I had an offline conversation about whether we couldn't
separate out a SupportFileList from FileSpecList to limit the amount of places
that need to think about lazy files and also to potentially move the
FileSpec::m_checksum into. Here is a very rough pat
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/75880
>From e089e1d67c01a42da16b7544abf8c4935cde4aed Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 18 Dec 2023 15:59:00 -0800
Subject: [PATCH 1/2] Add support for inline DWARF source files.
LLVM suppor
rampitec wrote:
One thing to note: this alias.scope I am creating myself in the module LDS
lowering, so I do exactly know what to expect. And then since there is this
module LDS lowering even if any alias scope would be created before (which
never happens, much less for an intrinsic call) it i
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/72150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jroelofs wrote:
I am surprised I haven't seen any complaints from buildbots about Andoid...
anyway, thanks.
394e481a38c774f12c765fde7e9302d039a7cd94
https://github.com/llvm/llvm-project/pull/75635
___
lldb-commits mailing list
lldb-commits@lists.llvm
minglotus-6 wrote:
> It fails here https://lab.llvm.org/buildbot/#/builders/18/builds/13216
thanks for the report. I marked the two relevant tests as `UNSUPPORTED` in
[commit
85525f8](https://github.com/llvm/llvm-project/commit/85525f8fb6740a4cc117b00a238c85bda4ea01bf).
Will need to investiga
vitalybuka wrote:
It fails here
https://lab.llvm.org/buildbot/#/builders/18/builds/13216
https://github.com/llvm/llvm-project/pull/75954
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
aeubanks wrote:
still seeing Android errors
```
[275/404] Building C object
CMakeFiles/clang_rt.builtins-aarch64.dir/cpu_model/aarch64.c.o
FAILED: CMakeFiles/clang_rt.builtins-aarch64.dir/cpu_model/aarch64.c.o
/b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/./bin/clang
--
PortalPete wrote:
> > ### Goal
> > Every `ValueObjectSP` will have an actual value and will never be equal to
> > `nullptr`.
>
> I would like to learn more about the goal. It seems like the existing code
> will result in widespread use of `optional>`. Is the
> plan to reduce these cases to a
clayborg wrote:
> > ### Goal
> > Every `ValueObjectSP` will have an actual value and will never be equal to
> > `nullptr`.
>
> I would like to learn more about the goal. It seems like the existing code
> will result in widespread use of `optional>`. Is the
> plan to reduce these cases to a sm
kastiglione wrote:
> ### Goal
>
> Every `ValueObjectSP` will have an actual value and will never be equal to
> `nullptr`.
I would like to learn more about the goal. It seems like the existing code will
result in widespread use of `optional>`. Is the plan to
reduce these cases to a smaller amo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pete Lawrence (PortalPete)
Changes
### Purpose
For now, we'd like to get people's thought's on the goal, design, and scope of
this PR by reviewing these preliminary changes.
I recommend focussing (or starting) on these files:
* `ValueObjec
https://github.com/PortalPete ready_for_review
https://github.com/llvm/llvm-project/pull/74912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/74912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/74912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pete Lawrence
Date: 2023-12-19T15:00:56-08:00
New Revision: 8ddf98ad4bb14867987b48a37dd29750c665112f
URL:
https://github.com/llvm/llvm-project/commit/8ddf98ad4bb14867987b48a37dd29750c665112f
DIFF:
https://github.com/llvm/llvm-project/commit/8ddf98ad4bb14867987b48a37dd29750c665112f.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/75870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/75880
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,7 +65,10 @@ class FileSpecList {
FileSpecList(FileSpecList &&rhs) = default;
/// Initialize this object from a vector of FileSpecs
- FileSpecList(std::vector &&rhs) : m_files(std::move(rhs)) {}
+ FileSpecList(std::vector &&rhs) {
+for (auto &fs : rhs)
+ m
https://github.com/rampitec updated
https://github.com/llvm/llvm-project/pull/75974
>From 7e382620cdc5999c645ed0746f242595f0294c58 Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin
Date: Mon, 4 Dec 2023 16:11:53 -0800
Subject: [PATCH 01/12] [AMDGPU] Use alias info to relax waitcounts for LDS
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b3d024c6737adb87e83193de88af04ec74ddf3ea
154ab4f551b5f0bf83e016ebb6fa8516be67fc31 --
rampitec wrote:
Actually since I am only using alias scope I can avoid all alias analysis
altogether and only compare alias scope. This does not need an analysis pass,
calls to mayAlias, and in general simpler code. You can see an alternative PR
if you like it more: https://github.com/llvm/llv
https://github.com/rampitec created
https://github.com/llvm/llvm-project/pull/75974
LDA DMA loads increase VMCNT and a load from the LDS stored must
wait on this counter to only read memory after it is written.
Wait count insertion pass does not track memory dependencies, it
tracks register depe
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c8418c4a19dac494069559918b3e4ea505ddf148
63b1cca8660e40d612e43496d3ff07c48bafa628 --
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/75926
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jamesETsmith updated
https://github.com/llvm/llvm-project/pull/68494
>From c4a3ccfbad090ad8314aa8ad53092edc8d5432bc Mon Sep 17 00:00:00 2001
From: James Smith
Date: Thu, 28 Sep 2023 10:11:15 -0400
Subject: [PATCH 01/19] [libc++] Implement ranges::iota and
ranges::out_value_r
jroelofs wrote:
More follow-ups in 85d5ed81b1df, and 52e7b6f5c520
https://github.com/llvm/llvm-project/pull/75635
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jroelofs wrote:
@petrhosek oh, I see what the problem is. I'll add another follow-up shortly.
Sorry for the noise.
https://github.com/llvm/llvm-project/pull/75635
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
petrhosek wrote:
We're still seeing the following error on our builders:
```
/b/s/w/ir/x/w/llvm_build/./bin/clang --target=aarch64-unknown-linux-gnu
--sysroot=/b/s/w/ir/x/w/cipd/linux -DHAS_ASM_LSE -DVISIBILITY_HIDDEN
--target=aarch64-unknown-linux-gnu -O2 -g -DNDEBUG -fno-lto -std=c11 -fPIC
https://github.com/minglotus-6 closed
https://github.com/llvm/llvm-project/pull/75954
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
fhahn wrote:
Looks like this is causing #75938. Please take a look
https://github.com/llvm/llvm-project/pull/71072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rampitec wrote:
> > This is still correct, pointer argument cannot alias module global. A
> > pointer argument to a kernel is an LDS external requested by the host side,
> > and host cannot see module LDS.
>
> I.e. that is really the point of the patch: if we are able to definitively
> identi
https://github.com/rampitec updated
https://github.com/llvm/llvm-project/pull/74537
>From 7e382620cdc5999c645ed0746f242595f0294c58 Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin
Date: Mon, 4 Dec 2023 16:11:53 -0800
Subject: [PATCH 01/10] [AMDGPU] Use alias info to relax waitcounts for LDS
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/75865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1700,13 +1706,13 @@ ValueObjectSP ValueObject::GetSyntheticChildAtOffset(
return synthetic_child_sp;
if (!can_create)
-return {};
+return ValueObjectSP();
PortalPete wrote:
This one is more about consistency because the vast majority of the
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/75865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1777,30 +1783,31 @@ static const char
*SkipLeadingExpressionPathSeparators(const char *expression) {
ValueObjectSP
ValueObject::GetSyntheticExpressionPathChild(const char *expression,
bool can_create) {
- ValueObjectSP syntheti
@@ -1992,71 +1999,67 @@ void ValueObject::GetExpressionPath(Stream &s,
}
ValueObjectSP ValueObject::GetValueForExpressionPath(
-llvm::StringRef expression, ExpressionPathScanEndReason *reason_to_stop,
-ExpressionPathEndResultType *final_value_type,
+llvm::StringRef
@@ -1992,71 +1999,67 @@ void ValueObject::GetExpressionPath(Stream &s,
}
ValueObjectSP ValueObject::GetValueForExpressionPath(
-llvm::StringRef expression, ExpressionPathScanEndReason *reason_to_stop,
-ExpressionPathEndResultType *final_value_type,
+llvm::StringRef
https://github.com/PortalPete updated
https://github.com/llvm/llvm-project/pull/75865
>From b26dbee59abf1168a395b7852f05fb12771dc6e4 Mon Sep 17 00:00:00 2001
From: Pete Lawrence
Date: Thu, 7 Dec 2023 12:14:01 -1000
Subject: [PATCH] [lldb] Improve maintainability and readability for
ValueObject
jroelofs wrote:
* c88e74c26d5c - (31 minutes ago) fixup! fixup! [builtins] Refactor cpu_model
support to reduce #if nesting. NFCI - Jon Roelofs
* a5a17e8fadd4 - (39 minutes ago) fixup! [builtins] Refactor cpu_model support
to reduce #if nesting. NFCI - Jon Roelofs
* 256b214b6b0f - (66 minutes a
jroelofs wrote:
There were a few follow-ups to address that. Sorry.
https://github.com/llvm/llvm-project/pull/75635
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vitalybuka wrote:
Breaks https://lab.llvm.org/buildbot/#/builders/269/builds/2975
https://github.com/llvm/llvm-project/pull/75635
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,7 +65,10 @@ class FileSpecList {
FileSpecList(FileSpecList &&rhs) = default;
/// Initialize this object from a vector of FileSpecs
- FileSpecList(std::vector &&rhs) : m_files(std::move(rhs)) {}
+ FileSpecList(std::vector &&rhs) {
+for (auto &fs : rhs)
+ m
rampitec wrote:
> This is still correct, pointer argument cannot alias module global. A pointer
> argument to a kernel is an LDS external requested by the host side, and host
> cannot see module LDS.
I.e. that is really the point of the patch: if we are able to definitively
identify an LDS ob
rampitec wrote:
> Test case:
>
> ```
> @lds.0 = internal addrspace(3) global [64 x float] poison, align 16
> @lds.1 = internal addrspace(3) global [64 x float] poison, align 16
>
> declare void @llvm.amdgcn.raw.buffer.load.lds(<4 x i32> %rsrc, ptr
> addrspace(3) nocapture, i32 %size, i32 %voff
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/75926
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1777,30 +1783,31 @@ static const char
*SkipLeadingExpressionPathSeparators(const char *expression) {
ValueObjectSP
ValueObject::GetSyntheticExpressionPathChild(const char *expression,
bool can_create) {
- ValueObjectSP syntheti
@@ -175,7 +175,7 @@ TypeSP DWARFASTParserClang::ParseTypeFromClangModule(const
SymbolContext &sc,
*sc.comp_unit, results.GetSearchedSymbolFiles(), [&](Module &module) {
module.FindTypes(query, results);
pcm_type_sp = results.GetTypeMap().FirstType()
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/75927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/75927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
minglotus-6 wrote:
I'll go ahead and push it since the diff is test only.
https://github.com/llvm/llvm-project/pull/75954
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1700,13 +1706,13 @@ ValueObjectSP ValueObject::GetSyntheticChildAtOffset(
return synthetic_child_sp;
if (!can_create)
-return {};
+return ValueObjectSP();
JDevlieghere wrote:
I'm possibly biased as the author of the [modernize-return-braced-
@@ -1777,30 +1783,31 @@ static const char
*SkipLeadingExpressionPathSeparators(const char *expression) {
ValueObjectSP
ValueObject::GetSyntheticExpressionPathChild(const char *expression,
bool can_create) {
- ValueObjectSP syntheti
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/75636
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jroelofs edited
https://github.com/llvm/llvm-project/pull/75636
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/75635
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/75880
>From 437b7803c8011745c7e57faf74f15210cbbf1f09 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 18 Dec 2023 15:59:00 -0800
Subject: [PATCH] Add support for inline DWARF source files.
LLVM supports D
@@ -38,7 +65,10 @@ class FileSpecList {
FileSpecList(FileSpecList &&rhs) = default;
/// Initialize this object from a vector of FileSpecs
- FileSpecList(std::vector &&rhs) : m_files(std::move(rhs)) {}
+ FileSpecList(std::vector &&rhs) {
+for (auto &fs : rhs)
+ m
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/75635
>From 336d1629f38a8681038f026c599a256761b522dc Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Fri, 15 Dec 2023 11:13:30 -0700
Subject: [PATCH 1/6] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF
minglotus-6 wrote:
> After this patch, follow up with a patch documenting raw and index format.
> This has long being requested by many in the community.
Sure, I'm working on an `rst` doc and would like to focus on the PGO profile
format (while compiler-rt infrastructure supports other use cas
minglotus-6 wrote:
The diff of this reland compared with the 1st reland is clearer in this commit
(https://github.com/llvm/llvm-project/pull/75954/commits/cca510e569e9325ec089974e006eb2a8e2d0a2a7)
https://github.com/llvm/llvm-project/pull/75954
___
ll
https://github.com/minglotus-6 updated
https://github.com/llvm/llvm-project/pull/75954
>From 4936920fbbe5e70a47be35b057200de3b07a087f Mon Sep 17 00:00:00 2001
From: mingmingl
Date: Mon, 18 Dec 2023 20:21:40 -0800
Subject: [PATCH 1/2] Reapply "Reland "[PGO][GlobalValue][LTO]In
GlobalValues::get
https://github.com/david-xl approved this pull request.
After this patch, follow up with a patch documenting raw and index format.
This has long being requested by many in the community.
https://github.com/llvm/llvm-project/pull/66825
___
lldb-commit
https://github.com/tmatheson-arm updated
https://github.com/llvm/llvm-project/pull/75947
>From d3201659d87260acaf1d20a96705e290caf21693 Mon Sep 17 00:00:00 2001
From: Tomas Matheson
Date: Thu, 2 Feb 2023 13:19:05 +
Subject: [PATCH 1/3] [AArch64] add missing test case for v9.4-A
---
clang/
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/75840
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2023-12-19T08:49:12-08:00
New Revision: 45657e81a111021dab5f1daa9482afae5d95569c
URL:
https://github.com/llvm/llvm-project/commit/45657e81a111021dab5f1daa9482afae5d95569c
DIFF:
https://github.com/llvm/llvm-project/commit/45657e81a111021dab5f1daa9482afae5d95569c.diff
@@ -235,6 +236,51 @@ ParseSupportFilesFromPrologue(const lldb::ModuleSP &module,
for (size_t idx = first_file_idx; idx <= last_file_idx; ++idx) {
std::string remapped_file;
if (auto file_path = GetFileByIndex(prologue, idx, compile_dir, style)) {
+ auto entry = p
@@ -38,7 +65,10 @@ class FileSpecList {
FileSpecList(FileSpecList &&rhs) = default;
/// Initialize this object from a vector of FileSpecs
- FileSpecList(std::vector &&rhs) : m_files(std::move(rhs)) {}
+ FileSpecList(std::vector &&rhs) {
+for (auto &fs : rhs)
+ m
@@ -17,13 +17,40 @@
namespace lldb_private {
class Stream;
+/// Represents a source file whose contents is known (for example
+/// because it can be reconstructed from debug info), but that
+/// hasn't been written to a local disk yet.
+struct LazyFileSpec {
+ virtual ~LazyFi
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/75926
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/75635
>From 336d1629f38a8681038f026c599a256761b522dc Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Fri, 15 Dec 2023 11:13:30 -0700
Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF
https://github.com/jamesETsmith updated
https://github.com/llvm/llvm-project/pull/68494
>From c4a3ccfbad090ad8314aa8ad53092edc8d5432bc Mon Sep 17 00:00:00 2001
From: James Smith
Date: Thu, 28 Sep 2023 10:11:15 -0400
Subject: [PATCH 01/18] [libc++] Implement ranges::iota and
ranges::out_value_r
Author: David Spickett
Date: 2023-12-19T14:25:23Z
New Revision: 970152bec1ca2e9a924fb8dc92d098bd110b4dae
URL:
https://github.com/llvm/llvm-project/commit/970152bec1ca2e9a924fb8dc92d098bd110b4dae
DIFF:
https://github.com/llvm/llvm-project/commit/970152bec1ca2e9a924fb8dc92d098bd110b4dae.diff
LOG
DavidSpickett wrote:
The PDB was not the issue, it's always worked that way and the DWARF is still
in the main executable.
I've opened https://github.com/llvm/llvm-project/issues/75936 for
`TestUniqueTypes4.py` because I think this commit did not break the test that
already existed, but in ch
Michael137 wrote:
> I would have thought
> `lldb/test/API/lang/cpp/gmodules/templates/TestGModules.py` would have failed
> then as it has >1 module.
>
> Do you know what "external module" means in this context, as opposed to just
> module? The code searches "the clang Module" first, then the
DavidSpickett wrote:
I would have thought
`lldb/test/API/lang/cpp/gmodules/templates/TestGModules.py` would have failed
then as it has >1 module.
Do you know what "external module" means in this context, as opposed to just
module? The code searches "the clang Module" first, then the external
Michael137 wrote:
> Would the whole test suite have to be built with modules enabled?
Hmmm we used to have a debug-info category for `gmodules` which ran each test
with `-gmodules`. But in the vast majority of cases that wasn't actually adding
any useful coverage. There's a handful of `gmodule
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/75927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rorth wrote:
It took me a bit to notice this snippet in `sanitizer_solaris.cpp`:
```
DECLARE__REAL_AND_INTERNAL(int, fork, void) {
// TODO(glider): this may call user's pthread_atfork() handlers which is bad.
return _REAL(fork)();
}
```
which didn't show up in searches for `internal_fork`.
>
DavidSpickett wrote:
`lldb/include/lldb/Symbol/CompileUnit.h`
```
/// \param[in] lambda
/// The lambda that should be applied to every function. The lambda can
/// return true if the iteration should be aborted earlier.
///
/// \return
/// If the lambda early-exited, this
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
The way this code was updated in dd9587795811ba21e6ca6ad52b4531e17e6babd6 meant
that if the first module did not have the symbol, the iteration stopped as
returning true means stop. So only if every m
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/75927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/75927
The way this code was updated in dd9587795811ba21e6ca6ad52b4531e17e6babd6 meant
that if the first module did not have the symbol, the iteration stopped as
returning true means stop. So only if every module
labath wrote:
Fixed by https://github.com/llvm/llvm-project/pull/75908.
https://github.com/llvm/llvm-project/pull/75793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Trying to add tests for this in `SymbolFileDWARFTests`
https://github.com/llvm/llvm-project/pull/75926
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This is required for users of `TypeQuery` that limit the set of languages of
the query using APIs such as `GetSupportedLanguagesForTypes` or
`GetSupportedLanguagesForExpressions`.
Example usage: https://g
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/75926
This is required for users of `TypeQuery` that limit the set of languages of
the query using APIs such as `GetSupportedLanguagesForTypes` or
`GetSupportedLanguagesForExpressions`.
Example usage: https://gith
1 - 100 of 112 matches
Mail list logo
