[Lldb-commits] [lldb] Return high address masks correctly in Process (PR #78379)

2024-01-16 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/78379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 54d8193 - Return high address masks correctly in Process (#78379)

2024-01-16 Thread via lldb-commits
Author: Jason Molenda Date: 2024-01-16T23:59:05-08:00 New Revision: 54d81936393758fff8982aa4f4f997f4d9062828 URL: https://github.com/llvm/llvm-project/commit/54d81936393758fff8982aa4f4f997f4d9062828 DIFF: https://github.com/llvm/llvm-project/commit/54d81936393758fff8982aa4f4f997f4d9062828.diff

[Lldb-commits] [llvm] [libcxx] [compiler-rt] [clang-tools-extra] [flang] [lld] [mlir] [libc] [clang] [lldb] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-16 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/77886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [libcxx] [compiler-rt] [clang-tools-extra] [flang] [lld] [mlir] [libc] [clang] [lldb] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-16 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/77886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upstream xros support in lldb (PR #78389)

2024-01-16 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. lgtm. https://github.com/llvm/llvm-project/pull/78389 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upstream xros support in lldb (PR #78389)

2024-01-16 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/78389 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upstream xros support in lldb (PR #78389)

2024-01-16 Thread Jason Molenda via lldb-commits
@@ -1180,7 +1180,7 @@ bool GDBRemoteCommunicationClient::GetDefaultThreadId(lldb::tid_t &tid) { static void ParseOSType(llvm::StringRef value, std::string &os_name, std::string &environment) { if (value.equals("iossimulator") || value.equals("tvossimu

[Lldb-commits] [lldb] [lldb] Upstream xros support in lldb (PR #78389)

2024-01-16 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM 🚀 https://github.com/llvm/llvm-project/pull/78389 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [lld] [libc] [libcxx] [llvm] [clang-tools-extra] [lldb] [flang] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-16 Thread Matt Arsenault via lldb-commits
https://github.com/arsenm approved this pull request. lgtm, but can still fix the -O0 thing https://github.com/llvm/llvm-project/pull/74537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [clang] [lldb] [clang-tools-extra] [llvm] [flang] [lld] [compiler-rt] [libcxx] [libc] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-16 Thread Matt Arsenault via lldb-commits
@@ -130,6 +130,8 @@ ; GCN-O0-NEXT:MachineDominator Tree Construction ; GCN-O0-NEXT:Machine Natural Loop Construction ; GCN-O0-NEXT:MachinePostDominator Tree Construction +; GCN-O0-NEXT:Basic Alias Analysis (stateless AA impl) +; GCN-O0-NEXT:

[Lldb-commits] [lldb] [llvm] [libcxx] [clang-tools-extra] [compiler-rt] [clang] [lld] [libc] [flang] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-16 Thread Matt Arsenault via lldb-commits
@@ -707,7 +723,40 @@ void WaitcntBrackets::updateByEvent(const SIInstrInfo *TII, (TII->isDS(Inst) || TII->mayWriteLDSThroughDMA(Inst))) { // MUBUF and FLAT LDS DMA operations need a wait on vmcnt before LDS // written can be accessed. A load from LDS to VMEM

[Lldb-commits] [libc] [clang] [compiler-rt] [clang-tools-extra] [lld] [lldb] [flang] [llvm] [libcxx] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-16 Thread Matt Arsenault via lldb-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/74537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [clang] [compiler-rt] [clang-tools-extra] [libcxxabi] [libunwind] [lldb] [mlir] [flang] [llvm] [libcxx] [ASan][AMDGPU] Fix Assertion Failure. (PR #78242)

2024-01-16 Thread Matt Arsenault via lldb-commits
@@ -0,0 +1,48 @@ +;RUN: opt < %s -passes=asan -S | FileCheck %s + +target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-p7:160:256:256:32-p8:128:128-p9:192:256:256:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-

[Lldb-commits] [libc] [clang] [compiler-rt] [clang-tools-extra] [libcxxabi] [libunwind] [lldb] [mlir] [flang] [llvm] [libcxx] [ASan][AMDGPU] Fix Assertion Failure. (PR #78242)

2024-01-16 Thread via lldb-commits
https://github.com/ampandey-1995 updated https://github.com/llvm/llvm-project/pull/78242 >From fe6d4abebb12e063e10b2266f76ff1a604783c0c Mon Sep 17 00:00:00 2001 From: Amit Pandey Date: Mon, 11 Dec 2023 14:23:44 +0530 Subject: [PATCH] [ASan][AMDGPU] Fix Assertion Failure. Assertion failure `(i

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/77999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 933c25e - [lldb] Store SupportFile in LineEntry (NFC) (#77999)

2024-01-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-01-16T21:09:23-08:00 New Revision: 933c25e558e6d0d8766d024a329d003a8d4c1162 URL: https://github.com/llvm/llvm-project/commit/933c25e558e6d0d8766d024a329d003a8d4c1162 DIFF: https://github.com/llvm/llvm-project/commit/933c25e558e6d0d8766d024a329d003a8d4c1162.d

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/77999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/77999 >From dcc17c06960845deccfcd0efe78434110c2add9e Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 12 Jan 2024 15:20:12 -0800 Subject: [PATCH] [lldb] Store SupportFile in LineEntry (NFC) Store a Sup

[Lldb-commits] [libc] [clang] [compiler-rt] [clang-tools-extra] [libcxxabi] [flang] [lldb] [lld] [llvm] [libcxx] [RISCV] Support Global Dynamic TLSDESC in the RISC-V backend (PR #66915)

2024-01-16 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/66915 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [clang-tools-extra] [libcxxabi] [compiler-rt] [clang] [lldb] [lld] [flang] [llvm] [libc] [RISCV] Support Global Dynamic TLSDESC in the RISC-V backend (PR #66915)

2024-01-16 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay approved this pull request. LGTM once the TLSDESC option is moved to use llvm/lib/CodeGen/CommandFlags.cpp It's worth giving others some time to respond. https://github.com/llvm/llvm-project/pull/66915 ___ lldb-commits maili

[Lldb-commits] [libc] [clang] [compiler-rt] [clang-tools-extra] [libcxxabi] [flang] [lldb] [lld] [llvm] [libcxx] [RISCV] Support Global Dynamic TLSDESC in the RISC-V backend (PR #66915)

2024-01-16 Thread Fangrui Song via lldb-commits
@@ -80,6 +80,11 @@ static cl::opt EnableRISCVDeadRegisterElimination( " them with stores to x0"), cl::init(true)); +// TODO: This should be controlled by -mtls-dialect= +cl::opt EnableRISCVTLSDESC("riscv-enable-tlsdesc", MaskRay wrote: We sho

[Lldb-commits] [lldb] Return high address masks correctly in Process (PR #78379)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM with the promise for a test when you land the updated PR for D155905. https://github.com/llvm/llvm-project/pull/78379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [lldb] [lldb] Upstream xros support in lldb (PR #78389)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️ > > You can test this locally with the following command: > View the diff from clang-format here. The suggested changes are orthogonal to the changes in this PR: they just happen to be on the preceding

[Lldb-commits] [lldb] Return high address masks correctly in Process (PR #78379)

2024-01-16 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: To test this one, I need to move this old patch https://reviews.llvm.org/D155905 over to a github PR and land it; it will add SBProcess methods to set, get, and test the address mask settings the same way that we get them from a gdb-remote stub or a corefile. That patch is

[Lldb-commits] [lldb] [lldb] Upstream xros support in lldb (PR #78389)

2024-01-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 32382bb8329a0931456ab0c60e351cf3a18ab6f3 a326e09e34fd383fe35513c419b4be46558aab69 --

[Lldb-commits] [lldb] [lldb] Upstream xros support in lldb (PR #78389)

2024-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Upstream support for debugging xros applications through LLDB. --- Patch is 27.98 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/78389.diff 21 Files Af

[Lldb-commits] [lldb] [lldb] Upstream xros support in lldb (PR #78389)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/78389 Upstream support for debugging xros applications through LLDB. >From a326e09e34fd383fe35513c419b4be46558aab69 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 10 Jan 2024 17:35:47 -0800 Subject:

[Lldb-commits] [lldb] Return high address masks correctly in Process (PR #78379)

2024-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes In https://reviews.llvm.org/D151292 I added the ability to track address masks separately for high and low memory addresses, a capability of AArch64. I did my testing with manual address mask settings

[Lldb-commits] [lldb] Return high address masks correctly in Process (PR #78379)

2024-01-16 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/78379 In https://reviews.llvm.org/D151292 I added the ability to track address masks separately for high and low memory addresses, a capability of AArch64. I did my testing with manual address mask settings (via

[Lldb-commits] [lldb] Add the Linux "you can use this binary" bits to run_to_source_breakpoint (PR #78377)

2024-01-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r a4cd99ea8736eda2b8b4de34453f55008bcf9c30...970fbad325ac101f930c2eb18a69d3341908b63b lldb/

[Lldb-commits] [lldb] Add the Linux "you can use this binary" bits to run_to_source_breakpoint (PR #78377)

2024-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes Follow-on to a4cd99ea8736eda2b8b4de34453f55008bcf9c30 - I forgot you have to add ANY shared library you want to use to extra_images... --- Full diff: https://github.com/llvm/llvm-project/pull/78377.diff 1 Files A

[Lldb-commits] [lldb] 705c5b8 - Add the Linux "you can use this binary" bits to run_to_source_breakpoint (#78377)

2024-01-16 Thread via lldb-commits
Author: jimingham Date: 2024-01-16T17:54:12-08:00 New Revision: 705c5b80ace9d6fb1b9d1129ca1529d6645f1f24 URL: https://github.com/llvm/llvm-project/commit/705c5b80ace9d6fb1b9d1129ca1529d6645f1f24 DIFF: https://github.com/llvm/llvm-project/commit/705c5b80ace9d6fb1b9d1129ca1529d6645f1f24.diff LOG

[Lldb-commits] [lldb] Add the Linux "you can use this binary" bits to run_to_source_breakpoint (PR #78377)

2024-01-16 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/78377 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the Linux "you can use this binary" bits to run_to_source_breakpoint (PR #78377)

2024-01-16 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/78377 Follow-on to a4cd99ea8736eda2b8b4de34453f55008bcf9c30 - I forgot you have to add ANY shared library you want to use to extra_images... >From 970fbad325ac101f930c2eb18a69d3341908b63b Mon Sep 17 00:00:00 2001 Fr

[Lldb-commits] [lldb] 32382bb - [lldb] Remove unused LineEntry ctor (NFC)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-01-16T16:37:27-08:00 New Revision: 32382bb8329a0931456ab0c60e351cf3a18ab6f3 URL: https://github.com/llvm/llvm-project/commit/32382bb8329a0931456ab0c60e351cf3a18ab6f3 DIFF: https://github.com/llvm/llvm-project/commit/32382bb8329a0931456ab0c60e351cf3a18ab6f3.d

[Lldb-commits] [lldb] [lldb] Build the TestRosetta.py executable with system stdlib (PR #78370)

2024-01-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/78370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a43a4a5 - [lldb] Build the TestRosetta.py executable with system stdlib (#78370)

2024-01-16 Thread via lldb-commits
Author: Alex Langford Date: 2024-01-16T16:29:31-08:00 New Revision: a43a4a5329fbb4c5bedddb9cbbe89d3659422be3 URL: https://github.com/llvm/llvm-project/commit/a43a4a5329fbb4c5bedddb9cbbe89d3659422be3 DIFF: https://github.com/llvm/llvm-project/commit/a43a4a5329fbb4c5bedddb9cbbe89d3659422be3.diff

[Lldb-commits] [lldb] [lldb] Build the TestRosetta.py executable with system stdlib (PR #78370)

2024-01-16 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. https://github.com/llvm/llvm-project/pull/78370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Build the TestRosetta.py executable with system stdlib (PR #78370)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/78370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Build the TestRosetta.py executable with system stdlib (PR #78370)

2024-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes This is a speculative fix for TestRosetta.py which is currently failing on Green Dragon. TestRosetta just makes sure we can debug an x86_64 process on Apple Silicon. However, we're failing to build the x8

[Lldb-commits] [lldb] [lldb] Build the TestRosetta.py executable with system stdlib (PR #78370)

2024-01-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/78370 This is a speculative fix for TestRosetta.py which is currently failing on Green Dragon. TestRosetta just makes sure we can debug an x86_64 process on Apple Silicon. However, we're failing to build the x86_64

[Lldb-commits] [lldb] Ensure that the executable module is ModuleList[0] (PR #78360)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/78360 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

2024-01-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Closing as per the discussion above. The long term goal is to have a single class unifying this context idea across plugins. In hindsight, the patch that was going to use this functionality can inline some version of this without any ugliness. https://github.com/llvm/llv

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

2024-01-16 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/77349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [DoNotMerge] DW_IDX_parent full implementation (PR #77121)

2024-01-16 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/77121 >From 6a46e61047dde4f3fc561c8c0b08bfbd7b28353e Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 6 Dec 2023 11:26:18 -0800 Subject: [PATCH 1/4] [AsmPrinter][DebugNames] Implement DW_IDX_

[Lldb-commits] [lldb] 854aa91 - [lldb] Store SupportFile as shared_ptr (NFC)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-01-16T15:40:15-08:00 New Revision: 854aa9112df253bcad4db6f21ea9b2fbca4ed83e URL: https://github.com/llvm/llvm-project/commit/854aa9112df253bcad4db6f21ea9b2fbca4ed83e DIFF: https://github.com/llvm/llvm-project/commit/854aa9112df253bcad4db6f21ea9b2fbca4ed83e.d

[Lldb-commits] [lldb] Ensure that the executable module is ModuleList[0] (PR #78360)

2024-01-16 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Looks good to me. https://github.com/llvm/llvm-project/pull/78360 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Ensure that the executable module is ModuleList[0] (PR #78360)

2024-01-16 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/78360 >From 4d53ea53a9a5d9344d41195697b3b98359af1ede Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Tue, 16 Jan 2024 14:33:29 -0800 Subject: [PATCH 1/2] Ensure that the executable module is ModuleList[0] We claim i

[Lldb-commits] [lldb] Ensure that the executable module is ModuleList[0] (PR #78360)

2024-01-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 32dd5b20973bde1ef77fa3b84b9f85788a1a303a 4d53ea53a9a5d9344d41195697b3b98359af1ede --

[Lldb-commits] [lldb] Ensure that the executable module is ModuleList[0] (PR #78360)

2024-01-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 32dd5b20973bde1ef77fa3b84b9f85788a1a303a...4d53ea53a9a5d9344d41195697b3b98359af1ede lldb/

[Lldb-commits] [lldb] Ensure that the executable module is ModuleList[0] (PR #78360)

2024-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes We claim in a couple places that the zeroth element of the module list for a target is the main executable, but we don't actually enforce that in the ModuleList class. As we saw, for instance, in 32dd5b20973bde1e

[Lldb-commits] [lldb] Ensure that the executable module is ModuleList[0] (PR #78360)

2024-01-16 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/78360 We claim in a couple places that the zeroth element of the module list for a target is the main executable, but we don't actually enforce that in the ModuleList class. As we saw, for instance, in 32dd5b20973

[Lldb-commits] [clang] [libc] [libunwind] [clang-tools-extra] [llvm] [lld] [libcxxabi] [lldb] [libcxx] [compiler-rt] [flang] Fix a bug in Smith's algorithm used in complex div/mul. (PR #78330)

2024-01-16 Thread Zahira Ammarguellat via lldb-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/78330 >From 8f8917528e30d2ba67f669cfd1a893bc85c21121 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 16 Jan 2024 11:24:03 -0800 Subject: [PATCH] Fixed a bug in Smith's algorithm and made sure last option in co

[Lldb-commits] [lldb] [lldb][Progress] Fix test for trimmed progress reports (PR #78357)

2024-01-16 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/78357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8947469 - [lldb][Progress] Fix test for trimmed progress reports (#78357)

2024-01-16 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-01-16T14:35:39-08:00 New Revision: 8947469ec1ad6d35b2feec0acc43d0d191514f0b URL: https://github.com/llvm/llvm-project/commit/8947469ec1ad6d35b2feec0acc43d0d191514f0b DIFF: https://github.com/llvm/llvm-project/commit/8947469ec1ad6d35b2feec0acc43d0d191514f0b.d

[Lldb-commits] [lldb] [lldb][Progress] Fix test for trimmed progress reports (PR #78357)

2024-01-16 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/78357 >From f1e8b700c5db6f97db87fdda3f5a81ba5f2582ab Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 16 Jan 2024 13:51:10 -0800 Subject: [PATCH] [lldb][Progress] Fix test for trimmed progress reports

[Lldb-commits] [lldb] 1b5f72c - [lldb] Hoist SupportFile out of FileSpecList (NFC)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-01-16T14:20:22-08:00 New Revision: 1b5f72c5ece4442ca29ced45f8bcb25ed0d57790 URL: https://github.com/llvm/llvm-project/commit/1b5f72c5ece4442ca29ced45f8bcb25ed0d57790 DIFF: https://github.com/llvm/llvm-project/commit/1b5f72c5ece4442ca29ced45f8bcb25ed0d57790.d

[Lldb-commits] [lldb] [lldb][Progress] Fix test for trimmed progress reports (PR #78357)

2024-01-16 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/78357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Progress] Fix test for trimmed progress reports (PR #78357)

2024-01-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 65ecbdf61f5a3fb53f05abc610b90a8671f93730...e232f553186f6f63f5fd4a85b6747e0f3838b3dc lldb

[Lldb-commits] [lldb] [lldb][Progress] Fix test for trimmed progress reports (PR #78357)

2024-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes The test TestTrimmedProgressReporting tests that progress reports are being sent by listening for events with the titles of specific progress reports. Commit f1ef910b removed the report for Apple D

[Lldb-commits] [lldb] [lldb][Progress] Fix test for trimmed progress reports (PR #78357)

2024-01-16 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/78357 The test TestTrimmedProgressReporting tests that progress reports are being sent by listening for events with the titles of specific progress reports. Commit f1ef910b removed the report for Apple DWARF ind

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-16 Thread Greg Clayton via lldb-commits
clayborg wrote: > > > If a module is debug info only, like a dSYM file, and then you try to > > > `target module add` it to a target, it would be nice to add it as the > > > symbol file for an already existing module. The test below, I wouldn't > > > want a target with two things representing

[Lldb-commits] [lldb] 142f270 - Recommit "[AST] Use APIntStorage to fix memory leak in EnumConstantDecl. (#78311)"

2024-01-16 Thread Craig Topper via lldb-commits
Author: Craig Topper Date: 2024-01-16T13:52:17-08:00 New Revision: 142f270c279f2576e4618fc0d1121181c7531fdf URL: https://github.com/llvm/llvm-project/commit/142f270c279f2576e4618fc0d1121181c7531fdf DIFF: https://github.com/llvm/llvm-project/commit/142f270c279f2576e4618fc0d1121181c7531fdf.diff

[Lldb-commits] [llvm] [libcxx] [libcxxabi] [clang] [lldb] [libc] [clang-tools-extra] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2024-01-16 Thread Louis Dionne via lldb-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/69498 >From 6f89b118ed56ad7a3af1996e19ccd30cc893c51e Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 14 Jun 2023 17:49:22 -0700 Subject: [PATCH 1/7] [libc++] Fix the behavior of throwing `operator new` under -f

[Lldb-commits] [lldb] [lldb-dap] Removing the debugger log callback, instead use the default behavior. (PR #78343)

2024-01-16 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/78343 The logging callback prevents `lldb> log enable -f lldb api` from writing to a file and instead redirects all logging to the callback. Fixes [issues/78334](https://github.com/llvm/llvm-project/issues/78334). >F

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > > If a module is debug info only, like a dSYM file, and then you try to > > `target module add` it to a target, it would be nice to add it as the > > symbol file for an already existing module. The test below, I wouldn't want > > a target with two things representing a.ou

[Lldb-commits] [lldb] Work around a bug in the interaction between newer dyld's and older simulator dyld's (PR #78004)

2024-01-16 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/78004 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 32dd5b2 - Work around a bug in the interaction between newer dyld's and older simulator dyld's (#78004)

2024-01-16 Thread via lldb-commits
Author: jimingham Date: 2024-01-16T11:31:42-08:00 New Revision: 32dd5b20973bde1ef77fa3b84b9f85788a1a303a URL: https://github.com/llvm/llvm-project/commit/32dd5b20973bde1ef77fa3b84b9f85788a1a303a DIFF: https://github.com/llvm/llvm-project/commit/32dd5b20973bde1ef77fa3b84b9f85788a1a303a.diff LOG

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-16 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/78005 >From c3a4cd38b41e332342aa7042d3a9c2f75416bfc3 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 12 Jan 2024 16:39:47 -0800 Subject: [PATCH] [lldb-dap] Adjusting how repl-mode auto determines commands vs va

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-16 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/78005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-16 Thread Greg Clayton via lldb-commits
clayborg wrote: > If a module is debug info only, like a dSYM file, and then you try to `target > module add` it to a target, it would be nice to add it as the symbol file for > an already existing module. The test below, I wouldn't want a target with two > things representing a.out, which is

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-16 Thread John Harrison via lldb-commits
@@ -395,43 +402,56 @@ ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, case ReplMode::Command: return ExpressionContext::Command; case ReplMode::Auto: -// If the frame is invalid then there is no variables to complete, assume -// this is an

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-16 Thread John Harrison via lldb-commits
@@ -395,43 +402,56 @@ ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, case ReplMode::Command: return ExpressionContext::Command; case ReplMode::Auto: -// If the frame is invalid then there is no variables to complete, assume -// this is an

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-16 Thread John Harrison via lldb-commits
@@ -395,43 +402,56 @@ ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, case ReplMode::Command: return ExpressionContext::Command; case ReplMode::Auto: -// If the frame is invalid then there is no variables to complete, assume -// this is an

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-16 Thread John Harrison via lldb-commits
@@ -395,43 +402,56 @@ ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, case ReplMode::Command: return ExpressionContext::Command; case ReplMode::Auto: -// If the frame is invalid then there is no variables to complete, assume -// this is an

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-16 Thread John Harrison via lldb-commits
@@ -380,12 +380,19 @@ llvm::json::Value DAP::CreateTopLevelScopes() { return llvm::json::Value(std::move(scopes)); } -ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, - std::string &text) { +static std::string

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-16 Thread John Harrison via lldb-commits
@@ -380,12 +380,19 @@ llvm::json::Value DAP::CreateTopLevelScopes() { return llvm::json::Value(std::move(scopes)); } -ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, - std::string &text) { +static std::string

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-16 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/78005 >From f01c82be09e28c1eead4d80f4ceea67dee0318d6 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 12 Jan 2024 16:39:47 -0800 Subject: [PATCH] [lldb-dap] Adjusting how repl-mode auto determines commands vs va

[Lldb-commits] [clang-tools-extra] [clang] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-16 Thread Erich Keane via lldb-commits
@@ -12,6 +12,7 @@ #include "clang/AST/DeclCXX.h" #include "clang/AST/DeclTemplate.h" #include "clang/AST/DeclVisitor.h" +#include "clang/AST/ODRHash.h" erichkeane wrote: We shouldn't be minimizing the #include set, but it is often a 'red flag' when someone ad

[Lldb-commits] [clang-tools-extra] [clang] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-16 Thread Erich Keane via lldb-commits
https://github.com/erichkeane commented: I would love it if @efriedma-quic / @rjmccall looked at the mangling parts, and @dwblaikie looked at the Debug info. Else, LGTM. https://github.com/llvm/llvm-project/pull/78041 ___ lldb-commits mailing list ll

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-16 Thread Erich Keane via lldb-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/78041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [lldb] [clang] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-16 Thread Erich Keane via lldb-commits
@@ -551,6 +646,18 @@ static const T &DiagTemplateArg(const T &DB, const TemplateArgument &Arg) { case TemplateArgument::Integral: return DB << toString(Arg.getAsIntegral(), 10); + case TemplateArgument::StructuralValue: { +// FIXME: We're guessing at LangOptions! -

[Lldb-commits] [lld] [llvm] [libunwind] [compiler-rt] [libcxx] [clang-tools-extra] [libc] [libcxxabi] [flang] [lldb] [mlir] [clang] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

2024-01-16 Thread Aaron Ballman via lldb-commits
@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[Lldb-commits] [libc] [llvm] [lld] [flang] [libcxx] [libunwind] [mlir] [clang] [compiler-rt] [lldb] [libcxxabi] [clang-tools-extra] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

2024-01-16 Thread Mark de Wever via lldb-commits
@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[Lldb-commits] [libc] [lldb] [libunwind] [libcxx] [clang-tools-extra] [libcxxabi] [llvm] [compiler-rt] [lld] [clang] [flang] [mlir] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

2024-01-16 Thread Mark de Wever via lldb-commits
@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-16 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f1ef910 - [lldb][Progress] Separate title and details (#77547)

2024-01-16 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-01-16T07:57:18-08:00 New Revision: f1ef910b97d6acb80480b79a4144541311369cc9 URL: https://github.com/llvm/llvm-project/commit/f1ef910b97d6acb80480b79a4144541311369cc9 DIFF: https://github.com/llvm/llvm-project/commit/f1ef910b97d6acb80480b79a4144541311369cc9.d

[Lldb-commits] [lldb] [llvm] [lldb] Add LLDB_BUG_REPORT_URL macro to allow a different URL for lldb bug reporting. (PR #78210)

2024-01-16 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/78210 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1617c8d - [lldb] Add LLDB_BUG_REPORT_URL macro to allow a different URL for lldb bug reporting. (#78210)

2024-01-16 Thread via lldb-commits
Author: Zequan Wu Date: 2024-01-16T10:50:48-05:00 New Revision: 1617c8d3b8c5fc5d1ec54e4e1b2c43679e573065 URL: https://github.com/llvm/llvm-project/commit/1617c8d3b8c5fc5d1ec54e4e1b2c43679e573065 DIFF: https://github.com/llvm/llvm-project/commit/1617c8d3b8c5fc5d1ec54e4e1b2c43679e573065.diff LOG

[Lldb-commits] [clang] [libcxx] [llvm] [libunwind] [libc] [lldb] [compiler-rt] [lld] [clang-tools-extra] [flang] [AMDGPU] Fix predicates for V_DOT instructions. (PR #78198)

2024-01-16 Thread Ivan Kosarev via lldb-commits
https://github.com/kosarev updated https://github.com/llvm/llvm-project/pull/78198 >From 0dc06c5ab3b1ff5f2441ff0ee26f5a6dfbbb7753 Mon Sep 17 00:00:00 2001 From: Ivan Kosarev Date: Mon, 15 Jan 2024 17:20:34 + Subject: [PATCH] [AMDGPU] Fix predicates for V_DOT instructions. Resolves AsmParse

[Lldb-commits] [clang] [mlir] [libcxx] [llvm] [libunwind] [libcxxabi] [libc] [lldb] [compiler-rt] [lld] [clang-tools-extra] [flang] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

2024-01-16 Thread Aaron Ballman via lldb-commits
@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[Lldb-commits] [clang] [libcxx] [llvm] [libunwind] [libc] [lldb] [compiler-rt] [clang-tools-extra] [flang] [libc++] Implement ranges::iota (PR #68494)

2024-01-16 Thread James E T Smith via lldb-commits
https://github.com/jamesETsmith edited https://github.com/llvm/llvm-project/pull/68494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [llvm] [compiler-rt] [libcxx] [libunwind] [flang] [clang] [mlir] [clang-tools-extra] [libc] [lldb] [libcxxabi] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

2024-01-16 Thread Hristo Hristov via lldb-commits
@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[Lldb-commits] [lld] [llvm] [compiler-rt] [libcxx] [libunwind] [flang] [clang] [mlir] [clang-tools-extra] [libc] [lldb] [libcxxabi] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

2024-01-16 Thread Aaron Ballman via lldb-commits
@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[Lldb-commits] [clang] [libcxx] [lld] [libc] [compiler-rt] [clang-tools-extra] [llvm] [flang] [lldb] [libcxxabi] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-16 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/76653 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits