[Lldb-commits] [lldb] 4cf458c - Fix help doc for 'enable-background-lookup' obsolete setting

2024-02-15 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-02-15T23:53:14-08:00 New Revision: 4cf458c696047d6d2991c121da7a5c165ff747ce URL: https://github.com/llvm/llvm-project/commit/4cf458c696047d6d2991c121da7a5c165ff747ce DIFF: https://github.com/llvm/llvm-project/commit/4cf458c696047d6d2991c121da7a5c165ff747ce.diff

[Lldb-commits] [lldb] 266bbc2 - [lldb] Re-enable TestStepOverWatchpoint on macOS 14.4 and later

2024-02-15 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-02-15T22:54:00-08:00 New Revision: 266bbc203da2d0bc880e643560fb48aff4830478 URL: https://github.com/llvm/llvm-project/commit/266bbc203da2d0bc880e643560fb48aff4830478 DIFF:

[Lldb-commits] [lldb] 096c530 - [lldb] Fix Python test formatting (NFC)

2024-02-15 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-02-15T22:54:00-08:00 New Revision: 096c530ab3ea5c96526451181117f30db17b4b1d URL: https://github.com/llvm/llvm-project/commit/096c530ab3ea5c96526451181117f30db17b4b1d DIFF:

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-15 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. You can remove the headerdoc in the SymbolFileDWARF.h file and this is good to go. https://github.com/llvm/llvm-project/pull/81706 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-15 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/81706 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-15 Thread Greg Clayton via lldb-commits
@@ -186,7 +186,19 @@ class SymbolFileDWARF : public SymbolFileCommon { GetMangledNamesForFunction(const std::string _qualified_name, std::vector _names) override; - uint64_t GetDebugInfoSize() override; + /// Get total currently loaded debug

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/81319 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 327d2f8 - [lldb][progress] Add progress manager class (#81319)

2024-02-15 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-02-15T15:46:47-08:00 New Revision: 327d2f8c6cee019d4f915036f40041b5369b61e5 URL: https://github.com/llvm/llvm-project/commit/327d2f8c6cee019d4f915036f40041b5369b61e5 DIFF:

[Lldb-commits] [lldb] Re-land [lldb-dap] Add support for data breakpoint. (PR #81909)

2024-02-15 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/81909 >From d95a420ef100d0e73f8ff829926fc3f3d0708386 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 15 Feb 2024 14:29:18 -0500 Subject: [PATCH 1/2] [lldb-dap] Add support for data breakpoint. This implements

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/81319 >From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 8 Feb 2024 15:31:33 -0800 Subject: [PATCH 1/4] [lldb][progress] Add progress manager class Per

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Chelsea Cassanova via lldb-commits
@@ -66,3 +67,41 @@ void Progress::ReportProgress() { m_debugger_id); } } + +ProgressManager ::InstanceImpl() { + static std::once_flag g_once_flag; + static ProgressManager *g_progress_manager = nullptr; + std::call_once(g_once_flag, []() { +

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-15 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: Skipped the test in 65c25a4c40865a0e460c0fecb1b33f7cf7455573 Tear down behavior was patched for LLDB back in b1490b6172c48cf802b24bd738c90eeb019436fe. I'm guessing that explains why we weren't noticing those errors -- they get logged as cleanup_errors, not as errors. (Maybe

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Chelsea Cassanova via lldb-commits
@@ -119,6 +120,32 @@ class Progress { bool m_complete = false; }; +/// A class used to group progress reports by category. This is done by using a +/// map that maintains a refcount of each category of progress reports that have +/// come in. Keeping track of progress

[Lldb-commits] [lldb] 65c25a4 - [lldb][test] Skip TestDAP_commands.py test due to flakiness

2024-02-15 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2024-02-15T11:51:44-08:00 New Revision: 65c25a4c40865a0e460c0fecb1b33f7cf7455573 URL: https://github.com/llvm/llvm-project/commit/65c25a4c40865a0e460c0fecb1b33f7cf7455573 DIFF:

[Lldb-commits] [lldb] Re-land [lldb-dap] Add support for data breakpoint. (PR #81909)

2024-02-15 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/81909 >From d95a420ef100d0e73f8ff829926fc3f3d0708386 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 15 Feb 2024 14:29:18 -0500 Subject: [PATCH] [lldb-dap] Add support for data breakpoint. This implements

[Lldb-commits] [lldb] Re-land [lldb-dap] Add support for data breakpoint. (PR #81909)

2024-02-15 Thread Zequan Wu via lldb-commits
ZequanWu wrote: DAP adds a new request `DataAddressBreakpointInfo` at https://github.com/microsoft/debug-adapter-protocol/pull/461 with the following format to allow setting watchpoints at given address and size: ``` interface DataAddressBreakpointInfoRequest extends Request { command:

[Lldb-commits] [lldb] Re-land [lldb-dap] Add support for data breakpoint. (PR #81909)

2024-02-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r e82659fff2f07b5ea1d94e0d8bcb9c540d6bede1...757013af5361f5bf0f486d7ac0ee2f6980248f15

[Lldb-commits] [lldb] Re-land [lldb-dap] Add support for data breakpoint. (PR #81909)

2024-02-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes This implements functionality to handle DataBreakpointInfo request and SetDataBreakpoints request. Previous commit https://github.com/llvm/llvm-project/commit/8c56e78ec531f0e2460213c20fff869b6b7add99 was

[Lldb-commits] [lldb] Re-land [lldb-dap] Add support for data breakpoint. (PR #81909)

2024-02-15 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/81909 This implements functionality to handle DataBreakpointInfo request and SetDataBreakpoints request. Previous commit https://github.com/llvm/llvm-project/commit/8c56e78ec531f0e2460213c20fff869b6b7add99 was

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Just remove `static ProgressManager ();` and inline the code into `static ProgressManager ();` and this is good to go. https://github.com/llvm/llvm-project/pull/81319 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Greg Clayton via lldb-commits
@@ -66,3 +67,41 @@ void Progress::ReportProgress() { m_debugger_id); } } + +ProgressManager ::InstanceImpl() { + static std::once_flag g_once_flag; + static ProgressManager *g_progress_manager = nullptr; + std::call_once(g_once_flag, []() { +

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Greg Clayton via lldb-commits
@@ -66,3 +67,37 @@ void Progress::ReportProgress() { m_debugger_id); } } + +ProgressManager ::InstanceImpl() { + static std::once_flag g_once_flag; + static ProgressManager *g_progress_manager = nullptr; + std::call_once(g_once_flag, []() { +

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Greg Clayton via lldb-commits
@@ -119,6 +120,32 @@ class Progress { bool m_complete = false; }; +/// A class used to group progress reports by category. This is done by using a +/// map that maintains a refcount of each category of progress reports that have +/// come in. Keeping track of progress

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/81319 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/81319 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/81319 >From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 8 Feb 2024 15:31:33 -0800 Subject: [PATCH 1/3] [lldb][progress] Add progress manager class Per

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-15 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: I believe the old unittest framework may have been ignoring failures that happen during teardown. I have started looking at https://github.com/llvm/llvm-project/issues/81686 a bit, but +1 to suppressing this temporarily -- I should be able to land that in a bit.

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-15 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I can't imagine how the unit test framework could have made this flaky. It's more likely the test was flakey before and it went unnoticed. Can we (temporarily) disable the DAP test? https://github.com/llvm/llvm-project/pull/81703

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-15 Thread Shubham Sandeep Rastogi via lldb-commits
rastogishubham wrote: Hi @rupprecht, It seems like this patch has still not fixed the issue in greendragon and the test is still flaky https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: > @DavidSpickett what's the benefit of waiting for the arm bots to come back up? If you give me the choice of more potential chaos or less, I'm always going to choose less :) But yes this shouldn't be too difficult to pick out if it does fail.