[Lldb-commits] [lldb] [lldb][test] Modernize asserts (PR #82503)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes This uses [teyit](https://pypi.org/project/teyit/) to modernize asserts, as recommended by the [unittest release notes](https://docs.python.org/3.12/whatsnew/3.12.html#id3). For example, `assertTrue(a

[Lldb-commits] [lldb] [lldb][test] Modernize asserts (PR #82503)

https://github.com/bulbazord approved this pull request. I did a quick manual inspection of all of them, the transformation produced by Teyit looks correct to me. I did notice a few places where we were doing convoluted checks (I left a comment on one) but those should be addressed in follow-u

[Lldb-commits] [lldb] [lldb][test] Modernize asserts (PR #82503)

https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/82503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Modernize asserts (PR #82503)

@@ -456,8 +457,9 @@ def queues_with_libBacktraceRecording(self): "doing_the_work_2", "queue 2's pending item #0 should be doing_the_work_2", ) -self.assertTrue( -queue_performer_2.GetPendingItemAtIndex().IsValid() == False

[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

DavidSpickett wrote: This change has caused a failing test on Linux: https://lab.llvm.org/buildbot/#/builders/68/builds/69157 That's not the first build, because the bot was red for ages beforehand and I'm not going to check them all. I've bisected it on arm64 instead to confirm it and get a

[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

@@ -9,43 +9,27 @@ #include "gtest/gtest.h" #include "Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h" -#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h" -#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h" #include "Plugins/Script

[Lldb-commits] [lldb] [lldb] Standardize command option parsing error messages (PR #82273)

https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/82273 >From 790810f9318c7947fe2edd187f60425a85c949b5 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Thu, 15 Feb 2024 17:39:42 -0800 Subject: [PATCH 1/2] [lldb] Standardize command option parsing error messages I

[Lldb-commits] [lldb] [lldb] Standardize command option parsing error messages (PR #82273)

bulbazord wrote: I've added a doxygen comment to the new function I introduced. I plan on landing this later today if there are no objections. https://github.com/llvm/llvm-project/pull/82273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [lldb][test] Modernize asserts (PR #82503)

@@ -456,8 +457,9 @@ def queues_with_libBacktraceRecording(self): "doing_the_work_2", "queue 2's pending item #0 should be doing_the_work_2", ) -self.assertTrue( -queue_performer_2.GetPendingItemAtIndex().IsValid() == False

[Lldb-commits] [lldb] [lldb][test] Modernize asserts (PR #82503)

https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/82503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Modernize assertEqual(value, bool) (PR #82526)

https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/82526 Any time we see the pattern `assertEqual(value, bool)`, we can replace that with `assert(value)`. Likewise for `assertNotEqual`. Technically this relaxes the test a bit, as we may want to make sure `value` is

[Lldb-commits] [lldb] [lldb][test] Modernize assertEqual(value, bool) (PR #82526)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes Any time we see the pattern `assertEqual(value, bool)`, we can replace that with `assert(value)`. Likewise for `assertNotEqual`. Technically this relaxes the test a bit, as we may want to make sur

[Lldb-commits] [lldb] [lldb][test] Modernize asserts (PR #82503)

@@ -456,8 +457,9 @@ def queues_with_libBacktraceRecording(self): "doing_the_work_2", "queue 2's pending item #0 should be doing_the_work_2", ) -self.assertTrue( -queue_performer_2.GetPendingItemAtIndex().IsValid() == False

[Lldb-commits] [lldb] c63e68b - Bump the minimum LLVM version for TestTypeList.py

Author: Shubham Sandeep Rastogi Date: 2024-02-21T13:42:10-08:00 New Revision: c63e68ba5fb54b69521c4f010d1c5290856c6509 URL: https://github.com/llvm/llvm-project/commit/c63e68ba5fb54b69521c4f010d1c5290856c6509 DIFF: https://github.com/llvm/llvm-project/commit/c63e68ba5fb54b69521c4f010d1c5290856c

[Lldb-commits] [lldb] [lldb][test] Modernize assertEqual(value, bool) (PR #82526)

https://github.com/bulbazord approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/82526 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1eeeab8 - [lldb][test] Modernize assertEqual(value, bool) (#82526)

Author: Jordan Rupprecht Date: 2024-02-21T20:39:02-06:00 New Revision: 1eeeab82c6eb185f5139e633a59c2dbcb15616e4 URL: https://github.com/llvm/llvm-project/commit/1eeeab82c6eb185f5139e633a59c2dbcb15616e4 DIFF: https://github.com/llvm/llvm-project/commit/1eeeab82c6eb185f5139e633a59c2dbcb15616e4.di

[Lldb-commits] [lldb] [lldb][test] Modernize assertEqual(value, bool) (PR #82526)

https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/82526 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7e1432f - [lldb] Standardize command option parsing error messages (#82273)

Author: Alex Langford Date: 2024-02-21T19:26:43-08:00 New Revision: 7e1432f1258e229a4fcc9c017937166f0578e1f8 URL: https://github.com/llvm/llvm-project/commit/7e1432f1258e229a4fcc9c017937166f0578e1f8 DIFF: https://github.com/llvm/llvm-project/commit/7e1432f1258e229a4fcc9c017937166f0578e1f8.diff

[Lldb-commits] [lldb] [lldb] Standardize command option parsing error messages (PR #82273)

https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/82273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [debugserver] fix qLaunchSuccess error, add QErrorStringInPack… (PR #82593)

https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/82593 …etSupported Pavel added an extension to lldb's gdb remote serial protocol that allows the debug stub to append an error message (ascii hex encoded) after an error response packet Exx. This was added in 2

[Lldb-commits] [lldb] 6757913 - [lldb][test] Fix PythonDataObjectsTest

Author: Jordan Rupprecht Date: 2024-02-21T22:59:03-08:00 New Revision: 675791335285fa86434dc46e5c92f543e0e79d19 URL: https://github.com/llvm/llvm-project/commit/675791335285fa86434dc46e5c92f543e0e79d19 DIFF: https://github.com/llvm/llvm-project/commit/675791335285fa86434dc46e5c92f543e0e79d19.di

[Lldb-commits] [lldb] [lldb] [debugserver] fix qLaunchSuccess error, add QErrorStringInPack… (PR #82593)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes …etSupported Pavel added an extension to lldb's gdb remote serial protocol that allows the debug stub to append an error message (ascii hex encoded) after an error response packet Exx. This was added

[Lldb-commits] [lldb] [lldb] [debugserver] fix qLaunchSuccess error, add QErrorStringInPack… (PR #82593)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 386aa7b16977150da917a78423fd05cb19609850 0ba4e6402969028fa6152c366a56063a56acded1 --

[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

@@ -9,43 +9,27 @@ #include "gtest/gtest.h" #include "Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h" -#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h" -#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h" #include "Plugins/Script

[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

rupprecht wrote: > This change has caused a failing test on Linux: > https://lab.llvm.org/buildbot/#/builders/68/builds/69157 > Fixed w/ 675791335285fa86434dc46e5c92f543e0e79d19 https://github.com/llvm/llvm-project/pull/82096 ___ lldb-commits mailin