[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

@@ -1568,15 +1569,16 @@ bool Target::SetArchitecture(const ArchSpec &arch_spec, bool set_platform, if (m_arch.GetSpec().IsCompatibleMatch(other)) { compatible_local_arch = true; -bool arch_changed, vendor_changed, os_changed, os_ver_changed, -

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

jasonmolenda wrote: The debugserver changes all look good to me, fwiw. My only feedback is about the API test. https://github.com/llvm/llvm-project/pull/82938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

@@ -26,3 +31,8 @@ def test(self): "target triple is updated correctly") error = process.Kill() self.assertSuccess(error) + +# Test debugserver behavior. +self.filecheck('platform shell cat "%s"' % packets, __file__) +

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

@@ -1568,15 +1569,16 @@ bool Target::SetArchitecture(const ArchSpec &arch_spec, bool set_platform, if (m_arch.GetSpec().IsCompatibleMatch(other)) { compatible_local_arch = true; -bool arch_changed, vendor_changed, os_changed, os_ver_changed, -

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

https://github.com/JDevlieghere commented: Overall this looks good but we should verify that this doesn't regress running unmodified iOS binaries on macOS (https://reviews.llvm.org/D117340, https://reviews.llvm.org/D121444). It was really tricky to get that right and it's all based on the bina

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

@@ -0,0 +1,7 @@ +C_SOURCES := main.c + +# Uncomment this for q&d local debugging. JDevlieghere wrote: Q&D? https://github.com/llvm/llvm-project/pull/82938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

@@ -1568,15 +1569,16 @@ bool Target::SetArchitecture(const ArchSpec &arch_spec, bool set_platform, if (m_arch.GetSpec().IsCompatibleMatch(other)) { compatible_local_arch = true; -bool arch_changed, vendor_changed, os_changed, os_ver_changed, -

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/82938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 3f91bdfdd50aa4eaf1d3e49cf797220cfeccaf16...aecc7f751328a11c12bb910b1e30cab41b98a146 lldb/

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/82938 >From 5c9e53d45ba948b8a5e8416aa9b3322c87fc46c8 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 23 Feb 2024 09:58:17 -0800 Subject: [PATCH 1/2] Replace ArchSpec::PiecewiseCompare() with Triple::oper

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes This reapplies [Replace ArchSpec::PiecewiseCompare() with Triple::operator==()](https://github.com/llvm/llvm-project/commit/5c9e53d45ba948b8a5e8416aa9b3322c87fc46c8), with an additional fix in debugser

[Lldb-commits] [lldb] Change debugserver to report the cpu(sub)type of process, not the host. (PR #82938)

https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/82938 This reapplies [Replace ArchSpec::PiecewiseCompare() with Triple::operator==()](https://github.com/llvm/llvm-project/commit/5c9e53d45ba948b8a5e8416aa9b3322c87fc46c8), with an additional fix in debugserver.