[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/83941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d93a126 - [lldb] Add ability to detect darwin host linker version to xfail tests (#83941)

2024-03-07 Thread via lldb-commits
Author: Alex Langford Date: 2024-03-07T18:04:42-05:00 New Revision: d93a126090b6e772d3b96f201cdd44ea0d6360ef URL: https://github.com/llvm/llvm-project/commit/d93a126090b6e772d3b96f201cdd44ea0d6360ef DIFF: https://github.com/llvm/llvm-project/commit/d93a126090b6e772d3b96f201cdd44ea0d6360ef.diff

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Saleem Abdulrasool via lldb-commits
@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator std::s

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Hiroshi Yamauchi via lldb-commits
@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator std::s

[Lldb-commits] [lldb] [PAC][lldb][Dwarf] Support `__ptrauth`-qualified types in user expressions (PR #84387)

2024-03-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Daniil Kovalev (kovdan01) Changes Depends on #84384 This adds support for `DW_TAG_LLVM_ptrauth_type` entries corresponding to explicitly signed types (e.g. free function pointers) in lldb user expressions. Applies PR https://github.com/app

[Lldb-commits] [lldb] [PAC][lldb][Dwarf] Support `__ptrauth`-qualified types in user expressions (PR #84387)

2024-03-07 Thread Daniil Kovalev via lldb-commits
https://github.com/kovdan01 ready_for_review https://github.com/llvm/llvm-project/pull/84387 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Change GetNumChildren()/CalculateNumChildren() methods return llvm::Expected (PR #84219)

2024-03-07 Thread via lldb-commits
jimingham wrote: > > I would say this differently. Many clients of the GetNumChildren API are > > planning to respond the same way to an error and a number of children == 0. > > I haven't done a complete audit, but my expectation for this patch is that > the vast majority of users of this API

[Lldb-commits] [lldb] [PAC][lldb][Dwarf] Support `__ptrauth`-qualified types in user expressions (PR #84387)

2024-03-07 Thread Daniil Kovalev via lldb-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/84387 >From 728f5644aebfafd2114e7e47a9b83ef057423997 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 20 Feb 2024 10:57:54 -0800 Subject: [PATCH 1/4] Upstream ptrauth changes to DWARFASTParserClang --- ..

[Lldb-commits] [lldb] [PAC][lldb][Dwarf] Support `__ptrauth`-qualified types in user expressions (PR #84387)

2024-03-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9cf9cb271bf86bda4996be9a31fa413381f2f5e3 8d05d535a1c9f091e5c90af0a2e6969c57e26405 --

[Lldb-commits] [lldb] [PAC][lldb][Dwarf] Support `__ptrauth`-qualified types in user expressions (PR #84387)

2024-03-07 Thread Daniil Kovalev via lldb-commits
https://github.com/kovdan01 created https://github.com/llvm/llvm-project/pull/84387 Depends on #84384 This adds support for `DW_TAG_LLVM_ptrauth_type` entries corresponding to explicitly signed types (e.g. free function pointers) in lldb user expressions. Applies PR https://github.com/apple/ll

[Lldb-commits] [lldb] [lldb][test] Enforce `pexpect` system availability by default (PR #84270)

2024-03-07 Thread Daniel Thornburgh via lldb-commits
mysterymath wrote: > @mysterymath do you run the API test suites with that custom python, i.e. > `ninja check-lldb-api`? If so, would you be able to add bundle `pexpect` for > your tests even if it's not in what you ship? We do run the tests with the Python we ship, since we don't have direct

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. looks good https://github.com/llvm/llvm-project/pull/83941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/83941 >From 89d1c201636403bb26f12cf9681cbaf86b5c943b Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Mon, 4 Mar 2024 14:17:20 -0800 Subject: [PATCH] [lldb] Add ability to detect darwin host linker version to xfai

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Alex Langford via lldb-commits
@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator std::s

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r a41226b05510a6f40d99fc622d78853460dc5599...a72d9d259b441c338399340d630ed7a64c1e228a lldb/

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/83941 >From a72d9d259b441c338399340d630ed7a64c1e228a Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Mon, 4 Mar 2024 14:17:20 -0800 Subject: [PATCH] [lldb] Add ability to detect darwin host linker version to xfai

[Lldb-commits] [lldb] [lldb] Add ability to detect darwin host linker version to xfail tests (PR #83941)

2024-03-07 Thread Dave Lee via lldb-commits
@@ -333,3 +335,41 @@ def expectedCompiler(compilers): return True return False + + +# This is a helper function to determine if a specific version of Xcode's linker +# contains a TLS bug. We want to skip TLS tests if they contain this bug, but +# adding a link

[Lldb-commits] [lldb] ecf7db8 - [lldb] Disable shell tests affected by ld_new bug (#84246)

2024-03-07 Thread via lldb-commits
Author: Dave Lee Date: 2024-03-07T12:55:13-08:00 New Revision: ecf7db8b52d7061ef8f14c1f7b6fcc370072d087 URL: https://github.com/llvm/llvm-project/commit/ecf7db8b52d7061ef8f14c1f7b6fcc370072d087 DIFF: https://github.com/llvm/llvm-project/commit/ecf7db8b52d7061ef8f14c1f7b6fcc370072d087.diff LOG:

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Change GetNumChildren()/CalculateNumChildren() methods return llvm::Expected (PR #84219)

2024-03-07 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > I would say this differently. Many clients of the GetNumChildren API are > planning to respond the same way to an error and a number of children == 0. I haven't done a complete audit, but my expectation for this patch is that the vast majority of users of this API will

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 🚀 https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do some gardening in ProgressReportTest (NFC) (PR #84278)

2024-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/84278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4586366 - [lldb] Do some gardening in ProgressReportTest (NFC) (#84278)

2024-03-07 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-03-07T12:41:06-08:00 New Revision: 458636690afdd223ffa72f49164f30449b588892 URL: https://github.com/llvm/llvm-project/commit/458636690afdd223ffa72f49164f30449b588892 DIFF: https://github.com/llvm/llvm-project/commit/458636690afdd223ffa72f49164f30449b588892.d

[Lldb-commits] [lldb] [lldb] Do some gardening in ProgressReportTest (NFC) (PR #84278)

2024-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/84278 >From 8b85a2dd23e29cd9eca807d70ffb95bc4b1dcc82 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 6 Mar 2024 21:54:45 -0800 Subject: [PATCH] [lldb] Do some gardening in ProgressReportTest (NFC) -

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/84246 >From 1fb13a2d034dbea1d1ba2ef87354199a815f3788 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Mar 2024 14:23:05 -0800 Subject: [PATCH 1/3] [lldb] Disable shell tests affected by ld64 bug --- lldb/test

[Lldb-commits] [lldb] [lldb][test] Enforce `pexpect` system availability by default (PR #84270)

2024-03-07 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: @mysterymath do you run the API test suites with that custom python, i.e. `ninja check-lldb-api`? If so, would you be able to add bundle `pexpect` for your tests even if it's not in what you ship? The goal is to be able to delete https://github.com/llvm/llvm-project/tree/main

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Saleem Abdulrasool via lldb-commits
@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator std::s

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Hiroshi Yamauchi via lldb-commits
hjyamauchi wrote: CC @compnerd https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Hiroshi Yamauchi via lldb-commits
hjyamauchi wrote: CC @compnerd https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Enforce `pexpect` system availability by default (PR #84270)

2024-03-07 Thread Daniel Thornburgh via lldb-commits
mysterymath wrote: Chiming in on behalf of Fuchsia, since this did break us. We build and ship a custom Python with our LLDB, since we're intended to be a portable distribution. That Python doesn't have pexpect. I'm not very familiar with what pexpect is used for, or the states of the world b

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Hiroshi Yamauchi via lldb-commits
hjyamauchi wrote: This demonstrates the Clang vs MSVC behavior difference: https://godbolt.org/z/GvsdEM5r7 https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: LGTM with the check behind `if platform.system() == "Darwin"`. https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Jonas Devlieghere via lldb-commits
@@ -179,3 +180,14 @@ def calculate_arch_features(arch_string): if "LD_PRELOAD" in os.environ: config.available_features.add("ld_preload-present") + JDevlieghere wrote: I think that's obvious to us, but someone not familiar with our platform might wonder

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Hiroshi Yamauchi (hjyamauchi) Changes MSVC fails when there is ambiguity (multiple options) around implicit type conversion operators. Make ConstString's conversion operator to string_view explicit to avoid ambiguity with one to StringRef

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Hiroshi Yamauchi via lldb-commits
https://github.com/hjyamauchi created https://github.com/llvm/llvm-project/pull/84362 MSVC fails when there is ambiguity (multiple options) around implicit type conversion operators. Make ConstString's conversion operator to string_view explicit to avoid ambiguity with one to StringRef and re

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
@@ -179,3 +180,14 @@ def calculate_arch_features(arch_string): if "LD_PRELOAD" in os.environ: config.available_features.add("ld_preload-present") + +# Determine if a specific version of Xcode's linker contains a bug. We want to +# skip affected tests if they contain this b

[Lldb-commits] [lldb] 7fc583c - Change Get|SetNumChildren to use unint32_t

2024-03-07 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-03-07T10:58:34-08:00 New Revision: 7fc583c9a5ddf447b2b53007778cb034a186d4b5 URL: https://github.com/llvm/llvm-project/commit/7fc583c9a5ddf447b2b53007778cb034a186d4b5 DIFF: https://github.com/llvm/llvm-project/commit/7fc583c9a5ddf447b2b53007778cb034a186d4b5.diff

[Lldb-commits] [lldb] Change the return type of CalculateNumChildren to uint32_t. (PR #83501)

2024-03-07 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Merged in https://github.com/llvm/llvm-project/commit/e710523e408ce64c15fddf9f7dbe1248795c20d7 https://github.com/llvm/llvm-project/pull/83501 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] Change the return type of CalculateNumChildren to uint32_t. (PR #83501)

2024-03-07 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/83501 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Change GetNumChildren()/CalculateNumChildren() methods return llvm::Expected (PR #84219)

2024-03-07 Thread via lldb-commits
jimingham wrote: I would say this differently. Many clients of the GetNumChildren API are planning to respond the same way to an error and a number of children == 0. Having to embed this "i'm not actually checking the error, I'm just converting it to num-children = 0" snippet looks odd, like

[Lldb-commits] [lldb] e710523 - Change GetChildAtIndex to take a uint32_t

2024-03-07 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-03-07T10:55:02-08:00 New Revision: e710523e408ce64c15fddf9f7dbe1248795c20d7 URL: https://github.com/llvm/llvm-project/commit/e710523e408ce64c15fddf9f7dbe1248795c20d7 DIFF: https://github.com/llvm/llvm-project/commit/e710523e408ce64c15fddf9f7dbe1248795c20d7.diff

[Lldb-commits] [lldb] 3d7c5b8 - Change the return type of SyntheticFrontend::CalculateNumChildren to int32_t

2024-03-07 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-03-07T10:55:02-08:00 New Revision: 3d7c5b80e38b01223811eb557a5e9953cfa2154d URL: https://github.com/llvm/llvm-project/commit/3d7c5b80e38b01223811eb557a5e9953cfa2154d DIFF: https://github.com/llvm/llvm-project/commit/3d7c5b80e38b01223811eb557a5e9953cfa2154d.diff

[Lldb-commits] [lldb] 54c955b - Change the return type of ValueObject::CalculateNumChildren to uint32_t.

2024-03-07 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-03-07T10:55:02-08:00 New Revision: 54c955b828bbdcf46586556339cbd3cf8f205b4f URL: https://github.com/llvm/llvm-project/commit/54c955b828bbdcf46586556339cbd3cf8f205b4f DIFF: https://github.com/llvm/llvm-project/commit/54c955b828bbdcf46586556339cbd3cf8f205b4f.diff

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
kastiglione wrote: I think this should be merged, and if either end of the version range proves to be too limited, we can increase the range. https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] Change GetNumChildren()/CalculateNumChildren() methods return llvm::Expected (PR #84219)

2024-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. I'm worried about making it too easy to ignore errors. The whole point of the llvm::Error class is that you have to check it. There might be a legitimate reason you don't about the error the call site, but it should very ex

[Lldb-commits] [lldb] Change the return type of CalculateNumChildren to uint32_t. (PR #83501)

2024-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 🚢 it! https://github.com/llvm/llvm-project/pull/83501 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Alex Langford via lldb-commits
bulbazord wrote: > Called it `ld_new-bug`. If it's not the TLS bug, I wonder if the version > range is correct. The TLS bug in the new linker is explicitly from versions 1000 to 1109. If this isn't related to TLS, we'll need to confirm with the linker folks on our side. https://github.com/llv

[Lldb-commits] [lldb] [lldb] Minor cleanup in StoringDiagnosticConsumer (PR #84263)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/84263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6515930 - [lldb] Minor cleanup in StoringDiagnosticConsumer (#84263)

2024-03-07 Thread via lldb-commits
Author: Dave Lee Date: 2024-03-07T10:13:14-08:00 New Revision: 6515930b0cc4aa2e11e75728ef6cbeecbe5caec2 URL: https://github.com/llvm/llvm-project/commit/6515930b0cc4aa2e11e75728ef6cbeecbe5caec2 DIFF: https://github.com/llvm/llvm-project/commit/6515930b0cc4aa2e11e75728ef6cbeecbe5caec2.diff LOG:

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld_new bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld64 bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
kastiglione wrote: Called it `ld_new-bug`. If it's not the TLS bug, I wonder if the version range is correct. https://github.com/llvm/llvm-project/pull/84246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld64 bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/84246 >From 1fb13a2d034dbea1d1ba2ef87354199a815f3788 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Mar 2024 14:23:05 -0800 Subject: [PATCH 1/2] [lldb] Disable shell tests affected by ld64 bug --- lldb/test

[Lldb-commits] [lldb] [lldb] Do some gardening in ProgressReportTest (NFC) (PR #84278)

2024-03-07 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/84278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't report all progress event as completed. (PR #84281)

2024-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/84281 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ea49e04 - [lldb] Don't report all progress event as completed. (#84281)

2024-03-07 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-03-07T09:55:00-08:00 New Revision: ea49e04b35bc8e4bed7ee4db4074d201f780a15c URL: https://github.com/llvm/llvm-project/commit/ea49e04b35bc8e4bed7ee4db4074d201f780a15c DIFF: https://github.com/llvm/llvm-project/commit/ea49e04b35bc8e4bed7ee4db4074d201f780a15c.d

[Lldb-commits] [lldb] Report back errors in GetNumChildren() (PR #84265)

2024-03-07 Thread via lldb-commits
jimingham wrote: >From looking at the code, it seems like there are two clear classes of users, >those that need to check the error, and those that, in the error case, 0 is >just as good as the error. The latter appears not infrequently as: `llvm::expectedToStdOptional(value_sp->GetNumChildre

[Lldb-commits] [lldb] Fix vfork test strcmp buildbot failure (PR #84224)

2024-03-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes The buildbot seems to complain about `strcmp` function not available in the vfork patch (https://github.com/llvm/llvm-project/pull/81564): https://lab.llvm.org/buildbot/#/builders/68/builds/70093/steps/6/logs/std

[Lldb-commits] [lldb] Fix vfork test strcmp buildbot failure (PR #84224)

2024-03-07 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/84224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 36f866c - Fix vfork test strcmp buildbot failure (#84224)

2024-03-07 Thread via lldb-commits
Author: jeffreytan81 Date: 2024-03-07T09:37:27-08:00 New Revision: 36f866c6ec3f6671fd4178ed4e49fd632a335cc2 URL: https://github.com/llvm/llvm-project/commit/36f866c6ec3f6671fd4178ed4e49fd632a335cc2 DIFF: https://github.com/llvm/llvm-project/commit/36f866c6ec3f6671fd4178ed4e49fd632a335cc2.diff

[Lldb-commits] [lldb] Fix vfork test strcmp buildbot failure (PR #84224)

2024-03-07 Thread via lldb-commits
jeffreytan81 wrote: I guess it is no harm to land it. https://github.com/llvm/llvm-project/pull/84224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix vfork test strcmp buildbot failure (PR #84224)

2024-03-07 Thread via lldb-commits
https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/84224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Allow languages to filter breakpoints set by line (PR #83908)

2024-03-07 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: address review comments from Adrian. I think I have a better name for the target option and language method now https://github.com/llvm/llvm-project/pull/83908 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] [lldb] Allow languages to filter breakpoints set by line (PR #83908)

2024-03-07 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/83908 >From 51307b548d09c34ee06037ccf459110e451970a9 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 4 Mar 2024 09:56:18 -0800 Subject: [PATCH 1/4] [lldb] Allow languages to filter breakpoin

[Lldb-commits] [lldb] [lldb] Don't report all progress event as completed. (PR #84281)

2024-03-07 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/84281 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't report all progress event as completed. (PR #84281)

2024-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/84281 >From 57908c4924fbb339309e2a4c297178b2a3689bef Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 6 Mar 2024 22:28:14 -0800 Subject: [PATCH] [lldb] Don't report all progress event as completed. Cur

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld64 bug (PR #84246)

2024-03-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I was just wondering, is this actually the TLS bug? I looked at the test and I don't see it doing anything with thread local storage. This might be another "new ld" bug. Maybe the feature should be called `ld-prime-bug`? https://github.com/llvm/llvm-project/pull/84246

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld64 bug (PR #84246)

2024-03-07 Thread Dave Lee via lldb-commits
@@ -179,3 +180,14 @@ def calculate_arch_features(arch_string): if "LD_PRELOAD" in os.environ: config.available_features.add("ld_preload-present") + kastiglione wrote: my thinking is that the darwin check is baked into the invocation of xcrun. If you thin

[Lldb-commits] [lldb] [lldb] Don't report all progress event as completed. (PR #84281)

2024-03-07 Thread Adrian Prantl via lldb-commits
@@ -110,20 +110,22 @@ void ProgressManager::Decrement(const Progress::ProgressData &progress_data) { return; if (pos->second.first <= 1) { -ReportProgress(pos->second.second); +ReportProgress(pos->second.second, EventType::End); m_progress_category_map.eras

[Lldb-commits] [lldb] [lldb] Disable shell tests affected by ld64 bug (PR #84246)

2024-03-07 Thread Adrian Prantl via lldb-commits
@@ -179,3 +180,14 @@ def calculate_arch_features(arch_string): if "LD_PRELOAD" in os.environ: config.available_features.add("ld_preload-present") + adrian-prantl wrote: I guess it fails gracefully, but should this check whether we're on Darwin first? ht

[Lldb-commits] [lldb] [lldb] Minor cleanup in StoringDiagnosticConsumer (PR #84263)

2024-03-07 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/84263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 03588a2 - [lldb][test][FreeBSD] xfail TestPlatformConnect on AArch64

2024-03-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-03-07T14:54:30Z New Revision: 03588a27261f7ebea15af49268d2ec901fe1979e URL: https://github.com/llvm/llvm-project/commit/03588a27261f7ebea15af49268d2ec901fe1979e DIFF: https://github.com/llvm/llvm-project/commit/03588a27261f7ebea15af49268d2ec901fe1979e.diff LOG

[Lldb-commits] [lldb] [lldb][test] Enforce `pexpect` system availability by default (PR #84270)

2024-03-07 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/84270 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3239b4d - [lldb][test] Enforce `pexpect` system availability by default (#84270)

2024-03-07 Thread via lldb-commits
Author: Jordan Rupprecht Date: 2024-03-07T08:53:18-06:00 New Revision: 3239b4dcfebbaa3eeaff9258893a6674050d8354 URL: https://github.com/llvm/llvm-project/commit/3239b4dcfebbaa3eeaff9258893a6674050d8354 DIFF: https://github.com/llvm/llvm-project/commit/3239b4dcfebbaa3eeaff9258893a6674050d8354.di

[Lldb-commits] [clang] [lldb] [NFC][Clang] Improve const correctness for IdentifierInfo (PR #79365)

2024-03-07 Thread via lldb-commits
cor3ntin wrote: @bwendling feel free to fix the conflicts and merge https://github.com/llvm/llvm-project/pull/79365 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Address mask sbprocess apis and new mask invalid const (PR #83663)

2024-03-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: We could have ABI plugins limit the mask to the known maximum address size, or set all the upper bits to 1. Though I think `0...0` is less confusing. But it's only fixing what you might call a visual issue, the mask will have upper 32 bits preserved, but at runtime no addr