[Lldb-commits] [lldb] [lldb] Fix dwim-print to not delete non-result persistent variables (PR #85152)

2024-03-13 Thread via lldb-commits
@@ -170,6 +170,14 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, ExpressionResults expr_result = target.EvaluateExpression( expr, exe_scope, valobj_sp, eval_options, &fixed_expression); +auto persistent_name = valobj_sp->GetName(); +// Evaluat

[Lldb-commits] [lldb] [lldb] Fix dwim-print to not delete non-result persistent variables (PR #85152)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/85152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix dwim-print to not delete non-result persistent variables (PR #85152)

2024-03-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/85152.diff 2 Files Affected: - (modified) lldb/source/Commands/CommandObjectDWIMPrint.cpp (+10-2) - (modified) lldb/test/API/commands/dwim-print/Te

[Lldb-commits] [lldb] [lldb] Fix dwim-print to not delete non-result persistent variables (PR #85152)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/85152 None >From 970cf82fa3d64c5a4e1b3929c110b42974ef13cd Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 13 Mar 2024 14:49:23 -0700 Subject: [PATCH] [lldb] Fix dwim-print to not delete non-result persistent v

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Thanks for all the helpful comments as always, David. I updated the test case to fix the issues you identified and added comments that I think make it clearer that it is testing both a live process and a corefile. https://github.com/llvm/llvm-project/pull/84998

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/84998 >From 4278537c262b01b1d6432391bd9d8017eb96c60a Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 12 Mar 2024 17:09:30 -0700 Subject: [PATCH 1/2] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data

[Lldb-commits] [lldb] [lldb] Skip TestIndirectSymbols (PR #85133)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/85133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b49d741 - [lldb] Skip TestIndirectSymbols (#85133)

2024-03-13 Thread via lldb-commits
Author: Dave Lee Date: 2024-03-13T14:15:41-07:00 New Revision: b49d741c0c3bb21b40c925b4c1a717470181eb8d URL: https://github.com/llvm/llvm-project/commit/b49d741c0c3bb21b40c925b4c1a717470181eb8d DIFF: https://github.com/llvm/llvm-project/commit/b49d741c0c3bb21b40c925b4c1a717470181eb8d.diff LOG:

[Lldb-commits] [lldb] [lldb] Skip TestIndirectSymbols (PR #85133)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/85133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Skip TestIndirectSymbols (PR #85133)

2024-03-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes Correction to cb8f3837e2311c369ef24a077a0c34e4ff56c08f --- Full diff: https://github.com/llvm/llvm-project/pull/85133.diff 1 Files Affected: - (modified) lldb/test/API/macosx/indirect_symbol/TestIndirectSy

[Lldb-commits] [lldb] [lldb] Skip TestIndirectSymbols (PR #85133)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/85133 Correction to cb8f3837e2311c369ef24a077a0c34e4ff56c08f >From f5fb7236ad4df2fe9322ab00e4839e92ef29a8d3 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 13 Mar 2024 14:09:20 -0700 Subject: [PATCH] [lldb] Sk

[Lldb-commits] [lldb] [lldb] XFAIL TestIndirectSymbols on darwin (PR #85127)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/85127 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e2b8cc1 - [lldb] XFAIL TestIndirectSymbols on darwin (#85127)

2024-03-13 Thread via lldb-commits
Author: Dave Lee Date: 2024-03-13T13:34:01-07:00 New Revision: e2b8cc11b307aaf2717c344cbaa1d3eb5a4e0401 URL: https://github.com/llvm/llvm-project/commit/e2b8cc11b307aaf2717c344cbaa1d3eb5a4e0401 DIFF: https://github.com/llvm/llvm-project/commit/e2b8cc11b307aaf2717c344cbaa1d3eb5a4e0401.diff LOG:

[Lldb-commits] [lldb] [lldb] XFAIL TestIndirectSymbols on darwin (PR #85127)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/85127 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] XFAIL TestIndirectSymbols on darwin (PR #85127)

2024-03-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/85127.diff 1 Files Affected: - (modified) lldb/test/API/macosx/indirect_symbol/TestIndirectSymbols.py (+1) ``diff diff --git a/lldb/test/

[Lldb-commits] [lldb] [lldb] XFAIL TestIndirectSymbols on darwin (PR #85127)

2024-03-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/85127 None >From 5d0a5c8721766544067ccd8e169a5e2effeba981 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 13 Mar 2024 13:30:20 -0700 Subject: [PATCH] [lldb] XFAIL TestIndirectSymbols on darwin --- lldb/test/A

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-13 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/84860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8bed754 - [lldb][test] Add `pexpect` category for tests that `import pexpect` (#84860)

2024-03-13 Thread via lldb-commits
Author: Jordan Rupprecht Date: 2024-03-13T15:16:15-05:00 New Revision: 8bed754c2f965c8cbbb050be6f650b78f7fd78a6 URL: https://github.com/llvm/llvm-project/commit/8bed754c2f965c8cbbb050be6f650b78f7fd78a6 DIFF: https://github.com/llvm/llvm-project/commit/8bed754c2f965c8cbbb050be6f650b78f7fd78a6.di

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-13 Thread Daniel Thornburgh via lldb-commits
https://github.com/mysterymath approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/84860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. +1 https://github.com/llvm/llvm-project/pull/84860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Avoid a potential exit(1) in LLVMContext::diagnose() (PR #84992)

2024-03-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/84992 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c3eccf0 - Avoid a potential exit(1) in LLVMContext::diagnose() (#84992)

2024-03-13 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-03-13T08:53:13-07:00 New Revision: c3eccf03b365a705bc8dc043217478a82bc37a4d URL: https://github.com/llvm/llvm-project/commit/c3eccf03b365a705bc8dc043217478a82bc37a4d DIFF: https://github.com/llvm/llvm-project/commit/c3eccf03b365a705bc8dc043217478a82bc37a4d.diff

[Lldb-commits] [lldb] [LLDB] Add lldb-python-scripts to the things installed on Linux. (PR #85080)

2024-03-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/85080 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4e49ee5 - [lldb][Test] Disable ConcurrentVFork tests on Arm/AArch64 Linux

2024-03-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-03-13T14:30:40Z New Revision: 4e49ee55c587637e17dec7a72b9ce86d85f8f241 URL: https://github.com/llvm/llvm-project/commit/4e49ee55c587637e17dec7a72b9ce86d85f8f241 DIFF: https://github.com/llvm/llvm-project/commit/4e49ee55c587637e17dec7a72b9ce86d85f8f241.diff LOG

[Lldb-commits] [lldb] eb21ee4 - [lldb][test] Disable other runlocker test on AArch64 Linux

2024-03-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-03-13T14:15:30Z New Revision: eb21ee49cff081911d99d29ba887c1715fc2b8fc URL: https://github.com/llvm/llvm-project/commit/eb21ee49cff081911d99d29ba887c1715fc2b8fc DIFF: https://github.com/llvm/llvm-project/commit/eb21ee49cff081911d99d29ba887c1715fc2b8fc.diff LOG

[Lldb-commits] [lldb] [LLDB] Add lldb-python-scripts to the things installed on Linux. (PR #85080)

2024-03-13 Thread Alastair Houghton via lldb-commits
al45tair wrote: This is a cherry pick of https://github.com/apple/llvm-project/pull/8257. https://github.com/llvm/llvm-project/pull/85080 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [LLDB] Add lldb-python-scripts to the things installed on Linux. (PR #85080)

2024-03-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alastair Houghton (al45tair) Changes We should be installing the python scripts here. rdar://123436512 --- Full diff: https://github.com/llvm/llvm-project/pull/85080.diff 1 Files Affected: - (modified) lldb/cmake/caches/Apple-lldb-Linux

[Lldb-commits] [lldb] [LLDB] Add lldb-python-scripts to the things installed on Linux. (PR #85080)

2024-03-13 Thread Alastair Houghton via lldb-commits
https://github.com/al45tair created https://github.com/llvm/llvm-project/pull/85080 We should be installing the python scripts here. rdar://123436512 >From 87d1f8011683499d6c225c1b855cec4c10dbb70e Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Thu, 22 Feb 2024 11:49:30 + Subject:

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-03-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This extends the existing register fields support from AArch64 Linux to AArch64 FreeBSD. So you will now see output like this: ``` (lldb) register read cpsr cpsr = 0x6200 = (N = 0, Z =

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-03-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is a stacked PR, the first two commits are https://github.com/llvm/llvm-project/pull/84147 and https://github.com/llvm/llvm-project/pull/85057. https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/85058 This extends the existing register fields support from AArch64 Linux to AArch64 FreeBSD. So you will now see output like this: ``` (lldb) register read cpsr cpsr = 0x6200 = (N = 0, Z = 1, C

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

2024-03-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Doing this in its own commit so the intent of the previous change is clearer. --- Full diff: https://github.com/llvm/llvm-project/pull/85057.diff 1 Files Affected: - (modified) lldb/source/Plugins/P

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

2024-03-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is a stacked PR, first commit here is https://github.com/llvm/llvm-project/pull/84147. https://github.com/llvm/llvm-project/pull/85057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

2024-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/85057 Doing this in its own commit so the intent of the previous change is clearer. >From a251b494614a0700f424c2bedebcabd2e053a653 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 6 Mar 2024 09:08:25 +00

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,13 @@ +#include +#include +union ptrbytes { + int *p; + uint8_t bytes[8]; +}; DavidSpickett wrote: I like this way of avoiding shifts. https://github.com/llvm/llvm-project/pull/84998 ___ lldb-commits mai

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,49 @@ +"""Test that lldb on Darwin ignores metadata in the top byte of addresses.""" + +import os +import re +import subprocess + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,49 @@ +"""Test that lldb on Darwin ignores metadata in the top byte of addresses.""" DavidSpickett wrote: Oh I get it, you're running a process first then making a core file and expecting to get the same output. This needs to be made clear at the top

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,49 @@ +"""Test that lldb on Darwin ignores metadata in the top byte of addresses.""" + +import os +import re +import subprocess + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,49 @@ +"""Test that lldb on Darwin ignores metadata in the top byte of addresses.""" + +import os +import re +import subprocess + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,49 @@ +"""Test that lldb on Darwin ignores metadata in the top byte of addresses.""" DavidSpickett wrote: addresses in core files. Also the filename should have core somewhere in it. https://github.com/llvm/llvm-project/pull/84998 ___