github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6aa53888a8e8a6e3f0bd279539703f4d4701b4e7
d69497fc66ce092fd75fcbe7c64460a49a6e2172 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
This patch adds support for the new foreign type unit support in .debug_names.
Features include:
- don't manually index foreign TUs if we have info for them
- only use the type unit entries that match the
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/87740
This patch adds support for the new foreign type unit support in .debug_names.
Features include:
- don't manually index foreign TUs if we have info for them
- only use the type unit entries that match the .dwo
@@ -553,9 +553,9 @@ bool ClangUserExpression::PrepareForParsing(
}
bool ClangUserExpression::TryParse(
-DiagnosticManager _manager, ExecutionContextScope *exe_scope,
-ExecutionContext _ctx, lldb_private::ExecutionPolicy execution_policy,
-bool
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/87657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/87657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -553,9 +553,9 @@ bool ClangUserExpression::PrepareForParsing(
}
bool ClangUserExpression::TryParse(
-DiagnosticManager _manager, ExecutionContextScope *exe_scope,
-ExecutionContext _ctx, lldb_private::ExecutionPolicy execution_policy,
-bool
rastogishubham wrote:
To make sure green dragon stays green, I reverted this change with
ca55ee88263e5b190965c3f14fd3b2647efab26a
https://github.com/llvm/llvm-project/pull/87676
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: Shubham Rastogi
Date: 2024-04-04T15:37:07-07:00
New Revision: ca55ee88263e5b190965c3f14fd3b2647efab26a
URL:
https://github.com/llvm/llvm-project/commit/ca55ee88263e5b190965c3f14fd3b2647efab26a
DIFF:
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/87540
>From 5234f6873d894dd80b2c1fef40fd18e4b722a2c9 Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 3 Apr 2024 11:31:06 -0700
Subject: [PATCH 1/2] [lldb] fix dead lock in TypeCategoryMap.cpp
https://github.com/v-bulle edited
https://github.com/llvm/llvm-project/pull/87540
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_EXPORTED_SYMBOLS
cyndyishida wrote:
Would
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_EXPORTED_SYMBOLS
JDevlieghere wrote:
"tools" has a pretty specific meaning for
@@ -654,6 +654,11 @@ enabled sub-projects. Nearly all of these variable names
begin with
Generate dSYM files and strip executables and libraries (Darwin Only).
Defaults to OFF.
+**LLVM_ENABLE_EXPORTED_SYMBOLS**:BOOL
+ When building executables, preserve symbol exports.
JDevlieghere wrote:
Alright, so this happens when `listener` in `TypeCategoryMap` is the
`TypeCategory`. Please update the commit message and add a comment before the
call to `Changed` to say why we're doing it outside the scope of the lock. With
those changes this should be good to go.
@@ -654,6 +654,11 @@ enabled sub-projects. Nearly all of these variable names
begin with
Generate dSYM files and strip executables and libraries (Darwin Only).
Defaults to OFF.
+**LLVM_ENABLE_EXPORTED_SYMBOLS**:BOOL
+ When building executables, preserve symbol exports.
https://github.com/delcypher requested changes to this pull request.
Generally looks good. I have some minor nits. I'd like to see
`LLVM_ENABLE_EXPORTED_SYMBOLS` renamed to avoid ambiguity.
https://github.com/llvm/llvm-project/pull/87684
___
@@ -654,6 +654,11 @@ enabled sub-projects. Nearly all of these variable names
begin with
Generate dSYM files and strip executables and libraries (Darwin Only).
Defaults to OFF.
+**LLVM_ENABLE_EXPORTED_SYMBOLS**:BOOL
+ When building executables, preserve symbol exports.
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_EXPORTED_SYMBOLS
delcypher wrote:
We may want to rename this. The name hints
https://github.com/delcypher edited
https://github.com/llvm/llvm-project/pull/87684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
gulfemsavrun wrote:
It also broke our toolchain builders:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8751560900790274577/overview
https://github.com/llvm/llvm-project/pull/87676
___
lldb-commits mailing list
rastogishubham wrote:
Hi @kevinfrei it seems like this patch broke greendragon
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/812/
https://github.com/llvm/llvm-project/pull/87676
___
lldb-commits mailing list
@@ -553,9 +553,9 @@ bool ClangUserExpression::PrepareForParsing(
}
bool ClangUserExpression::TryParse(
-DiagnosticManager _manager, ExecutionContextScope *exe_scope,
-ExecutionContext _ctx, lldb_private::ExecutionPolicy execution_policy,
-bool
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_NO_EXPORTED_SYMBOLS
jroelofs wrote:
Flags like this shouldn't have `DISABLE` in
jimingham wrote:
lldb can and does present its external symbol interface through LLDB.framework.
I can't see any reason why it would also need to export symbols from the
executable. The lldb driver is just a fairly small convenience wrapper around
the API's from LLDB.framework, its job is
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_NO_EXPORTED_SYMBOLS
cyndyishida wrote:
No preference here. Whatever seems easier
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/87684
>From 3ac6872328334384fa20998541fac841add767d9 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 4 Apr 2024 12:08:28 -0700
Subject: [PATCH 1/2] [cmake] Build executables with -no_exported_symbols when
kastiglione wrote:
Thanks for adding this! I've been using `CMAKE_EXE_LINKER_FLAGS` to
`-Wl,-no_exported_symbols`, and have had no problems.
https://github.com/llvm/llvm-project/pull/87684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_NO_EXPORTED_SYMBOLS
kastiglione wrote:
should the name reflect the opposite of
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_NO_EXPORTED_SYMBOLS
jroelofs wrote:
The double negative is confusing. Maybe
Author: Kevin Frei
Date: 2024-04-04T11:43:55-07:00
New Revision: d6713ad80d6907210c629f22babaf12177fa329c
URL:
https://github.com/llvm/llvm-project/commit/d6713ad80d6907210c629f22babaf12177fa329c
DIFF:
https://github.com/llvm/llvm-project/commit/d6713ad80d6907210c629f22babaf12177fa329c.diff
31 matches
Mail list logo
