vvereschaka wrote:
Hi @Endilll ,
these changes break MSVC build of the projects including LLDB. The `cl`
compiler gets unsupported gcc/clang options, such as
`-Wno-deprecated-declarations`, `-Wno-unknown-pragmas` and
`-Wno-strict-aliasing`, and gets failed because of it.
Here is the command
royitaqi wrote:
Just curious, @gulfemsavrun , how were you able to merge without another
person's approval of the PR? I'm noob to github pull request - thought revert
PR are the same as other PRs and need an approval, but reading this PR it seems
such step isn't required.
royitaqi wrote:
@gulfemsavrun
The fix PR is ready, as linked in the above
(https://github.com/llvm/llvm-project/pull/94067). I just need someone to
approve it and merge it.
I'm quite new to this process. Is reverting also require someone to approve a
revert PR and merge it? Or is it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (gulfemsavrun)
Changes
Reverts llvm/llvm-project#92843 because it broke some lldb tests:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8746385730949743489/overview
---
Full diff:
Author: gulfemsavrun
Date: 2024-05-31T20:06:18-07:00
New Revision: 85fd1688b2fc73ba97d95e621cfbfe9a3fff
URL:
https://github.com/llvm/llvm-project/commit/85fd1688b2fc73ba97d95e621cfbfe9a3fff
DIFF:
https://github.com/llvm/llvm-project/commit/85fd1688b2fc73ba97d95e621cfbfe9a3fff.diff
https://github.com/gulfemsavrun closed
https://github.com/llvm/llvm-project/pull/94088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/gulfemsavrun created
https://github.com/llvm/llvm-project/pull/94088
Reverts llvm/llvm-project#92843 because it broke some lldb tests:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8746385730949743489/overview
>From
gulfemsavrun wrote:
Can you please revert the patch if it's going to take a while to land the fix
because I don't want our builders to stay red over the weekend?
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/94067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
royitaqi wrote:
FWIW, it's easier to [see the fix this
way](https://github.com/royitaqi/llvm-project/compare/enhance-transcript-2...royitaqi:llvm-project:enhance-transcript-3).
<-- This is the delta of `royitaqi:enhance-transcript-3` on top of
`royitaqi:enhance-transcript-2` (which has been
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/94067
>From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 20 May 2024 22:30:40 -0400
Subject: [PATCH 01/13] Add resolvedCommand to transcript, add transcript to
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/94007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
@@ -45,6 +45,38 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very limited API, lldb will
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/94067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -177,7 +177,8 @@ def test_get_transcript(self):
# (lldb) r
self.assertEqual(transcript[3]["command"], "r")
self.assertEqual(transcript[3]["commandName"], "process launch")
-self.assertEqual(transcript[3]["commandArguments"], "-X true --")
+
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/94007
>From e024ea45c052411f2e7284c0ef5a6d048681cad7 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Fri, 31 May 2024 11:29:27 -0700
Subject: [PATCH 1/2] Add doc strings for SBValue::IsValid and
SBValue::GetError.
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
@@ -177,7 +177,8 @@ def test_get_transcript(self):
# (lldb) r
self.assertEqual(transcript[3]["command"], "r")
self.assertEqual(transcript[3]["commandName"], "process launch")
-self.assertEqual(transcript[3]["commandArguments"], "-X true --")
+
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
gulfemsavrun wrote:
We also see the same test error on our bots.
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8746387351248919521/overview
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits
efriedma-quic wrote:
> > The correct answer here is probably to fix the sizes in the RecordLayout
> > itself; in particular, the DataSize of the members.
>
> That would be ideal, but also means we'd have to reflect the various C++
> attributes that affect layout in DWARF. Avoiding adding such
royitaqi wrote:
cc @clayborg
https://github.com/llvm/llvm-project/pull/94067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/94067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
royitaqi wrote:
I have proposed a fix in https://github.com/llvm/llvm-project/pull/94067
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/royitaqi created
https://github.com/llvm/llvm-project/pull/94067
Problematic PR: https://github.com/llvm/llvm-project/pull/92843
There is a failure in the added test for Linux (test passes on macOS)
The problem of the said test is that its assertion is unnecessarily
Michael137 wrote:
> The correct answer here is probably to fix the sizes in the RecordLayout
> itself; in particular, the DataSize of the members.
That would be ideal, but also means we'd have to reflect the various C++
attributes that affect layout in DWARF. Avoiding adding such
royitaqi wrote:
This appears to be failing the `lldb-x86-64-debian` buildbot:
https://lab.llvm.org/buildbot/#/builders/68/builds/75333
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
gulfemsavrun wrote:
> @gulfemsavrun apologies, fix is here: #94046
Thanks, this fixed the issue.
https://github.com/llvm/llvm-project/pull/93881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: royitaqi
Date: 2024-05-31T14:42:00-07:00
New Revision: ad884d97288c752ba9088d01cf7ab80b20e4d2a6
URL:
https://github.com/llvm/llvm-project/commit/ad884d97288c752ba9088d01cf7ab80b20e4d2a6
DIFF:
https://github.com/llvm/llvm-project/commit/ad884d97288c752ba9088d01cf7ab80b20e4d2a6.diff
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/94046
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2024-05-31T14:04:40-07:00
New Revision: 68fdc1cf87eb04686e079af27eaeec0f1c41f8cc
URL:
https://github.com/llvm/llvm-project/commit/68fdc1cf87eb04686e079af27eaeec0f1c41f8cc
DIFF:
https://github.com/llvm/llvm-project/commit/68fdc1cf87eb04686e079af27eaeec0f1c41f8cc.diff
kastiglione wrote:
@gulfemsavrun apologies, fix is here: #94046
https://github.com/llvm/llvm-project/pull/93881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/94046
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/94046
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/94046.diff
2 Files Affected:
- (modified) lldb/source/Core/Mangled.cpp (+3-2)
- (modified) lldb/unittests/Core/MangledTest.cpp (+2-2)
gulfemsavrun wrote:
We started seeing test failures in `LLDBCoreTests`:
```
Script:
--
/b/s/w/ir/x/w/llvm_build/tools/lldb/unittests/Core/./LLDBCoreTests
--gtest_filter=MangledTest.EmptyForInvalidDLangName
--
lldb/unittests/Core/MangledTest.cpp:89: Failure
Expected equality of these values:
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/94046
None
>From a783b4c189d3c5387418e58156667ecc8382b5ce Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Fri, 31 May 2024 13:47:24 -0700
Subject: [PATCH] [lldb] Fix Dlang symbol test breakage
---
adrian-prantl wrote:
Thanks for providing the context, Lang!
Inside of LLDB we use llvm::Expected often in completely closed environments
where the expectation is always that all errors are handled internally and we
never would exit the process with an error code, so this would be useful here.
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as
representing the head of a
linked list."
) lldb::SBValue;
+%feature("docstring", "
+Returns true if the SBValue holds any useful state
+and false otherwise.
+IsValid is a very weak API, lldb will only
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/94026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -768,3 +768,63 @@ TEST(DWARFExpression, ExtensionsDWO) {
testExpressionVendorExtensions(dwo_module_sp, *dwo_dwarf_unit);
}
+
+TEST_F(DWARFExpressionMockProcessTest, DW_OP_piece_file_addr) {
+ struct MockTarget : Target {
+MockTarget(Debugger , const ArchSpec _arch,
e-kwsm wrote:
Broken into
- #94038
- #94039
- #94040
- #94041
- #94042
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/e-kwsm closed https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Eisuke Kawashima (e-kwsm)
Changes
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):
Comparisons to singletons like None should always be done with is or is
not, never the equality operators.
---
Full diff:
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/94039
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):
> Comparisons to singletons like None should always be done with is or is not,
> never the equality operators.
>From
@@ -768,3 +768,63 @@ TEST(DWARFExpression, ExtensionsDWO) {
testExpressionVendorExtensions(dwo_module_sp, *dwo_dwarf_unit);
}
+
+TEST_F(DWARFExpressionMockProcessTest, DW_OP_piece_file_addr) {
+ struct MockTarget : Target {
+MockTarget(Debugger , const ArchSpec _arch,
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/91858
>From cdc6e7c4ee2238e82fb9bf1754962d0aff10422b Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sun, 12 May 2024 00:06:53 +0900
Subject: [PATCH 1/2] fix(python): fix comparison to True/False
from PEP8
@@ -2153,26 +2152,41 @@ bool DWARFExpression::Evaluate(
}
break;
- case Value::ValueType::FileAddress:
- case Value::ValueType::HostAddress:
-if (error_ptr) {
- lldb::addr_t addr =
@@ -2153,26 +2152,41 @@ bool DWARFExpression::Evaluate(
}
break;
- case Value::ValueType::FileAddress:
- case Value::ValueType::HostAddress:
-if (error_ptr) {
- lldb::addr_t addr =
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/94026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/94026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/94026
>From 72844ebd5cf8f74f6db5d1c52d1f557ca942dbee Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 31 May 2024 12:21:28 -0700
Subject: [PATCH] [lldb] Support reading DW_OP_piece from file address
@@ -1615,7 +1615,7 @@ class Target : public
std::enable_shared_from_this,
TargetStats () { return m_stats; }
-private:
+protected:
JDevlieghere wrote:
If you're wondering, this is so the unit test can access the private
constructor.
e-kwsm wrote:
broken into
- #94028
- #94029
- #94030
- #94031
- #94032
- #94033
- #94034
- #94035
- #94036
- #94037
https://github.com/llvm/llvm-project/pull/91856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/e-kwsm closed https://github.com/llvm/llvm-project/pull/91856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Eisuke Kawashima (e-kwsm)
Changes
---
Patch is 94.92 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/94034.diff
73 Files Affected:
- (modified) lldb/examples/python/crashlog.py (+4-4)
-
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/94026
>From 3aaf98ebce78fd376d33bd0aeb4d4c57762ea63a Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 31 May 2024 12:21:28 -0700
Subject: [PATCH] [lldb] Support reading DW_OP_piece from file address
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/94034
None
>From 5c7ba6c7d95cced5d8acc609a40a6b8307bc7fed Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 02:39:21 +0900
Subject: [PATCH] fix(lldb/**.py): fix invalid escape sequences
---
https://github.com/e-kwsm closed https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
We received a bug report where someone was trying to print a global variable
without a process. This would succeed in a debug build but fail in a on
optimized build. We traced the issue back to the
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/94026
We received a bug report where someone was trying to print a global variable
without a process. This would succeed in a debug build but fail in a on
optimized build. We traced the issue back to the
e-kwsm wrote:
broken into
- #94012
- #94013
- #94014
- #94015
- #94016
- #94017
- #94018
- #94019
- #94020
- #94021
- #94022
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Eisuke Kawashima (e-kwsm)
Changes
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):
Comparisons to singletons like None should always be done with is or is
not, never the equality operators.
---
Full diff:
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/94017
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):
> Comparisons to singletons like None should always be done with is or is not,
> never the equality operators.
>From
mysterymath wrote:
> We have other packages the test suite relies on (pexpect, psutil, etc) so it
> seemed reasonable, but if folks feel strongly about it we can maintain our
> own "version parsing".
Notably the other packages are optional; the lion's share of the test suite can
be run
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/91857
>From 8379b042ef389e7c032e1bc3b32957bd386e2411 Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH 1/2] fix(python): fix comparison to None
from PEP8
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
The IsValid API is actually quite weak - it means "this value can't answer any
questions meaningfully." But I've run into a couple cases where people thought
it meant "was able to reconstruct the value on this
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/94007
The IsValid API is actually quite weak - it means "this value can't answer any
questions meaningfully." But I've run into a couple cases where people thought
it meant "was able to reconstruct the value on
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/92843
>From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 20 May 2024 22:30:40 -0400
Subject: [PATCH 01/11] Add resolvedCommand to transcript, add transcript to
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/93881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2024-05-31T11:20:23-07:00
New Revision: 5a02a9a2e6794f086dfe1cd6f15ba2210bc0
URL:
https://github.com/llvm/llvm-project/commit/5a02a9a2e6794f086dfe1cd6f15ba2210bc0
DIFF:
https://github.com/llvm/llvm-project/commit/5a02a9a2e6794f086dfe1cd6f15ba2210bc0.diff
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
BTW, because the max number of children is probably getting ignored in the
wild, this has to be advisory, you can't require that:
val.GetNumChildren(max_children) <= max_children
I don't think you do that but it might be good to note the fact.
@@ -1425,4 +1425,6 @@ let Command = "statistics dump" in {
Desc<"Dump the total possible debug info statistics. "
"Force loading all the debug information if not yet loaded, and collect "
"statistics with those.">;
+ def statistics_dump_transcript:
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/92843
>From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 20 May 2024 22:30:40 -0400
Subject: [PATCH 01/10] Add resolvedCommand to transcript, add transcript to
jimingham wrote:
This seems reasonable. However, I note that on the page where we show how to
write synthetic child providers, we say:
def num_children(self):
this call should return the number of children that you want your object
to have
That's actually not true - we pass the
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/93880
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2024-05-31T10:43:05-07:00
New Revision: 1e81b67925fdd77a3d65ba2a7f652d1e840512f4
URL:
https://github.com/llvm/llvm-project/commit/1e81b67925fdd77a3d65ba2a7f652d1e840512f4
DIFF:
https://github.com/llvm/llvm-project/commit/1e81b67925fdd77a3d65ba2a7f652d1e840512f4.diff
jimingham wrote:
> LGTM assuming you can make the formatter happy.
This change says "If a ValueObject has no target, don't try to find a formatter
for it". If it doesn't have a target, it's either an error or stale, and isn't
going to have a value to format, so any more work we did here
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/93881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
LGTM with the formatting fixed.
https://github.com/llvm/llvm-project/pull/93883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/93883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> FWIW, there appears to be an actual arch package for this
> https://archlinux.org/packages/extra/any/python-packaging/, so it shouldn't
> be (I think -- I'm not an Arch user) necessary to install `pip`.
Homebrew on macOS works similarly, it has a
1 - 100 of 139 matches
Mail list logo
