https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/96260
>From 9b541e6a035635e26c6a24eca022de8552fa4c17 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 20 Jun 2024 17:53:17 -0700
Subject: [PATCH 1/2] [lldb] Change lldb's breakpoint handling behavior
lldb
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/96260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
LGTM, nice cleanup.
https://github.com/llvm/llvm-project/pull/96256
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/96263
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-06-20T18:23:50-07:00
New Revision: 1373f7c714824f5957aa5fabf8370286f86e6b14
URL:
https://github.com/llvm/llvm-project/commit/1373f7c714824f5957aa5fabf8370286f86e6b14
DIFF:
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/96263
>From b9af881866b3702be5d5bf55f694d4eb051e2872 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 20 Jun 2024 18:19:26 -0700
Subject: [PATCH] Revert "[lldb/crashlog] Make interactive mode the new
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
Reverts llvm/llvm-project#94575 since introduces test failure:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6166/
---
Full diff:
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/96263
Reverts llvm/llvm-project#94575 since introduces test failure:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6166/
>From b9af881866b3702be5d5bf55f694d4eb051e2872 Mon Sep 17 00:00:00
jasonmolenda wrote:
This patch definitely needs review from Jim Ingham, who is out this week.
@ZequanWu and @cmtice FYI.
I tested this on arm64 macOS and on aarch64 Ubuntu - the important Process
changes are were in ProcessGDBRemote, StopInfoMachException, and in
ProcessWindows, I believe
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
lldb today has two rules: When a thread stops at a BreakpointSite, we set the
thread's StopReason to be "breakpoint hit" (regardless if we've actually hit
the breakpoint, or if we've merely stopped
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/96260
lldb today has two rules: When a thread stops at a BreakpointSite, we set the
thread's StopReason to be "breakpoint hit" (regardless if we've actually hit
the breakpoint, or if we've merely stopped *at*
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH 1/3] [API] add GetSyntheticValue
---
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
d8091522664248a4ba73d8d1e7fa6ac57bfcf67c...e0ed752849486f67d9fddbef3767a1756afd1ab2
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/96256
>From 41f7b780548ccfc15ad22da51742f1809c34c103 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 20 Jun 2024 13:51:53 -0700
Subject: [PATCH] [lldb] Unify Platform::ResolveExecutable duplication
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The Platform class currently has two functions to resolve an executable:
`ResolveExecutable` and `ResolveRemoteExecutable`. The former strictly deals
with local files while the latter can handle
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH 1/2] [API] add GetSyntheticValue
---
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/96256
The Platform class currently has two functions to resolve an executable:
`ResolveExecutable` and `ResolveRemoteExecutable`. The former strictly deals
with local files while the latter can handle
Author: Med Ismail Bennani
Date: 2024-06-20T17:23:18-07:00
New Revision: aafa0ef900791857f55629bcf61c37f53cc0d2af
URL:
https://github.com/llvm/llvm-project/commit/aafa0ef900791857f55629bcf61c37f53cc0d2af
DIFF:
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/94575
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,93 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH] [API] add GetSyntheticValue
---
JDevlieghere wrote:
`IsProbablySame` works for me
https://github.com/llvm/llvm-project/pull/95606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/96243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
I got the original PR back on track...
https://github.com/llvm/llvm-project/pull/96243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
@ayermolo: you suggestion worked. thanks. This PR is back on track...
@labath: I implemented your suggestions, let me know if this look ok now
https://github.com/llvm/llvm-project/pull/87740
___
lldb-commits mailing list
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/87740
>From badd915257bb192add91696e0b8530c057bd385f Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Sat, 30 Mar 2024 10:50:34 -0700
Subject: [PATCH 01/11] Add support for using foreign type units in
.debug_names.
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/96243
This patch adds support for the new foreign type unit support in .debug_names.
Features include:
- don't manually index foreign TUs if we have info for them
- only use the type unit entries that match the .dwo
@@ -43,8 +43,7 @@ CompilerType RegisterTypeBuilderClang::GetRegisterType(
ScratchTypeSystemClang::GetForTarget(m_target);
assert(type_system);
- std::string register_type_name = "__lldb_register_fields_";
- register_type_name += name;
+ std::string
https://github.com/medismailben approved this pull request.
LGTM, with comments addressed.
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -0,0 +1,93 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -99,10 +99,15 @@ typedef std::optional
(*SymbolLocatorLocateExecutableSymbolFile)(
typedef bool (*SymbolLocatorDownloadObjectAndSymbolFile)(
ModuleSpec _spec, Status , bool force_lookup,
bool copy_executable);
-typedef bool (*BreakpointHitCallback)(void *baton,
-
@@ -99,10 +99,15 @@ typedef std::optional
(*SymbolLocatorLocateExecutableSymbolFile)(
typedef bool (*SymbolLocatorDownloadObjectAndSymbolFile)(
ModuleSpec _spec, Status , bool force_lookup,
bool copy_executable);
-typedef bool (*BreakpointHitCallback)(void *baton,
-
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4254,14 +4356,55 @@ static std::vector
ParseFlagsFields(XMLNode flags_node,
});
if (name && start && end) {
- if (*start > *end) {
+ if (*start > *end)
LLDB_LOG(
log,
"ProcessGDBRemote::ParseFlagsFields Start {0} > end
https://github.com/jasonmolenda approved this pull request.
This looks good to me. The only thing I could suggest is that we check the
specified fields/size are less than 64 bits when reading the enum field
definitions, but that means I can specify fields above 32 bits and then
associate
@@ -370,6 +370,16 @@ void FieldEnum::Enumerator::ToXML(Stream ) const {
escaped_name.c_str(), m_value);
}
+void FieldEnum::Enumerator::log(Log *log) const {
jasonmolenda wrote:
These seem closer to Dump methods that output to a Log instead of a
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/95768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From 2cfcef620125ed7d0ba84acfa20de3064437282c Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From aa575bbc2b91837851631cf7a14e03398e2efa48 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
jasonmolenda wrote:
> Unfortunately, I don't know of a concise way to express this difference,
> maybe because the concept is not concise to begin with. `IsProbablySameFile`,
> `MayDescribeSameFile`, `PotentiallySameFile` ?
I was thinking about this too, and the best idea I had was
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/95997
>From 3ba6a550cb4731b9754646665e18fcdc6e255bd4 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 18 Jun 2024 14:35:55 -0700
Subject: [PATCH] [lldb] Fix SBAddressRange validation checks.
---
https://github.com/fmayer approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/95678
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -64,7 +64,7 @@ bool SBAddressRange::operator!=(const SBAddressRange ) {
void SBAddressRange::Clear() {
LLDB_INSTRUMENT_VA(this);
- m_opaque_up.reset();
+ m_opaque_up->Clear();
mbucko wrote:
correct
https://github.com/llvm/llvm-project/pull/95007
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/96232
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-06-20T12:50:26-07:00
New Revision: 9473e162b92a7e0bb1471eaaa6cbd6b5fc104fed
URL:
https://github.com/llvm/llvm-project/commit/9473e162b92a7e0bb1471eaaa6cbd6b5fc104fed
DIFF:
https://github.com/llvm/llvm-project/commit/9473e162b92a7e0bb1471eaaa6cbd6b5fc104fed.diff
https://github.com/kastiglione approved this pull request.
thanks
https://github.com/llvm/llvm-project/pull/96232
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/96232
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/96232
>From 73309c4f67ea550b9af336cecc30dd242d89c08b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 20 Jun 2024 12:38:58 -0700
Subject: [PATCH] [DWIMPrint] Move the setting of the result status into
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
This is another NFC change for TypeSystemClang, because an object description
cannot actually fail there. It will have different behavior in the Swift plugin.
---
Full diff:
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/96232
This is another NFC change for TypeSystemClang, because an object description
cannot actually fail there. It will have different behavior in the Swift plugin.
>From
temyurchenko wrote:
> Do you need someone to land these changes on your behalf?
Yeah, I don't have the rights :(
https://github.com/llvm/llvm-project/pull/93913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -2800,6 +2809,10 @@ void PruneThreadPlans();
virtual size_t DoReadMemory(lldb::addr_t vm_addr, void *buf, size_t size,
Status ) = 0;
+ void DoFindInMemory(lldb::addr_t start_addr, lldb::addr_t end_addr,
+ const uint8_t
@@ -101,3 +101,5 @@ bool SBAddressRange::GetDescription(SBStream ,
m_opaque_up->GetDescription(, target.GetSP().get());
return true;
}
+
+lldb_private::AddressRange ::ref() const { return *m_opaque_up;
}
clayborg wrote:
This is no longer needed right?
@@ -2800,6 +2809,10 @@ void PruneThreadPlans();
virtual size_t DoReadMemory(lldb::addr_t vm_addr, void *buf, size_t size,
Status ) = 0;
+ void DoFindInMemory(lldb::addr_t start_addr, lldb::addr_t end_addr,
+ const uint8_t
@@ -92,3 +92,7 @@ bool SBAddressRangeList::GetDescription(SBStream ,
stream << "]";
return true;
}
+
+lldb_private::AddressRanges ::ref() const {
+ return m_opaque_up->ref();
+}
clayborg wrote:
we might want to add an `assert()` call here like you did
@@ -64,7 +64,7 @@ bool SBAddressRange::operator!=(const SBAddressRange ) {
void SBAddressRange::Clear() {
LLDB_INSTRUMENT_VA(this);
- m_opaque_up.reset();
+ m_opaque_up->Clear();
clayborg wrote:
This is no longer needed right? This PR contains this fix
@@ -2007,6 +2007,135 @@ size_t Process::ReadMemory(addr_t addr, void *buf,
size_t size, Status ) {
}
}
+void Process::DoFindInMemory(lldb::addr_t start_addr, lldb::addr_t end_addr,
+ const uint8_t *buf, size_t size,
+
@@ -58,6 +58,8 @@ class LLDB_API SBAddressRange {
friend class SBFunction;
friend class SBProcess;
+ lldb_private::AddressRange () const;
+
clayborg wrote:
This is no longer needed right? This PR contains this fix right?
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/95997
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3073,14 +3073,43 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE ) {
// See comments below about -gsimple-template-names for why we attempt to
// compute missing template parameter names.
-ConstString template_params;
-if
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/96013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-06-20T10:46:26-07:00
New Revision: 5e9f247c064cb2361cd641f62eb4b7049d21641a
URL:
https://github.com/llvm/llvm-project/commit/5e9f247c064cb2361cd641f62eb4b7049d21641a
DIFF:
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/95997
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/95997
>From ca4dcf373b0617ab588ee804e3d28f8d311da06a Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 18 Jun 2024 14:35:55 -0700
Subject: [PATCH] [lldb] Fix SBAddressRange validation checks.
---
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/95857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Landed in f1edc0459a4cc8cd4d00331c2a5cb318955318b2
https://github.com/llvm/llvm-project/pull/95857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-06-20T10:32:07-07:00
New Revision: f1edc0459a4cc8cd4d00331c2a5cb318955318b2
URL:
https://github.com/llvm/llvm-project/commit/f1edc0459a4cc8cd4d00331c2a5cb318955318b2
DIFF:
https://github.com/llvm/llvm-project/commit/f1edc0459a4cc8cd4d00331c2a5cb318955318b2.diff
Author: Adrian Prantl
Date: 2024-06-20T10:32:06-07:00
New Revision: b8f0ca09b66716fc337448a2e43146038bf115ab
URL:
https://github.com/llvm/llvm-project/commit/b8f0ca09b66716fc337448a2e43146038bf115ab
DIFF:
https://github.com/llvm/llvm-project/commit/b8f0ca09b66716fc337448a2e43146038bf115ab.diff
Author: Adrian Prantl
Date: 2024-06-20T10:32:06-07:00
New Revision: f900644ae2b6c7a485673974688a62c3f3301dcc
URL:
https://github.com/llvm/llvm-project/commit/f900644ae2b6c7a485673974688a62c3f3301dcc
DIFF:
https://github.com/llvm/llvm-project/commit/f900644ae2b6c7a485673974688a62c3f3301dcc.diff
Author: Adrian Prantl
Date: 2024-06-20T10:32:06-07:00
New Revision: d1bc75c0bce141b94f9afadfde4e784760735ec0
URL:
https://github.com/llvm/llvm-project/commit/d1bc75c0bce141b94f9afadfde4e784760735ec0
DIFF:
https://github.com/llvm/llvm-project/commit/d1bc75c0bce141b94f9afadfde4e784760735ec0.diff
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/96013
>From 663bee087c345ed0d5759906d780cb4a75facac8 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 18 Jun 2024 19:32:44 -0700
Subject: [PATCH 1/2] [lldb] Make LanguageRuntime::GetTypeBitSize return
clayborg wrote:
> This class behaves quite differently from other SB API classes. Normally, the
> opaque pointer can be cleared to release the potentially more resource heavy
> private counterpart. `AddressRange` is a pretty simple class, so I understand
> that it makes things easier if we
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/95857
>From 7e3d1420a941431de223098ee153d2d4c63cfbfc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 17 Jun 2024 14:29:01 -0700
Subject: [PATCH 1/4] Convert ValueObject::Dump() to return llvm::Error()
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/95997
>From 59c382f0b06d632c05baeb357c0390a2423932fc Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 18 Jun 2024 14:35:55 -0700
Subject: [PATCH] [lldb] Fix SBAddressRange validation checks.
---
@@ -4744,11 +4744,12 @@
TypeSystemClang::GetBitSize(lldb::opaque_compiler_type_t type,
ExecutionContext exe_ctx(exe_scope);
Process *process = exe_ctx.GetProcessPtr();
if (process) {
-ObjCLanguageRuntime *objc_runtime =
Author: Michael Buch
Date: 2024-06-20T17:53:37+01:00
New Revision: 0ec567c370df86893a22bf59d2716f6e553ca63b
URL:
https://github.com/llvm/llvm-project/commit/0ec567c370df86893a22bf59d2716f6e553ca63b
DIFF:
https://github.com/llvm/llvm-project/commit/0ec567c370df86893a22bf59d2716f6e553ca63b.diff
Author: Adrian Prantl
Date: 2024-06-20T09:45:58-07:00
New Revision: 869f5517605224944d6037716e234d9f1f0e7067
URL:
https://github.com/llvm/llvm-project/commit/869f5517605224944d6037716e234d9f1f0e7067
DIFF:
https://github.com/llvm/llvm-project/commit/869f5517605224944d6037716e234d9f1f0e7067.diff
AaronBallman wrote:
Do you need someone to land these changes on your behalf?
https://github.com/llvm/llvm-project/pull/93913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/96145
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mbucko wrote:
> This class behaves quite differently from other SB API classes. Normally, the
> opaque pointer can be cleared to release the potentially more resource heavy
> private counterpart. `AddressRange` is a pretty simple class, so I understand
> that it makes things easier if we
@@ -4744,11 +4744,12 @@
TypeSystemClang::GetBitSize(lldb::opaque_compiler_type_t type,
ExecutionContext exe_ctx(exe_scope);
Process *process = exe_ctx.GetProcessPtr();
if (process) {
-ObjCLanguageRuntime *objc_runtime =
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/95007
>From bae5474315a8a9053033c90237e1eacd9e56e39c Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 4 Jun 2024 12:01:48 -0700
Subject: [PATCH] [lldb][API] Add Find(Ranges)InMemory() to Process SB API
Test Plan:
https://github.com/JDevlieghere requested changes to this pull request.
This class behaves quite differently from other SB API classes. Normally, the
opaque pointer can be cleared to release the potentially more resource heavy
private counterpart. `AddressRange` is a pretty simple class, so I
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/96202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,31 @@
+"""
+Test that the expression parser accounts for the underlying type of bitfield
+enums when looking for matching values.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
While testing register fields I found that if you put the max value into a
bitfield with an underlying type that is an unsigned enum, lldb would not print
the enum name.
This is because the code to
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/96202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/96202
While testing register fields I found that if you put the max value into a
bitfield with an underlying type that is an unsigned enum, lldb would not print
the enum name.
This is because the code to match
@@ -75,20 +75,18 @@ bool
lldb_private::contextMatches(llvm::ArrayRef context_chain,
static CompilerContextKind ConvertTypeClass(lldb::TypeClass type_class) {
if (type_class == eTypeClassAny)
return CompilerContextKind::AnyType;
- uint16_t result = 0;
- if (type_class
dzhidzhoev wrote:
> Can't say I'm excited to see this feature (although I admit it is looking
> less daunting than I originally feared). Can you explain why you need this
> feature? Is there some particular aspect of lldb's remote operation that you
> think isn't well covered by the existing
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/95768
>From a9b542a1686be0afd73ad89a504d2c66ba6c4a4f Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Mar 2024 10:56:29 +
Subject: [PATCH 1/2] [lldb] Parse and display register field enums
This
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/96145
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -75,20 +75,18 @@ bool
lldb_private::contextMatches(llvm::ArrayRef context_chain,
static CompilerContextKind ConvertTypeClass(lldb::TypeClass type_class) {
if (type_class == eTypeClassAny)
return CompilerContextKind::AnyType;
- uint16_t result = 0;
- if (type_class
@@ -3073,14 +3073,43 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE ) {
// See comments below about -gsimple-template-names for why we attempt to
// compute missing template parameter names.
-ConstString template_params;
-if
@@ -43,8 +43,7 @@ CompilerType RegisterTypeBuilderClang::GetRegisterType(
ScratchTypeSystemClang::GetForTarget(m_target);
assert(type_system);
- std::string register_type_name = "__lldb_register_fields_";
- register_type_name += name;
+ std::string
@@ -75,20 +75,18 @@ bool
lldb_private::contextMatches(llvm::ArrayRef context_chain,
static CompilerContextKind ConvertTypeClass(lldb::TypeClass type_class) {
if (type_class == eTypeClassAny)
return CompilerContextKind::AnyType;
- uint16_t result = 0;
- if (type_class
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Our dwarf parsing code treats structures and classes as interchangable.
CompilerContextKind is used when looking DIEs for types. This makes sure we
always they're treated the same way.
See also
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/96145
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/96145
Our dwarf parsing code treats structures and classes as interchangable.
CompilerContextKind is used when looking DIEs for types. This makes sure we
always they're treated the same way.
See also
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/95905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 103 matches
Mail list logo
