https://github.com/medismailben deleted
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben deleted
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,79 @@
+import lldb
+import unittest
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbreverse import ReverseTestBase
+from lldbsuite.test import lldbutil
+
+
+class TestR
@@ -0,0 +1,176 @@
+import logging
+import os
+import os.path
+import random
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.gdbclientutils import *
+import lldbgdbserverutils
+from lldbsuite.support import seven
+
+
+class GDBProxyTestBase(TestBase):
---
@@ -0,0 +1,415 @@
+import os
+import os.path
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbproxy import *
+import lldbgdbserverutils
+import re
+
+
+class ThreadSnapshot:
+def __init__(self, thread_
@@ -0,0 +1,79 @@
+import lldb
+import unittest
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbreverse import ReverseTestBase
+from lldbsuite.test import lldbutil
+
+
+class TestR
@@ -0,0 +1,79 @@
+import lldb
+import unittest
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbreverse import ReverseTestBase
+from lldbsuite.test import lldbutil
+
+
+class TestR
https://github.com/medismailben commented:
This is very interesting, I've left a few comments here and there but I've
noticed you didn't check if this works both when the debugger is in synchronous
and asynchronous in your tests. This is definitely something you want to
exercise since it chang
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1881,18 +1970,24 @@ ThreadSP ProcessGDBRemote::SetThreadStopInfo(
handled = true;
}
} else if (!signo) {
-addr_t pc = thread_sp->GetRegisterContext()->GetPC();
-lldb::BreakpointSiteSP bp_site_sp =
-thread_sp->GetProcess()-
@@ -1395,6 +1395,91 @@ Status ProcessGDBRemote::DoResume() {
return error;
}
+Status ProcessGDBRemote::DoResumeReverse() {
+ Status error;
+ Log *log = GetLog(GDBRLog::Process);
+ LLDB_LOGF(log, "ProcessGDBRemote::DoResumeReverse()");
+
+ ListenerSP listener_sp(
+ L
@@ -0,0 +1,12 @@
+static void start_recording() {}
+
+static void trigger_breakpoint() {}
+
+static void stop_recording() {}
medismailben wrote:
It would be nice to add some sample code in each of these functions to test of
lldb behaves with things like variable
rocallahan wrote:
BTW this was discussed in
https://discourse.llvm.org/t/how-to-test-reverse-execution-support-in-lldb/79696.
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Robert O'Callahan (rocallahan)
Changes
This commit only adds support for the
`SBProcess::ReverseContinue()` API. A user-accessible command for this will
follow in a later commit.
This feature depends on a gdbserver implementation (e.g. `rr
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/rocallahan created
https://github.com/llvm/llvm-project/pull/99736
This commit only adds support for the
`SBProcess::ReverseContinue()` API. A user-accessible command for this will
follow in a later commit.
This feature depends on a gdbserver implementation (e.g. `rr`) provi
jasonmolenda wrote:
I've reverted this change until I can debug the failures found on the CI bots.
Two debuginfo dexter tests failed, likely because the way stepping and
breakpoints works is now different. If you're sitting at a BreakpointSite
which has not yet executed, previously lldb wou
Author: Jason Molenda
Date: 2024-07-19T18:43:53-07:00
New Revision: 52c08d7ffd380f4abd819c20bec76252272f6337
URL:
https://github.com/llvm/llvm-project/commit/52c08d7ffd380f4abd819c20bec76252272f6337
DIFF:
https://github.com/llvm/llvm-project/commit/52c08d7ffd380f4abd819c20bec76252272f6337.diff
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/1091
Here is the relevant piece of the build log f
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building
`lldb` at step 6 "test-build-unified-tree-check-cross-project".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/181/builds/205
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`cross-project-tests-sie-ubuntu-dwarf5` running on `doug-worker-1b` while
building `lldb` at step 6 "test-build-unified-tree-check-cross-project".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/163/bui
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/96260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-07-19T17:26:13-07:00
New Revision: 05f0e86cc895181b3d2210458c78938f83353002
URL:
https://github.com/llvm/llvm-project/commit/05f0e86cc895181b3d2210458c78938f83353002
DIFF:
https://github.com/llvm/llvm-project/commit/05f0e86cc895181b3d2210458c78938f83353002.diff
https://github.com/sayhaan updated
https://github.com/llvm/llvm-project/pull/99225
>From f07d79ccb57075ee75783cb4bd5cba4b4ca6af80 Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Tue, 1 Jun 2021 11:37:41 -0700
Subject: [PATCH 1/4] Rebase: [Facebook] Add clang driver options to test debug
info
jasonmolenda wrote:
The pre-merge linux-x86 test builds both failed in TestConcurrentVFork.py after
I updated the branch to current main. I don't know if there's a bot issue or a
main issue. I tried repoing on aarch64 ubuntu; that test is skipped on aarch64
but I removed the skips and it run
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
HostProcessWindows::Terminate() correctly uses m_process which type is
process_t (HANDLE) to call ::TerminateProcess(). But Host::Kill() uses a cast
from pid, which is wrong.
---
Full diff: https://githu
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/99721
HostProcessWindows::Terminate() correctly uses m_process which type is
process_t (HANDLE) to call ::TerminateProcess(). But Host::Kill() uses a cast
from pid, which is wrong.
>From 0712380a0ef60fae0a3035ac1e57
https://github.com/sayhaan updated
https://github.com/llvm/llvm-project/pull/99225
>From f07d79ccb57075ee75783cb4bd5cba4b4ca6af80 Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Tue, 1 Jun 2021 11:37:41 -0700
Subject: [PATCH 1/3] Rebase: [Facebook] Add clang driver options to test debug
info
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/99692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jacob Lalonde
Date: 2024-07-19T15:49:22-07:00
New Revision: fada9227325b3eaa0bdc09a486f29a7f08b7b3fb
URL:
https://github.com/llvm/llvm-project/commit/fada9227325b3eaa0bdc09a486f29a7f08b7b3fb
DIFF:
https://github.com/llvm/llvm-project/commit/fada9227325b3eaa0bdc09a486f29a7f08b7b3fb.diff
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/99692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@labath Would you mind looking at this? Simple fix that got missed because it's
a Window's only test
https://github.com/llvm/llvm-project/pull/99692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
Jlalond wrote:
Addressed Windows issue in #99692
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/96260
>From 9b541e6a035635e26c6a24eca022de8552fa4c17 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 20 Jun 2024 17:53:17 -0700
Subject: [PATCH 1/8] [lldb] Change lldb's breakpoint handling behavior
lldb
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/96260
>From 9b541e6a035635e26c6a24eca022de8552fa4c17 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 20 Jun 2024 17:53:17 -0700
Subject: [PATCH 1/8] [lldb] Change lldb's breakpoint handling behavior
lldb
https://github.com/shawbyoung closed
https://github.com/llvm/llvm-project/pull/98125
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/shawbyoung edited
https://github.com/llvm/llvm-project/pull/98125
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/99362
>From f498534a60636a6b8ee06f27dcd04a5074537180 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 1/2] Trying to deal with Linux AArch64 test failures :/
Reapply "D
Jlalond wrote:
@luporl FYI this fixes the test
https://github.com/llvm/llvm-project/pull/99692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
In #98403 some of the tests were transitioned to the new
`SBProcess::SaveCore(SBSaveCoreOptions)` API, but were not detected in testing.
This patch addresses that.
---
Full diff: https://github.com/llvm/llv
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/99692
In #98403 some of the tests were transitioned to the new
`SBProcess::SaveCore(SBSaveCoreOptions)` API, but were not detected in testing.
This patch addresses that.
>From f4c7fcb17855dc5f4f51dce791e05adfff0666e6
https://github.com/jimingham approved this pull request.
I had a couple trivial comment comments (and you didn't fix one typo). But
this LGTM as well.
https://github.com/llvm/llvm-project/pull/96260
___
lldb-commits mailing list
lldb-commits@lists.ll
@@ -577,15 +577,18 @@ StopInfoSP
StopInfoMachException::CreateStopReasonWithMachException(
ProcessSP process_sp(thread.GetProcess());
RegisterContextSP reg_ctx_sp(thread.GetRegisterContext());
- BreakpointSiteSP bp_site_sp;
- addr_t pc = LLDB_INVALID_ADDRESS;
- if (reg
https://github.com/jimingham deleted
https://github.com/llvm/llvm-project/pull/96260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -577,15 +577,18 @@ StopInfoSP
StopInfoMachException::CreateStopReasonWithMachException(
ProcessSP process_sp(thread.GetProcess());
RegisterContextSP reg_ctx_sp(thread.GetRegisterContext());
- BreakpointSiteSP bp_site_sp;
- addr_t pc = LLDB_INVALID_ADDRESS;
- if (reg
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/99673
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-07-19T11:39:56-07:00
New Revision: a96c906102e8d0284c7a402eac4fa1ad9ab3e871
URL:
https://github.com/llvm/llvm-project/commit/a96c906102e8d0284c7a402eac4fa1ad9ab3e871
DIFF:
https://github.com/llvm/llvm-project/commit/a96c906102e8d0284c7a402eac4fa1ad9ab3e871.
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/99673
>From 16ef7297eef25d329631fd62d126bf7a7be24c4d Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 19 Jul 2024 11:08:39 -0700
Subject: [PATCH 1/2] [lldb/Target] Add GetStartSymbol method to DynamicL
@@ -10,9 +10,11 @@
#define LLDB_TARGET_DYNAMICLOADER_H
#include "lldb/Core/PluginInterface.h"
+#include "lldb/Symbol/Symbol.h"
#include "lldb/Utility/FileSpec.h"
#include "lldb/Utility/Status.h"
#include "lldb/Utility/UUID.h"
+#include "lldb/Utility/UnimplementedError.h"
--
@@ -10,9 +10,11 @@
#define LLDB_TARGET_DYNAMICLOADER_H
#include "lldb/Core/PluginInterface.h"
+#include "lldb/Symbol/Symbol.h"
#include "lldb/Utility/FileSpec.h"
#include "lldb/Utility/Status.h"
#include "lldb/Utility/UUID.h"
+#include "lldb/Utility/UnimplementedError.h"
--
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/99673
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -10,9 +10,11 @@
#define LLDB_TARGET_DYNAMICLOADER_H
#include "lldb/Core/PluginInterface.h"
+#include "lldb/Symbol/Symbol.h"
#include "lldb/Utility/FileSpec.h"
#include "lldb/Utility/Status.h"
#include "lldb/Utility/UUID.h"
+#include "lldb/Utility/UnimplementedError.h"
--
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/99673
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/99673
>From 16ef7297eef25d329631fd62d126bf7a7be24c4d Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 19 Jul 2024 11:08:39 -0700
Subject: [PATCH] [lldb/Target] Add GetStartSymbol method to DynamicLoade
@@ -329,6 +330,11 @@ class DynamicLoader : public PluginInterface {
/// safe to call certain APIs or SPIs.
virtual bool IsFullyInitialized() { return true; }
+ /// Return the `start` function \b symbol in the dynamic loader module.
+ virtual llvm::Expected GetStartSymbol
@@ -329,6 +330,11 @@ class DynamicLoader : public PluginInterface {
/// safe to call certain APIs or SPIs.
virtual bool IsFullyInitialized() { return true; }
+ /// Return the `start` function \b symbol in the dynamic loader module.
+ virtual llvm::Expected GetStartSymbol
https://github.com/JDevlieghere requested changes to this pull request.
This PR does two things that are orthogonal, therefore they should be separate
PRs. Please omit the whitespace changes (those can be addressed separately as
well). Also, please make sure to have a self contained PR descript
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/99362
>From b3fe99591b7bc6dad2e9cc46bd4fc2c2f87d1eff Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 1/2] Trying to deal with Linux AArch64 test failures :/
Reapply "D
@@ -329,6 +330,11 @@ class DynamicLoader : public PluginInterface {
/// safe to call certain APIs or SPIs.
virtual bool IsFullyInitialized() { return true; }
+ /// Return the `start` function \b symbol in the dynamic loader module.
+ virtual llvm::Expected GetStartSymbol
@@ -329,6 +330,11 @@ class DynamicLoader : public PluginInterface {
/// safe to call certain APIs or SPIs.
virtual bool IsFullyInitialized() { return true; }
+ /// Return the `start` function \b symbol in the dynamic loader module.
jasonmolenda wrote:
Th
https://github.com/bulbazord commented:
Looks fine to me, but you probably want @jasonmolenda to sign off to be sure.
https://github.com/llvm/llvm-project/pull/99673
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -0,0 +1,194 @@
+//===--- DirectToIndirectFCR.cpp - RISC-V specific pass
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -163,11 +166,83 @@ TotalArgsSizeInWords(bool is_rv64,
return total_size;
}
+static bool UpdateRegister(RegisterContext *reg_ctx,
+ const lldb::RegisterKind reg_kind,
+ const uint32_t reg_num, const addr_t value) {
+ Log
@@ -0,0 +1,194 @@
+//===--- DirectToIndirectFCR.cpp - RISC-V specific pass
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch introduces a new method to the dynamic loader plugin, to fetch its
`start` symbol.
This can be useful to resolve the `start` symbol address for instance.
---
Full diff: https://github.c
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/99673
This patch introduces a new method to the dynamic loader plugin, to fetch its
`start` symbol.
This can be useful to resolve the `start` symbol address for instance.
>From 2e3064b3f1af9ea5b4930cf3fd87c9f48f
https://github.com/benlangmuir approved this pull request.
LGTM other than what Jan already mentioned, thanks!
https://github.com/llvm/llvm-project/pull/99599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/jansvoboda11 approved this pull request.
LGTM sans the missing newline at the end of file and file headers not aligned
to 80 columns.
https://github.com/llvm/llvm-project/pull/99599
___
lldb-commits mailing list
lldb-commits@lists.l
Jlalond wrote:
> Were those the same failures that were showing up on the buildbots? If not it
> could just be that there's an issue with your build configuration.
>
> In this case, the fix was pretty simple (see
> [a27037b](https://github.com/llvm/llvm-project/commit/a27037becd1bdea568e2f970d
luporl wrote:
lldb-aarch64-windows is still failing:
https://lab.llvm.org/buildbot/#/builders/141/builds/912
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
github-actions[bot] wrote:
@dlav-sc Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build,
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/99044
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: dlav-sc
Date: 2024-07-19T13:22:18+02:00
New Revision: fdfc49186318727653cf6b13686bb77cfed60e33
URL:
https://github.com/llvm/llvm-project/commit/fdfc49186318727653cf6b13686bb77cfed60e33
DIFF:
https://github.com/llvm/llvm-project/commit/fdfc49186318727653cf6b13686bb77cfed60e33.diff
LOG:
labath wrote:
sure thing.
https://github.com/llvm/llvm-project/pull/99044
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/99532
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vladislav Dzhidzhoev
Date: 2024-07-19T13:08:07+02:00
New Revision: 243af2ff217f65ef291232faa60779b86e01a967
URL:
https://github.com/llvm/llvm-project/commit/243af2ff217f65ef291232faa60779b86e01a967
DIFF:
https://github.com/llvm/llvm-project/commit/243af2ff217f65ef291232faa60779b86e01a96
labath wrote:
Were those the same failures that were showing up on the buildbots? If not it
could just be that there's an issue with your build configuration.
In this case, the fix was pretty simple (see
a27037becd1bdea568e2f970d4b85fa5e02f3b08), but generally, if don't know what's
the proble
labath wrote:
> > What exactly does it help with? Given that you're canonicalizing to a
> > forward slash, does that mean that some of the tools you use don't accept
> > backslashes (perhaps because they come from cygwin or the like)?
>
> As far as I understand, MinGW make, on which Chocolatey
labath wrote:
> > It may be better to split this into smaller patches, given the fragility of
> > this code. (Basically, one patch for each of your bullet points).
>
> I was thinking about that, but for me it looked like path_wrapper thing and
> cross-compilation/sdkroot fixes should have been
@@ -263,9 +280,9 @@ CFLAGS += $(NO_LIMIT_DEBUG_INFO_FLAGS) $(ARCH_CFLAGS)
# Use this one if you want to build one part of the result without debug
information:
ifeq "$(OS)" "Darwin"
- CFLAGS_NO_DEBUG = -O0 $(ARCHFLAG) $(ARCH) $(FRAMEWORK_INCLUDES)
$(ARCH_CFLAGS) $(CFLA
labath wrote:
:partying_face:
https://github.com/llvm/llvm-project/pull/99535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-07-19T11:37:29+02:00
New Revision: a27037becd1bdea568e2f970d4b85fa5e02f3b08
URL:
https://github.com/llvm/llvm-project/commit/a27037becd1bdea568e2f970d4b85fa5e02f3b08
DIFF:
https://github.com/llvm/llvm-project/commit/a27037becd1bdea568e2f970d4b85fa5e02f3b08.diff
https://github.com/labath approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/99532
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
You're welcome. BTW, are you able to push the merge button, or do you need
someone to do that for you?
https://github.com/llvm/llvm-project/pull/99044
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/labath commented:
Libc++ supports a [large
number](https://github.com/llvm/llvm-project/blob/6235698f47828747d3b1b0418e547e2e4ff9138f/libcxx/cmake/Modules/HandleLibCXXABI.cmake#L85)
of configurations when in comes to the ABI library.
I think the most common are: shared-libcx
@@ -0,0 +1,58 @@
+//===--- DirectToIndirectFCR.h - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,58 @@
+//===--- DirectToIndirectFCR.h - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
jasonmolenda wrote:
I think we should change these checks to look for an explicitly inaccessible
memory region, like
```
if (region_info.GetReadable() != MemoryRegionInfo::OptionalBool::eNo &&
region_info.GetWritable() != MemoryRegionInfo::OptionalBool::eNo &&
re
88 matches
Mail list logo
