DhruvSrivastavaX wrote:
Ok Alex, Thanks for approving.
https://github.com/llvm/llvm-project/pull/105523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
If @clayborg takes too long to review, I'd suggest merging this and then acting
on any late feedback. But give him a few days for sure if possible. He's a
better reviewer than me.
https://github.com/llvm/llvm-project/pull/102928
_
vogelsgesang wrote:
> This LGTM considering that the screenshot looks right and this passes all the
> tests.
Thanks! I assume you still want me to wait for @clayborg's review before
merging?
https://github.com/llvm/llvm-project/pull/102928
___
lldb-
vogelsgesang wrote:
> I'll explain what I do [...]
Thanks for that context! I don't currently have a LSP in mind. Let's see which
UI VS-Code will be providing for this (if any). I hope it will not conflict
with your existing UI
https://github.com/llvm/llvm-project/pull/102928
https://github.com/walter-erquinigo approved this pull request.
This LGTM considering that the screenshot looks right and this passes all the
tests.
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm
walter-erquinigo wrote:
> > @vogelsgesang , the $__lldb_extensions.declaration is used by the Mojo
> > extension. Once this change gets it, I'll update the Mojo extension to use
> > the new declaration info and remove $__lldb_extensions.declaration.
>
> Is that extension's source code availabl
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux`
running on `fuchsia-debian-64-us-central1-a-1` while building `lldb` at step 4
"annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/11/builds/3754
Here is the relevant pie
vogelsgesang wrote:
> @vogelsgesang , can you show a screenshot of the variables pane after this
> change? I want to make sure that simple types, like ints, are not displayed
> as having children.
**With this commit (and also with the changes from #104589)**
https://github.com/user-attachment
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104589
>From 5bdcb821527bf67eead6c42825ea6e559ec749c3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH 1/3] [lldb-dap] Implement declaration locations
This
vogelsgesang wrote:
> @vogelsgesang , the $__lldb_extensions.declaration is used by the Mojo
> extension. Once this change gets it, I'll update the Mojo extension to use
> the new declaration info and remove $__lldb_extensions.declaration.
Is that extension's source code available? I wonder ho
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/105604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: John Harrison
Date: 2024-08-21T18:52:48-07:00
New Revision: 8e0b9c85924ca22a65d57988ea2c5c22a5181ed9
URL:
https://github.com/llvm/llvm-project/commit/8e0b9c85924ca22a65d57988ea2c5c22a5181ed9
DIFF:
https://github.com/llvm/llvm-project/commit/8e0b9c85924ca22a65d57988ea2c5c22a5181ed9.diff
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105604
>From 54dcc78eace39c197f1fb762880746b569980955 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 21 Aug 2024 18:22:17 -0700
Subject: [PATCH] Skip the lldb-dap output test on windows, it seems all the
lldb-
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
https://github.com/vogelsgesang approved this pull request.
Looks good to me!
Thanks for this amazing usability improvement!
If this would have existed the first time I tried this extension, it would have
saved me a lot of time
https://github.com/llvm/llvm-project/pull/104711
__
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
I'm approving this to unblock.
https://github.com/llvm/llvm-project/pull/104874
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/105604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This should fix https://lab.llvm.org/buildbot/#/builders/141/builds/1747
---
Full diff: https://github.com/llvm/llvm-project/pull/105604.diff
1 Files Affected:
- (modified) lldb/test/API/tools/lldb-dap/outp
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/105604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/105604
This should fix https://lab.llvm.org/buildbot/#/builders/141/builds/1747
>From 54dcc78eace39c197f1fb762880746b569980955 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 21 Aug 2024 18:22:17 -0700
Subject:
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/102928
>From 5bdcb821527bf67eead6c42825ea6e559ec749c3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH 1/2] [lldb-dap] Implement declaration locations
This
@@ -0,0 +1,40 @@
+"""
+Test lldb-dap locations request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class TestDAP_locations(lldbdap_testcase
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
@@ -4078,6 +4255,9 @@ void RegisterRequestCallbacks() {
g_dap.RegisterRequestCallback("threads", request_threads);
g_dap.RegisterRequestCallback("variables", request_variables);
g_dap.RegisterRequestCallback("disassemble", request_disassemble);
+ // Instruction breapoint
@@ -4046,6 +4048,181 @@ void request__testGetTargetBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// SetInstructionBreakpoints request; value of command field is
+// 'setInstructionBreakpoints'. Replaces all exist
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/104589
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,81 @@
+"""
+Test lldb-dap locations request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class TestDAP_locations(lldbdap_testcase
vogelsgesang wrote:
@petrhosek this commit builds on top of #104523 and relies on the frame
recognizer introduced as part of it.
As soon as [your proposed
solutions](https://github.com/llvm/llvm-project/pull/104523#issuecomment-2303287484)
was addressed, the `subtleFrames` test case should al
Da-Viper wrote:
> cool
>
> Don't forget to run `npm run format` before landing this
Done
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
https://github.com/walter-erquinigo approved this pull request.
cool
Don't forget to run `npm run format` before landing this
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/104711
>From 2cda519a06d46bd6a5ae02e8be8daacb39a49b3e Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Thu, 22 Aug 2024 01:42:17 +0100
Subject: [PATCH] Rebase and add check dap path on config change
---
.../lldb-dap
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
Author: Adrian Prantl
Date: 2024-08-21T16:53:37-07:00
New Revision: 19d3f3417100dc99caa4394fbd26fc0c4702264e
URL:
https://github.com/llvm/llvm-project/commit/19d3f3417100dc99caa4394fbd26fc0c4702264e
DIFF:
https://github.com/llvm/llvm-project/commit/19d3f3417100dc99caa4394fbd26fc0c4702264e.diff
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
petrhosek wrote:
The `lldb-api :: lang/cpp/std-function-recognizer/TestStdFunctionRecognizer.py`
test has been failing on our builders with the following error:
```
Script:
--
/b/s/w/ir/x/w/lldb_install/python3/bin/python3
/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/105460
>From 5021ef81d8c18a06cbb6d7595845bacd7e99b423 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 20 Aug 2024 18:29:24 -0700
Subject: [PATCH 1/2] [lldb] Change the two remaining SInt64 settings in Targ
jasonmolenda wrote:
I opened a new PR that starts with this PR's patchset which I had to revert,
and I will address the issues that need to be fixed there with separate
additional commits in preparation for merging it again.
https://github.com/llvm/llvm-project/pull/105594
https://github.com/l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
This is a PR to track the changes I need to make to
https://github.com/llvm/llvm-project/pull/96260
to address the CI bot failures when I merged that PR, as well as investigating
the windows problem Mar
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/105594
This is a PR to track the changes I need to make to
https://github.com/llvm/llvm-project/pull/96260
to address the CI bot failures when I merged that PR, as well as investigating
the windows problem Martin
@@ -3091,17 +3093,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/104874
>From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 19 Aug 2024 10:57:35 -0700
Subject: [PATCH 1/2] Fix StartDebuggingRequestHandler/ReplModeRequestHandler
jeffreytan81 wrote:
@walter-erquinigo, the performance issue is not only showing for 1% rare
gigantic target. It is actually reported by a customer's target with 4000
modules with only 3GB of debug info. Disabling this feature significantly
improves the stepping experience.
To get a sense of
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/105576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
petrhosek wrote:
This `subtleFrames` is failing on our builders, would it be possible to take a
look?
```
Script:
--
/b/s/w/ir/x/w/lldb_install/python3/bin/python3
/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS
--env ARCHIVER=/b/s/w/ir/x/w/cipd/bin/llvm-ar --env
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,6 @@
+CXX_SOURCES := main-copy.cpp
+CXXFLAGS_EXTRAS := -O1 -g
walter-erquinigo wrote:
why don't you use -O0?
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/walter-erquinigo commented:
This LGTM, but I'd like @clayborg to give a second look.
Thanks for this fancy feature, I've been wanting it for a while
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-
@@ -4046,6 +4048,181 @@ void request__testGetTargetBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// SetInstructionBreakpoints request; value of command field is
+// 'setInstructionBreakpoints'. Replaces all exist
@@ -0,0 +1,81 @@
+"""
+Test lldb-dap locations request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class TestDAP_locations(lldbdap_testcase
https://github.com/walter-erquinigo commented:
Overall looks very nice, and I want to make sure that this works for the Mojo
language after this gets merged.
Please rebase this change so that I have a better time reviewing it.
Also, happy to chime in on discourse to make sure that the RFC gets a
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/104589
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo commented:
This looks good to me, but I'd like @clayborg to have a second look.
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,40 @@
+"""
+Test lldb-dap locations request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class TestDAP_locations(lldbdap_testcase
walter-erquinigo wrote:
@vogelsgesang , can you show a screenshot of the variables pane after this
change? I want to make sure that simple types, like ints, are not displayed as
having children.
https://github.com/llvm/llvm-project/pull/102928
___
ll
walter-erquinigo wrote:
@vogelsgesang , the `$__lldb_extensions.declaration` is used by the Mojo
extension. Once this change gets it, I'll update the Mojo extension to use the
new declaration info and remove `$__lldb_extensions.declaration`.
https://github.com/llvm/llvm-project/pull/102928
___
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/105456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: John Harrison
Date: 2024-08-21T13:48:29-07:00
New Revision: 30ca06c4d0d06f67f10a9e19d4333acc2074811b
URL:
https://github.com/llvm/llvm-project/commit/30ca06c4d0d06f67f10a9e19d4333acc2074811b
DIFF:
https://github.com/llvm/llvm-project/commit/30ca06c4d0d06f67f10a9e19d4333acc2074811b.diff
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/105456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105456
>From 9246649c24991127b8f54ae1f21121386cef7254 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 20 Aug 2024 16:33:14 -0700
Subject: [PATCH 1/5] When sending a DAP Output Event break each message into
sepa
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a16f0dc9c2f0690e28622b0d80bd154fb0e6a30a
106a6bab4972913d989b97108c4f5f25bef2eca3 --e
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105456
>From 9246649c24991127b8f54ae1f21121386cef7254 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 20 Aug 2024 16:33:14 -0700
Subject: [PATCH 1/4] When sending a DAP Output Event break each message into
sepa
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105456
>From 9246649c24991127b8f54ae1f21121386cef7254 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 20 Aug 2024 16:33:14 -0700
Subject: [PATCH 1/3] When sending a DAP Output Event break each message into
sepa
@@ -399,7 +399,7 @@ void SendProcessEvent(LaunchMethod launch_method) {
// Grab any STDOUT and STDERR from the process and send it up to VS Code
// via an "output" event to the "stdout" and "stderr" categories.
void SendStdOutStdErr(lldb::SBProcess &process) {
- char buffer[10
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105456
>From 9246649c24991127b8f54ae1f21121386cef7254 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 20 Aug 2024 16:33:14 -0700
Subject: [PATCH 1/3] When sending a DAP Output Event break each message into
sepa
@@ -3091,17 +3093,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
In f9f3316, Adrian fixed an issue where LLDB wouldn't update the target's
architecture when the process reported a different triple that only differed in
its sub-architecture.
This unintentionally
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/105576
In f9f3316, Adrian fixed an issue where LLDB wouldn't update the target's
architecture when the process reported a different triple that only differed in
its sub-architecture.
This unintentionally regress
@@ -3091,17 +3093,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
@@ -3091,17 +3093,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104589
>From 5bdcb821527bf67eead6c42825ea6e559ec749c3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH 1/2] [lldb-dap] Implement declaration locations
This
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/102928
>From 5bdcb821527bf67eead6c42825ea6e559ec749c3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH] [lldb-dap] Implement declaration locations
This comm
@@ -399,7 +399,7 @@ void SendProcessEvent(LaunchMethod launch_method) {
// Grab any STDOUT and STDERR from the process and send it up to VS Code
// via an "output" event to the "stdout" and "stderr" categories.
void SendStdOutStdErr(lldb::SBProcess &process) {
- char buffer[10
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/105456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request.
Just a minor nit and good to go
https://github.com/llvm/llvm-project/pull/105456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
DmT021 wrote:
I'm not sure I understand because this will break the logic that is currently
in place. Many nuances in post-processing wouldn't be possible to implement
with a simple short-circuit.
If a symbol is found in the hinted module, it might be internal.
`IRExecutionUnit::FindInSymbols`
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/105464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Vogelsgesang
Date: 2024-08-21T20:30:10+02:00
New Revision: 6257a98b258a3f17b78af31bf43009a559c5dd1d
URL:
https://github.com/llvm/llvm-project/commit/6257a98b258a3f17b78af31bf43009a559c5dd1d
DIFF:
https://github.com/llvm/llvm-project/commit/6257a98b258a3f17b78af31bf43009a559c5dd1d
https://github.com/JDevlieghere approved this pull request.
Sorry for breaking this & thanks for fixing it.
https://github.com/llvm/llvm-project/pull/105460
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105464
>From c4178df5541103388e26343f62e96f8e2a65be86 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Mon, 12 Aug 2024 23:00:45 +
Subject: [PATCH 1/3] [lldb-dap] Implement `StepGranularity` for "next"
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/105449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -311,10 +309,22 @@ void DAP::SendOutput(OutputType o, const llvm::StringRef
output) {
category = "telemetry";
break;
}
- body.try_emplace("category", category);
- EmplaceSafeString(body, "output", output.str());
- event.try_emplace("body", std::move(body));
-
https://github.com/bulbazord approved this pull request.
This one looks very straightforward. I haven't been involved in any of the
earlier discussions about AIX support so please wait for more involved folks to
also take a look.
https://github.com/llvm/llvm-project/pull/105523
___
@@ -7,6 +7,9 @@
//===--===//
#include "lldb/API/SBSaveCoreOptions.h"
+#include "lldb/API/SBError.h"
+#include "lldb/API/SBFileSpec.h"
Jlalond wrote:
Good call, I'll try to trim all the unnee
@@ -80,6 +80,17 @@ class LLDB_API SBSaveCoreOptions {
/// \return True if the thread was removed, false if it was not in the list.
bool RemoveThread(lldb::SBThread thread);
+ /// Add a memory region to save in the core file.
+ ///
+ /// \param region The memory region t
@@ -7,6 +7,9 @@
//===--===//
#include "lldb/API/SBSaveCoreOptions.h"
+#include "lldb/API/SBError.h"
+#include "lldb/API/SBFileSpec.h"
bulbazord wrote:
SBFileSpec is unused right? Shouldn't n
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/105442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -90,6 +93,16 @@ bool SBSaveCoreOptions::RemoveThread(lldb::SBThread thread) {
return m_opaque_up->RemoveThread(thread.GetSP());
}
+
+lldb::SBError SBSaveCoreOptions::AddMemoryRegionToSave(const
SBMemoryRegionInfo ®ion) {
+ LLDB_INSTRUMENT_VA(this, region);
+ // Current
1 - 100 of 121 matches
Mail list logo
