[Lldb-commits] [lldb] [lldb] Implement DW_CFA_val_offset and DW_CFA_val_offset_sf (PR #150732)

2025-07-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Daniel Sanders (dsandersllvm) Changes The test for this is artificial as I'm not aware of any upstream targets that use DW_CFA_val_offset RegisterContextUnwind::ReadFrameAddress now reports how it's attempting to obtain the CFA unless all

[Lldb-commits] [lldb] [lldb] Implement DW_CFA_val_offset and DW_CFA_val_offset_sf (PR #150732)

2025-07-25 Thread Daniel Sanders via lldb-commits
https://github.com/dsandersllvm created https://github.com/llvm/llvm-project/pull/150732 The test for this is artificial as I'm not aware of any upstream targets that use DW_CFA_val_offset RegisterContextUnwind::ReadFrameAddress now reports how it's attempting to obtain the CFA unless all suc

[Lldb-commits] [lldb] [lldb] Protect the selected frame idx in StackFrameList (PR #150718)

2025-07-25 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `lldb` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/20409 Here is the relevant p

[Lldb-commits] [lldb] [lldb] Always compute the execution & symbol context (PR #148994)

2025-07-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/148994 >From a4034e2f0948bfa61bfbf681bd5d9355aeb09beb Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 15 Jul 2025 16:54:05 -0700 Subject: [PATCH] [lldb] Always compute the execution & symbol context A

[Lldb-commits] [lldb] [lldb] Protect the selected frame idx in StackFrameList (PR #150718)

2025-07-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/150718 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e76780b - [lldb] Protect the selected frame idx in StackFrameList (#150718)

2025-07-25 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-25T18:03:09-07:00 New Revision: e76780b9da76295f88cb24817e9384b88e6416dc URL: https://github.com/llvm/llvm-project/commit/e76780b9da76295f88cb24817e9384b88e6416dc DIFF: https://github.com/llvm/llvm-project/commit/e76780b9da76295f88cb24817e9384b88e6416dc.d

[Lldb-commits] [lldb] [lldb] Protect the selected frame idx in StackFrameList (PR #150718)

2025-07-25 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/150718 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Protect the selected frame idx in StackFrameList (PR #150718)

2025-07-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/150718 Protected m_selected_frame_idx using the StackFrameList mutex. All other readers and writes already take the m_list_mutex so we can use that to protect concurrent access. >From 0c77d94246d94004e73d7e097a3

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-25 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: > This makes sense, but I wouldn't want people to start using > `@remove_test_categories` randomly. Could you make it so that the removal > logic is internal to the magic test multiplier? The code is already dealing > with categories explicitly, so I think that you could just

[Lldb-commits] [lldb] [lldb] Use std::make_shared where possible (NFC) (PR #150714)

2025-07-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/150714 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cf6a4bb - [lldb] Use std::make_shared where possible (NFC) (#150714)

2025-07-25 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-25T15:55:21-07:00 New Revision: cf6a4bbc42c7e54bf6e251206134b207e757b604 URL: https://github.com/llvm/llvm-project/commit/cf6a4bbc42c7e54bf6e251206134b207e757b604 DIFF: https://github.com/llvm/llvm-project/commit/cf6a4bbc42c7e54bf6e251206134b207e757b604.d

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-25 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/150579 >From f687e98f005544a4a9c7dad38579f5f91573a6ed Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 24 Jul 2025 23:46:37 -0700 Subject: [PATCH] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows

[Lldb-commits] [lldb] [lldb][rpc] Disable building lldb-rpc-gen tool (PR #150699)

2025-07-25 Thread Vladimir Vereschaka via lldb-commits
@@ -323,6 +323,14 @@ else() set(LLDB_CAN_USE_DEBUGSERVER OFF) endif() +if (NOT DEFINED LLDB_CAN_USE_LLDB_RPC_SERVER) + set(LLDB_CAN_USE_LLDB_RPC_SERVER OFF) +endif() + +if (NOT DEFINED LLDB_BUILD_LLDBRPC) vvereschaka wrote: Probably you just forgot to re

[Lldb-commits] [lldb] [lldb][rpc] Disable building lldb-rpc-gen tool (PR #150699)

2025-07-25 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/150699 >From e2aeab7dfb6a7db3f43a9a714d3b00de36ecf5f3 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Fri, 25 Jul 2025 13:43:43 -0700 Subject: [PATCH] [lldb][rpc] Disable building lldb-rpc-gen tool Disabl

[Lldb-commits] [lldb] [lldb][rpc] Disable building lldb-rpc-gen tool (PR #150699)

2025-07-25 Thread Martin Storsjö via lldb-commits
https://github.com/mstorsjo approved this pull request. Not sure if this is the best/nicest fix, but it works for unbreaking my builds, so thanks! https://github.com/llvm/llvm-project/pull/150699 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [lldb][rpc] Disable building lldb-rpc-gen tool (PR #150699)

2025-07-25 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/150699 >From 9890570dd8819bdc3e745b045c725d335a304c9a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Fri, 25 Jul 2025 13:43:43 -0700 Subject: [PATCH] [lldb][rpc] Disable building lldb-rpc-gen tool Disabl

[Lldb-commits] [lldb] [lldb][rpc] Disable building lldb-rpc-gen tool (PR #150699)

2025-07-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes Disabling the lldb-rpc-gen tool while issues with certain builds are solved: https://github.com/llvm/llvm-project/pull/148996 --- Full diff: https://github.com/llvm/llvm-project/pull/150699.diff

[Lldb-commits] [lldb] [lldb][rpc] Disable building lldb-rpc-gen tool (PR #150699)

2025-07-25 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/150699 Disabling the lldb-rpc-gen tool while issues with certain builds are solved: https://github.com/llvm/llvm-project/pull/148996 >From cd91a8c70687e28fe1089e24cbcd45d3c44d0133 Mon Sep 17 00:00:00 2001 From:

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-25 Thread Vladimir Vereschaka via lldb-commits
vvereschaka wrote: Thank you @mstorsjo , >This is fairly easy to reproduce on Linux, if you e.g. on x86_64 linux have >aarch64 cross compilers available (on Debian/Ubuntu available by installing >g++-aarch64-linux-gnu): I suppose, the LLVM_HOST_TRIPLE option causes that problem with RPC gen,

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-25 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: Also, another less fatal annoyance: If compiling LLDB with GCC, this now produces warnings like these: ``` [1/78] Processing file /home/martin/code/llvm-project/lldb/include/lldb/API/SBAddress.h. warning: unknown warning option '-Wno-class-memaccess'; did you mean '-Wno-class-v

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-25 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/147655 >From fd971a1109662f763b2c273fb39d2ef431afbe60 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 24 Jul 2025 14:05:55 -0700 Subject: [PATCH 1/4] [lldb][rpc] Add RPC client library tests Adds she

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-25 Thread Santhosh Kumar Ellendula via lldb-commits
santhoshe447 wrote: > This patch still only recognizes the `xqci` from the ELF file and adds it to > the disassembly flags (v. ObjectFileELF::GetSectionHeaderInfo, > ObjectFileELF::ParseRISCVAttributes). > > Is this the only attribute that can be set via this mechanism? is it possible > for o

[Lldb-commits] [lldb] [lldb-dap] Add performance optimization options to improve launch times (PR #150365)

2025-07-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. The [LLVM Developer Policy](https://llvm.org/docs/DeveloperPolicy.html#ai-generated-contributions) states: > While the LLVM project has a liberal policy on AI tool use, contributors are > considered responsible for their

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-25 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > @JDevlieghere do you have a WIP tree they can use that has more changes? Not currently no, but it's only one or two patches more patches before we have parity with the original PR. I just need to decide how to split them up once this PR lands. As much as I enjoy the disc

[Lldb-commits] [lldb] [LLDB][NativePDB] Allow type lookup in namespaces (PR #149876)

2025-07-25 Thread via lldb-commits
@@ -134,7 +134,9 @@ bool TypeQuery::ContextMatches( if (ctx == ctx_end) return false; // Pattern too long. -if (ctx->kind == CompilerContextKind::Namespace && ctx->name.IsEmpty()) { +if ((ctx->kind & CompilerContextKind::Namespace) == Nerixyz

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-25 Thread Michael Buch via lldb-commits
@@ -2471,6 +2471,47 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +llvm::Error +SymbolFileDWARF::FindAndResolveFunction(SymbolContextList &sc_list, +llvm::StringRef lookup_name) { + std::lock_guar

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-25 Thread Michael Buch via lldb-commits
@@ -771,6 +774,63 @@ class LoadAddressResolver { lldb::addr_t m_best_internal_load_address = LLDB_INVALID_ADDRESS; }; +/// Returns address of the function referred to by the special function call +/// label \c label. +/// +/// \param[in] label Function call label encoding th

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-25 Thread Michael Buch via lldb-commits
@@ -96,6 +96,31 @@ class Expression { ///invalid. }; +/// Holds parsed information about a function call label that +/// LLDB attaches as an AsmLabel to function AST nodes it parses +/// from debug-info. +/// +/// The format being: +/// +///

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-25 Thread Michael Buch via lldb-commits
@@ -96,6 +96,31 @@ class Expression { ///invalid. }; +/// Holds parsed information about a function call label that +/// LLDB attaches as an AsmLabel to function AST nodes it parses +/// from debug-info. +/// +/// The format being: +/// +///

[Lldb-commits] [lldb] 7b42e7c - [LLDB] Add formatters for MSVC STL std::string_view and friends (#150318)

2025-07-25 Thread via lldb-commits
Author: nerix Date: 2025-07-25T17:01:35+01:00 New Revision: 7b42e7c98e13bd9f50db754346de946b3a6e1bbe URL: https://github.com/llvm/llvm-project/commit/7b42e7c98e13bd9f50db754346de946b3a6e1bbe DIFF: https://github.com/llvm/llvm-project/commit/7b42e7c98e13bd9f50db754346de946b3a6e1bbe.diff LOG: [L

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::string_view and friends (PR #150318)

2025-07-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/150318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::string_view and friends (PR #150318)

2025-07-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/150318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::string_view and friends (PR #150318)

2025-07-25 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/150318 >From 87f45bf97c50a7478fded9702972a83f667c1f68 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Wed, 23 Jul 2025 22:31:28 +0200 Subject: [PATCH 1/2] [LLDB] Add formatters for MSVC STL std::string_view and friends

[Lldb-commits] [lldb] 6adbbcc - [lldb][docs] Correct link syntax for wasm tracking issue

2025-07-25 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-07-25T14:53:28Z New Revision: 6adbbcc7dbcf4ee65c74d396f555f3e057271d9b URL: https://github.com/llvm/llvm-project/commit/6adbbcc7dbcf4ee65c74d396f555f3e057271d9b DIFF: https://github.com/llvm/llvm-project/commit/6adbbcc7dbcf4ee65c74d396f555f3e057271d9b.diff LOG

[Lldb-commits] [lldb] Draft: [LLDB] Add scalar literal node (PR #147064)

2025-07-25 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > > single interface to traverse the AST tree: > > That's the part that would change in this setup. Instead of one API, we'd > have two: `EvaluateValueNode()` and `EvaluateScalarNode()`, and we'd have two > node hierarchies: ValueNode and ScalarNode. MemberOfNode would be a Value

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-25 Thread David Spickett via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// DavidSpickett wrote: Cool. https://github.com/llvm/llvm-project/pull/150143 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-25 Thread David Spickett via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: > I'm personally skeptical of this part. LLDB's command line driver is very > small and doesn't do much. You absolutely could turn that into a DAP client, > but you wouldn't get much in return. Most of the "TUI" parts of LLDB are > tightly coupled with the core of the libr

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -20,212 +18,342 @@ using namespace testing; namespace { -class MockSyncService : public AdbClient::SyncService { +class MockConnection : public Connection { labath wrote: Is this used anywhere? If it is, it may be better to just use a real connection ins

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,46 @@ +//===-- AdbClientUtils.h --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -220,6 +220,12 @@ ConnectionStatus ConnectionFileDescriptor::Disconnect(Status *error_ptr) { // Prevents reads and writes during shutdown. m_shutting_down = true; + if (!m_io_sp) { labath wrote: Is this still needed? I mean, it sort of makes sense, b

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -8,98 +8,45 @@ #include "AdbClient.h" -#include "llvm/ADT/STLExtras.h" -#include "llvm/ADT/SmallVector.h" -#include "llvm/ADT/StringRef.h" -#include "llvm/Support/FileUtilities.h" - -#include "lldb/Host/ConnectionFileDescriptor.h" -#include "lldb/Host/FileSystem.h" -#inclu

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -32,50 +34,14 @@ class AdbClient { using DeviceIDList = std::list; - class SyncService { -friend class AdbClient; - - public: -virtual ~SyncService(); - -virtual Status PullFile(const FileSpec &remote_file, -const FileSpec &local

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -418,13 +436,68 @@ bool PlatformAndroid::GetRemoteOSVersion() { return !m_os_version.empty(); } +uint32_t PlatformAndroid::FindProcesses( +const ProcessInstanceInfoMatch &match_info, +ProcessInstanceInfoList &process_infos) { + Status error; + AdbClientUP adb(Ge

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -418,13 +436,68 @@ bool PlatformAndroid::GetRemoteOSVersion() { return !m_os_version.empty(); } +uint32_t PlatformAndroid::FindProcesses( labath wrote: How does this relate to the rest of the patch? https://github.com/llvm/llvm-project/pull/145382 _

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -445,11 +518,9 @@ PlatformAndroid::GetLibdlFunctionDeclarations(lldb_private::Process *process) { } PlatformAndroid::AdbClientUP PlatformAndroid::GetAdbClient(Status &error) { - AdbClientUP adb(std::make_unique(m_device_id)); - if (adb) -error.Clear(); - else -e

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -108,62 +55,73 @@ Status AdbClient::CreateByDeviceID(const std::string &device_id, "Expected a single connected device, got instead %zu - try " "setting 'ANDROID_SERIAL'", connected_devices.size()); -adb.SetDeviceID(connected_devices.front(

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I like what you've done, though it makes it a bit difficult to review. In the future, if you find yourself moving lot of code around, try to separate that from the functional changes into a PR of its own. That makes things flow a lot easier. In this case,

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Hence why I think the "user" approach is the most promising, generally > speaking. Agreed. If I want to debug qemu-user I treat it like any other program, if I want the simulated process I connect to the internal stub. Some will want integrated solutions but that can co

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-25 Thread Quentin Michaud via lldb-commits
mh4ck-Thales wrote: I tested this patch and while basic debugging works, some features that were available in #77949 are not working anymore (retrieval of variable values, disassembly of the Wasm bytecode...). I'm not sure if it's a bug or if it's because the #77949 patch has been split into i

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-25 Thread Quentin Michaud via lldb-commits
mh4ck-Thales wrote: > I'd be happy to keep chatting about this if you're interested in exploring > that path further, now or in the future. I also don't want to necessarily > push you towards the GDB remote protocol. For languages like C++, Rust, > Swift, or really anything targeting LLVM/supp

[Lldb-commits] [lldb] [LLDB] Make MSVC STL formatters work with (Native/DIA) PDB (PR #150513)

2025-07-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: > It also adds tests for both plugins. They are shell tests, because API tests > currently only test with DWARF and after > https://github.com/llvm/llvm-project/pull/149305 they'd only test with one > plugin. They're not as exhaustive as the API tests - their goal is to sh

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-25 Thread Quentin Michaud via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,162 @@ +//===-- AdbClientUtils.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,162 @@ +//===-- AdbClientUtils.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-25 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: This makes sense, but I wouldn't want people to start using `@remove_test_categories` randomly. Could you make it so that the removal logic is internal to the magic test multiplier? The code is already dealing with categories explicitly, so I think that you

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -1799,6 +1799,7 @@ def no_reason(_): for cat in categories: @decorators.add_test_categories([cat]) +@decorators.remove_test_categories(categories) labath wrote: (Also, the decorators are applied from

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -1799,6 +1799,7 @@ def no_reason(_): for cat in categories: @decorators.add_test_categories([cat]) +@decorators.remove_test_categories(categories) labath wrote: The loop creates a new function every i

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -771,6 +774,63 @@ class LoadAddressResolver { lldb::addr_t m_best_internal_load_address = LLDB_INVALID_ADDRESS; }; +/// Returns address of the function referred to by the special function call +/// label \c label. +/// +/// \param[in] label Function call label encoding th

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -2471,6 +2471,47 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +llvm::Error +SymbolFileDWARF::FindAndResolveFunction(SymbolContextList &sc_list, +llvm::StringRef lookup_name) { + std::lock_guar

[Lldb-commits] [lldb] [lldb] Remove unnecessary calls to Fix{Code, Data}Address (PR #150537)

2025-07-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: Your idea sounds fine, no idea if any of these are load bearing but test suites are the only way to find out. If Mac is fine go ahead and land this, the AArch64 Linux bot has top byte ignore and pointer authentication available. https://github.com/llvm/llvm-project/pull/15

[Lldb-commits] [lldb] [llvm] [LLDB] Switch to using DIL as default implementation for 'frame var'. (PR #147887)

2025-07-25 Thread via lldb-commits
llvmbot wrote: /pull-request llvm/llvm-project#150600 https://github.com/llvm/llvm-project/pull/147887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -96,6 +96,31 @@ class Expression { ///invalid. }; +/// Holds parsed information about a function call label that +/// LLDB attaches as an AsmLabel to function AST nodes it parses +/// from debug-info. +/// +/// The format being: +/// +///

[Lldb-commits] [lldb] [llvm] [LLDB] Switch to using DIL as default implementation for 'frame var'. (PR #147887)

2025-07-25 Thread Pavel Labath via lldb-commits
labath wrote: Okay, here goes nothing. https://github.com/llvm/llvm-project/pull/147887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLDB] Switch to using DIL as default implementation for 'frame var'. (PR #147887)

2025-07-25 Thread Pavel Labath via lldb-commits
labath wrote: /cherry-pick f5c676d6d95dc63b8dcb43dd2e4dfc913a9c5a50 33396d71e9aef624670380e11348a11b8ff74246 https://github.com/llvm/llvm-project/pull/147887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] [llvm] [LLDB] Switch to using DIL as default implementation for 'frame var'. (PR #147887)

2025-07-25 Thread Pavel Labath via lldb-commits
https://github.com/labath milestoned https://github.com/llvm/llvm-project/pull/147887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] added getName method in SBModule (PR #150331)

2025-07-25 Thread Pavel Labath via lldb-commits
labath wrote: I don't think that `m_object_name` is what you're looking for. It's supposed to be used for disambiguation when a single physical file contains multiple logical object files, such as with BSD archives. It being empty for "normal" files is kind of expected: ``` ConstString m_obj

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -247,6 +248,28 @@ uint32_t File::GetPermissions(Status &error) const { return file_stats.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO); } +NativeFile::NativeFile() +: m_descriptor(kInvalidDescriptor), m_stream(kInvalidStream) {} + +NativeFile::NativeFile(FILE *fh, bool tran

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: Same issue reported in https://github.com/llvm/llvm-project/issues/150454. https://github.com/llvm/llvm-project/pull/148996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -1978,7 +1978,12 @@ llvm::Expected DWARFExpression::Evaluate( // grows to the nearest host integer type. llvm::APInt fail_value(1, 0, false); llvm::APInt ap_int = scalar.UInt128(fail_value); -assert(ap_int.getBitWidth() >= bit_

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-25 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/150149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-25 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I'm not sure that what clang is doing is completely compliant. According to the standard, DWARF expression values """can represent a value of any supported base type of the target machine. Instead of a base type, elements can have a generic type, which is a

[Lldb-commits] [lldb] [LLDB][NativePDB] Allow type lookup in namespaces (PR #149876)

2025-07-25 Thread Pavel Labath via lldb-commits
@@ -134,7 +134,9 @@ bool TypeQuery::ContextMatches( if (ctx == ctx_end) return false; // Pattern too long. -if (ctx->kind == CompilerContextKind::Namespace && ctx->name.IsEmpty()) { +if ((ctx->kind & CompilerContextKind::Namespace) == labath

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::string_view and friends (PR #150318)

2025-07-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM (just left comment re. null summary) https://github.com/llvm/llvm-project/pull/150318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::string_view and friends (PR #150318)

2025-07-25 Thread Michael Buch via lldb-commits
@@ -78,14 +78,12 @@ def cleanup(): "u32_string", type="std::u32string_view", summary='U"🍄🍅🍆🍌"' ) self.expect_var_path("u32_empty", type="std::u32string_view", summary='U""') -self.expect_var_path( -"oops", type="std::string_view"

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150398)

2025-07-25 Thread via lldb-commits
llvmbot wrote: /pull-request llvm/llvm-project#150591 https://github.com/llvm/llvm-project/pull/150398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c63c2f4 - [lldb][docs] Add WASM support issue link to website

2025-07-25 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-07-25T08:41:16Z New Revision: c63c2f4972f63cd19352719c966659bb80cec450 URL: https://github.com/llvm/llvm-project/commit/c63c2f4972f63cd19352719c966659bb80cec450 DIFF: https://github.com/llvm/llvm-project/commit/c63c2f4972f63cd19352719c966659bb80cec450.diff LOG

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150398)

2025-07-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett milestoned https://github.com/llvm/llvm-project/pull/150398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150398)

2025-07-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: /cherry-pick 1a32bcb4379fb90d2b764ac33b917de1431c6b16 https://github.com/llvm/llvm-project/pull/150398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/150579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-25 Thread David Spickett via lldb-commits
@@ -1799,6 +1799,7 @@ def no_reason(_): for cat in categories: @decorators.add_test_categories([cat]) +@decorators.remove_test_categories(categories) DavidSpickett wrote: I don't understand how this loop

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: Agree with the intent, very confused by the implementation. https://github.com/llvm/llvm-project/pull/150579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-25 Thread Michael Buch via lldb-commits
@@ -2471,6 +2471,47 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +llvm::Error +SymbolFileDWARF::FindAndResolveFunction(SymbolContextList &sc_list, +llvm::StringRef lookup_name) { + std::lock_guar

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-25 Thread Michael Buch via lldb-commits
@@ -771,6 +774,63 @@ class LoadAddressResolver { lldb::addr_t m_best_internal_load_address = LLDB_INVALID_ADDRESS; }; +/// Returns address of the function referred to by the special function call +/// label \c label. +/// +/// \param[in] label Function call label encoding th

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-25 Thread Michael Buch via lldb-commits
@@ -96,6 +96,31 @@ class Expression { ///invalid. }; +/// Holds parsed information about a function call label that +/// LLDB attaches as an AsmLabel to function AST nodes it parses +/// from debug-info. +/// +/// The format being: +/// +///

[Lldb-commits] [libcxx] [lldb] [libcxx] adds size-based `__split_buffer` representation to unstable ABI (PR #139632)

2025-07-25 Thread Christopher Di Bella via lldb-commits
cjdb wrote: @ldionne Would you mind reviewing this again, please? https://github.com/llvm/llvm-project/pull/139632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits