[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread Dave Lee via lldb-commits
@@ -150,6 +151,11 @@ llvm::Expected ValueObjectPrinter::GetDescriptionForDisplay() { if (maybe_str) return maybe_str; + if (maybe_str.errorIsA()) +// Propagate expression errors to expose diagnostics to the user. +// Without this early exit, the summary/value m

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread Dave Lee via lldb-commits
kastiglione wrote: > That's changing this UI to NOT print the value if the `po` expression fails > for some reason. > > Is that your intent? it's my intent when the failure is a _compiler reason_ – which is to make a distinction that this is a more narrow change than "some reason". https://gi

[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

2025-08-07 Thread Ely Ronnen via lldb-commits
eronnen wrote: @JDevlieghere Pinging in case you still would like to review :grimacing: https://github.com/llvm/llvm-project/pull/148061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread Dave Lee via lldb-commits
kastiglione wrote: The ultimate intent is to show errors preventing an expected successful object description. If producing an object description fails, printing an object's address (value) is not what users expect. We can change this to print the error and the value, but I don't expect any us

[Lldb-commits] [lldb] Reland "[NFC][lldb] Speed up lookup of shared modules" (229d860) (PR #152607)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Augusto Noronha (augusto2112) Changes The previous commit was reverted because it broke a test on the bots. Original commit message: By profiling LLDB debugging a Swift application without a dSYM and a large amount of .o files, I identifi

[Lldb-commits] [lldb] Reland "[NFC][lldb] Speed up lookup of shared modules" (229d860) (PR #152607)

2025-08-07 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: @JDevlieghere I addresses the comments you left on https://github.com/llvm/llvm-project/pull/152054 https://github.com/llvm/llvm-project/pull/152607 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [lldb] Reland "[NFC][lldb] Speed up lookup of shared modules" (229d860) (PR #152607)

2025-08-07 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/152607 The previous commit was reverted because it broke a test on the bots. Original commit message: By profiling LLDB debugging a Swift application without a dSYM and a large amount of .o files, I identified th

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-08-07 Thread via lldb-commits
jimingham wrote: You can easily unwind when you're done looking at a crashed expression with `thread return -x` - there is probably an SB API way to do that as well but I don't remember it off the top of my head. So you could support the `UnwindOnError(False)` pretty easily by doing that afte

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152599)

2025-08-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. ConstString? ugh. https://github.com/llvm/llvm-project/pull/152599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152599)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/152599 >From 296b5377ae0e24e43d9de9e508e88f67011c1356 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 7 Aug 2025 14:50:06 -0700 Subject: [PATCH 1/2] [lldb] Support the Python stable C API in PythonStr

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152599)

2025-08-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/ScriptInterpreter/Python/PythonDa

[Lldb-commits] [lldb] [lldb] Only use PyConfig when LLDB_EMBED_PYTHON_HOME is enabled (PR #152588)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Part of https://github.com/llvm/llvm-project/issues/151617 https://github.com/llvm/llvm-project/pull/152588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152599)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: This PR is a NOOP unless you have `LLDB_ENABLE_PYTHON_LIMITED_API` enabled. https://github.com/llvm/llvm-project/pull/152599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152599)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This conditionally reimplements PythonString::AsUTF8 using PyUnicode_AsUTF8String instead of PyUnicode_AsUTF8AndSize. PyUnicode_AsUTF8AndSize caches the UTF-8 representation of the string in the Un

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152599)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152599 This conditionally reimplements PythonString::AsUTF8 using PyUnicode_AsUTF8String instead of PyUnicode_AsUTF8AndSize. PyUnicode_AsUTF8AndSize caches the UTF-8 representation of the string in the Unicode o

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan deleted https://github.com/llvm/llvm-project/pull/152054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] 41b5880 - [LLDB] Run a few more PDB tests with native PDB as well (#152580)

2025-08-07 Thread via lldb-commits
Author: nerix Date: 2025-08-07T13:44:32-07:00 New Revision: 41b5880c957320b1be68cdb642ba735fdd27bb7c URL: https://github.com/llvm/llvm-project/commit/41b5880c957320b1be68cdb642ba735fdd27bb7c DIFF: https://github.com/llvm/llvm-project/commit/41b5880c957320b1be68cdb642ba735fdd27bb7c.diff LOG: [L

[Lldb-commits] [lldb] Revert "[NFC][lldb] Speed up lookup of shared modules (#152054)" (PR #152582)

2025-08-07 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/22275 Here is the relevant piece of the b

[Lldb-commits] [lldb] [lldb] Only use PyConfig when LLDB_EMBED_PYTHON_HOME is enabled (PR #152588)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -134,9 +115,30 @@ struct InitializePythonRAII { PyImport_AppendInittab("_lldb", LLDBSwigPyInit); } +#if LLDB_EMBED_PYTHON_HOME JDevlieghere wrote: Part of it, yes, but you could avoid changing the order by splitting the ifdef-ed code in two, whi

[Lldb-commits] [lldb] [LLDB] Run a few more PDB tests with native PDB as well (PR #152580)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I've filed https://github.com/llvm/llvm-project/issues/152594 to track this. https://github.com/llvm/llvm-project/pull/152580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,240 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,240 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: More nits. This also shouldn't have been merged without an LGTM/approval. https://github.com/llvm/llvm-project/pull/152054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,240 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [lldb] Only use PyConfig when LLDB_EMBED_PYTHON_HOME is enabled (PR #152588)

2025-08-07 Thread Med Ismail Bennani via lldb-commits
@@ -134,9 +115,30 @@ struct InitializePythonRAII { PyImport_AppendInittab("_lldb", LLDBSwigPyInit); } +#if LLDB_EMBED_PYTHON_HOME medismailben wrote: Was moving the initialization past the `if (!Py_IsInitialized()) {` needed ? https://github.com/ll

[Lldb-commits] [lldb] [LLDB] Run a few more PDB tests with native PDB as well (PR #152580)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (PR #145382)

2025-08-07 Thread Chad Smith via lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-08-07 Thread Chad Smith via lldb-commits
cs01 wrote: Friendly ping @labath https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,240 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,240 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,240 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/152054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,240 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [lldb] Only use PyConfig when LLDB_EMBED_PYTHON_HOME is enabled (PR #152588)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes PyConfig and friends are not part of the stable API. We could switch back to Py_SetPythonHome, which has been deprecated, but still part of the stable API. For now, limit the use of PyConfig to when

[Lldb-commits] [lldb] [lldb] Only use PyConfig when LLDB_EMBED_PYTHON_HOME is enabled (PR #152588)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152588 PyConfig and friends are not part of the stable API. We could switch back to Py_SetPythonHome, which has been deprecated, but still part of the stable API. For now, limit the use of PyConfig to when LLDB_E

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-08-07 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: > Seems like this is [tripping > up](https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake-sanitized/2038/testReport/lldb-unit/Instruction___EmulatorTests_1/16/) > UBSan: Thanks for reporting, fixed in 11e1d46 https://github.com/llvm/llvm-project/pull/151460 __

[Lldb-commits] [lldb] 11e1d46 - [lldb] Fix UBSan complaints for #151460

2025-08-07 Thread Igor Kudrin via lldb-commits
Author: Igor Kudrin Date: 2025-08-07T13:01:52-07:00 New Revision: 11e1d465860903fd9ead27c0c1e60de4439011db URL: https://github.com/llvm/llvm-project/commit/11e1d465860903fd9ead27c0c1e60de4439011db DIFF: https://github.com/llvm/llvm-project/commit/11e1d465860903fd9ead27c0c1e60de4439011db.diff L

[Lldb-commits] [lldb] Revert "[NFC][lldb] Speed up lookup of shared modules (#152054)" (PR #152582)

2025-08-07 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/152582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[NFC][lldb] Speed up lookup of shared modules (#152054)" (PR #152582)

2025-08-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Core/ModuleList.cpp `` View

[Lldb-commits] [lldb] 75cc77e - Revert "[NFC][lldb] Speed up lookup of shared modules (#152054)" (#152582)

2025-08-07 Thread via lldb-commits
Author: Augusto Noronha Date: 2025-08-07T12:49:47-07:00 New Revision: 75cc77e55e12d39aed94702b0b1365e39713081e URL: https://github.com/llvm/llvm-project/commit/75cc77e55e12d39aed94702b0b1365e39713081e DIFF: https://github.com/llvm/llvm-project/commit/75cc77e55e12d39aed94702b0b1365e39713081e.dif

[Lldb-commits] [lldb] Revert "[NFC][lldb] Speed up lookup of shared modules (#152054)" (PR #152582)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Augusto Noronha (augusto2112) Changes This reverts commit 229d86026fa0e5d9412a0d5004532f0d9733aac6. --- Full diff: https://github.com/llvm/llvm-project/pull/152582.diff 1 Files Affected: - (modified) lldb/source/Core/ModuleList.cpp (+7-2

[Lldb-commits] [lldb] Revert "[NFC][lldb] Speed up lookup of shared modules (#152054)" (PR #152582)

2025-08-07 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/152582 This reverts commit 229d86026fa0e5d9412a0d5004532f0d9733aac6. >From 2c9d14251c8a5bd2354d2747d44b8bb7db30c3b1 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 7 Aug 2025 12:44:40 -0700 Subject: [PAT

[Lldb-commits] [lldb] [LLDB] Run a few more PDB tests with native PDB as well (PR #152580)

2025-08-07 Thread via lldb-commits
Nerixyz wrote: > IIUC, if you don't have DIA enabled, these tests will basically run the same > test twice (both using the NativePDB reader). Yes, that's not ideal. I don't know Lit too well, but a shared test set could be great. That would also track the progress of the native plugin. https:

[Lldb-commits] [lldb] [LLDB] Run a few more PDB tests with native PDB as well (PR #152580)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. I wonder though if there's something better we can do here. IIUC, if you don't have DIA enabled, these tests will basically run the same test twice (both using the NativePDB reader). It would be nice if we could avoid that, and

[Lldb-commits] [lldb] [LLDB] Run a few more PDB tests with native PDB as well (PR #152580)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Some DIA PDB tests pass with the native plugin already, but didn't test this. This adds test runs with the native plugin - no functional changes. In addition to the x86 calling convention test, there's also https:/

[Lldb-commits] [lldb] [LLDB] Run a few more PDB tests with native PDB as well (PR #152580)

2025-08-07 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/152580 Some DIA PDB tests pass with the native plugin already, but didn't test this. This adds test runs with the native plugin - no functional changes. In addition to the x86 calling convention test, there's also ht

[Lldb-commits] [lldb] [LLDB][NativePDB] Resolve declaration for tag types (PR #152579)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Tag types like stucts or enums didn't have a declaration attached to them. The source locations are present in the IPI stream in `LF_UDT_MOD_SRC_LINE` records: ``` 0x101F | LF_UDT_MOD_SRC_LINE [size = 18, hash =

[Lldb-commits] [lldb] [LLDB][NativePDB] Resolve declaration for tag types (PR #152579)

2025-08-07 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/152579 Tag types like stucts or enums didn't have a declaration attached to them. The source locations are present in the IPI stream in `LF_UDT_MOD_SRC_LINE` records: ``` 0x101F | LF_UDT_MOD_SRC_LINE [size = 18, ha

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread via lldb-commits
jimingham wrote: The way we've been doing the `po` implementations for a while now is: "If the object description succeeds, print the object description, otherwise print the value." This routine gets used here: llvm::Expected object_desc = (value_printed || summary_printed)

[Lldb-commits] [lldb] [LLDB] Add `ScalarLiteralNode` and literal parsing in DIL (PR #152308)

2025-08-07 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/152308 >From 55fbd4724159eea9868df1eeac9b83bf5894544b Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Fri, 1 Aug 2025 20:14:59 +0500 Subject: [PATCH 1/4] Add ScalarLiteralNode --- lldb/include/lldb/ValueObject/DILAST

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-08-07 Thread via lldb-commits
athierry-oct wrote: Sounds good, thank you! In the test, it seems the intention was originally to set UnwindOnError to true, but it's still set to false when evaluating the expression (there's no call to `options.SetUnwindOnError(False)` after the comment that says "now set UnwindOnError to t

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread via lldb-commits
jimingham wrote: I think it would be more in line with user's expectations if, instead of directly returning maybe_string in this case, you build a new string that has: Object Description Error: foo = 10 or something like that. https://github.com/llvm/llvm-project/pull/152417 _

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread via lldb-commits
jimingham wrote: Our experience is that people think `po` is the way to show them values, and so they will ALWAYS want to see the value regardless of where it comes from. https://github.com/llvm/llvm-project/pull/152417 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] 229d860 - [NFC][lldb] Speed up lookup of shared modules (#152054)

2025-08-07 Thread via lldb-commits
Author: Augusto Noronha Date: 2025-08-07T11:12:38-07:00 New Revision: 229d86026fa0e5d9412a0d5004532f0d9733aac6 URL: https://github.com/llvm/llvm-project/commit/229d86026fa0e5d9412a0d5004532f0d9733aac6 DIFF: https://github.com/llvm/llvm-project/commit/229d86026fa0e5d9412a0d5004532f0d9733aac6.dif

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-08-07 Thread via lldb-commits
jimingham wrote: If the user has set "UnwindOnException" to false in their ExpressionOptions, we need to propagate that stop event and the driver would need to consume it to show the user that they are stopped at the crash site. So we definitely have to rebroadcast the event and the driver ne

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-07 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/152054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix incorrect print of UUID and load address (PR #152560)

2025-08-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/152560 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix incorrect print of UUID and load address (PR #152560)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/152560 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix incorrect print of UUID and load address (PR #152560)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dominic Chen (ddcc) Changes The current display is missing a space, for example: ``` no target │ Locating binary: 24906A83-0182-361B-8B4A-90A249B04FD7at 0x000c0d108000 ``` --- Full diff: https://github.com/llvm/llvm-project/pull/152560

[Lldb-commits] [lldb] [lldb] Fix incorrect print of UUID and load address (PR #152560)

2025-08-07 Thread Dominic Chen via lldb-commits
https://github.com/ddcc created https://github.com/llvm/llvm-project/pull/152560 The current display is missing a space, for example: ``` no target │ Locating binary: 24906A83-0182-361B-8B4A-90A249B04FD7at 0x000c0d108000 ``` >From 4c9d337dcd01c6713fc6a250ac30bdb22ae1abfb Mon Sep 17 00:00:00

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #152367)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/152367 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ARM] Port Arm Linux to use NativeRegisterContextDBReg (PR #152284)

2025-08-07 Thread via lldb-commits
b10902118 wrote: Other parts looks the same as my previous try. I haven't test this one, but older version seems to already have problem with thumb breakpoint. In my manual test, soft bp caused segmentation fault on 6.15 arm64 linux kernel (just remember qemu complained [GUP] and gpt says it i

[Lldb-commits] [lldb] [lldb][ARM] Port Arm Linux to use NativeRegisterContextDBReg (PR #152284)

2025-08-07 Thread via lldb-commits
https://github.com/b10902118 edited https://github.com/llvm/llvm-project/pull/152284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ARM] Port Arm Linux to use NativeRegisterContextDBReg (PR #152284)

2025-08-07 Thread via lldb-commits
@@ -76,17 +77,26 @@ class NativeRegisterContextDBReg // On AArch64 and Loongarch the hardware breakpoint length size is 4, and the // target address must 4-byte alignment. - bool ValidateBreakpoint(size_t size, lldb::addr_t addr) { + virtual bool ValidateBreakpoint(size_

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #152367)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Reapply "[lldb] Update JSONTransport to use MainLoop for reading." (#152155) This reverts commit cd40281685f642ad879e33f3fda8d1faa136ebf4. This also includes some updates to try to address the platforms with

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #152367)

2025-08-07 Thread John Harrison via lldb-commits
https://github.com/ashgti ready_for_review https://github.com/llvm/llvm-project/pull/152367 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #152367)

2025-08-07 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/152367 >From 02417f51a23fbfd4d941b6f9b18e82fe8eb87566 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 5 Aug 2025 11:23:31 -0700 Subject: [PATCH] [lldb] Update JSONTransport to use MainLoop for reading. Reapply

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add network symbol optimization configuration options (PR #150777)

2025-08-07 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Yes, could you split this path into smaller ones? That's more standard for LLDB https://github.com/llvm/llvm-project/pull/150777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] 44aedac - [lldb] Move the generic MCP server code into Protocol/MCP (NFC) (#152396)

2025-08-07 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-07T09:01:28-07:00 New Revision: 44aedacb1b64b415fddfada39eb876602980ea72 URL: https://github.com/llvm/llvm-project/commit/44aedacb1b64b415fddfada39eb876602980ea72 DIFF: https://github.com/llvm/llvm-project/commit/44aedacb1b64b415fddfada39eb876602980ea72.d

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-08-07 Thread via lldb-commits
athierry-oct wrote: Thanks for your help! I did a bit more digging : in `TestCallThatRestarts.py`, it seems the stop event is sent by `EvaluateExpression()` to the primary listener because the process is stopped by a signal (SIGCHLD). So, the execution of the thread plan that runs during expr

[Lldb-commits] [lldb] [lldb][ARM] Port Arm Linux to use NativeRegisterContextDBReg (PR #152284)

2025-08-07 Thread via lldb-commits
@@ -0,0 +1,116 @@ +//===-- NativeRegisterContextDBReg_arm.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Move the generic MCP server code into Protocol/MCP (NFC) (PR #152396)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLVM] [LLDB] Emit and handle `lf_alias` nodes (PR #152484)

2025-08-07 Thread David Blaikie via lldb-commits
dwblaikie wrote: (I'm not particularly up on the details of PDB - but this patch should land, if/when it lands, in a few parts (& maybe should be separate pull requests) - the LLVM side of things, for instance, could be separated from the LLDB parts at least, I think) https://github.com/llvm/

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-07 Thread John Harrison via lldb-commits
ashgti wrote: I don't know if there is any other documentation on that. Its in the code and supported and used by a few different extensions. For example, the npm extension uses this strategy for debugging with the vscode-js-debug extension. https://github.com/microsoft/vscode/blob/main/src/v

[Lldb-commits] [lldb] [lldb] Move the generic MCP server code into Protocol/MCP (NFC) (PR #152396)

2025-08-07 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/152396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-08-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Seems like this is [tripping up](https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake-sanitized/2038/testReport/lldb-unit/Instruction___EmulatorTests_1/16/) UBSan: ``` [--] 1 test from TestAArch64Emulator [ RUN ] TestAArch64Emulator.TestAutoAdvan

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread Adrian Prantl via lldb-commits
@@ -150,6 +151,11 @@ llvm::Expected ValueObjectPrinter::GetDescriptionForDisplay() { if (maybe_str) return maybe_str; + if (maybe_str.errorIsA()) +// Propagate expression errors to expose diagnostics to the user. +// Without this early exit, the summary/value m

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-08-07 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > > adding an option to the dissemble CommandObject is the right solution. > > Personally I think I would prefer an option to the CommandObject. Do you > > think this is feasible, or are there more many points through which the > > disassembly is reachable, making an optio

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-07 Thread Michael Buch via lldb-commits
@@ -2482,6 +2485,134 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +static int ClangToItaniumCtorKind(clang::CXXCtorType kind) { + switch (kind) { + case clang::CXXCtorType::Ctor_Complete: +return 1; + case clang::CXXCtorType::Cto

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-08-07 Thread Santhosh Kumar Ellendula via lldb-commits
santhoshe447 wrote: Kindly share any inputs or suggestion, if any. https://github.com/llvm/llvm-project/pull/147990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Mangled] Move SuffixRange computation into TrackingOutputBuffer (PR #152483)

2025-08-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/152483 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fac7453 - [lldb][Mangled] Move SuffixRange computation into TrackingOutputBuffer (#152483)

2025-08-07 Thread via lldb-commits
Author: Michael Buch Date: 2025-08-07T14:39:52+01:00 New Revision: fac7453d2ca7ebe33dec3d60211c0374a2bb69cd URL: https://github.com/llvm/llvm-project/commit/fac7453d2ca7ebe33dec3d60211c0374a2bb69cd DIFF: https://github.com/llvm/llvm-project/commit/fac7453d2ca7ebe33dec3d60211c0374a2bb69cd.diff

[Lldb-commits] [lldb] [lldb][Mangled] Move SuffixRange computation into TrackingOutputBuffer (PR #152483)

2025-08-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/152483 >From cdcb92a3012107dce4418de1c74c6142dc356a14 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 7 Aug 2025 13:11:59 +0100 Subject: [PATCH 1/2] [lldb][Mangled] Move SuffixRange computation into Tracking

[Lldb-commits] [lldb] [lldb][rpc] Fix build failures when building lldb-rpc-gen (PR #151603)

2025-08-07 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: > > Right - I see. But why does this build configuration have to affect whether > > it should build lldb-rpc-gen or not? Is it because the clang in this build > > can't manage to process the lldb headers (which are built for the current > > host)? > > Right, "the clang in this

[Lldb-commits] [lldb] [lldb][Mangled] Move SuffixRange computation into TrackingOutputBuffer (PR #152483)

2025-08-07 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit approved this pull request. https://github.com/llvm/llvm-project/pull/152483 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLVM] [LLDB] Emit and handle `lf_alias` nodes (PR #152484)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walnut (Walnut356) Changes This patch causes LLVM to emit `lf_alias` nodes for typedefs, allowing typedefs to be represented in the type data stream. Typedef `S_UDT` nodes are still created for the symbol stream. This strictly generates ad

[Lldb-commits] [lldb] [llvm] [LLVM] [LLDB] Emit and handle `lf_alias` nodes (PR #152484)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-platform-windows @llvm/pr-subscribers-debuginfo Author: Walnut (Walnut356) Changes This patch causes LLVM to emit `lf_alias` nodes for typedefs, allowing typedefs to be represented in the type data stream. Typedef `S_UDT` nodes are still created for th

[Lldb-commits] [lldb] [llvm] [LLVM] [LLDB] Emit and handle `lf_alias` nodes (PR #152484)

2025-08-07 Thread via lldb-commits
https://github.com/Walnut356 edited https://github.com/llvm/llvm-project/pull/152484 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLVM] [LLDB] Emit and handle `lf_alias` nodes (PR #152484)

2025-08-07 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [llvm] [LLVM] [LLDB] Emit and handle `lf_alias` nodes (PR #152484)

2025-08-07 Thread via lldb-commits
https://github.com/Walnut356 created https://github.com/llvm/llvm-project/pull/152484 This patch causes LLVM to emit `lf_alias` nodes for typedefs, allowing typedefs to be represented in the type data stream. Typedef `S_UDT` nodes are still created for the symbol stream. This strictly generate

[Lldb-commits] [lldb] [lldb][Mangled] Move SuffixRange computation into TrackingOutputBuffer (PR #152483)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This way all the tracking is self-contained in `TrackingOutputBuffer` and we can test the `SuffixRange` properly. --- Full diff: https://github.com/llvm/llvm-project/pull/152483.diff 5 Files Affected: -

[Lldb-commits] [lldb] [lldb][Mangled] Move SuffixRange computation into TrackingOutputBuffer (PR #152483)

2025-08-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/152483 This way all the tracking is self-contained in `TrackingOutputBuffer` and we can test the `SuffixRange` properly. >From cdcb92a3012107dce4418de1c74c6142dc356a14 Mon Sep 17 00:00:00 2001 From: Michael Buch D

[Lldb-commits] [lldb] [lldb] Don't crash if no default unwind plan (PR #152481)

2025-08-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Nikita Popov (nikic) Changes The code was assuming that if abi_sp is not null, then it will also return a non-null default unwind plan. However, this is not the case at least on s390x, so check for that. In that case, we'll treat it as an

[Lldb-commits] [lldb] [lldb] Don't crash if no default unwind plan (PR #152481)

2025-08-07 Thread Nikita Popov via lldb-commits
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/152481 The code was assuming that if abi_sp is not null, then it will also return a non-null default unwind plan. However, this is not the case at least on s390x, so check for that. In that case, we'll treat it as an in

[Lldb-commits] [lldb] [LLDB] Make MSVC STL formatters work with (Native/DIA) PDB (PR #150513)

2025-08-07 Thread via lldb-commits
@@ -0,0 +1,188 @@ +# REQUIRES: target-windows Nerixyz wrote: Yea, that was my plan. Once that's merged, I'll update the tests. https://github.com/llvm/llvm-project/pull/150513 ___ lldb-commits mailing list lldb-commits

  1   2   >