https://github.com/vitalybuka approved this pull request.
LGTM, but please address others comments
https://github.com/llvm/llvm-project/pull/154618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/155335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@piyushjaiswal98 Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/155352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Piyush Jaiswal
Date: 2025-08-26T17:55:29-07:00
New Revision: 101ad14f535461236ba0a656554d884d6d0b25a0
URL:
https://github.com/llvm/llvm-project/commit/101ad14f535461236ba0a656554d884d6d0b25a0
DIFF:
https://github.com/llvm/llvm-project/commit/101ad14f535461236ba0a656554d884d6d0b25a0.diff
https://github.com/piyushjaiswal98 updated
https://github.com/llvm/llvm-project/pull/155335
>From 443c2b4c983399fce0ac6805abfa7ca2fffd1322 Mon Sep 17 00:00:00 2001
From: Piyush Jaiswal
Date: Mon, 25 Aug 2025 17:31:45 -0700
Subject: [PATCH 1/3] Improving lldbdap server error diagnosability and a
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/149827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,9 +1,32 @@
// RUN: %clang_cc1 -triple arm64-apple-macosx14.0.0 -O0
-debug-info-kind=standalone -dwarf-version=5 \
-// RUN: -fsanitize=signed-integer-overflow
-fsanitize-trap=signed-integer-overflow -emit-llvm %s -o - | FileCheck %s
+// RUN: -fsanitize=signed-integer-overf
https://github.com/ilovepi commented:
LGTM from my perspective. Its worth noting that I'm not one of the normal
maintainers of UBSan though. My team is just eager for this feature for our
embedded/kernel users. I'll defer to @vitalybuka and @thurstond since they deal
with this part of the code
Anthony-Eid wrote:
@medismailben I just updated the branch by merging with main. I started a
rebase but I don't have enough time to finish it until later tonight. I might
see if I can cherry pick my changes instead of rebase because I think that
would be easier to test
https://github.com/llvm
https://github.com/Anthony-Eid updated
https://github.com/llvm/llvm-project/pull/124232
>From e741fc75ccb6e2a725b3b26dd4c503cdea6c5fbb Mon Sep 17 00:00:00 2001
From: Anthony Eid
Date: Fri, 24 Jan 2025 00:43:39 -0500
Subject: [PATCH 1/6] Stop using replicated variable ids
---
lldb/tools/lldb-d
@@ -1,9 +1,32 @@
// RUN: %clang_cc1 -triple arm64-apple-macosx14.0.0 -O0
-debug-info-kind=standalone -dwarf-version=5 \
-// RUN: -fsanitize=signed-integer-overflow
-fsanitize-trap=signed-integer-overflow -emit-llvm %s -o - | FileCheck %s
+// RUN: -fsanitize=signed-integer-overf
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/154618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
thurstond wrote:
> @thurstond I implemented a -fsanitize-debug-trap-reasons= flag takes an enum
> value. It takes either none, basic (what we had before this patch), or
> detailed (the new behavior added by this patch). For compatibility I kept the
> binary forms of the flags around and made t
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/155460
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: John Harrison
Date: 2025-08-26T15:09:36-07:00
New Revision: a67257bbfb5bce5a21f21d7e78049cfcbb283e33
URL:
https://github.com/llvm/llvm-project/commit/a67257bbfb5bce5a21f21d7e78049cfcbb283e33
DIFF:
https://github.com/llvm/llvm-project/commit/a67257bbfb5bce5a21f21d7e78049cfcbb283e33.diff
https://github.com/delcypher edited
https://github.com/llvm/llvm-project/pull/154618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/delcypher edited
https://github.com/llvm/llvm-project/pull/154618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-08-26T14:56:25-07:00
New Revision: aadc708e78568f1ec5713dd4ba768e77044b651d
URL:
https://github.com/llvm/llvm-project/commit/aadc708e78568f1ec5713dd4ba768e77044b651d
DIFF:
https://github.com/llvm/llvm-project/commit/aadc708e78568f1ec5713dd4ba768e77044b651d.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/154727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/154727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
delcypher wrote:
@thurstond I implemented a `-fsanitize-debug-trap-reasons=` flag takes an enum
value. It takes either `none`, `basic` (what we had before this patch), or
`detailed` (the new behavior added by this patch). For compatibility I kept the
binary forms of the flags around and made t
JDevlieghere wrote:
🚢
https://github.com/llvm/llvm-project/pull/155460
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -198,12 +207,165 @@ struct ToolDefinition {
// JSON Schema for the tool's parameters.
std::optional inputSchema;
};
-
llvm::json::Value toJSON(const ToolDefinition &);
bool fromJSON(const llvm::json::Value &, ToolDefinition &, llvm::json::Path);
using ToolArguments
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/155460
>From 8b89bfa1a114dd45bbd0b8023540112654f8590b Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 26 Aug 2025 10:56:45 -0700
Subject: [PATCH 1/3] [lldb] Adding structured types for existing MCP calls.
This
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/153536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/153536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/153536
>From a8b0d3ebb8e3b5519ecda14699346123781abc2b Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Wed, 13 Aug 2025 22:47:58 -0700
Subject: [PATCH 1/5] [vscode-lldb] Support lldb-dap environment in debug
configuratio
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/153536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -157,6 +157,61 @@ async function getDAPArguments(
.get("arguments", []);
}
+/**
+ * Retrieves the environment that will be provided to lldb-dap either from
settings or the provided
+ * {@link vscode.DebugConfiguration}.
+ *
+ * @param workspaceFolder The {@link vscode.
thurstond wrote:
> Don't want to derail the review of this PR too much, but I am curious about
> the debug-info increase. A breakdown of section size increases would be
> interesting, if those are available.
Output from bloaty:
```
FILE SIZEVM SIZE
-- --
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/153536
>From a8b0d3ebb8e3b5519ecda14699346123781abc2b Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Wed, 13 Aug 2025 22:47:58 -0700
Subject: [PATCH 1/4] [vscode-lldb] Support lldb-dap environment in debug
configuratio
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/155460
>From 8b89bfa1a114dd45bbd0b8023540112654f8590b Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 26 Aug 2025 10:56:45 -0700
Subject: [PATCH 1/2] [lldb] Adding structured types for existing MCP calls.
This
Author: Alex Langford
Date: 2025-08-26T13:21:28-07:00
New Revision: 8b544f3639bb51ebccdd212e2acc1847726d7dca
URL:
https://github.com/llvm/llvm-project/commit/8b544f3639bb51ebccdd212e2acc1847726d7dca
DIFF:
https://github.com/llvm/llvm-project/commit/8b544f3639bb51ebccdd212e2acc1847726d7dca.diff
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/155282
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/piyushjaiswal98 updated
https://github.com/llvm/llvm-project/pull/155352
>From 80ee7d1200ad32e4e3eb46ce5a6cd1ce0eb9a1ce Mon Sep 17 00:00:00 2001
From: Piyush Jaiswal
Date: Mon, 25 Aug 2025 21:17:17 -0700
Subject: [PATCH 1/2] Improving lldbdap_testcase.py error diagnosability
Michael137 wrote:
> > We didn't expect the debug info to increase that much based on the [#145967
> > (comment)](https://github.com/llvm/llvm-project/pull/145967#issuecomment-3099264478).
> > Are they using some variant of -fno-sanitize-merge by any chance?
> > Typically in optimized builds th
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/155483
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/153536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/155282
>From d4dc7c8612c0a939e86842270fdaf4a4573e8b8e Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 13 Sep 2024 10:33:43 -0700
Subject: [PATCH] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol
https://github.com/dmpots approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/154809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/149827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Part of https://github.com/llvm/llvm-project/pull/149827
Allows us to use the mangling substitution facilities in CPlusPlusLanguage but
also SymbolFileDWARF.
Added tests now that they're "public".
---
Fu
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/155483
Part of https://github.com/llvm/llvm-project/pull/149827
Allows us to use the mangling substitution facilities in CPlusPlusLanguage but
also SymbolFileDWARF.
Added tests now that they're "public".
>From 0b
adrian-prantl wrote:
Should this file be deleted?
https://github.com/llvm/llvm-project/pull/152887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/155460
>From 8b89bfa1a114dd45bbd0b8023540112654f8590b Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 26 Aug 2025 10:56:45 -0700
Subject: [PATCH 1/2] [lldb] Adding structured types for existing MCP calls.
This
adrian-prantl wrote:
I think this should be deleted.
https://github.com/llvm/llvm-project/pull/152887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
@@ -376,6 +382,148 @@ void Disassembler::PrintInstructions(Debugger &debugger,
const ArchSpec &arch,
}
}
+ // Add rich variable location annotations to the disassembly output.
+ //
+ // For each instruction, this block attempts to resolve in-scope variables
+ // and
@@ -376,6 +382,148 @@ void Disassembler::PrintInstructions(Debugger &debugger,
const ArchSpec &arch,
}
}
+ // Add rich variable location annotations to the disassembly output.
+ //
+ // For each instruction, this block attempts to resolve in-scope variables
+ // and
@@ -376,6 +382,148 @@ void Disassembler::PrintInstructions(Debugger &debugger,
const ArchSpec &arch,
}
}
+ // Add rich variable location annotations to the disassembly output.
adrian-prantl wrote:
```suggestion
// Add variable location annotations t
@@ -154,6 +154,10 @@ Status
CommandObjectDisassemble::CommandOptions::SetOptionValue(
}
} break;
+ case 'v': //< --rich variable annotations
+enable_rich_annotations = true;
adrian-prantl wrote:
Can you rename `rich` to `variable` in most places?
@@ -399,6 +398,7 @@ class Disassembler : public
std::enable_shared_from_this,
eOptionMarkPCAddress =
(1u << 3), // Mark the disassembly line the contains the PC
eOptionShowControlFlowKind = (1u << 4),
+eOptionRichAnnotations = (1u << 5),
ad
adrian-prantl wrote:
```[lldb/test/API/functionalities/disassembler-variables/d_original_example](https://github.com/llvm/llvm-project/pull/152887#diff-b7942b849ea60f4e92ce3d85f3eb55811b20ea9507da4380e9c1b77f4336d61d)```
https://github.com/llvm/llvm-project/pull/152887
__
@@ -81,6 +81,10 @@ bool operator==(const Request &a, const Request &b) {
return a.id == b.id && a.method == b.method && a.params == b.params;
}
+void PrintTo(const Request &req, std::ostream *os) {
+ *os << formatv("{0}", toJSON(req)).str();
+}
ashgti wrote
https://github.com/piyushjaiswal98 updated
https://github.com/llvm/llvm-project/pull/155352
>From 80ee7d1200ad32e4e3eb46ce5a6cd1ce0eb9a1ce Mon Sep 17 00:00:00 2001
From: Piyush Jaiswal
Date: Mon, 25 Aug 2025 21:17:17 -0700
Subject: [PATCH 1/2] Improving lldbdap_testcase.py error diagnosability
delcypher wrote:
@thurstond
> I agree it can be useful in many cases, but it could also make the debug info
> unbearably large. (Anecdata: Big Google disables the current trap-reasons
> annotations in their internal toolchain, because it made the debug info up to
> 15% larger, even without t
Author: Jonas Devlieghere
Date: 2025-08-26T08:07:24-07:00
New Revision: 26777283e6cb952ba9242c6299b0948dcc3253a5
URL:
https://github.com/llvm/llvm-project/commit/26777283e6cb952ba9242c6299b0948dcc3253a5
DIFF:
https://github.com/llvm/llvm-project/commit/26777283e6cb952ba9242c6299b0948dcc3253a5.d
https://github.com/ashgti converted_to_draft
https://github.com/llvm/llvm-project/pull/155315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
> Let's split out the changes to the protocol, we can land and test those
> independently and that would simplify this patch a lot. I also think all the
> socket code is (not yet) necessary.
Split the protocol changes into #155460 and I'll also add another to move the
MCPTranspo
@@ -1534,6 +1536,103 @@ inline DiagnosticBuilder
DiagnosticsEngine::Report(unsigned DiagID) {
return Report(SourceLocation(), DiagID);
}
+//===--===//
+// RuntimeTrapDiagnosticBuilder and helper classes
+//
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This adds or renames existing types to match the names of the types on
https://modelcontextprotocol.io/specification/2025-06-18/schema for the
existing calls.
The new types are used in the unit tests and ser
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/155460
This adds or renames existing types to match the names of the types on
https://modelcontextprotocol.io/specification/2025-06-18/schema for the
existing calls.
The new types are used in the unit tests and server
https://github.com/delcypher updated
https://github.com/llvm/llvm-project/pull/154618
>From db45694078e74e2c080e40dd8ba635d2c9f313c6 Mon Sep 17 00:00:00 2001
From: Dan Liew
Date: Tue, 19 Aug 2025 15:08:44 -0700
Subject: [PATCH 01/21] [UBSan][BoundsSafety] Implement support for more
expressive
https://github.com/delcypher updated
https://github.com/llvm/llvm-project/pull/154618
>From db45694078e74e2c080e40dd8ba635d2c9f313c6 Mon Sep 17 00:00:00 2001
From: Dan Liew
Date: Tue, 19 Aug 2025 15:08:44 -0700
Subject: [PATCH 01/22] [UBSan][BoundsSafety] Implement support for more
expressive
https://github.com/delcypher updated
https://github.com/llvm/llvm-project/pull/154618
>From db45694078e74e2c080e40dd8ba635d2c9f313c6 Mon Sep 17 00:00:00 2001
From: Dan Liew
Date: Tue, 19 Aug 2025 15:08:44 -0700
Subject: [PATCH 01/20] [UBSan][BoundsSafety] Implement support for more
expressive
@@ -466,8 +466,15 @@ def attach(
# if we throw an exception during the test case.
def cleanup():
if disconnectAutomatically:
-self.dap_server.request_disconnect(terminateDebuggee=True)
-self.dap_server.terminate()
+
@@ -157,6 +157,61 @@ async function getDAPArguments(
.get("arguments", []);
}
+/**
+ * Retrieves the environment that will be provided to lldb-dap either from
settings or the provided
+ * {@link vscode.DebugConfiguration}.
+ *
+ * @param workspaceFolder The {@link vscode.
https://github.com/delcypher updated
https://github.com/llvm/llvm-project/pull/154618
>From db45694078e74e2c080e40dd8ba635d2c9f313c6 Mon Sep 17 00:00:00 2001
From: Dan Liew
Date: Tue, 19 Aug 2025 15:08:44 -0700
Subject: [PATCH 01/19] [UBSan][BoundsSafety] Implement support for more
expressive
@@ -1839,19 +1842,43 @@ void ScalarExprEmitter::EmitBinOpCheck(
StaticData.push_back(CGF.EmitCheckTypeDescriptor(Info.Ty));
} else {
// Arithmetic overflow (+, -, *).
+ int ArithOverflowKind = 0;
switch (Opcode) {
- case BO_Add: Check = Sanitize
https://github.com/delcypher updated
https://github.com/llvm/llvm-project/pull/154618
>From db45694078e74e2c080e40dd8ba635d2c9f313c6 Mon Sep 17 00:00:00 2001
From: Dan Liew
Date: Tue, 19 Aug 2025 15:08:44 -0700
Subject: [PATCH 01/18] [UBSan][BoundsSafety] Implement support for more
expressive
https://github.com/dmpots requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/154809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/149827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Looks good. Are there other places where this would be applicable? If so, maybe
we can turn this into a little helper? If not then this is fine.
https://github.com/llvm/llvm-project/pull/155352
___
lldb-commi
@@ -2235,6 +2259,27 @@ ObjectFileELF::ParseSymbols(Symtab *symtab, user_id_t
start_id,
if (mapping_symbol)
continue;
}
+ } else if (IsRISCVArch(arch.GetMachine())) {
+if (symbol.getBinding() == STB_LOCAL) {
+ char mapping_sym
@@ -2037,6 +2037,25 @@ static char FindArmAarch64MappingSymbol(const char
*symbol_name) {
return '\0';
}
+static char FindRISCVMappingSymbol(const char *symbol_name) {
+ if (!symbol_name)
+return '\0';
+
+ if (strcmp(symbol_name, "$d") == 0) {
+return 'd';
+ }
+
@@ -2102,6 +2121,12 @@ ObjectFileELF::ParseSymbols(Symtab *symtab, user_id_t
start_id,
if (!symbol_name)
symbol_name = "";
+// Skip local symbols starting with ".L" because these are compiler
+// generated local labels used for internal purposes (e.g. debugg
@@ -2102,6 +2121,12 @@ ObjectFileELF::ParseSymbols(Symtab *symtab, user_id_t
start_id,
if (!symbol_name)
symbol_name = "";
+// Skip local symbols starting with ".L" because these are compiler
+// generated local labels used for internal purposes (e.g. debugg
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py
`
@@ -466,8 +466,15 @@ def attach(
# if we throw an exception during the test case.
def cleanup():
if disconnectAutomatically:
-self.dap_server.request_disconnect(terminateDebuggee=True)
-self.dap_server.terminate()
+
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/153695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: cmtice
Date: 2025-08-26T07:40:35-07:00
New Revision: d85069c3d06e583ec83ebd05e5added26121fe02
URL:
https://github.com/llvm/llvm-project/commit/d85069c3d06e583ec83ebd05e5added26121fe02
DIFF:
https://github.com/llvm/llvm-project/commit/d85069c3d06e583ec83ebd05e5added26121fe02.diff
LOG: [
https://github.com/cmtice closed
https://github.com/llvm/llvm-project/pull/154269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ebuka Ezike
Date: 2025-08-26T15:26:01+01:00
New Revision: 749537f4878165f5548b499669ec11a61da1903c
URL:
https://github.com/llvm/llvm-project/commit/749537f4878165f5548b499669ec11a61da1903c
DIFF:
https://github.com/llvm/llvm-project/commit/749537f4878165f5548b499669ec11a61da1903c.diff
L
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/155238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -150,3 +158,161 @@ addr_t ArchitectureArm::GetOpcodeLoadAddress(addr_t
opcode_addr,
}
return opcode_addr & ~(1ull);
}
+
+// The ARM M-Profile Armv7-M Architecture Reference Manual
+// "Exception return behavior" describes how the processor
+// saves registers to the sta
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/153695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> I don't think that matching the capitalization was ever the goal
Then I'm cool with this on the grounds that it's following presumed existing
practice.
Tbf I don't think I've ever seen a CLI application do this highlighting, so
there isn't a precedent.
https://github.c
@@ -293,6 +293,9 @@ void RegisterContextUnwind::InitializeZerothFrame() {
return;
}
+ // Give the Architecture a chance to replace the UnwindPlan.
+ AdoptArchitectureUnwindPlan();
DavidSpickett wrote:
All this code is unfamiliar to me. Is there some o
@@ -150,3 +158,161 @@ addr_t ArchitectureArm::GetOpcodeLoadAddress(addr_t
opcode_addr,
}
return opcode_addr & ~(1ull);
}
+
+// The ARM M-Profile Armv7-M Architecture Reference Manual
+// "Exception return behavior" describes how the processor
+// saves registers to the sta
@@ -150,3 +158,161 @@ addr_t ArchitectureArm::GetOpcodeLoadAddress(addr_t
opcode_addr,
}
return opcode_addr & ~(1ull);
}
+
+// The ARM M-Profile Armv7-M Architecture Reference Manual
+// "Exception return behavior" describes how the processor
+// saves registers to the sta
@@ -0,0 +1,41 @@
+{
+ "triple": "armv7m-apple",
+ "uuid": "2D157DBA-53C9-3AC7-B5A1-9D336EC831CB",
+ "type": "executable",
+ "sections": [
+{
+ "user_id": 100,
+ "name": "TEXT",
+ "type": "code",
+ "address": 2097664,
+ "size": 598872,
+ "file_
@@ -150,3 +158,161 @@ addr_t ArchitectureArm::GetOpcodeLoadAddress(addr_t
opcode_addr,
}
return opcode_addr & ~(1ull);
}
+
+// The ARM M-Profile Armv7-M Architecture Reference Manual
+// "Exception return behavior" describes how the processor
+// saves registers to the sta
@@ -150,3 +158,161 @@ addr_t ArchitectureArm::GetOpcodeLoadAddress(addr_t
opcode_addr,
}
return opcode_addr & ~(1ull);
}
+
+// The ARM M-Profile Armv7-M Architecture Reference Manual
+// "Exception return behavior" describes how the processor
+// saves registers to the sta
@@ -799,6 +799,23 @@ Status ProcessMachCore::DoGetMemoryRegionInfo(addr_t
load_addr,
region_info.SetMapped(MemoryRegionInfo::eNo);
}
return Status();
+ } else {
+// The corefile has no LC_SEGMENT at this virtual address,
+// but see if there is a binary
@@ -233,6 +234,41 @@ void ObjectFileJSON::CreateSections(SectionList
&unified_section_list) {
}
}
+bool ObjectFileJSON::SetLoadAddress(Target &target, lldb::addr_t value,
+bool value_is_offset) {
+ Log *log(GetLog(LLDBLog::DynamicLoader)
@@ -0,0 +1,51 @@
+"""
+Test that we can backtrace up an ARM Cortex-M Exception return stack
+"""
+
+import lldb
+import json
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCortexMExceptionUnwind(T
@@ -150,3 +158,161 @@ addr_t ArchitectureArm::GetOpcodeLoadAddress(addr_t
opcode_addr,
}
return opcode_addr & ~(1ull);
}
+
+// The ARM M-Profile Armv7-M Architecture Reference Manual
+// "Exception return behavior" describes how the processor
+// saves registers to the sta
@@ -150,3 +158,161 @@ addr_t ArchitectureArm::GetOpcodeLoadAddress(addr_t
opcode_addr,
}
return opcode_addr & ~(1ull);
}
+
+// The ARM M-Profile Armv7-M Architecture Reference Manual
+// "Exception return behavior" describes how the processor
+// saves registers to the sta
@@ -1717,6 +1726,42 @@ RegisterContextUnwind::SavedLocationForRegister(
return UnwindLLDB::RegisterSearchResult::eRegisterNotFound;
}
+UnwindPlanSP RegisterContextUnwind::AdoptArchitectureUnwindPlan() {
DavidSpickett wrote:
Sometimes you don't adopt, so cal
@@ -150,3 +158,161 @@ addr_t ArchitectureArm::GetOpcodeLoadAddress(addr_t
opcode_addr,
}
return opcode_addr & ~(1ull);
}
+
+// The ARM M-Profile Armv7-M Architecture Reference Manual
+// "Exception return behavior" describes how the processor
+// saves registers to the sta
1 - 100 of 110 matches
Mail list logo
