abhishek.aggarwal closed this revision.
abhishek.aggarwal added a comment.
Already merged it in LLDb repo. So closing this revision.
https://reviews.llvm.org/D24251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
abhishek.aggarwal updated this revision to Diff 70677.
abhishek.aggarwal added a comment.
Removed get() for shared_ptr
https://reviews.llvm.org/D24251
Files:
include/lldb/API/SBSection.h
scripts/interface/SBSection.i
source/API/SBSection.cpp
Index: source/API/SBSection.cpp
==
abhishek.aggarwal updated this revision to Diff 70513.
abhishek.aggarwal added a comment.
Changes based on review
- Added header doc and ran clang-format on code
https://reviews.llvm.org/D24251
Files:
include/lldb/API/SBSection.h
scripts/interface/SBSection.i
source/API/SBSection.cpp
In
abhishek.aggarwal updated this revision to Diff 65903.
abhishek.aggarwal added a comment.
New patch according to review feedback
- Added another variant of AddCommand API with syntax as an additional argument
https://reviews.llvm.org/D22863
Files:
include/lldb/API/SBCommandInterpreter.h
so
abhishek.aggarwal added inline comments.
Comment at: include/lldb/API/SBCommandInterpreter.h:141-142
@@ -140,4 +140,4 @@
lldb::SBCommand
-AddCommand (const char* name, lldb::SBCommandPluginInterface *impl, const
char* help);
+AddCommand (const char* name, lldb:
abhishek.aggarwal added a comment.
Hi Greg
Please find my comments inlined. Let me know if I am missing something here.
Comment at: include/lldb/API/SBCommandInterpreter.h:141-142
@@ -140,4 +140,4 @@
lldb::SBCommand
-AddCommand (const char* name, lldb::SBCommandP
abhishek.aggarwal added a comment.
source/Plugins/Process/FreeBSD/FreeBSDThread.cpp will not compile for FreeBSD.
In Line 576, bp_id is undefined. Please replace it with bp_site_sp->GetID()
http://reviews.llvm.org/D16767
___
lldb-commits mailing li
abhishek.aggarwal added a comment.
Comments Inlined.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:853-854
@@ +852,4 @@
+{
+if (log)
+log->Printf("NativeRegisterContextLinux_x86_64::%s ptrace
APIs
abhishek.aggarwal added a comment.
Hi Pavel and Tamas
I enabled logs in case ptrace API fails to read FXSAVE/XSAVE area. This will
serve as an indicator to find the reason of failure if register read fails.
http://reviews.llvm.org/D15042
___
lldb-
abhishek.aggarwal updated this revision to Diff 41489.
abhishek.aggarwal added a comment.
Added Loggings
An indication through logs in case ptrace API fails
to read FXSAVE/XSAVE area.
http://reviews.llvm.org/D15042
Files:
packages/Python/lldbsuite/test/functionalities/return-value/TestRetur
abhishek.aggarwal added a comment.
Hello Greg
Is there anyone else , except the reviewers already included for the patch, I
should put as the reviewer for this patch ?
http://reviews.llvm.org/D15042
___
lldb-commits mailing list
lldb-commits@lists
abhishek.aggarwal updated this revision to Diff 41382.
abhishek.aggarwal added a comment.
Removed assert if ptrace API fails
http://reviews.llvm.org/D15042
Files:
packages/Python/lldbsuite/test/functionalities/return-value/TestReturnValue.py
source/Plugins/Process/Linux/NativeRegisterContex
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253026: Fix to solve Bug 23139 & Bug 23560 (authored by
Abhishek).
Changed prior to commit:
http://reviews.llvm.org/D14226?vs=40014&id=40127#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14226
F
abhishek.aggarwal added a comment.
Hello Jason
No problem regarding the delay. Thanks a lot for reviewing the patch. I have
made the changes as suggested by you. I will land it now.
http://reviews.llvm.org/D14226
___
lldb-commits mailing list
lldb
abhishek.aggarwal updated this revision to Diff 40014.
abhishek.aggarwal added a comment.
Removed log and inserted statement terminator
http://reviews.llvm.org/D14226
Files:
packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py
packages/Python/lldbsuite/test/expression_comma
abhishek.aggarwal updated this revision to Diff 40013.
abhishek.aggarwal added a comment.
Used Assert instead of If condition
http://reviews.llvm.org/D14226
Files:
packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py
packages/Python/lldbsuite/test/expression_command/test/Te
abhishek.aggarwal added a comment.
In http://reviews.llvm.org/D12677#242006, @ovyalov wrote:
> I reverted the CL because it was causing
> TestRegisters.test_fp_special_purpose_register_read to fail on OSX:
>
> - stop reason = EXC_BREAKPOINT
> - "register read ftag" yields 0x80 instead of expecte
abhishek.aggarwal closed this revision.
abhishek.aggarwal added a comment.
Couldn't land this patch by arc due to merge conflicts. Hence merging it
manually and closing this revision.
http://reviews.llvm.org/D12677
___
lldb-commits mailing list
lld
abhishek.aggarwal updated this revision to Diff 34161.
abhishek.aggarwal added a comment.
Clang/GCC generate different assembly for same inferior.
Changed a.cpp to remove dependency of TestRegisters.py on assembly
instructions generated by Clang/GCC.
Changed TestRegisters.py to write a generic t
abhishek.aggarwal added inline comments.
Comment at: test/functionalities/register/TestRegisters.py:195
@@ +194,3 @@
+for x in range(0,16):
+self.runCmd ("si", RUN_SUCCEEDED)
+
labath wrote:
> First I would like to applaud for writing a
20 matches
Mail list logo
