https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/115401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -395,7 +394,44 @@ bool ThreadPlanStepRange::SetNextBranchBreakpoint() {
m_next_branch_bp_sp->GetID(), bp_site_id,
run_to_address.GetLoadAddress(&m_process.GetTarget()));
}
-
+// The "next branch breakpoint might land on
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/114628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/114333
>From c9a4d24f222a70c7c108deebb6c25222893d7159 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 24 Jan 2024 12:42:45 -0800
Subject: [PATCH 1/2] [lldb] Load embedded type summary section (#7859) (#8040)
@@ -1608,9 +1612,48 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
if (image_module_sp) {
added_modules.AppendIfNeeded(image_module_sp, false);
ObjectFile *objfile = image_module_sp->GetObjectFile();
- if (objfile)
-
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
// Add a hint if object description was requested, but no description
// function was implemented.
auto maybe_add_hint = [&](llvm::StringRef output) {
+static bool note_shown = false;
+
https://github.com/adrian-prantl commented:
@kastiglione Is there a way to turn this into a test? Apparently this works:
```
(lldb) p ;
(lldb)
```
https://github.com/llvm/llvm-project/pull/114478
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
// Add a hint if object description was requested, but no description
// function was implemented.
auto maybe_add_hint = [&](llvm::StringRef output) {
+static bool note_shown = false;
+
https://github.com/adrian-prantl approved this pull request.
I was going to say this is not the right way to do this, but I suppose there
isn't really a better mechanism available, since this isn't an error. Otherwise
you'd be better off joining a diagnostic error with the note so the UI layer
adrian-prantl wrote:
Unfortunately older videos are regularly being removed. We should probably
remove the links and add https://developer.apple.com/videos/play/wwdc2024/10198
instead.
https://github.com/llvm/llvm-project/pull/114289
___
lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/114333
Compared to the python version, this also does type checking and error
handling, so it's slightly longer, however, it's still comfortably
under 500 lines.
See https://discourse.llvm.org/t/a-bytecode-for-ll
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/114289
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,63 @@
+; Test finding types by CompilerContext.
+; REQUIRES: aarch64
+; RUN: llc %s -filetype=obj -o %t.o
+; RUN: lldb-test symbols %t.o -find=type --mangled-name=UniqueDifferentName |
FileCheck %s
+;
+; NORESULTS: Found 0 types
+; CHECK: Found 1 types:
+; CHECK: stru
https://github.com/adrian-prantl commented:
Thanks!
https://github.com/llvm/llvm-project/pull/114161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl commented:
Can you add a test (perhaps using lldb-test and a .ll or .s file)?
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/114251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/114251
The order in which the libraries appear is not always stable and even if it
were, this test is not the right place to check for this.
>From 553d4742e6972a068105177aafd47b3da2c01d8f Mon Sep 17 00:00:00 200
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter
byt
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter
byt
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter
byt
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter
byt
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter
byt
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter
byt
@@ -0,0 +1,165 @@
+# A bytecode for (LLDB) data formatters
+
+## Background
+
+LLDB provides very rich customization options to display data types (see
https://lldb.llvm.org/use/variable.html ). To use custom data formatters,
developers typically need to edit the global `~/.lldb
@@ -0,0 +1,486 @@
+"""
+Specification, compiler, disassembler, and interpreter
+for LLDB dataformatter bytecode.
+
+See formatter-bytecode.md for more details.
+"""
+from __future__ import annotations
+
+# Types
+type_String = 1
+type_Int = 2
+type_UInt = 3
+type_Object = 4
+type_
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/113743
Add support for type summaries embedded into the binary.
These embedded summaries will typically be generated by Swift macros, but can
also be generated by any other means.
rdar://115184658
This upstrea
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH] Add a compiler/interpreter of LLDB data formatter bytecode
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From dcab1a5a65fe5345f9c2de9346b7884f74ab7f4d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH] Add a compiler/interpreter of LLDB data formatter bytecode
@@ -0,0 +1,165 @@
+# A bytecode for (LLDB) data formatters
+
+## Background
+
+LLDB provides very rich customization options to display data types (see
https://lldb.llvm.org/use/variable.html ). To use custom data formatters,
developers typically need to edit the global `~/.lldb
@@ -0,0 +1,165 @@
+# A bytecode for (LLDB) data formatters
+
+## Background
+
+LLDB provides very rich customization options to display data types (see
https://lldb.llvm.org/use/variable.html ). To use custom data formatters,
developers typically need to edit the global `~/.lldb
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/113398
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> Compiling languages into this is intriguing.
>
> MLIR noob thinking out loud: if MLIR could lower into this could you write
> your formatter in Fortran? 🤣
It is well known that Fortran is superbly suited to process text:
https://en.wikipedia.org/wiki/Colossal_Cave_Adven
@@ -0,0 +1,165 @@
+# A bytecode for (LLDB) data formatters
+
+## Background
+
+LLDB provides very rich customization options to display data types (see
https://lldb.llvm.org/use/variable.html ). To use custom data formatters,
developers typically need to edit the global `~/.lldb
@@ -0,0 +1,486 @@
+"""
+Specification, compiler, disassembler, and interpreter
+for LLDB dataformatter bytecode.
+
+See formatter-bytecode.md for more details.
+"""
+from __future__ import annotations
+
+# Types
+type_String = 1
+type_Int = 2
+type_UInt = 3
+type_Object = 4
+type_
@@ -0,0 +1,486 @@
+"""
+Specification, compiler, disassembler, and interpreter
+for LLDB dataformatter bytecode.
+
+See formatter-bytecode.md for more details.
+"""
+from __future__ import annotations
+
+# Types
+type_String = 1
+type_Int = 2
+type_UInt = 3
+type_Object = 4
+type_
@@ -0,0 +1,486 @@
+"""
+Specification, compiler, disassembler, and interpreter
+for LLDB dataformatter bytecode.
+
+See formatter-bytecode.md for more details.
+"""
+from __future__ import annotations
+
+# Types
+type_String = 1
+type_Int = 2
+type_UInt = 3
+type_Object = 4
+type_
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From c4360a6979a38f7e9a11edc07f02d8b3ac5bd2aa Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH] Add a compiler/interpreter of LLDB data formatter bytecode
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From 3267f7a2001e769217e3192f6efb67fb77973339 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH] Add a compiler/interpreter of LLDB data formatter bytecode
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/113398
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/113398
This PR adds a proof-of-concept for a bytecode designed to ship and run LLDB
data formatters. More motivation and context can be found in the
`formatter-bytecode.md` file and on discourse.
>From 64252584
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/113220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream,
continue;
}
-auto &loc = *detail.source_location;
remaining_details.push_back(detail);
+ }
+
+ // Sort the diagnostics.
+ auto sort = [](auto &ds) {
+llvm::sort(ds.begin(), ds.end(), [](
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/113220
None
>From 417e6f4c27d1603d118dadd8327e57b766626e6d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 21 Oct 2024 13:57:09 -0700
Subject: [PATCH] [lldb] Fix the sorting function for diagnostics
---
adrian-prantl wrote:
@JDevlieghere fixed this in 40ea92c859234d536553cf26650e89d6e52071c6
https://github.com/llvm/llvm-project/pull/112062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream,
continue;
}
-auto &loc = *detail.source_location;
remaining_details.push_back(detail);
+ }
+
+ // Sort the diagnostics.
+ auto sort = [](auto &ds) {
+llvm::sort(ds.begin(), ds.end(), [](
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/112801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112801
>From 3585c9ce2a79e7608ea666c9be5c398d0d5ce1cb Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 17 Oct 2024 16:44:07 -0700
Subject: [PATCH] More aggressively deduplicate global warnings based on
co
Author: Adrian Prantl
Date: 2024-10-18T16:55:21-07:00
New Revision: 2b7e9d27817da54c34a6f02dc00d2466c31f6fa0
URL:
https://github.com/llvm/llvm-project/commit/2b7e9d27817da54c34a6f02dc00d2466c31f6fa0
DIFF:
https://github.com/llvm/llvm-project/commit/2b7e9d27817da54c34a6f02dc00d2466c31f6fa0.diff
@@ -305,6 +319,16 @@ class BreakpointLocation
/// It also takes care of decrementing the ignore counters.
/// If it returns false we should continue, otherwise stop.
bool IgnoreCountShouldStop();
+
+ // If this location knows that the virtual stack frame it represents
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112801
>From 14b4120a75f35ef8ade38e6dee2c60685de10c9b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 17 Oct 2024 16:44:07 -0700
Subject: [PATCH] More aggressively deduplicate global warnings based on
co
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112801
>From 7d01c051172c89a722e386c9fb607919d4be11bc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 17 Oct 2024 16:44:07 -0700
Subject: [PATCH] More aggressively deduplicate global warnings based on
co
@@ -281,6 +283,18 @@ class BreakpointLocation
/// Returns the breakpoint location ID.
lldb::break_id_t GetID() const { return m_loc_id; }
+
+ // Set the line entry that should be shown to users for this location.
+ // It is up to the caller to verify that this is a val
@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext(
0, file_indexes, src_location_spec, &line_entry);
}
+ // If we didn't manage to find a breakpoint that matched the line number
+ // requested, that might be because it is only an inline call site, and
+
adrian-prantl wrote:
The failures are timeouts.
https://github.com/llvm/llvm-project/pull/112801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -32,6 +32,12 @@ def test_step_in_template_with_python_api(self):
self.build()
self.step_in_template()
+@add_test_categories(["pyapi"])
+def test_virtual_inline_stepping(self):
+"""Test stepping through a virtual inlined call stack"""
+
@@ -357,3 +363,61 @@ def step_in_template(self):
step_sequence = [["// In max_value specialized", "into"]]
self.run_step_sequence(step_sequence)
+
+def run_to_call_site_and_step(self, source_regex, func_name, start_pos):
+main_spec = lldb.SBFileSpec
@@ -32,6 +32,12 @@ def test_step_in_template_with_python_api(self):
self.build()
self.step_in_template()
+@add_test_categories(["pyapi"])
+def test_virtual_inline_stepping(self):
+"""Test stepping through a virtual inlined call stack"""
+
https://github.com/adrian-prantl approved this pull request.
Very exciting, this is something I've wished for for a long time!
https://github.com/llvm/llvm-project/pull/112939
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext(
0, file_indexes, src_location_spec, &line_entry);
}
+ // If we didn't manage to find a breakpoint that matched the line number
+ // requested, that might be because it is only an inline call site, and
+
@@ -369,6 +393,13 @@ class BreakpointLocation
lldb::break_id_t m_loc_id; ///< Breakpoint location ID.
StoppointHitCounter m_hit_counter; ///< Number of times this breakpoint
/// location has been hit.
+ std::optional m_preferred_line_en
@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext(
0, file_indexes, src_location_spec, &line_entry);
}
+ // If we didn't manage to find a breakpoint that matched the line number
+ // requested, that might be because it is only an inline call site, and
+
@@ -656,6 +671,49 @@ void
BreakpointLocation::SendBreakpointLocationChangedEvent(
}
}
+std::optional BreakpointLocation::GetSuggestedStackFrameIndex() {
+ if (!GetPreferredLineEntry())
+return {};
+ LineEntry preferred = *GetPreferredLineEntry();
+ SymbolContext sc;
@@ -369,6 +393,13 @@ class BreakpointLocation
lldb::break_id_t m_loc_id; ///< Breakpoint location ID.
StoppointHitCounter m_hit_counter; ///< Number of times this breakpoint
/// location has been hit.
+ std::optional m_preferred_line_en
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112801
>From e35350b790f34660911c23cdbe34e6a0347f924d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 17 Oct 2024 16:44:07 -0700
Subject: [PATCH] More aggressively deduplicate global warnings based on
co
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/112801
I've been getting complaints from users being spammed by -gmodules missing file
warnings going out of control because each object file depends on an entire DAG
of PCM files that usually are all missing at
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/112466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112466
>From 433765aeb92179d3dcd422949275bf043661682b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 15 Oct 2024 20:15:12 -0700
Subject: [PATCH] [lldb] Fix offset calculation when printing diagnostics in
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/112451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112466
>From 7c35b47aa81ee0d2151944eff59c159ea3fd4c5c Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 15 Oct 2024 16:20:33 -0700
Subject: [PATCH 1/2] [lldb] Fix a crash when two diagnostics are on the sam
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112451
>From 7c35b47aa81ee0d2151944eff59c159ea3fd4c5c Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 15 Oct 2024 16:20:33 -0700
Subject: [PATCH] [lldb] Fix a crash when two diagnostics are on the same
c
@@ -16,12 +16,36 @@ std::string Render(std::vector details) {
} // namespace
TEST_F(ErrorDisplayTest, RenderStatus) {
- DiagnosticDetail::SourceLocation inline_loc;
- inline_loc.in_user_input = true;
{
+DiagnosticDetail::SourceLocation inline_loc;
+inline_loc.in_u
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/112466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/112466
None
>From d400a1358678162df02c7cada2a66b837d3ff005 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 15 Oct 2024 16:20:33 -0700
Subject: [PATCH 1/2] [lldb] Fix a crash when two diagnostics are on t
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112451
>From d400a1358678162df02c7cada2a66b837d3ff005 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 15 Oct 2024 16:20:33 -0700
Subject: [PATCH] [lldb] Fix a crash when two diagnostics are on the same
c
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/112451
…reverse order
The second inner loop (only) was missing the check for offset > column. Also
this patch sorts the diagnostics before printing them.
>From 934214ae1daf3fd70ee1cf332b269d636fbbc193 Mon Sep 1
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112109
>From 23e1eeafd84d0f14803da52f89723a3ae257dbb8 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 11 Oct 2024 19:27:37 -0700
Subject: [PATCH] [lldb] Expose structured command diagnostics via the SBAPI
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/112260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> @adrian-prantl do you want the system log to include the dropped errors in
> `Status`. If so we'll need to promote that to use `LLDB_LOG_ERROR` instead.
No, I expect that to be too much traffic in the beginning at least.
https://github.com/llvm/llvm-project/pull/111911
_
@@ -123,30 +123,79 @@ void CommandReturnObject::SetError(llvm::Error error) {
}
}
-llvm::StringRef
-CommandReturnObject::GetInlineDiagnosticString(unsigned indent) {
- RenderDiagnosticDetails(m_diag_stream, indent, true, m_diagnostics);
+std::string CommandReturnObject::Get
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112109
>From e60c7d3313748bc3147be188e2243f271d71d19a Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 11 Oct 2024 19:27:37 -0700
Subject: [PATCH] [lldb] Expose structured command diagnostics via the SBAPI
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/112109
This allows IDEs to render LLDB expression diagnostics to their liking without
relying on characterprecise ASCII art from LLDB. It is exposed as a versioned
SBStructuredData object, since it is expected t
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/112062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112062
>From c40bb5f2b7d8ac95faa14579cd55bd2885ea9705 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 11 Oct 2024 17:02:39 -0700
Subject: [PATCH] [lldb] Rename CommandReturnObject::Get.*Data -> Get.*Strin
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/112062
In a later commit, I want to add a method to access diagnostics as actual
structured data, which will make these function names rather confusing.
>From e0f65d0a82d8ba5b7375b158a88e2680c4bf40c3 Mon Sep 17
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/110901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> > Looks good, I guess. Is that constructor even necessary, given that it just
> > forwards the argument to the base class, and we already have the forwarding
> > `using` declaration?
>
> The constructor looks redundant at the moment, perhaps it is just a legacy
> from t
@@ -160,6 +166,9 @@ class CommandReturnObject {
StreamTee m_out_stream;
StreamTee m_err_stream;
+ std::vector m_diagnostics;
+ StreamString m_diag_stream;
+ std::optional m_diagnostic_indent;
adrian-prantl wrote:
Because DiagnostcDetails are created in
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From e13c841a6452ae5b0cfae129764dc95d6ac29e09 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
@@ -0,0 +1,11 @@
+# RUN: echo quit | %lldb -o "log enable -x" \
adrian-prantl wrote:
Thanks! Indeed, there's bug there.
https://github.com/llvm/llvm-project/pull/110901
___
lldb-commits mailing list
lldb-commits@lists.
adrian-prantl wrote:
To clone an error, do Status::FromError(error). Every call to Status::toError()
clones the error (as opposed to takeError()). Generally we want to avoid
cloning errors though.
https://github.com/llvm/llvm-project/pull/111911
___
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/111911
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,19 +38,23 @@ class Args {
std::unique_ptr ptr;
char quote = '\0';
+/// The position of the argument in the original argument string.
+std::optional column;
char *data() { return ptr.get(); }
public:
ArgEntry() = default;
-ArgEntry(ll
https://github.com/adrian-prantl approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/111882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From 49b51bad4dd2ca41e61da38b1e35ffcb1eb9e7d6 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From 0a78922cc8e21c62ed7b09a88a14ff6119697cd9 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From 0be5ebe9109e10f340431b3ff8c56febedf64b6b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From 6ec95d9321072323755783ed3f5e56acbfaf37cc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
@@ -0,0 +1,79 @@
+//===-- DiagnosticsRendering.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
1 - 100 of 1194 matches
Mail list logo
