Author: Adrian Prantl
Date: 2024-08-27T12:34:54-07:00
New Revision: b24ffa6002424423ee6bd54347db9b0855efbc2a
URL:
https://github.com/llvm/llvm-project/commit/b24ffa6002424423ee6bd54347db9b0855efbc2a
DIFF:
https://github.com/llvm/llvm-project/commit/b24ffa6002424423ee6bd54347db9b0855efbc2a.diff
Author: Adrian Prantl
Date: 2024-08-27T12:28:25-07:00
New Revision: 5e64520dae5dd980bc6db25414edc3a167d8af8f
URL:
https://github.com/llvm/llvm-project/commit/5e64520dae5dd980bc6db25414edc3a167d8af8f
DIFF:
https://github.com/llvm/llvm-project/commit/5e64520dae5dd980bc6db25414edc3a167d8af8f.diff
Author: Adrian Prantl
Date: 2024-08-27T11:04:54-07:00
New Revision: c349ded7e61f3611ea54fa712e54b16c4c317a6b
URL:
https://github.com/llvm/llvm-project/commit/c349ded7e61f3611ea54fa712e54b16c4c317a6b
DIFF:
https://github.com/llvm/llvm-project/commit/c349ded7e61f3611ea54fa712e54b16c4c317a6b.diff
@@ -305,7 +307,9 @@ def test_frame_recognizer_target_specific(self):
self.expect(
"frame recognizer list",
-substrs=["recognizer.MyFrameRecognizer, module a.out, symbol bar"],
+substrs=[
+"recognizer.MyFrameRecognizer
adrian-prantl wrote:
Looks like this is failing on the Darwin bot:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/10463/
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
Author: Adrian Prantl
Date: 2024-08-27T11:00:08-07:00
New Revision: d1d8edf50449accf7896620afc0249af91354d17
URL:
https://github.com/llvm/llvm-project/commit/d1d8edf50449accf7896620afc0249af91354d17
DIFF:
https://github.com/llvm/llvm-project/commit/d1d8edf50449accf7896620afc0249af91354d17.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/106163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Updated all the non-Darwin plugins. I believe to have addressed all outstanding
comments now.
https://github.com/llvm/llvm-project/pull/106163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -15,7 +15,7 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args:
lldb.SBStructuredData
def read_memory_at_address(
self, addr: int, size: int, error: lldb.SBError
) -> lldb.SBData:
-error.SetErrorString("This is an invalid scripted process!"
adrian-prantl wrote:
> I like this. I have just two remarks:
>
> * it might be better to split this into three steps (add new APIs, port to
> new APIs, remove old APIs), as that will make reverts easier/less disruptive
> (I don't know how much we can trust pre-commit CI these days, but I would
adrian-prantl wrote:
> I worry the assert will kill the LLDB library and cause issues. Can we add a
> temporary setting that can override this in case it does cause crashes? I
> really don't want LLDB crashing if we can help it. It will be hard to test
> all of the error code paths that can ha
@@ -56,19 +56,41 @@ class Status {
///
/// \param[in] type
/// The type for \a err.
- explicit Status(ValueType err,
- lldb::ErrorType type = lldb::eErrorTypeGeneric);
+ explicit Status(ValueType err, lldb::ErrorType type =
lldb::eErrorTypeGeneric,
Author: Adrian Prantl
Date: 2024-08-26T10:05:30-07:00
New Revision: bbf2781bc49aee4d7ee8ec40dcf7316db360c454
URL:
https://github.com/llvm/llvm-project/commit/bbf2781bc49aee4d7ee8ec40dcf7316db360c454
DIFF:
https://github.com/llvm/llvm-project/commit/bbf2781bc49aee4d7ee8ec40dcf7316db360c454.diff
https://github.com/adrian-prantl approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -145,6 +167,17 @@
StackFrameRecognizerManager::GetRecognizerForFrame(StackFrameSP frame) {
if (!entry.module_regexp->Execute(module_name.GetStringRef()))
continue;
+ConstString function_name = [&]() {
+ switch (entry.mangling_preference) {
+ cas
@@ -562,17 +562,22 @@ Status ProcessMachCore::DoLoadCore() {
SetCanJIT(false);
- // The corefile's architecture is our best starting point.
- ArchSpec arch(m_core_module_sp->GetArchitecture());
- if (arch.IsValid())
-GetTarget().SetArchitecture(arch);
-
CreateMemo
adrian-prantl wrote:
I reverted the reverts and pushed two commits to fix the missing initialization.
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
Author: Adrian Prantl
Date: 2024-08-23T12:09:19-07:00
New Revision: a0fac6f2d868316a88aa5b62963e26dca9bfa372
URL:
https://github.com/llvm/llvm-project/commit/a0fac6f2d868316a88aa5b62963e26dca9bfa372
DIFF:
https://github.com/llvm/llvm-project/commit/a0fac6f2d868316a88aa5b62963e26dca9bfa372.diff
@@ -92,11 +95,13 @@ void StackFrameRecognizerManager::ForEach(
symbol_name = entry.symbol_regexp->GetText().str();
callback(entry.recognizer_id, entry.recognizer->GetName(), module_name,
- llvm::ArrayRef(ConstString(symbol_name)), true);
+
Author: Adrian Prantl
Date: 2024-08-23T11:06:02-07:00
New Revision: 11d2de436cbab8667fe1f99d7b538e6fb555b4d7
URL:
https://github.com/llvm/llvm-project/commit/11d2de436cbab8667fe1f99d7b538e6fb555b4d7
DIFF:
https://github.com/llvm/llvm-project/commit/11d2de436cbab8667fe1f99d7b538e6fb555b4d7.diff
Author: Adrian Prantl
Date: 2024-08-23T11:06:01-07:00
New Revision: ad7577524286ae6070dc7f18bde35cf050d31e5e
URL:
https://github.com/llvm/llvm-project/commit/ad7577524286ae6070dc7f18bde35cf050d31e5e
DIFF:
https://github.com/llvm/llvm-project/commit/ad7577524286ae6070dc7f18bde35cf050d31e5e.diff
Author: Adrian Prantl
Date: 2024-08-23T11:06:01-07:00
New Revision: 9e9e8238df63b9f10c6635d3f16d8a0fbc7f00c4
URL:
https://github.com/llvm/llvm-project/commit/9e9e8238df63b9f10c6635d3f16d8a0fbc7f00c4
DIFF:
https://github.com/llvm/llvm-project/commit/9e9e8238df63b9f10c6635d3f16d8a0fbc7f00c4.diff
Author: Adrian Prantl
Date: 2024-08-23T11:06:01-07:00
New Revision: 3c0fba4f2471cacb27d787c7d8f54f21d9dcafae
URL:
https://github.com/llvm/llvm-project/commit/3c0fba4f2471cacb27d787c7d8f54f21d9dcafae
DIFF:
https://github.com/llvm/llvm-project/commit/3c0fba4f2471cacb27d787c7d8f54f21d9dcafae.diff
Author: Adrian Prantl
Date: 2024-08-23T11:06:01-07:00
New Revision: b7c1be1a7f49539ea644ff3fd8b55f237e37b35e
URL:
https://github.com/llvm/llvm-project/commit/b7c1be1a7f49539ea644ff3fd8b55f237e37b35e
DIFF:
https://github.com/llvm/llvm-project/commit/b7c1be1a7f49539ea644ff3fd8b55f237e37b35e.diff
@@ -92,11 +95,13 @@ void StackFrameRecognizerManager::ForEach(
symbol_name = entry.symbol_regexp->GetText().str();
callback(entry.recognizer_id, entry.recognizer->GetName(), module_name,
- llvm::ArrayRef(ConstString(symbol_name)), true);
+
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/105756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Retiring in favor of https://github.com/llvm/llvm-project/pull/105695/.
https://github.com/llvm/llvm-project/pull/105756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
adrian-prantl wrote:
@gribozavr Thanks for pointing this out. This is funny: I forgot to initialize
the generation counter in StackFrame. I didn't notice because this actually
doesn't cause a bug; it just needs to increment and wrap around so the starting
position doesn't matter.
https://git
Author: Adrian Prantl
Date: 2024-08-23T09:25:24-07:00
New Revision: fd7904a07bc26950fa7735fb6871a064e3ebc836
URL:
https://github.com/llvm/llvm-project/commit/fd7904a07bc26950fa7735fb6871a064e3ebc836
DIFF:
https://github.com/llvm/llvm-project/commit/fd7904a07bc26950fa7735fb6871a064e3ebc836.diff
@@ -92,11 +95,13 @@ void StackFrameRecognizerManager::ForEach(
symbol_name = entry.symbol_regexp->GetText().str();
callback(entry.recognizer_id, entry.recognizer->GetName(), module_name,
- llvm::ArrayRef(ConstString(symbol_name)), true);
+
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/105756
Instead of doing the coarse-grained initial matching of frame recognizers on
fully demangled names, it can be much more efficient and reliable to filter on
all functions of a particular language by discri
Author: Adrian Prantl
Date: 2024-08-21T16:53:37-07:00
New Revision: 19d3f3417100dc99caa4394fbd26fc0c4702264e
URL:
https://github.com/llvm/llvm-project/commit/19d3f3417100dc99caa4394fbd26fc0c4702264e
DIFF:
https://github.com/llvm/llvm-project/commit/19d3f3417100dc99caa4394fbd26fc0c4702264e.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/104523
>From a27308d05fb651a50e92bb9f03a56d8ad424537f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 15 Aug 2024 16:18:33 -0700
Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from
backt
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
@@ -278,6 +278,29 @@ class CommandObjectFrameSelect : public
CommandObjectParsed {
if (frame_idx == UINT32_MAX)
frame_idx = 0;
+ // If moving up/down by one, skip over hidden frames.
+ if (*m_options.relative_frame_offset == 1 ||
+ *m_options.
@@ -1208,7 +1208,8 @@ bool SBThread::GetStatus(SBStream &status) const {
ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
if (exe_ctx.HasThreadScope()) {
-exe_ctx.GetThreadPtr()->GetStatus(strm, 0, 1, 1, true);
+exe_ctx.GetThreadPtr()->GetStatus(strm, 0, 1, 1, tr
@@ -17,6 +17,7 @@
#include "lldb/lldb-private-forward.h"
#include "lldb/lldb-public.h"
+#include <_types/_uint16_t.h>
adrian-prantl wrote:
That was clang-format.
https://github.com/llvm/llvm-project/pull/104523
___
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/104523
>From 81af1010aad7f6ab1abcf397c81245e53cc29adc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 15 Aug 2024 16:18:33 -0700
Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from
backt
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/104817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/104799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Implemented StepOut.
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/104523
>From ece2b891557ee8323ff7d2d67b66cb01d06502a9 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 15 Aug 2024 16:18:33 -0700
Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from
backt
adrian-prantl wrote:
@medismailben I copied&pasted the python interface code from the function
above; could you review that code extra carefully?
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
adrian-prantl wrote:
I uploaded a new version of the patch that addresses all outstanding feedback,
except for `finish` (I haven't looked at how that is implemented yet):
- correctly caching recognized frames
- hiding the recognizer API behind Frame::IsHidden()
- exposing it via the SBAPI
- exte
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/104523
>From 8f6af48316f834ffe2e2ddd8d0a75df22955e9fb Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 15 Aug 2024 16:18:33 -0700
Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from
backt
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/104523
>From 665332171ea0251c39eed5a737d014c061412f1d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 15 Aug 2024 16:18:33 -0700
Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from
backt
adrian-prantl wrote:
> When we were talking about this originally I thought that StackFrames would
> get an "ImplementationFrame" property, and we would use that to determine
> whether to hide the frame in bt (when not passing --unfiltered). Then the
> frame recognizers when they are run on th
adrian-prantl wrote:
Action items so far:
- change the option to `--unfiltered` (no argument)
- expose in SBFrame
- expose in Python
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
@@ -1048,6 +1048,9 @@ let Command = "thread backtrace" in {
Arg<"FrameIndex">, Desc<"Frame in which to start the backtrace">;
def thread_backtrace_extended : Option<"extended", "e">, Group<1>,
Arg<"Boolean">, Desc<"Show the extended backtrace, if available">;
+ def threa
adrian-prantl wrote:
> This seems pretty cool! Question: what would happen if the top frame (the one
> with the PC) gets filtered out by the recognizer?
The current frame never gets filtered. If you select a filtered frame with `f
123` and run `bt` the current frame will be there.
https://git
adrian-prantl wrote:
> ... But i do wonder if there should be a way for a user to provide regexes
> that should behave this way too.
The idea is that users can write their own frame recognizers in Python (though
I have not exposed this in this patch). I'll see if I can ad this!
> I don't know
@@ -979,6 +988,8 @@ size_t StackFrameList::GetStatus(Stream &strm, uint32_t
first_frame,
++num_frames_displayed;
}
+ if (filtered)
+strm << "Note: Some frames were hidden by frame recognizers\n";
adrian-prantl wrote:
Yes, this is intentional. Fram
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/104523
>From 66292a2279cb66522932a4909a8382790da80060 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 15 Aug 2024 16:18:33 -0700
Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from
backt
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/104523
Compilers and language runtimes often use helper functions that are
fundamentally uninteresting when debugging anything but the compiler/runtime
itself. This patch introduces a user-extensible mechanism t
Author: Adrian Prantl
Date: 2024-08-13T09:43:07-07:00
New Revision: 7e236136ab2896dee12bbe96d5994bb65c326e9f
URL:
https://github.com/llvm/llvm-project/commit/7e236136ab2896dee12bbe96d5994bb65c326e9f
DIFF:
https://github.com/llvm/llvm-project/commit/7e236136ab2896dee12bbe96d5994bb65c326e9f.diff
adrian-prantl wrote:
@labath This test fails in two configs on the matrix bot:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-matrix/602/testReport/junit/lldb-shell/SymbolFile_DWARF_x86/Test_Clang_17_0_6___dwp_hash_collision_s/
https://green.lab.llvm.org/job/llvm.org/view/LLDB/j
adrian-prantl wrote:
@clayborg Based on the blamelist in
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/9352/ this
broke
[lldb-api.functionalities/gdb_remote_client.TestGdbClientModuleLoad.py](https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/9352/testRep
@@ -436,6 +437,39 @@ class Platform : public PluginInterface {
return lldb_private::ConstString();
}
+ /// Search each CU associated with the specified 'module' for
+ /// the SDK paths the CUs were compiled against. In the presence
+ /// of different SDKs, we try to p
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/102488
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/102497
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
Thanks, this LGTM, next step should be to replace the use of
`include_directories` with `DW_AT_APPLE_sdk`.
https://github.com/llvm/llvm-project/pull/102309
___
lldb-commits mailing list
lldb
adrian-prantl wrote:
@jimingham Should we revert the patch until this is fixed or are there more
patches depending on this?
https://github.com/llvm/llvm-project/pull/90930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/102161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -561,7 +562,85 @@ static void SetupLangOpts(CompilerInstance &compiler,
lang_opts.NoBuiltin = true;
}
-static void SetupImportStdModuleLangOpts(CompilerInstance &compiler) {
+// NOTE: should be kept in sync with sdkSupportsBuiltinModules in
+// Toolchains/Darwin.cpp
+stat
@@ -578,7 +657,12 @@ static void SetupImportStdModuleLangOpts(CompilerInstance
&compiler) {
lang_opts.GNUMode = true;
lang_opts.GNUKeywords = true;
lang_opts.CPlusPlus11 = true;
- lang_opts.BuiltinHeadersInSystemModules = true;
+
+ // FIXME: We should use the driver to
@@ -561,7 +562,85 @@ static void SetupLangOpts(CompilerInstance &compiler,
lang_opts.NoBuiltin = true;
}
-static void SetupImportStdModuleLangOpts(CompilerInstance &compiler) {
+// NOTE: should be kept in sync with sdkSupportsBuiltinModules in
+// Toolchains/Darwin.cpp
+stat
@@ -465,18 +465,24 @@ ClangExpressionParser::ClangExpressionParser(
// A value of 0 means no limit for both LLDB and Clang.
m_compiler->getDiagnostics().setErrorLimit(target_sp->GetExprErrorLimit());
- auto target_info = TargetInfo::CreateTargetInfo(
- m_compiler->ge
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/101697
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -615,6 +484,147 @@ ClangExpressionParser::ClangExpressionParser(
// 'fopen'). Those libc functions are already correctly handled by LLDB, and
// additionally enabling them as expandable builtins is breaking Clang.
lang_opts.NoBuiltin = true;
+}
+
+static void SetupImpo
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/101669
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
@Michael137 Have you tried applying the patch to swift-lldb and running the
tests?
https://github.com/llvm/llvm-project/pull/101333
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/97275
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
A high-level concern that I have with this is the grammar is full of
C++-specific nodes, which is not something I would like to see in living in
`Core`. Have we previously reached any consensus on how we want to handle
different languages in DIL?
I would be more comfortabl
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/96290
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/96232
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/96232
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/96232
>From 73309c4f67ea550b9af336cecc30dd242d89c08b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 20 Jun 2024 12:38:58 -0700
Subject: [PATCH] [DWIMPrint] Move the setting of the result status into
dum
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/96232
This is another NFC change for TypeSystemClang, because an object description
cannot actually fail there. It will have different behavior in the Swift plugin.
>From 942199ba4e70c4dc3bfbf7182e34863daf352f73
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/95857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Landed in f1edc0459a4cc8cd4d00331c2a5cb318955318b2
https://github.com/llvm/llvm-project/pull/95857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-06-20T10:32:07-07:00
New Revision: f1edc0459a4cc8cd4d00331c2a5cb318955318b2
URL:
https://github.com/llvm/llvm-project/commit/f1edc0459a4cc8cd4d00331c2a5cb318955318b2
DIFF:
https://github.com/llvm/llvm-project/commit/f1edc0459a4cc8cd4d00331c2a5cb318955318b2.diff
Author: Adrian Prantl
Date: 2024-06-20T10:32:06-07:00
New Revision: b8f0ca09b66716fc337448a2e43146038bf115ab
URL:
https://github.com/llvm/llvm-project/commit/b8f0ca09b66716fc337448a2e43146038bf115ab
DIFF:
https://github.com/llvm/llvm-project/commit/b8f0ca09b66716fc337448a2e43146038bf115ab.diff
Author: Adrian Prantl
Date: 2024-06-20T10:32:06-07:00
New Revision: f900644ae2b6c7a485673974688a62c3f3301dcc
URL:
https://github.com/llvm/llvm-project/commit/f900644ae2b6c7a485673974688a62c3f3301dcc
DIFF:
https://github.com/llvm/llvm-project/commit/f900644ae2b6c7a485673974688a62c3f3301dcc.diff
Author: Adrian Prantl
Date: 2024-06-20T10:32:06-07:00
New Revision: d1bc75c0bce141b94f9afadfde4e784760735ec0
URL:
https://github.com/llvm/llvm-project/commit/d1bc75c0bce141b94f9afadfde4e784760735ec0
DIFF:
https://github.com/llvm/llvm-project/commit/d1bc75c0bce141b94f9afadfde4e784760735ec0.diff
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/95857
>From 7e3d1420a941431de223098ee153d2d4c63cfbfc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 17 Jun 2024 14:29:01 -0700
Subject: [PATCH 1/4] Convert ValueObject::Dump() to return llvm::Error()
(N
Author: Adrian Prantl
Date: 2024-06-20T09:45:58-07:00
New Revision: 869f5517605224944d6037716e234d9f1f0e7067
URL:
https://github.com/llvm/llvm-project/commit/869f5517605224944d6037716e234d9f1f0e7067
DIFF:
https://github.com/llvm/llvm-project/commit/869f5517605224944d6037716e234d9f1f0e7067.diff
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/95857
>From 7e3d1420a941431de223098ee153d2d4c63cfbfc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 17 Jun 2024 14:29:01 -0700
Subject: [PATCH 1/4] Convert ValueObject::Dump() to return llvm::Error()
(N
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/95857
>From 7e3d1420a941431de223098ee153d2d4c63cfbfc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 17 Jun 2024 14:29:01 -0700
Subject: [PATCH 1/4] Convert ValueObject::Dump() to return llvm::Error()
(N
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/95857
>From 7e3d1420a941431de223098ee153d2d4c63cfbfc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 17 Jun 2024 14:29:01 -0700
Subject: [PATCH 1/4] Convert ValueObject::Dump() to return llvm::Error()
(N
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/95857
>From 7e3d1420a941431de223098ee153d2d4c63cfbfc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 17 Jun 2024 14:29:01 -0700
Subject: [PATCH 1/4] Convert ValueObject::Dump() to return llvm::Error()
(N
@@ -299,7 +299,9 @@ bool Watchpoint::DumpSnapshots(Stream *s, const char
*prefix) const {
.SetHideRootType(true)
.SetHideRootName(true)
.SetHideName(true);
-m_old_value_sp->Dump(strm, options);
+if (llvm::Error error = m_old_
@@ -461,34 +468,34 @@ bool
ValueObjectPrinter::PrintValueAndSummaryIfNeeded(bool &value_printed,
return !error_printed;
}
-bool ValueObjectPrinter::PrintObjectDescriptionIfNeeded(bool value_printed,
-bool summary_print
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/95857
>From 7e3d1420a941431de223098ee153d2d4c63cfbfc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 17 Jun 2024 14:29:01 -0700
Subject: [PATCH 1/4] Convert ValueObject::Dump() to return llvm::Error()
(N
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/95963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/95857
>From 7e3d1420a941431de223098ee153d2d4c63cfbfc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 17 Jun 2024 14:29:01 -0700
Subject: [PATCH 1/3] Convert ValueObject::Dump() to return llvm::Error()
(N
@@ -1233,7 +1233,10 @@ bool SBValue::GetDescription(SBStream &description) {
DumpValueObjectOptions options;
options.SetUseDynamicType(m_opaque_sp->GetUseDynamic());
options.SetUseSyntheticValue(m_opaque_sp->GetUseSynthetic());
-value_sp->Dump(strm, options);
+
adrian-prantl wrote:
I pushed two more patches in the same vain on top of the PR. This is now the
final state for what I want to achieve in the Swift plugin.
https://github.com/llvm/llvm-project/pull/95857
___
lldb-commits mailing list
lldb-commits@li
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/95857
>From 7e3d1420a941431de223098ee153d2d4c63cfbfc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 17 Jun 2024 14:29:01 -0700
Subject: [PATCH 1/3] Convert ValueObject::Dump() to return llvm::Error()
(N
301 - 400 of 1194 matches
Mail list logo
