https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/95857
This change by itself has no measurable effect on the LLDB testsuite. I'm
making it in preparation for threading through more errors in the Swift
language plugin.
>From 7e3d1420a941431de223098ee153d2d4c63
Author: Adrian Prantl
Date: 2024-06-17T15:11:33-07:00
New Revision: 6c17f1cabdee3399feceb478921a8369bde18b16
URL:
https://github.com/llvm/llvm-project/commit/6c17f1cabdee3399feceb478921a8369bde18b16
DIFF:
https://github.com/llvm/llvm-project/commit/6c17f1cabdee3399feceb478921a8369bde18b16.diff
@@ -0,0 +1,165 @@
+(* LLDB Debug Expressions, a subset of C++ *)
+(* Insired by https://www.nongnu.org/hcb *)
+
+expression = assignment_expression ;
adrian-prantl wrote:
Nice to actually have the grammar documented!
https://github.com/llvm/llvm-project/pull/957
@@ -85,7 +85,7 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
bool has_class_name = !class_name.empty();
bool has_interpreter_dict =
!(llvm::StringRef(m_interpreter.GetDictionaryName()).empty());
-if (!has_class_name && !has_interpret
@@ -200,7 +200,10 @@ def test_commands(self):
# Get output from the console. This should contain both the
# "exitCommands" that were run after the second breakpoint was hit
# and the "terminateCommands" due to the debugging session ending
-output
@@ -279,9 +281,16 @@ class SemaSourceWithPriorities : public
clang::ExternalSemaSource {
return nullptr;
}
+ /// Call ExternalASTSource::CompleteRedeclChain(D)
+ /// on each AST source. Returns as soon as we got
+ /// a definition for D.
void CompleteRedeclChain(c
@@ -228,6 +246,9 @@ class DWARFASTParserClang : public
lldb_private::plugin::dwarf::DWARFASTParser {
void LinkDeclToDIE(clang::Decl *decl,
const lldb_private::plugin::dwarf::DWARFDIE &die);
+ void RegisterDIE(lldb_private::plugin::dwarf::DWARFDebugInfo
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/95100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl commented:
Very excited to see this happening!
https://github.com/llvm/llvm-project/pull/95100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/95582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/95405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,10 @@
+// RUN: %clangxx_host %s -g -o %t
+//
+// RUN: %lldb -f %t \
+// RUN: -o "settings set interpreter.stop-command-source-on-error false" \
+// RUN: -o "b main" -o run -o "expression --language objc -- *(id)0x1234" -o
exit 2>&1 | FileCheck %s
adr
@@ -1758,6 +1759,11 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
}
if (attrs.is_forward_declaration) {
+Progress progress(llvm::formatv(
+"Parsing forward declaration {0}: {1}",
adrian-prantl wrote:
It should either
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/94679
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/94554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1657,7 +1650,7 @@ llvm::Expected DWARFExpression::Evaluate(
case DW_OP_eq:
if (stack.size() < 2) {
return llvm::createStringError(
-"Expression stack needs at least 2 items for DW_OP_eq.");
+"expression stack needs at least 2 items
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/94554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
This is going to be great! Thanks.
Minor nitpicks inside.
https://github.com/llvm/llvm-project/pull/94420
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -2341,9 +2198,7 @@ bool DWARFExpression::Evaluate(
// the stack by the called expression may be used as return values by prior
// agreement between the calling and called expressions.
case DW_OP_call2:
- if (error_ptr)
-error_ptr->SetErrorString("Uni
@@ -1350,10 +1300,8 @@ bool DWARFExpression::Evaluate(
if (pick_idx < stack.size())
stack.push_back(stack[stack.size() - 1 - pick_idx]);
else {
-if (error_ptr)
- error_ptr->SetErrorStringWithFormat(
- "Index %u out of range for
@@ -52,9 +52,10 @@ __attribute__((noinline)) void func4_amb(int &sink, int x) {
//% expect_cmd_failure=True)
//% self.filecheck("expr sink", "main.cpp","-check-prefix=FUNC4-EXPR",
//% expect_cmd_failure=True)
- // FUNC4-EXPR-FAIL: couldn't get the value of variab
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/94420
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Thanks for providing the context, Lang!
Inside of LLDB we use llvm::Expected often in completely closed environments
where the expectation is always that all errors are handled internally and we
never would exit the process with an error code, so this would be useful here.
@@ -2153,26 +2152,41 @@ bool DWARFExpression::Evaluate(
}
break;
- case Value::ValueType::FileAddress:
- case Value::ValueType::HostAddress:
-if (error_ptr) {
- lldb::addr_t addr =
curr_piece_source_value.GetS
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/94026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/94026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/93209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/93209
>From c5738598436c7a9e1ba38ba8ffd6f67a2e524785 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 23 May 2024 08:36:48 -0700
Subject: [PATCH] Add a createError variant without error code (NFC)
For the
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/93209
>From bece445681b0f810927c799cea53686cd000339b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 23 May 2024 08:36:48 -0700
Subject: [PATCH] Add a createError variant without error code (NFC)
For the
@@ -87,8 +87,8 @@ llvm::Error Socket::Initialize() {
if (err == 0) {
if (wsaData.wVersion < wVersion) {
WSACleanup();
- return llvm::make_error(
- "WSASock version is not expected.", llvm::inconvertibleErrorCode());
+ return llvm::createStringErro
adrian-prantl wrote:
The obvious downside is that it makes it easier to not even try to find a
matching error code, but it looks like most incontrovertible errors are caught
before the get reported as an exit status.
https://github.com/llvm/llvm-project/pull/93209
_
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/93209
For the significant amount of call sites that want to create an
incontrovertible error, such a wrapper function creates a significant
readability improvement and lowers the cost of entry to add error handl
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/92979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/92979
>From a8503fb49ef7964dbde318df103546bde72f7b42 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 21 May 2024 17:41:31 -0700
Subject: [PATCH] Change GetChildCompilerTypeAtIndex to return Expected (NFC)
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/92979
This change is a general improvement of the internal API. My motivation is to
use this in the Swift typesystem plugin.
>From 8a6202f8ae92a62ce577271ec580379f1424f9e3 Mon Sep 17 00:00:00 2001
From: Adrian P
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/92618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2067,7 +2067,7 @@ void Debugger::HandleProgressEvent(const lldb::EventSP
&event_sp) {
const uint32_t term_width = GetTerminalWidth();
const uint32_t ellipsis = 3;
if (message.size() + ellipsis >= term_width)
-message = message.substr(0, term_width - ellipsis);
+
adrian-prantl wrote:
> No, on the terminal it works that way by design. Unless you switch to
> something that takes full control of your screen (like curses) there's no
> good way to display multiple progress events at the same time and not doing
> the shadowing (i.e. letting more recent progr
adrian-prantl wrote:
> Thanks. Can you provide instructions to repro the failure locally?
The bot log should have the cmake line and all the commands that were run there.
https://github.com/llvm/llvm-project/pull/90663
___
lldb-commits mailing list
ll
adrian-prantl wrote:
That's just not how the LLVM project operates.
I'd rather deal with two conflicting PRs than deal with an assigned orphaned
issue that the assignee lost interest in.
This is in the end a communication problem, and I don't mind if someone
responds to the bug to say that they
adrian-prantl wrote:
@ZequanWu in the future, if one of your commits break a bot, make sure to
revert it immediately, you can always re-land it later with a fix or an
explanation why it wasn't your commit that broke the bots. Reverting a commit
is cheap, red bots are expensive :-)
https://git
adrian-prantl wrote:
> A new user already asked to be assigned to work on #91209 2 days ago in the
> comments. **I think that user deserves an opportunity to work on the issue**.
>
> Next time when you see a **"good first issue"** which a new user had already
> asked to get assigned to, please
adrian-prantl wrote:
> Re-apply https://github.com/llvm/llvm-project/pull/81196, with a fix.
It's usually helpful to indicate what/where the fix is to make it easier to
re-review.
https://github.com/llvm/llvm-project/pull/91868
___
lldb-commits maili
@@ -658,6 +659,38 @@ static char ConvertValueObjectStyleToChar(
return '\0';
}
+static llvm::Regex LLVMFormatPattern{"x[-+]?\\d*|n|d",
llvm::Regex::IgnoreCase};
+
+static bool DumpValueWithLLVMFormat(Stream &s, llvm::StringRef options,
+V
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/91868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/91868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/91686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Could this commit have broken the bots?
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/1897/
https://github.com/llvm/llvm-project/pull/90663
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
adrian-prantl wrote:
If this turns out to be necessary, one way to rate-limit them would be to have
a nesting depth counter. Assuming that these imports happen recursively we
could create only Progress objects for the top n layers.
https://github.com/llvm/llvm-project/pull/91452
__
adrian-prantl wrote:
I think that would be a good start. Also tagging @jasonmolenda for advice.
https://github.com/llvm/llvm-project/pull/91321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
adrian-prantl wrote:
> I am somewhat worried about this slowing down the actual operations it is
> reporting progress on. I didn't really measure this, but intuitively, I'd
> expect that a one of these operations (parsing/importing one type) would be
> pretty fast, and that the whole process t
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/91128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/91128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/91511
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/91511
…db-resource-headers
The Xcode build otherwise fails with
```
CMake Error in source/API/CMakeLists.txt:
The custom command generating
/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-standalone
@@ -1411,3 +1414,35 @@ clang::Decl *
ClangASTImporter::ASTImporterDelegate::GetOriginalDecl(clang::Decl *To) {
return m_main.GetDeclOrigin(To).decl;
}
+
+void ClangASTImporter::ASTImporterDelegate::UpdateImportProgress(
+clang::Decl const *From) {
+ assert(From &&
+
@@ -1240,7 +1241,13 @@ TypeSP
SymbolFileDWARFDebugMap::FindCompleteObjCDefinitionTypeForDIE(
void SymbolFileDWARFDebugMap::FindTypes(const TypeQuery &query,
TypeResults &results) {
std::lock_guard guard(GetModuleMutex());
+ Progress p
https://github.com/adrian-prantl commented:
Nice!
https://github.com/llvm/llvm-project/pull/91452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1411,3 +1414,35 @@ clang::Decl *
ClangASTImporter::ASTImporterDelegate::GetOriginalDecl(clang::Decl *To) {
return m_main.GetDeclOrigin(To).decl;
}
+
+void ClangASTImporter::ASTImporterDelegate::UpdateImportProgress(
+clang::Decl const *From) {
+ assert(From &&
+
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/91452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1240,7 +1241,13 @@ TypeSP
SymbolFileDWARFDebugMap::FindCompleteObjCDefinitionTypeForDIE(
void SymbolFileDWARFDebugMap::FindTypes(const TypeQuery &query,
TypeResults &results) {
std::lock_guard guard(GetModuleMutex());
+ Progress p
Author: Adrian Prantl
Date: 2024-05-07T13:44:44-07:00
New Revision: 8c4d7989c2b4a7e251afc3b13002611646de90b6
URL:
https://github.com/llvm/llvm-project/commit/8c4d7989c2b4a7e251afc3b13002611646de90b6
DIFF:
https://github.com/llvm/llvm-project/commit/8c4d7989c2b4a7e251afc3b13002611646de90b6.diff
Author: Adrian Prantl
Date: 2024-05-07T13:44:44-07:00
New Revision: 272ea28bdec93b33527dc54edbdef8f43c51df47
URL:
https://github.com/llvm/llvm-project/commit/272ea28bdec93b33527dc54edbdef8f43c51df47
DIFF:
https://github.com/llvm/llvm-project/commit/272ea28bdec93b33527dc54edbdef8f43c51df47.diff
@@ -37,6 +38,10 @@ def emit_enum(input, output):
with open(input, "r") as f:
lines = f.readlines()
+# Create output folder if it does not exist
+if not os.path.isdir(os.path.dirname(output)):
adrian-prantl wrote:
This can be simplified: ht
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -438,3 +439,15 @@ void RotatingLogHandler::Dump(llvm::raw_ostream &stream)
const {
}
stream.flush();
}
+
+TeeLogHandler::TeeLogHandler(std::shared_ptr first_log_handler,
+ std::shared_ptr second_log_handler)
+: m_first_log_handler(first_l
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/90984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -112,6 +112,22 @@ class RotatingLogHandler : public LogHandler {
static char ID;
};
+class TeeLogHandler : public LogHandler {
adrian-prantl wrote:
Doxygen comment?
https://github.com/llvm/llvm-project/pull/90984
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90917
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1347,6 +1347,12 @@ enum DebuggerBroadcastBit {
eBroadcastBitProgressCategory = (1 << 3),
};
+enum Severity {
adrian-prantl wrote:
Would `enum class` prevent people from accidentally casting this to an
unrelated enum with similar purpose but potentially
@@ -1347,6 +1347,12 @@ enum DebuggerBroadcastBit {
eBroadcastBitProgressCategory = (1 << 3),
};
+enum Severity {
+ eSeverityError,
+ eSeverityWarning,
+ eSeverityInfo,
adrian-prantl wrote:
Or even `eSeverityRemark = eSeverityInfo`
https://github.com/llv
@@ -1347,6 +1347,12 @@ enum DebuggerBroadcastBit {
eBroadcastBitProgressCategory = (1 << 3),
};
+enum Severity {
+ eSeverityError,
+ eSeverityWarning,
+ eSeverityInfo,
adrian-prantl wrote:
Can you comment that "Clang also calls these Remarks, it's concep
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -87,8 +87,15 @@ class Host {
StartMonitoringChildProcess(const MonitorChildProcessCallback &callback,
lldb::pid_t pid);
+ /// System log level.
+ enum SystemLogLevel {
+eSystemLogInfo,
+eSystemLogWarning,
adrian-pra
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90297
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-05-01T13:41:32-07:00
New Revision: b8c301f6e22a6a5ebec4b8870327237eb94c5b15
URL:
https://github.com/llvm/llvm-project/commit/b8c301f6e22a6a5ebec4b8870327237eb94c5b15
DIFF:
https://github.com/llvm/llvm-project/commit/b8c301f6e22a6a5ebec4b8870327237eb94c5b15.diff
Author: Adrian Prantl
Date: 2024-05-01T13:11:51-07:00
New Revision: fa9e96a2e55226b1f9f9744f42ac5e925297f819
URL:
https://github.com/llvm/llvm-project/commit/fa9e96a2e55226b1f9f9744f42ac5e925297f819
DIFF:
https://github.com/llvm/llvm-project/commit/fa9e96a2e55226b1f9f9744f42ac5e925297f819.diff
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-05-01T12:55:36-07:00
New Revision: c4e8e2c67bbfff2d1b23210c375c173aa05e3848
URL:
https://github.com/llvm/llvm-project/commit/c4e8e2c67bbfff2d1b23210c375c173aa05e3848
DIFF:
https://github.com/llvm/llvm-project/commit/c4e8e2c67bbfff2d1b23210c375c173aa05e3848.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/90666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/90666
>From 88db878450f40e450965629412d1ad5c303249e9 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 30 Apr 2024 13:59:39 -0700
Subject: [PATCH] Install generated API headers into LLDB.framework
---
lld
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/90666
>From d1b444aea800ef4f5950400728e00838dfd05fba Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 30 Apr 2024 13:59:39 -0700
Subject: [PATCH] Install generated API headers into LLDB.framework
---
lld
@@ -0,0 +1,67 @@
+#!/usr/bin/env python3
+
+import argparse
+import re
+
+HEADER = """\
+//===-- SBLanguages.h -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/L
https://github.com/adrian-prantl requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/90753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/90753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/90753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
I had to replace the GLOB with a hardcoded file name because the GLOB gets
evaluated at CMake configure time, when the file doesn't exist yet.
https://github.com/llvm/llvm-project/pull/90666
___
lldb-commits mailing list
lldb-comm
@@ -8,6 +8,12 @@ set(LLDB_INCLUDE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/include")
set(LLDB_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
set(LLDB_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
+if (LLDB_BUILT_STANDALONE)
+ set(LLDB_OBJ_DIR ${CMAKE_CURRENT_BINARY_DIR})
+else()
+ set(LLDB_OBJ_
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/90666
>From 9510a08995da26d0c3c1ea8d13f6c3f8fab772c2 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 30 Apr 2024 13:59:39 -0700
Subject: [PATCH] Install generated API headers into LLDB.framework
---
lld
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/90666
>From 6950a36e2619f032f2dd41f258f171b876274bd5 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 30 Apr 2024 13:59:39 -0700
Subject: [PATCH] Install generated API headers into LLDB.framework
---
lld
@@ -71,6 +71,7 @@ endif()
# At configuration time, collect headers for the framework bundle and copy them
# into a staging directory. Later we can copy over the entire folder.
file(GLOB public_headers ${LLDB_SOURCE_DIR}/include/lldb/API/*.h)
+file(GLOB built_public_headers
${L
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/90666
None
>From 628576baf4dbf11efa56a079dde9759ccc7e988d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 30 Apr 2024 13:59:39 -0700
Subject: [PATCH] Install generated API headers into LLDB.framework
--
Author: Adrian Prantl
Date: 2024-04-30T09:53:13-07:00
New Revision: 4cd11c986f78e19f53b3f3c92143b7b7c1ce54b1
URL:
https://github.com/llvm/llvm-project/commit/4cd11c986f78e19f53b3f3c92143b7b7c1ce54b1
DIFF:
https://github.com/llvm/llvm-project/commit/4cd11c986f78e19f53b3f3c92143b7b7c1ce54b1.diff
adrian-prantl wrote:
Btw. github doesn't let you see older revisions, but the code snippet you
posted that includes a .def file was exactly my first version of this patch.
You can still find @JDevlieghere's comment asking me to change it though :-)
Another thing worth noting is that the public
adrian-prantl wrote:
That's also why it's a `.h` file and not a `.inc`.
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> Why does this use tablegen to parse a .def file?
>
> Can't you get the same behavior without tablegen, using normal xmacro
> techniques, something like
>
> ```c++
> enum SBSourceLanguageName : uint16_t {
>
> #define HANDLE_DW_LNAME(ID, NAME, DESC, LOWER_BOUND) \
> eLa
@@ -685,7 +686,7 @@ bool Address::Dump(Stream *s, ExecutionContextScope
*exe_scope, DumpStyle style,
sc.DumpStopContext(s, exe_scope, *this, show_fullpaths,
show_module, show_inlined_frames,
show_f
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/90531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
401 - 500 of 1194 matches
Mail list logo
