[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

2023-08-14 Thread Alex Bradbury via Phabricator via lldb-commits
asb added a comment. Is there some separate discussion thread or proposal about this refactoring and its motivations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157497/new/ https://reviews.llvm.org/D157497

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2023-05-17 Thread Alex Bradbury via Phabricator via lldb-commits
asb added a comment. In D128612#4349259 , @djtodoro wrote: > In D128612#4345912 , @asb wrote: > >> In D128612#4337037 , @djtodoro >> wrote: >> >>> Hi! I am wondering if

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2023-05-16 Thread Alex Bradbury via Phabricator via lldb-commits
asb added a comment. Thanks for this patch Guy. As just discussed in the RISC-V sync-up call, it would be helpful from a review perspective to write down at least a simple plain-text description of the changes to the psABI doc needed to reflect the BE ABI implemented by GCC (and soon LLVM),

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2022-07-08 Thread Alex Bradbury via Phabricator via lldb-commits
asb added a comment. Thanks for this patch Guy. As just discussed in the RISC-V sync-up call, it would be helpful from a review perspective to write down at least a simple plain-text description of the changes to the psABI doc needed to reflect the BE ABI implemented by GCC (and soon LLVM),