[Lldb-commits] [PATCH] D147084: [lldb] Move ObjectFileJIT to lldbExpression

This revision was automatically updated to reflect the committed changes. Closed by commit rGa52054cfa29d: [lldb] Move ObjectFileJIT to lldbExpression (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147084/new/

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord abandoned this revision. bulbazord added a comment. I'm abandoning this approach in favor of what Pavel suggested: https://reviews.llvm.org/D147084 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147009/new/

[Lldb-commits] [PATCH] D147084: [lldb] Move ObjectFileJIT to lldbExpression

bulbazord created this revision. bulbazord added reviewers: labath, JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In the spirit of not having lldbExpression

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord planned changes to this revision. bulbazord added a comment. In D147009#4227163 , @labath wrote: > I already regret getting involved in this, but here it goes... Your effort and participation is greatly appreciated. I'm sorry if this is

[Lldb-commits] [PATCH] D147001: [lldb] TestInferiorCrashing.py should check for crash reason

This revision was automatically updated to reflect the committed changes. Closed by commit rG9efb4db29dcc: [lldb] TestInferiorCrashing.py should check for crash reason (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord updated this revision to Diff 508817. bulbazord added a comment. Herald added a subscriber: Michael137. Minor fix to ObjectFileWasm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147009/new/ https://reviews.llvm.org/D147009 Files:

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, labath, clayborg, mib, jingham. Herald added subscribers: pmatos, asb, sbc100, emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added subscribers: lldb-commits, MaskRay, aheejin.

[Lldb-commits] [PATCH] D147007: [lldb] Fix double free in python bindings error handling.

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for taking care of that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147007/new/ https://reviews.llvm.org/D147007

[Lldb-commits] [PATCH] D147001: [lldb] TestInferiorCrashing.py should check for crash reason

bulbazord created this revision. bulbazord added reviewers: labath, rupprecht. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In a now-reverted series of patches, I inadvertently broke the ability

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

bulbazord added a comment. In D146590#4220388 , @jgorbe wrote: > I found the actual reason for the crash I was talking about. This patch only > addressed the incorrect `OverflowError`, but the crash comes from a double > free (as @rupprecht mentioned)

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

bulbazord added a comment. I'm not too familiar with MSP430 but the general idea looks fine. Others may have comments about areas I'm less familiar with. One concern I have is that there are no tests. I can understand that it may be difficult to get automated tests running testing the

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

bulbazord added a comment. In D146668#4223456 , @labath wrote: > I'm sorry, but I don't think this is a good change (which I guess means the > previous one is not good either, but this one drives the point). I really > don't want lldb-server to depend

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

bulbazord added a comment. In D146668#4221223 , @thakis wrote: > Hello, > https://github.com/llvm/llvm-project/commit/5fb4147f74ad90095f08f243e5f19877d09d11b9 > broke the windows build (http://45.33.8.238/win/76494/step_4.txt) because > it's now

[Lldb-commits] [PATCH] D146152: Add __lldb_init_module_with_target for use when sourcing modules for a target

bulbazord added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:1031-1048 + // First call the target initializer: + if (target) { +python_function_name_string += ".__lldb_init_module_with_target"; +python_function_name =

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:540 +image = self.get_used_image(image_id) frame_offset = int(json_frame['imageOffset']) is `image` not the same as `json_image` from a few lines above this?

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c5cee779929: [lldb-server] Use Platform plugin corresponding to the host (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146668/new/

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

bulbazord added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:439 /// The section offset based address for this function. + /// \param[in] range + /// The symbol name this function should trampoline to. Comment

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

bulbazord updated this revision to Diff 507546. bulbazord added a comment. Adding a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146668/new/ https://reviews.llvm.org/D146668 Files:

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

bulbazord added a comment. Herald added a subscriber: JDevlieghere. With this patch: alex@ubuntu:~/llvm-project/build$ ./bin/lldb foo (lldb) target create "foo" Current executable set to '/home/alex/llvm-project/build/foo' (aarch64). (lldb) r Process 19623 launched:

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

bulbazord added inline comments. Comment at: lldb/source/Target/UnixSignals.cpp:39 + // If we have no host platform, be resilient and use default UnixSignals. + if (!host_platform_sp) +s_unix_signals_sp = std::make_shared(); bulbazord wrote: > rupprecht

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

bulbazord created this revision. bulbazord added a reviewer: rupprecht. Herald added a subscriber: krytarowski. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

bulbazord added inline comments. Comment at: lldb/source/Target/UnixSignals.cpp:39 + // If we have no host platform, be resilient and use default UnixSignals. + if (!host_platform_sp) +s_unix_signals_sp = std::make_shared(); rupprecht wrote: > bulbazord

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

bulbazord added inline comments. Comment at: lldb/source/Target/UnixSignals.cpp:39 + // If we have no host platform, be resilient and use default UnixSignals. + if (!host_platform_sp) +s_unix_signals_sp = std::make_shared(); rupprecht wrote: > I think the

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

bulbazord added a comment. In D146263#4214336 , @rupprecht wrote: > This seems to cause a regression on Linux where we no longer get the signal > details. > > Given an intentionally-crashy test binary, such as: > > void crash() { > // Allocate

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

bulbazord added inline comments. Comment at: lldb/source/Commands/CommandObjectRegister.cpp:229 +if (!DumpRegister(m_exe_ctx, strm, reg_ctx, reg_info, + /*print_flags=*/true, type_system)) strm.Printf("%-12s = error:

[Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

bulbazord added a comment. In D146553#4212417 , @DavidSpickett wrote: > Is this policy documented anywhere? Perhaps you can update one of the design > pages if it isn't already there. > > Because I am a bit confused about it. Some parts of lldb use

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

bulbazord added a comment. > `lldb -o "script data=lldb.SBData(); data.SetDataFromUInt64Array([2**63])"` Just tried this, didn't crash LLDB but it does give me the OverflowError you mentioned. Either way, this is probably okay? What do you think @mib? Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

This revision was automatically updated to reflect the committed changes. Closed by commit rG5499b026d218: [lldb][CMake] Enforce not linking against plugin libs in core libs (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

bulbazord added a comment. In D146473#4210440 , @bulbazord wrote: >> Can we do something similar for plugins? > > Yep, I'll tackle that in a follow-up. For those following along at home: D146553 Repository: rG LLVM

[Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

bulbazord created this revision. bulbazord added a reviewer: JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Non-plugin lldb libraries should generally not be linking against lldb plugin

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

This revision was automatically updated to reflect the committed changes. Closed by commit rG2356bf27f722: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

bulbazord added a comment. > Can we do something similar for plugins? Yep, I'll tackle that in a follow-up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146473/new/ https://reviews.llvm.org/D146473

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

bulbazord added a subscriber: aprantl. bulbazord added a comment. In D145580#4209621 , @DavidSpickett wrote: > On the subject of not using `TypeSystemClang`, looking around it seems like > `TypeSystem` is purely used to look up basic types, never to

[Lldb-commits] [PATCH] D146541: [lldb][expr] Propagate ClangDynamicCheckerFunctions::Install() errors to caller

bulbazord accepted this revision. bulbazord added a comment. Thanks for improving the error message here! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146541/new/ https://reviews.llvm.org/D146541 ___

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

bulbazord added a comment. Note that this won't stop people from performing `#include` with non-Utility files, but this marks the intent that Utility is not supposed to be using anything else in lldb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

bulbazord created this revision. bulbazord added a reviewer: JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldbUtility is not supposed to depend on anything else in lldb. Let's enforce

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rGee232506b870: [lldb] Move UnixSignals creation into Platform plugins (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D146263?vs=505934=506757#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

bulbazord added a comment. I'm supportive of this idea but I would like to find a way to do it without introducing dependencies on plugins in non-plugin code if possible. Comment at: lldb/include/lldb/Core/DumpRegisterValue.h:12 +#include

[Lldb-commits] [PATCH] D146335: [lldb] Introduce CMake variable LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS

This revision was automatically updated to reflect the committed changes. Closed by commit rGc47da7f10946: [lldb] Introduce CMake variable LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D146335: [lldb] Introduce CMake variable LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, labath. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The goal of this patch is to add the ability for the CMake

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

This revision was automatically updated to reflect the committed changes. Closed by commit rGf341d7a4091a: [lldb] Make MemoryCache::Read more resilient (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145624/new/

[Lldb-commits] [PATCH] D108335: [lldb] Move UnixSignals subclasses to lldbTarget

bulbazord abandoned this revision. bulbazord added a comment. This is made defunct by https://reviews.llvm.org/D146263 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108335/new/ https://reviews.llvm.org/D108335

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, labath, clayborg. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The high

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

bulbazord added inline comments. Comment at: lldb/test/Shell/helper/toolchain.py:46 +if config.objc_gnustep_dir: + build_script_args.append('--objc-gnustep-dir="{0}"'.format(config.objc_gnustep_dir)) sgraenitz wrote: > bulbazord wrote: > > Why does

[Lldb-commits] [PATCH] D146152: Add __lldb_init_module_with_target for use when sourcing modules for a target

bulbazord added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:1031-1048 + // First call the target initializer: + if (target) { +python_function_name_string += ".__lldb_init_module_with_target"; +python_function_name =

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

bulbazord added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1973-1977 +HostThread ::SetIOHandlerThread(HostThread _thread) { + HostThread _host = m_io_handler_thread; + m_io_handler_thread = new_thread; + return old_host; +} JDevlieghere wrote:

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

bulbazord added inline comments. Comment at: lldb/test/Shell/helper/build.py:254 +if args.objc_gnustep: +assert args.objc_gnustep_dir, "GNUstep libobjc2 runtime for Linux and Windows" +self.objc_gnustep_inc = os.path.join(args.objc_gnustep_dir,

[Lldb-commits] [PATCH] D145450: [lldb] Respect empty arguments in target.run-args

bulbazord added inline comments. Comment at: lldb/source/Host/common/ProcessLaunchInfo.cpp:324-325 std::string safe_arg = Args::GetShellSafeArgument(m_shell, argv[i]); + if (safe_arg.empty()) +safe_arg = "\"\""; // Add a space to

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

bulbazord added a comment. No problem from me. Jonas? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145295/new/ https://reviews.llvm.org/D145295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord updated this revision to Diff 504873. bulbazord added a comment. Address small nits from Greg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145624/new/ https://reviews.llvm.org/D145624 Files: lldb/include/lldb/Target/Memory.h

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord added inline comments. Comment at: lldb/source/Target/Memory.cpp:245-246 +if (m_invalid_ranges.FindEntryThatContains(cache_line_base_addr)) { + error.SetErrorStringWithFormat("memory read failed for 0x%" PRIx64, +

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

bulbazord added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:166-167 -Returns: -lldb.SBError: An `lldb.SBError` with error code 0. -""" -return lldb.SBError() - -@abstractmethod -def

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord marked 11 inline comments as done. bulbazord added inline comments. Comment at: lldb/source/Target/Memory.cpp:255-256 - // We need to read from the process + if (process_bytes_read < cache_line_byte_size) +

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord updated this revision to Diff 503942. bulbazord added a comment. - Addressed reviewer feedback - Simplified the case where we use L2 cache lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145624/new/ https://reviews.llvm.org/D145624

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord added a comment. In D145624#4182424 , @clayborg wrote: > I would suggest checking the google stadia patch for the L1 > and L2 caches: > >

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord added inline comments. Comment at: lldb/source/Target/Memory.cpp:133-141 // Check the L1 cache for a range that contain the entire memory read. If we - // find a range in the L1 cache that does, we use it. Else we fall back to - // reading memory in

[Lldb-commits] [PATCH] D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated

bulbazord added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:816-819 + ObjectFileMachO *ondisk_objfile_macho = + llvm::dyn_cast_or_null( + m_module_sp ? m_module_sp->GetObjectFile() :

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, clayborg, jasonmolenda, jingham, labath. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. MemoryCache::Read is not

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

bulbazord added a comment. Small nits Comment at: lldb/include/lldb/API/SBCommandInterpreter.h:251-253 + /// Interrupts the command currently executing in the RunCommandInterpreter + /// thread. + bool InterruptCommand(); Some info on the return value would

[Lldb-commits] [PATCH] D145450: [lldb] Respect empty arguments in target.run-args

This revision was automatically updated to reflect the committed changes. Closed by commit rGca8faf8f4659: [lldb] Respect empty arguments in target.run-args (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145450/new/

[Lldb-commits] [PATCH] D145450: [lldb] Respect empty arguments in target.run-args

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, clayborg, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently empty arguments are not

[Lldb-commits] [PATCH] D145414: [lldb/Utility] Fix layering violation caused by ScriptedMetadata

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/include/lldb/Utility/ScriptedMetadata.h:33-38 - ScriptedMetadata(const OptionGroupPythonClassWithDict _group) { -auto opt_group =

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for adding those tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144224/new/ https://reviews.llvm.org/D144224 ___

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

bulbazord added a comment. I still think it's a little weird that you can create LaunchInfo or AttachInfo, call SetScriptedProcessDictionary, and still have the ScriptedMetadata be "invalid", but I suppose it makes no sense if there is no class name anyway. Just a few small things. Everything

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

bulbazord added inline comments. Comment at: lldb/source/API/SBWatchpoint.cpp:319 + } + return false; +} delcypher wrote: > @bulbazord What I don't like about my implementation here is that the user > can't tell the difference between > > 1. there's no

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

bulbazord added a comment. Seems like you've already got feedback about breaking ABI. Small nit: Comment at: lldb/bindings/interface/SBWatchpointDocstrings.i:30-31 +%feature("docstring", " +Returns true if the watchpoint is a variable watchpoint. Otherwise the +

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

bulbazord accepted this revision. bulbazord added a comment. LGTM thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144688/new/ https://reviews.llvm.org/D144688 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

bulbazord added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1316 +auto_generated_function.AppendString("def __user_code():"); +for (int i = 0; i < num_lines; ++i) { + sstr.Clear();

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behavior

bulbazord added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1314-1324 +if (line.startswith("return ")) { + llvm::StringRef return_val = + line.substr(llvm::StringRef("return ").size()); +

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behavior

bulbazord requested changes to this revision. bulbazord added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1314-1324 +if (line.startswith("return ")) { +

[Lldb-commits] [PATCH] D144688: [lldb] Fix watchpoint command function stopping behavior

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I'm alright with this patch since it at least makes watchpoint commands consistent with breakpoint commands (w.r.t the `-F` flag). Comment at:

[Lldb-commits] [PATCH] D144311: [debugserver] Add one additional sleep before attaching after waiting

This revision was automatically updated to reflect the committed changes. Closed by commit rG97b579d31404: [debugserver] Add one additional sleep before attaching after waiting (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144528: [lldb] Warn when Mach-O files have overlapping segments

This revision was automatically updated to reflect the committed changes. Closed by commit rGcee05eed2f47: [lldb] Warn when Mach-O files have overlapping segments (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144528/new/

[Lldb-commits] [PATCH] D144528: [lldb] Warn when Mach-O files have overlapping segments

bulbazord added a comment. In D144528#4145593 , @jasonmolenda wrote: > I'm OK with giving this a try. SectionLoadList::SetSectionLoadAddress > specifically notes that there are cases were sections overlap in the virtual > address space. All of the

[Lldb-commits] [PATCH] D144528: [lldb] Warn when Mach-O files have overlapping segments

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I recently came across a binary that for some reason had

[Lldb-commits] [PATCH] D144311: [debugserver] Add one additional sleep before attaching after waiting

bulbazord created this revision. bulbazord added a reviewer: jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It's possible for debugserver to attach to a process during the handoff

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

bulbazord added a comment. I'm not sure how much this matters but the fact that `ScriptedMetadata::IsValid` (and the bool operator overload) relies on the class name being empty is a little strange to me. I feel like you could get yourself into a strange situation where you set the

[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f88c07cf820: [lldb] StructuredData should not truncate uint64_t values (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

bulbazord updated this revision to Diff 498479. bulbazord added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144238/new/ https://reviews.llvm.org/D144238 Files: lldb/source/Utility/StructuredData.cpp

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144237/new/ https://reviews.llvm.org/D144237 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

bulbazord added a comment. In D144238#4133940 , @mib wrote: > Should we also add a negative integer to the dictionary to make sure this > didn't cause a regression ? Negative integers are not correctly handled currently. I plan on fixing that in a

[Lldb-commits] [PATCH] D144228: [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rGffe982f96bff: [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

bulbazord created this revision. bulbazord added a reviewer: mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In json::Value, getAsInteger returns an optional and getAsNumber returns an optional.

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

bulbazord added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:310-311 +size_t ScriptedProcess::DoWriteMemory(lldb::addr_t vm_addr, const void *buf, + size_t size, Status ) { + lldb::DataExtractorSP

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method

bulbazord added a comment. LGTM. @jingham what do you think? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144224/new/ https://reviews.llvm.org/D144224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

bulbazord added a comment. Just a personal preference but making those lambdas into static functions may make it easier to read. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141702/new/ https://reviews.llvm.org/D141702 ___ lldb-commits

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteCStringToMemory method

bulbazord added a reviewer: jingham. bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. I'm alright with the implementation, but I think you should add some documentation here. Also, what do you think of the name

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4133440 , @bulbazord wrote: > I'll upload a patch to handle that. D144228 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/

[Lldb-commits] [PATCH] D144228: [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor

bulbazord created this revision. bulbazord added reviewers: saugustine, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Given the line launch_info = lldb.SBLaunchInfo(None) We see different

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4133356 , @saugustine wrote: > I don't think this necessarily matters or is a reason to revert, but we are > seeing issues with this patch and swig 3.0.2, that disappear with swig 4.0. > > The docs claim that

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG662548c82683: [lldb] Replace SB swig interfaces with API headers (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/

[Lldb-commits] [PATCH] D144142: [debugserver] Initialize logging earlier in the startup sequence

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcf18e4757b2: [debugserver] Initialize logging earlier in the startup sequence (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144142: [debugserver] Initialize logging earlier in the startup sequence

bulbazord updated this revision to Diff 497818. bulbazord added a comment. Moving second use of DNBSetLogMask outside of the log file block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144142/new/ https://reviews.llvm.org/D144142 Files:

[Lldb-commits] [PATCH] D144142: [debugserver] Initialize logging earlier in the startup sequence

bulbazord added inline comments. Comment at: lldb/tools/debugserver/source/debugserver.cpp:1342 DNBLogSetLogMask(log_flags); } jasonmolenda wrote: > Should this be moved out of this `log_file != NULL` block so that the logging > flags are set based on

[Lldb-commits] [PATCH] D144142: [debugserver] Initialize logging earlier in the startup sequence

bulbazord created this revision. bulbazord added a reviewer: jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Prior to setting up logging, we have uses of RNBLogSTDERR and RNBLogSTDOUT.

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord updated this revision to Diff 497117. bulbazord added a comment. Rebasing against top of tree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/ https://reviews.llvm.org/D142926 Files: lldb/bindings/CMakeLists.txt

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4123492 , @labath wrote: > Well... right now, there isn't anything else to do there. > > Anyway, I don't think this is particularly important. I don't know even if > the distros would like to do this or whether to

[Lldb-commits] [PATCH] D143792: [lldb] Fix image lookup crash

This revision was automatically updated to reflect the committed changes. Closed by commit rGf841c4af5f5e: [lldb] Fix image lookup crash (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143792/new/

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. Does anybody have any further concerns or objections? I'd like to get this change in early next week if possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/ https://reviews.llvm.org/D142926

[Lldb-commits] [PATCH] D143792: [lldb] Fix image lookup crash

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb may crash when performing `image lookup --verbose --address

<    2   3   4   5   6   7   8   9   10   11   >