https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/114576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -48,7 +48,10 @@ PathMappingList::PathMappingList(const PathMappingList &rhs)
const PathMappingList &PathMappingList::operator=(const PathMappingList &rhs) {
if (this != &rhs) {
-std::scoped_lock
locks(m_mutex, rhs.m_mutex);
+std::scoped_lock pairs_locks(m_pairs_m
https://github.com/bulbazord commented:
It took me some time to read this and think about the implications, but I think
this is generally okay. I left 1 comment about the order of lock acquisition
for `operator=`.
The only way I can see this going wrong is if a callback can mutate the list in
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/114576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/114469
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/114469
None
>From 9a43932849dba04c11cbed2abcac41a3e64b4e06 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Thu, 31 Oct 2024 14:40:59 -0700
Subject: [PATCH] [lldb] Disable automatically opening editor for
TestSes
https://github.com/bulbazord approved this pull request.
This looks good to me. Probably want somebody more involved in windows to sign
off though.
This might not be the right setting to ask this, but is there a plan to use one
of the PDB parsers over the other? Would it make sense to add this
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/114286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,34 @@
+set(LLVM_LINK_COMPONENTS
+ Support
+ )
+
+add_llvm_fuzzer(lldb-dwarf-expression-fuzzer
+ EXCLUDE_FROM_ALL
+ lldb-dwarf-expression-fuzzer.cpp
+ )
+
+include_directories(${LLDB_SOURCE_ROOT})
bulbazord wrote:
suggestion: Use `target_include_di
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/114136
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self):
@expectedFlakeyLinux(bugnumber="llvm.org/pr26437")
@skipIfDarwinEmbedded # debugserver can't create/write files on the device
def test_stdout_stderr_redirection_to_existing_files(self):
-"""Exerc
@@ -6,6 +6,8 @@
//
//===--===//
+#include
bulbazord wrote:
CI is good enough for me here. I've approved the PR.
https://github.com/llvm/llvm-project/pull/112657
___
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/112657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/113412
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6,6 +6,8 @@
//
//===--===//
+#include
bulbazord wrote:
Will this work on windows?
https://github.com/llvm/llvm-project/pull/112657
___
lldb
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/112938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,201 @@
+JSON Symbol File Format
+===
+
+The JSON symbol file format encodes symbols in a text based, human readable
+format. JSON symbol files can be used to symbolicate programs that miss symbol
+information, for example because they have been strip
@@ -0,0 +1,201 @@
+JSON Symbol File Format
+===
+
+The JSON symbol file format encodes symbols in a text based, human readable
+format. JSON symbol files can be used to symbolicate programs that miss symbol
+information, for example because they have been strip
@@ -0,0 +1,201 @@
+JSON Symbol File Format
+===
+
+The JSON symbol file format encodes symbols in a text based, human readable
+format. JSON symbol files can be used to symbolicate programs that miss symbol
bulbazord wrote:
Suggestion: `miss`
@@ -13,6 +13,13 @@
# the building of the a.out executable program. For example,
# DYLIB_ONLY := YES
#
+# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME
+# controls the name of the produced dylib. E.g., if set to "foo",
+# the generated dylib will be called "f
https://github.com/bulbazord approved this pull request.
🥳
https://github.com/llvm/llvm-project/pull/112276
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions {
/// Set the language using a pair of language code and version as
/// defined by the DWARF 6 specification.
/// WARNING: These codes may change until DWARF 6 is finalized.
- void SetLanguage(lldb::SBSourceLanguageNam
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions {
/// Set the language using a pair of language code and version as
/// defined by the DWARF 6 specification.
/// WARNING: These codes may change until DWARF 6 is finalized.
- void SetLanguage(lldb::SBSourceLanguageNam
@@ -136,6 +136,8 @@ class LLDB_API SBWatchpoint;
class LLDB_API SBWatchpointOptions;
class LLDB_API SBUnixSignals;
+typedef SourceLanguageName SBSourceLanguageName;
bulbazord wrote:
I'm not sure a typedef is enough here. It ends up being little more than
syn
@@ -123,30 +123,79 @@ void CommandReturnObject::SetError(llvm::Error error) {
}
}
-llvm::StringRef
-CommandReturnObject::GetInlineDiagnosticString(unsigned indent) {
- RenderDiagnosticDetails(m_diag_stream, indent, true, m_diagnostics);
+std::string CommandReturnObject::Get
@@ -3187,11 +3185,12 @@ void
CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler,
io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) ||
io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) {
// Display any inline diagnostics first.
-
@@ -2636,20 +2636,18 @@ void CommandInterpreter::HandleCommands(const
StringList &commands,
}
if (!success || !tmp_result.Succeeded()) {
- llvm::StringRef error_msg = tmp_result.GetErrorString();
+ std::string error_msg = tmp_result.GetErrorString();
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions {
/// Set the language using a pair of language code and version as
/// defined by the DWARF 6 specification.
/// WARNING: These codes may change until DWARF 6 is finalized.
- void SetLanguage(lldb::SBSourceLanguageNam
https://github.com/bulbazord requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/111929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6,27 +6,30 @@
UNALIGNED_INSTANCE_PATTERN_HEAP = ALIGNED_INSTANCE_PATTERN_HEAP[1:]
-def GetAlignedRange(test_base):
+def GetAlignedRange(test_base, shrink=False):
frame = test_base.thread.GetSelectedFrame()
ex = frame.EvaluateExpression("aligned_string_ptr")
bulbazord wrote:
> I agree with that, but the argument here was going the other way.
> lldb-enumerations.h are a base set of enumerations that anybody using LLDB,
> either lldb_private or the SB API's are free to use. But the SB API's are
> purely wrappers around lldb_private API's, and so sho
bulbazord wrote:
My mental model is that everything in `lldb-enumerations.h` should be public
and all the private enumerations should go in `lldb-private-enumerations.h`. In
practice I think there are tons of things in `lldb-enumerations.h` that should
not be public at all, but I'm not sure wh
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/111747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
+1 to what Jonas said. Making `dotest.py` more explicit makes reproducing test
behavior more reliable. :)
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/111326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
Love to see this kind of work done.
FWIW I worked on improving the performance of `ObjectFileMachO::ParseSymtab` in
https://github.com/llvm/llvm-project/pull/106791.
That change to reverted and I haven't had the time to figure out what happened
yet though...
https://github.com
@@ -201,8 +201,8 @@ class SymbolContext {
bool GetAddressRange(uint32_t scope, uint32_t range_idx,
bool use_inline_block_range, AddressRange &range) const;
- bool GetAddressRangeFromHereToEndLine(uint32_t end_line, AddressRange &range,
-
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM, a few minor suggestions but nothing of great importance. Thanks for
writing this up!
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/110150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/109851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM. One thing to note is that llvm's ValueType struct has an additional
uint64_t element for a section index. I wonder if LLDB can make use of that
element for something useful after some additional refactors?
https://github.com/llvm/l
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/109063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -186,36 +210,49 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
if (!checker_or_err)
return checker_or_err.takeError();
+llvm::Error abstract_method_errors = llvm::Error::success();
for (const auto &method_checker : *checker_or_err)
@@ -78,8 +100,11 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
using namespace python;
using Locker = ScriptInterpreterPythonImpl::Locker;
-auto create_error = [](std::string message) {
- return llvm::createStringError(llvm::inconverti
bulbazord wrote:
> Do we have a sense of whether it's just a broken test, or if the PR broke
> some functionality? We tested the change on some internal scenarios and it
> showed good improvement, so we'd like to cherry-pick this patch (or a new
> patch).
I'm not sure yet, I haven't had time
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/106791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/108498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/106791
>From ae9d2e4fdfe9eb15f37c2b27da1b1f239d018391 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 30 Aug 2024 12:49:33 -0700
Subject: [PATCH] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/107325
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/107325
Without this, LLDB asserts when enabling the expression logs.
>From 622c5b636d1a505f1ea3f68540db28061d8606ce Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Wed, 4 Sep 2024 16:02:20 -0700
Subject: [PATCH]
bulbazord wrote:
> OK, I see in `Symtab::InitAddressIndexes` we go through the symbol table and
> calculate the sizes of any entries that don't have a size based on the next
> symbol, or the end of the section.
>
> A little further in ObjectFileMachO::ParseSymtab when we add any
> LC_FUNCTION
@@ -97,7 +97,7 @@ class LLDB_API SBError {
friend class lldb_private::ScriptInterpreter;
friend class lldb_private::python::SWIGBridge;
- SBError(const lldb_private::Status &error);
+ SBError(lldb_private::Status &&error);
bulbazord wrote:
I have no con
@@ -22,13 +22,14 @@ class ValueListImpl {
public:
ValueListImpl() = default;
- ValueListImpl(const ValueListImpl &rhs) = default;
+ ValueListImpl(const ValueListImpl &rhs)
bulbazord wrote:
Actually you're right here, ValueListImpl is an implementation det
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/106791
Summary:
This improves the performance of ObjectFileMacho::ParseSymtab by removing eager
and expensive work in favor of doing it later in a less-expensive fashion.
Experiment:
My goal was to understand LLDB's
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/106773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -22,13 +22,14 @@ class ValueListImpl {
public:
ValueListImpl() = default;
- ValueListImpl(const ValueListImpl &rhs) = default;
+ ValueListImpl(const ValueListImpl &rhs)
bulbazord wrote:
This may be an ABI break if compilers generate different code or s
@@ -37,49 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGeneric.
+class GenericCateg
@@ -107,7 +107,7 @@ class LLDB_API SBError {
lldb_private::Status &ref();
- void SetError(const lldb_private::Status &lldb_error);
+ void SetError(lldb_private::Status &&lldb_error);
bulbazord wrote:
This also breaks ABI.
https://github.com/llvm/llvm-pr
@@ -97,7 +97,7 @@ class LLDB_API SBError {
friend class lldb_private::ScriptInterpreter;
friend class lldb_private::python::SWIGBridge;
- SBError(const lldb_private::Status &error);
+ SBError(lldb_private::Status &&error);
bulbazord wrote:
This breaks A
@@ -96,7 +96,7 @@ class LLDB_API SBValueList {
std::unique_ptr m_opaque_up;
- void SetError(const lldb_private::Status &status);
+ void SetError(lldb_private::Status &&status);
bulbazord wrote:
This also breaks ABI.
https://github.com/llvm/llvm-project/
@@ -159,22 +158,31 @@ class SourceManager {
size_t DisplayMoreWithLineNumbers(Stream *s, uint32_t count, bool reverse,
const SymbolContextList *bp_locs =
nullptr);
- bool SetDefaultFileAndLine(const FileSpec &file_spec, uint32_t line);
+
https://github.com/bulbazord approved this pull request.
LGTM overall, I looked at the previous PR to get some context.
https://github.com/llvm/llvm-project/pull/106740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
@@ -769,20 +769,26 @@ class CommandObjectBreakpointSet : public
CommandObjectParsed {
private:
bool GetDefaultFile(Target &target, FileSpec &file,
CommandReturnObject &result) {
-uint32_t default_line;
// First use the Source Manager's default
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/106740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
I haven't reviewed every single file but the ones I did look at look
straightforward and correct. The changes to `Status` itself I feel positively
about. I agree with the direction that this takes `Status` in.
https://github.com/llvm/llv
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/106034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/106157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/106157
Without calling `dyld_process_dispose`, LLDB will leak the memory associated
with the `dyld_process_t`.
rdar://134738265
>From 62bd1e90ea84cfb7bd6d18529918be544d036221 Mon Sep 17 00:00:00 2001
From: Alex Lan
bulbazord wrote:
I don't know much about the documentation but I added the two people who touch
it more frequently than anyone else.
https://github.com/llvm/llvm-project/pull/104847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/105449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
This one looks very straightforward. I haven't been involved in any of the
earlier discussions about AIX support so please wait for more involved folks to
also take a look.
https://github.com/llvm/llvm-project/pull/105523
___
@@ -80,6 +80,17 @@ class LLDB_API SBSaveCoreOptions {
/// \return True if the thread was removed, false if it was not in the list.
bool RemoveThread(lldb::SBThread thread);
+ /// Add a memory region to save in the core file.
+ ///
+ /// \param region The memory region t
@@ -7,6 +7,9 @@
//===--===//
#include "lldb/API/SBSaveCoreOptions.h"
+#include "lldb/API/SBError.h"
+#include "lldb/API/SBFileSpec.h"
bulbazord wrote:
SBFileSpec is unused right? Shouldn't n
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/105442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -90,6 +93,16 @@ bool SBSaveCoreOptions::RemoveThread(lldb::SBThread thread) {
return m_opaque_up->RemoveThread(thread.GetSP());
}
+
+lldb::SBError SBSaveCoreOptions::AddMemoryRegionToSave(const
SBMemoryRegionInfo ®ion) {
+ LLDB_INSTRUMENT_VA(this, region);
+ // Current
https://github.com/bulbazord commented:
I didn't look at all the implementation details, but the SBAPI stuff looks
fine. I don't see anything that will cause trouble down the line. Thanks!
https://github.com/llvm/llvm-project/pull/105442
___
lldb-comm
@@ -1316,6 +1316,7 @@ std::string GDBRemoteCommunication::ExpandRLE(std::string
packet) {
} else {
decoded.push_back(*c);
}
+c++;
bulbazord wrote:
Having the `c++` here is equivalent to having it in the "increment" portion of
the for loop c
@@ -1316,6 +1316,7 @@ std::string GDBRemoteCommunication::ExpandRLE(std::string
packet) {
} else {
bulbazord wrote:
I can't comment on it for some reason, but above this else is an `else if (*c
== 0x7d)`. That block also does `*++c`, which will also go out
https://github.com/bulbazord requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/94844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -278,6 +278,29 @@ class CommandObjectFrameSelect : public
CommandObjectParsed {
if (frame_idx == UINT32_MAX)
frame_idx = 0;
+ // If moving up/down by one, skip over hidden frames.
+ if (*m_options.relative_frame_offset == 1 ||
+ *m_options.
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
@@ -17,6 +17,7 @@
#include "lldb/lldb-private-forward.h"
#include "lldb/lldb-public.h"
+#include <_types/_uint16_t.h>
bulbazord wrote:
Is this header portable? If you want access to `uint16_t` I'd recommend
including `cinttypes` instead.
https://github.com/
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/104896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/102590
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Seems ok to me. I don't see what we gain from having a map from Phabricator
name to contributor information for just maintainers, many changes are were
made by people not on this list.
https://github.com/llvm/llvm-project/pull/102590
___
https://github.com/bulbazord approved this pull request.
The LLDB changes look good to me. I can't speak for the clang portions but fwiw
I think they look ok too.
https://github.com/llvm/llvm-project/pull/103388
___
lldb-commits mailing list
lldb-comm
@@ -0,0 +1,77 @@
+//===-- RealpathPrefixes.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/bulbazord commented:
Interesting. I left a few minor comments, I think Jim and Greg got a lot of the
edge cases and bulky feedback out of the way already. :)
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,77 @@
+//===-- RealpathPrefixes.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -144,16 +150,22 @@ static void ParseOSVersion(llvm::VersionTuple &version,
NSString *Key) {
#endif
} else {
// Find the bin path relative to the lib path where the cmake-based
-// OS X .dylib lives. This is not going to work if the bin and lib
-// dir are not
https://github.com/bulbazord approved this pull request.
lgtm, one small suggestion
https://github.com/llvm/llvm-project/pull/103458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/103458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 1051 matches
Mail list logo
