[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

2023-06-28 Thread Alison Zhang via Phabricator via lldb-commits
azhan92 updated this revision to Diff 535389. azhan92 added a comment. Herald added subscribers: JDevlieghere, jdoerfert. Remove unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files:

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

2023-06-29 Thread Alison Zhang via Phabricator via lldb-commits
azhan92 marked 3 inline comments as done. azhan92 added a comment. @hubert.reinterpretcast I have the call stack on AIX: #0 0x0904304c in read () from /usr/lib/libc.a(shr_64.o) #1 0x000100d5f044 in llvm::sys::RetryAfterSignal(int const&, long ( const&)(int, void*, unsigned long

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

2023-08-01 Thread Alison Zhang via Phabricator via lldb-commits
azhan92 updated this revision to Diff 546051. azhan92 added a comment. Herald added a reviewer: jhenderson. Check if directory before opening as a file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Fil

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

2023-08-01 Thread Alison Zhang via Phabricator via lldb-commits
azhan92 updated this revision to Diff 546053. azhan92 added a comment. Check if directory before opening file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files: llvm/lib/Support/Unix/Path.inc Ind

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

2023-08-01 Thread Alison Zhang via Phabricator via lldb-commits
azhan92 updated this revision to Diff 546064. azhan92 added a comment. Check if file is directory before opening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files: clang/lib/AST/Interp/Floating.h

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

2023-08-15 Thread Alison Zhang via Phabricator via lldb-commits
azhan92 updated this revision to Diff 550402. azhan92 added a comment. Address TOCTOU condition (will add updated test later). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files: llvm/lib/Support/Uni

[Lldb-commits] [PATCH] D151567: [Support] Report EISDIR when opening a directory

2023-08-22 Thread Alison Zhang via Phabricator via lldb-commits
azhan92 updated this revision to Diff 552353. azhan92 retitled this revision from "[Support] Report EISDIR when opening a directory " to "[Support] Report EISDIR when opening a directory". azhan92 added a comment. Add unit test to verify patch. Repository: rG LLVM Github Monorepo CHANGES SIN