[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

2022-12-06 Thread Amara Emerson via Phabricator via lldb-commits
aemerson added a comment. I just reverted this in 6e6be5f9504d because it seems to have broken macOS builds: llvm/lib/Support/Compression.cpp:24:10: fatal error: 'zstd.h' file not found #include ^~~~

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

2020-03-06 Thread Amara Emerson via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc1a97e992da6: Revert Revert [GlobalISel][Localizer] Enable intra-block localization of… (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D7?vs=248567=248898#toc

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

2020-03-05 Thread Amara Emerson via Phabricator via lldb-commits
aemerson updated this revision to Diff 248567. aemerson added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. @omjavaid can you look over the lldb changes? I don't have the hardware to be able to actually run this test but I've tried to relax the checks.

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

2018-05-18 Thread Amara Emerson via Phabricator via lldb-commits
aemerson added a comment. In https://reviews.llvm.org/D46889#1104823, @aprantl wrote: > Thanks for jumping on this Amara — I just wanted to point out that we > ususally don't revert lldb changes that only break the lldb-xcode bot if they > pass on the lldb-cmake bot at the same time. When this

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

2018-05-18 Thread Amara Emerson via Phabricator via lldb-commits
aemerson reopened this revision. aemerson added a comment. This revision is now accepted and ready to land. Hi Pavel, I reverted this in r332730 due to the bot breaking. Please have a look and commit again when ready. Thanks, Amara Repository: rL LLVM https://reviews.llvm.org/D46889

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

2018-05-18 Thread Amara Emerson via Phabricator via lldb-commits
aemerson added a comment. This caused a failure in green dragon: http://green.lab.llvm.org/green/job/lldb-xcode/6644 Can you please fix or revert this change, thanks. Repository: rL LLVM https://reviews.llvm.org/D46889 ___ lldb-commits mailing