[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK added inline comments. Comment at: lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py:17 + +@skipUnlessArch("x86_64") +@skipUnlessPlatform(["linux"]) clayborg wrote: > Do we only support x86_64 right now? If we

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK updated this revision to Diff 369722. Aj0SK added a comment. Fix not-correctly applied change from review regarding memory reading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108233/new/ https://reviews.llvm.org/D108233 Files:

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK updated this revision to Diff 369686. Aj0SK added a comment. Fixes arm and aarch64 build run fails. Adding aarch64 to the matching in SystemInfo stream and activating test only on x86_64 as this is the only platform where also thread info etc. is being saved. Repository: rG LLVM

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK updated this revision to Diff 369410. Aj0SK marked 2 inline comments as done and an inline comment as not done. Aj0SK added a comment. Add error for dump core style other than stack and change procedure getting the memory list stream. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK marked 8 inline comments as done and an inline comment as not done. Aj0SK added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:519 +lldb_private::Status +MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP _sp) { + Status

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:549 +bool is_interesting = false; +for (size_t interesting_address : interesting_addresses) + if (interesting_address >= addr && interesting_address < addr +

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:519 +lldb_private::Status +MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP _sp) { + Status error; Aj0SK wrote: > clayborg wrote: > > This should

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:225 +m.SizeOfImage = static_cast( +mod->GetObjectFile()->GetByteSize()); +m.Checksum = static_cast(0); clayborg wrote: > I am not sure if the

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK updated this revision to Diff 368765. Aj0SK added a comment. Change ObjectFileMinidump plugin to inherit from PluginInterface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108233/new/ https://reviews.llvm.org/D108233 Files:

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK marked 9 inline comments as done. Aj0SK added a comment. Thanks for the review! Some requested changes need to be clarified for me. I have a problem mainly with successfully registering the Plugin when it inherits only from PluginInterface. Comment at:

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK updated this revision to Diff 368110. Aj0SK added a comment. Herald added a subscriber: dang. Move minidump save-core functionality to separate plugin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108233/new/ https://reviews.llvm.org/D108233

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK created this revision. Aj0SK added a reviewer: clayborg. Herald added subscribers: pengfei, mgorny, emaste. Aj0SK requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. This change adds save-core functionality into the ObjectFileELF