[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

aadsm added a comment. Would it be possible to have a test for this? We would have probably found this, if we had a test at the time I rewrote this logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134842/new/ https://reviews.llvm.org/D134842

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f21d488bd79: [lldb-vscode] Emit the breakpoint changed event on location resolved (authored by aadsm). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added a comment. oh no, I picked the wrong commit to land :(. I think this is fine because I already addressed the comments, but if there's still something I should work on here, I'll put another diff up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa83a825e9902: Make sure the interpreter module was loaded before m

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm updated this revision to Diff 325221. aadsm added a comment. Checks the module is not loaded right after we attach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96637/new/ https://reviews.llvm.org/D96637 Files: lldb/packages/Python/lldbsui

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added inline comments. Comment at: lldb/test/API/functionalities/module_load_attach/TestModuleLoadAttach.py:32-33 +# Continue so that dlopen is called. +breakpoint = self.target().BreakpointCreateBySourceRegex( +"// break after dlopen", lldb.SBF

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added inline comments. Comment at: lldb/test/API/functionalities/module_load_attach/TestModuleLoadAttach.py:28 +def test_x(self): +process = self.build_launch_and_attach() +thread = process.GetSelectedThread() clayborg wrote: > Is this

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 325118. aadsm added a comment. Removed unnecessary comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/test/API/tools/lldb-vscode/breakpoint-events/Make

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 325117. aadsm added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/test/API/tools/lldb-vscode/breakpoint-events/Makefile lldb/test/A

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added a comment. > I don't think this does what you think it does. The $() doesn't give you the > process id of anything -- it substitutes a string by the result of running > that string as a shell command. So, the PID variable would get the (entire) > stdout of %s.out I'm confused here,

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm updated this revision to Diff 324866. aadsm added a comment. Add api test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96637/new/ https://reviews.llvm.org/D96637 Files: lldb/packages/Python/lldbsuite/test/decorators.py lldb/source/Plugi

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 324865. aadsm added a comment. revert last amend: added the test to the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/tools/lldb-vscode/lldb-vs

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 324864. aadsm added a comment. Add api test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/packages/Python/lldbsuite/test/decorators.py lldb/test/API/fun

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added a comment. > We should have a test for this. how do you recommend doing this? I spent a couple of hours on this but got no where. From what I understood we should prefer lit tests, so I was thinking of creating a binary that dlopens a module. However, I wasn't able to create a bina

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm created this revision. aadsm added reviewers: clayborg, labath, wallace, kusmour. aadsm requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. VSCode was not being informed whenever a location had been resolved (after being initated as non-

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm created this revision. aadsm added reviewers: mgorny, labath, emaste. aadsm requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This issue was introduced in https://reviews.llvm.org/D92187. The guard I'm changing were is supposed to act w

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

aadsm added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1558 + if (!launchCommands.empty()) { +// if "launchCommands" are provided, then they are expected to make the +// launch happen for launch requests and they replace the normal logic that ---

[Lldb-commits] [PATCH] D95008: Revert "Revert "Ignores functions that have a range starting outside of a code section""

aadsm created this revision. aadsm added a reviewer: stella.stamenova. Herald added a reviewer: shafik. aadsm requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. This reverts commit a9dcd15f50dc27ca3

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm added a comment. When I landed this I got test errors on the windows machine (the same tests pass on the other machine). I tried to repro this on 2 different machines I was able to get access but to no avail. These are the failing tests: http://lab.llvm.org:8011/#/builders/83/builds/644

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added a comment. reverting because I'm not able to repro the fails, so need more time to figure it out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87172/new/ https://reviews.llvm.org/D87172 ___

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG265a38fbc547: Check if debug line sequences are starting after the first code segment (authored by aadsm). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf30bc0168d2: Ignores functions that have a range starting outside of a code section (authored by aadsm). Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm updated this revision to Diff 303746. aadsm added a comment. Merged the 2 run/checks into one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87173/new/ https://reviews.llvm.org/D87173 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTPars

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

aadsm updated this revision to Diff 302180. aadsm added a comment. Herald added a subscriber: JDevlieghere. Herald added a reviewer: JDevlieghere. Use set and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70885/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm updated this revision to Diff 302178. aadsm added a comment. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. Also set the symbol as external when it is weak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87868/new

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:503-505 + if (section_list) { +InitializeFirstCodeAddress(*section_list); + } labath wrote: > clayborg wrote: > > remove braces > or even fold the declaration

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm updated this revision to Diff 302150. aadsm added a comment. Used -s to feed commands and disabled errors when interpreting them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87173/new/ https://reviews.llvm.org/D87173 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm updated this revision to Diff 301503. aadsm added a comment. Rewrote the test in lit. I had to do it in an non standard way. It seems that lldb will exit with an error code if you do -b -o of a command that doesn't "work", (e.g.: image lookup finds nothing). Since lit runs this with set -

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm updated this revision to Diff 301450. aadsm added a comment. - Fixed formatting issues - Updated comment on the reason we need to do this - Improved the lit test by also checking how many matches it found Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm updated this revision to Diff 300131. aadsm added a comment. Check all child sections and makes sure the section is an actual code section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87172/new/ https://reviews.llvm.org/D87172 Files: lld

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/line-entries-invalid-addresses.yaml:3 +# RUN: %lldb %t -b -o "image lookup -f main.cpp -l 2 -v" | FileCheck %s +# CHECK: LineEntry: {{.*}}main.cpp:2:{{.*}} + labath wrote: > I think you al

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:506 +for (uint32_t i = 0; i < num_sections; ++i) { + SectionSP section_sp(section_list->GetSectionAtIndex(i)); + const addr_t section_file_address = section_sp->GetFile

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added a comment. Should I still go ahead with this since @labath implemented the memory allocation on lldb-server? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87868/new/ https://reviews.llvm.org/D87868

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm updated this revision to Diff 298906. aadsm added a comment. Addressed all comments: - Moved initialization code to InitializeObject - Moved to lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87172/new/ https://reviews.llvm.org/D87172

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:36 bool lldb_private::InferiorCallMmap(Process *process, addr_t &allocated_addr, addr_t addr, addr_t length, unsigned prot,

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:54 +if (sc_list.GetContextAtIndex(i, sc) && +(sc.symbol->IsExternal() || sc.symbol->IsWeak())) { const uint32_t range_scope = labath wrote: > cla

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:54 +if (sc_list.GetContextAtIndex(i, sc) && +(sc.symbol->IsExternal() || sc.symbol->IsWeak())) { const uint32_t range_scope = clayborg wrote: > W

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm updated this revision to Diff 296220. aadsm added a comment. I explored Greg's suggestion of checking if the functions were external symbols. As suspected the overriden mmap is not external, so we can use this check to avoid calling it! It does look to me that Pavel's suggestion is the wa

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added a comment. > It seems like calling any 'mmap' definition should work. Is the interposed > mmap implementation failing and correctly returning -1, or is it succeeding > and incorrectly returning -1? In either case, it seems like it's worth > digging into why it's failing / returnin

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

aadsm added a comment. > Why would we be doing something (particularly a thing which will be hard to > do in a cross-platform manner, and will very likely border on, or downright > cross into, undefined behavior territory), if we get that from vscode for > free? I'm not sure what you mean with

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:520 std::vector m_lldb_cu_to_dwarf_unit; + lldb::addr_t m_first_code_address = LLDB_INVALID_ADDRESS; }; labath wrote: > clayborg wrote: > > A lengthy comment woul

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm created this revision. aadsm added reviewers: clayborg, jingham, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm requested review of this revision. I found an issue where the expression evaluation doesn't work (for non trivial exprs) when the leak

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm updated this revision to Diff 290113. aadsm added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Check lowest code address instead of checking if the section is code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm updated this revision to Diff 290112. aadsm added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87172/new/ https://reviews.llvm.org/D87172 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/s

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:74 // codes that start at 1, that we get O(1) access. - + const auto byte_order = eByteOrderLittle; clayborg wrote: > remove whitespace only changes please.

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2265-2267 +auto base_address = func_range.GetBaseAddress(); +if (base_address.IsSectionOffset() && +base_address.GetSection()->GetType() == eSectionTypeCode) { -

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/Inputs/test-invalid-offsets.yaml:520 + Data:0 +... clayborg wrote: > aadsm wrote: > > I generated this yaml with the code that is at the top, and then changed it > > to

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/Inputs/test-invalid-offsets.yaml:1 +# int foo() { +# return 42; I should rename this to `test-invalid-addresses.yaml` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm created this revision. aadsm added reviewers: clayborg, labath. Herald added a reviewer: shafik. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm requested review of this revision. Herald added a subscriber: JDevlieghere. This is a similar patch to https://reviews

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:441 + if (first_code_section_sp) +m_first_code_address = first_code_section_sp->GetFileAddress(); +} I'm actually not 100% sure about this, can there be new cod

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm created this revision. aadsm added reviewers: clayborg, labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, JDevlieghere. I found a few cases whe

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

This revision was automatically updated to reflect the committed changes. Closed by commit rG52381938bcc8: Create ${swig_target}-scripts target instead of lldb-python-scripts (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86402/ne

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

aadsm updated this revision to Diff 287211. aadsm added a comment. Update to create 2 separate install targets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86402/new/ https://reviews.llvm.org/D86402 Files: lldb/CMakeLists.txt lldb/bindings/py

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

aadsm added a comment. Sounds good, will update. In my mind it would be easier to just install all configured python scripts by specifying a single distribution component. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86402/new/ https://reviews.ll

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d8eedee917d: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

aadsm created this revision. aadsm added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm requested review of this revision. This addresses the issue raised here https://reviews.llvm.org/rG02bf5632a94da6c3570df002804f8d3f79c11bfc The `f

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm updated this revision to Diff 287160. aadsm added a comment. After reading a bit more how clang-tidy works this isn't fixable because it actually needs to compile it. I also didn't find a way to exclude a file from it. My plan is to just land this and then make a PR to add this file to ht

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm updated this revision to Diff 287149. aadsm added a comment. Moved the header file to be in Plugins/ScriptInterpreter/Python so clang-tidy doesn't get confused solving include paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86381/new/ h

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm updated this revision to Diff 287144. aadsm added a comment. Added include guards, clang-format and python include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86381/new/ https://reviews.llvm.org/D86381 Files: lldb/bindings/python/python-

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm created this revision. aadsm added reviewers: clayborg, wallace, lawrence_danna. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm requested review of this revision. Herald added a subscriber: JDevlieghere. `struct Py_buffer_RAII` definition uses explicit deleted f

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02bf5632a94d: Fix swig scripts install target name (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm updated this revision to Diff 287106. aadsm edited the summary of this revision. aadsm added a comment. Updated to use more friendly component name `lldb-python-scripts` name instead of `finish_swig_python_scripts` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

aadsm added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + lawrence_danna wrote: > lawrence_danna wrote: > > aadsm wrote: > > > labath wrote: > > > > Could you also `= delete` the copy operations to make sure nothing > > >

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

aadsm added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + labath wrote: > Could you also `= delete` the copy operations to make sure nothing funny > happens with those. The `= delete` is unsupported in SWIG 2, only in 3:

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm added a comment. @JDevlieghere thanks for the quick review, but on the name I mean the actual `finish_swig_python_scripts`, this sounds like a step name and not a component distributed by llvm like `liblldb` ot `lldb-server`. That was the reason at the time I named it `lldb-python-scripts

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm created this revision. aadsm added reviewers: JDevlieghere, wallace, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm requested review of this revision. LLVM install component targets needs to be in the form of: install-{target}[-stripped] I tes

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

aadsm updated this revision to Diff 276894. aadsm added a comment. This update still doesn't add windows support but I just want to get a feel that I'm going on the right direction. It addresses the following: - redirect stdout/err as early as possible to avoid something writing to it, and only

[Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

aadsm accepted this revision. aadsm added a comment. This revision is now accepted and ready to land. Thank you for this! <3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81978/new/ https://reviews.llvm.org/D81978 ___

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

aadsm added a comment. Absolutely, I'll look into that first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80659/new/ https://reviews.llvm.org/D80659 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

aadsm added a comment. thanks for the feedback, I'll read it more carefully later. As for the tests it should be easy to set up, didn't want to spend time on that before we agreed on doing it this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

aadsm created this revision. aadsm added reviewers: clayborg, labath, rmaz. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Doing this for 2 main reasons: - Avoid stdout from corrupting DAP messages - Make sure we can see in VSCode (or any other DAP client) the same output

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3609b0ec685: Add terminateCommands to lldb-vscode protocol (authored by aadsm, committed by António Afonso ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm updated this revision to Diff 264143. aadsm added a comment. Updated README.md, package.json to document the new option. Also refactored the test support a bit to allow easier testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

aadsm added a comment. @clayborg the support we added was for the lldb-server. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disco

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disco

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked 2 inline comments as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disco

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm added a comment. > I gotta say I don't understand the difference between "exit" and "terminate" > commands, as both seem to happen pretty at once. Is the difference that > "exit" commands are run only when the inferior exits freely on its own, and > not when we forcefully kill it? And tha

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm updated this revision to Diff 263299. aadsm added a comment. Rebase and remove unwanted debug code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/ https://reviews.llvm.org/D79726 Files: lldb/packages/Python/lldbsuite/test/tools/ll

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked 2 inline comments as done. aadsm added a comment. I chose the name terminate because this happens just before the `terminated` event is sent back to the client. Comment at: lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py:49-67 +@skipIfDarwin @

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm created this revision. aadsm added reviewers: clayborg, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm updated this revision to Diff 263206. aadsm added a comment. Remove debugging leftovers Adding this in line with "stopCommands" and "exitCommands" s

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm updated this revision to Diff 263206. aadsm added a comment. Remove debugging leftovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/ https://reviews.llvm.org/D79726 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/l

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

aadsm added a comment. Yeah, I'm not sure why the LoadModules function is calling target.SetExecutableModule. It is true that the libraries-svr4 will not include the main executable in its list. This code was added in the context of providing qXfer:libraries support here: https://reviews.llvm.o

[Lldb-commits] [PATCH] D70883: [vscode.py] Make read_packet only return None when EOF

aadsm abandoned this revision. aadsm added a comment. Fair enough, I haven't seen evidence of this (haven't searched for it) but I imagine IDEs need to ignore this as well otherwise they just barf if they're expecting `Content-Length` and a wild print appears. The notion of stdout of SBDebugger

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

aadsm added a comment. > Maybe you could do something similar to LocalLLDBInit.test ? That test uses the `lldb` `-S` (and others) flags that `lldb-vscode` doesn't support :(. These flags should really be added to the initialize packet but they're very specific to lldb and the DAP doesn't suppor

[Lldb-commits] [PATCH] D70882: Add environment var LLDBVSCODE_SKIP_INIT_FILES to lldb-vscode

aadsm updated this revision to Diff 231807. aadsm added a comment. Put the logic into a function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70882/new/ https://reviews.llvm.org/D70882 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscod

[Lldb-commits] [PATCH] D70884: [lldb] Fix TestFormattersSBAPI test

This revision was automatically updated to reflect the committed changes. Closed by commit rGafd5d912812e: [lldb] Fix TestFormattersSBAPI test (authored by aadsm, committed by António Afonso ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D70882: Add environment var LLDBVSCODE_SKIP_INIT_FILES to lldb-vscode

aadsm updated this revision to Diff 231759. aadsm added a comment. Use an env var instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70882/new/ https://reviews.llvm.org/D70882 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscod

[Lldb-commits] [PATCH] D70887: [lldb] Use realpath to avoid issues with symlinks in source paths

aadsm updated this revision to Diff 231740. aadsm added a comment. Solve this at the failing test level. We can't be sure of the filename will end up in the debug info so we just add both keys to the mapping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D70883: [vscode.py] Make read_packet only return None when EOF

aadsm added a comment. Yes. This happens when lldb-vscode is run in stdin/stdout mode (which is what happens in tests and I've also seen some IDEs doing the same) and installed commands are doing "print". In this case the client gets data that does not start with `Content-Length`. This fixes th

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

aadsm added a comment. Yeah, that's what I do in D70882 . I still think tests can be more robust by using explicit lldb command names but don't really care much :). I'm happy to abandon it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D70884: [lldb] Fix TestFormattersSBAPI test

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/python_api/formatters/TestFormattersSBAPI.py:71 -format.format = lldb.eFormatOctal +format.SetFormat(lldb.eFormatOctal) category.AddTyp

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

aadsm added a comment. The way phabricator shows the diff is tricky, this change has nothing to do with D70882 and stands by itself. The important part here is making the `g_vsc.debugger.SetOutputFileHandle(out, true); g_vsc.debugger.SetErrorFileHandle(out, fal

[Lldb-commits] [PATCH] D70882: Add skipInitFiles option to lldb-vscode initialize

aadsm planned changes to this revision. aadsm added a comment. Yes, I'll change this to env it makes more sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70882/new/ https://reviews.llvm.org/D70882 ___

[Lldb-commits] [PATCH] D70887: [lldb] Use realpath to avoid issues with symlinks in source paths

aadsm created this revision. aadsm added reviewers: clayborg, lanza, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I was not able to sucessfully run TestDSYMSourcePathRemapping.py because the source mapping was using /tmp/ but the debugger was checking /private/t

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

aadsm created this revision. aadsm added reviewers: clayborg, lanza, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We need to do this before we create the debugger because the commands run in the lldbinit might do output to these handlers as well. Repository:

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

aadsm created this revision. aadsm added reviewers: clayborg, lanza, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Not a big deal but might be if in the future we had another command starting with br. I found this because I had an lldbinit that added a breakpad c

[Lldb-commits] [PATCH] D70884: [lldb] Fix TestFormattersSBAPI test

aadsm created this revision. aadsm added reviewers: clayborg, lanza, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test was broken in two ways: - Using the wrong API (e.g.: format = instead of SetFormat) - The hex checker was only checking "01" which will pa

[Lldb-commits] [PATCH] D70883: [vscode.py] Make read_packet only return None when EOF

aadsm created this revision. aadsm added reviewers: clayborg, lanza, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb-vscode has an issue when run in stdout/stdin mode because it will send all stdout generated by scripts through well.. stdout :) This is problem

[Lldb-commits] [PATCH] D70882: Add skipInitFiles option to lldb-vscode initialize

aadsm updated this revision to Diff 231629. aadsm added a comment. Oops, wrnog default Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70882/new/ https://reviews.llvm.org/D70882 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.p

  1   2   3   >