[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. Friendly ping to get this landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. Polite ping to get this committed. I have rebased against main today and run the test, it still passes and the patch applies cleanly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. Just giving this a gentle nudge again. As I said before, there's no rush, but if there's any action I can take to get this landed, please let me know. Many thanks again, ben. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. In D11#3143966 , @shafik wrote: > Apologies, this dropped off my radar it LGTM, thank you! Thanks! Sorry for my ignorance, but what's the next step to land this? Do you want me to rebase it first and push that, or is

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. In D11#3141363 , @jingham wrote: > In D11#3141355 , @puremourning > wrote: > >> Sorry, but is anything further required from me on this patch ? > > You addressed an issue

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. Sorry, but is anything further required from me on this patch ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 ___ lldb-commits

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning updated this revision to Diff 381372. puremourning added a comment. Add some tests for dodgy inputs. Handle invalid cases more consistently. Factor out some copy paste code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. In D11#3078896 , @shafik wrote: > It looks good to me but can we verify it behaves nicely with undefined > behavior cases e.g.: > > std::string s = "Hellooo "; > std::string_view sv = s + "World\n";

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning updated this revision to Diff 381357. puremourning added a comment. Revert some formatting lost in rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 Files:

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. Thanks for the review! Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py:62 +ns = self.namespace +self.expect( +"frame variable",

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning updated this revision to Diff 381344. puremourning added a comment. Use expect_var_path rather than just expect in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 Files:

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning updated this revision to Diff 381295. puremourning added a comment. RE-post with clang-format in path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 Files:

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning updated this revision to Diff 381293. puremourning added a comment. Remove change to the formatting of empty u16 and u32 strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 Files:

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. > I would actually prefer if we could split this into a separate change :) > (Sorry!) No problem, that was my gut feeling at the time too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. I'm happy to revert/split out the change for empty strings, as this is perhaps contentious (and not exactly minimal for this patch). Also, I'm only implementing libcxx (for now). We can follow up with libstdc++ in another patch if this is accepted. This is my

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning created this revision. puremourning requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When printing a std::string_view, print the referenced string as the summary. Support string_view, u32string_view, u16string_view and

[Lldb-commits] [PATCH] D72152: Support Launching in External Console in lldb-vscode

puremourning created this revision. puremourning added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When testing terminal-mode applications using lldb-vscode on macOS, it's currently required to set LLDB_LAUNCH_FLAG_LAUNCH_IN_TTY when starting